[PR] Remove experimental bit from buildconsumer [maven]
gnodet opened a new pull request, #1364: URL: https://github.com/apache/maven/pull/1364 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove experimental bit from buildconsumer [maven-integration-testing]
gnodet opened a new pull request, #331: URL: https://github.com/apache/maven-integration-testing/pull/331 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixed a typo in ComparableVersionTest.java [maven]
gnodet merged PR #1363: URL: https://github.com/apache/maven/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804586#comment-17804586 ] ASF GitHub Bot commented on MNG-7983: - gnodet merged PR #1358: URL: https://github.com/apache/maven/pull/1358 > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7983. Resolution: Fixed > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet merged PR #1358: URL: https://github.com/apache/maven/pull/1358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.rat:apache-rat-plugin from 0.15 to 0.16 [maven-apache-parent]
dependabot[bot] opened a new pull request, #185: URL: https://github.com/apache/maven-apache-parent/pull/185 Bumps org.apache.rat:apache-rat-plugin from 0.15 to 0.16. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support
[
https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804551#comment-17804551
]
ASF GitHub Bot commented on MNG-5862:
-
pdeneve commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1882239484
@gnodet Thanks for you work. Any plans on resolving the requested change?
> POM XML parser needs XInclude and/or XML Entity support
> ---
>
> Key: MNG-5862
> URL: https://issues.apache.org/jira/browse/MNG-5862
> Project: Maven
> Issue Type: New Feature
> Components: POM
>Reporter: Jason Vas Dias
>Assignee: Guillaume Nodet
>Priority: Major
>
> POM XML files can get very large and repetitive , and not all modularizaton
> scenarios can be resolved by using a Super POM as described in MNG-1980 ,
> and would be easily resolved if only the POM parser supported XIncludes or
> XML Entities - neither are supported.
> Here is one such scenario:
> I have a large project that has several SureFire plugin based "Test Suites" -
> each test suite uses a "common-at-classes" module of common test classes,
> and is essentially identical except in its XML configuration "test resource"
> files
> - so the structure is like this :
> {quote}
> {noformat}
> Top Level project directory:
>./pom.xml
>./acceptance-tests/pom.xml
>./acceptance-tests/common-at-classes/pom.xml
>./acceptance-tests/test-suite_#1/pom.xml
>...
>./acceptance-tests/test-suite_#N/pom.xml
> {noformat}
> {quote}
> There are @ 10 ( being upgraded to @ 20) "test suites",
> which all do exactly the same thing, but with slightly
> different "test resource" configuration files,
> and depend on the 'acceptance-tests/common-at-classes" JAR .
> We can modularize all the test-suite dependencies OK in the single
> common-at-classes/pom.xml location .
> But their is no way to modularize the actual XML code that runs each
> test-suite with plugin executions - these plugin execution stanzas can
> currently ONLY
> be in each test-suite#N directory, even though they are identical.
> It would make no sense to have the "Super POM" : acceptance-tests/pom.xml
> contain the plugin executions to run any single test suite ; nor can the
> common-at-classes/pom.xml contain the plugin execution to run any
> test suite, since a test suite run depends on the customized test resource
> files that only exist in each "test_suite#N/" sub-project .
> So the only solution currently available with Maven is to copy the XML stanzas
> that configure and run the test suite ( about 400 lines of XML ) into each of
> the 10-20 test-suite/pom.xml files ; this is all because Maven does not
> support
> XML XInclude or XML Entities; if it did, we could put all this code into one
> XML
> file provided by the common-at-classes project, and include it in each test
> suite .
> The test suite XML is then a nightmare to maintain, consistently for all test
> suites.
> This is becoming such a problem that I am considering making the root project
> POM do nothing more than transform the test-suite poms with XML XInclude-s
> (using an external XML processor), creating a new copy of the whole project,
> and then run an exec plugin goal which runs maven with the transformed POMs.
> Please, please can we have some form of XInclude or XML Entity support , or
> support for an "" element, in the POM parser !
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-5862] Support XML entities and XInclude [maven]
pdeneve commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1882239484 @gnodet Thanks for you work. Any plans on resolving the requested change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-javadoc-plugin]
elharo commented on PR #260: URL: https://github.com/apache/maven-javadoc-plugin/pull/260#issuecomment-1882224798 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-javadoc-plugin]
dependabot[bot] commented on PR #258: URL: https://github.com/apache/maven-javadoc-plugin/pull/258#issuecomment-1882224309 Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-javadoc-plugin]
elharo commented on PR #258: URL: https://github.com/apache/maven-javadoc-plugin/pull/258#issuecomment-1882224191 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-javadoc-plugin]
dependabot[bot] commented on PR #262: URL: https://github.com/apache/maven-javadoc-plugin/pull/262#issuecomment-1882223753 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-javadoc-plugin]
elharo commented on PR #262: URL: https://github.com/apache/maven-javadoc-plugin/pull/262#issuecomment-1882223656 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]
dependabot[bot] commented on PR #263: URL: https://github.com/apache/maven-javadoc-plugin/pull/263#issuecomment-1882223447 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]
elharo commented on PR #263: URL: https://github.com/apache/maven-javadoc-plugin/pull/263#issuecomment-1882223358 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-resources from 1.1.0 to 1.3.0 [maven-checkstyle-plugin]
elharo commented on PR #129: URL: https://github.com/apache/maven-checkstyle-plugin/pull/129#issuecomment-188252 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven-checkstyle-plugin]
elharo merged PR #127: URL: https://github.com/apache/maven-checkstyle-plugin/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [maven-checkstyle-plugin]
elharo merged PR #128: URL: https://github.com/apache/maven-checkstyle-plugin/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 [maven-checkstyle-plugin]
elharo merged PR #131: URL: https://github.com/apache/maven-checkstyle-plugin/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump xml-apis:xml-apis from 1.4.01 to 2.0.2 [maven-doxia-sitetools]
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/maven-doxia-sitetools/pull/130 Bumps xml-apis:xml-apis from 1.4.01 to 2.0.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 [maven-doxia-sitetools]
dependabot[bot] opened a new pull request, #131: URL: https://github.com/apache/maven-doxia-sitetools/pull/131 Bumps [org.codehaus.plexus:plexus-component-metadata](https://github.com/codehaus-plexus/plexus-containers) from 2.1.1 to 2.2.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-containers/releases;>org.codehaus.plexus:plexus-component-metadata's releases. 2.2.0 improve documentation to switch to Sisu (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/121;>#121) https://github.com/hboutemy;>@hboutemy pom clean after parent upgrade (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/120;>#120) https://github.com/hboutemy;>@hboutemy Improve plexus-component metadata - remove dependency to plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/109;>#109) https://github.com/slachiewicz;>@slachiewicz Add deprecation information to Plexus components (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/108;>#108) https://github.com/slachiewicz;>@slachiewicz Require Java 8 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/107;>#107) https://github.com/slachiewicz;>@slachiewicz Drop plexus-container-default artefact (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/135;>#135) https://github.com/slachiewicz;>@slachiewicz Require Maven 3.6.3+ (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/133;>#133) https://github.com/slachiewicz;>@slachiewicz Switch to JUnit5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/134;>#134) https://github.com/slachiewicz;>@slachiewicz Bump org.eclipse.sisu.plexus from 0.3.0.M1 to 0.9.0.M2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/113;>#113) https://github.com/dependabot;>@dependabot Dependency updates Bump org.codehaus.plexus:plexus-testing from 1.2.0 to 1.3.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/139;>#139) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus from 15 to 16 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/138;>#138) https://github.com/dependabot;>@dependabot Bump org.apache.xbean:xbean-reflect from 4.23 to 4.24 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/131;>#131) https://github.com/dependabot;>@dependabot Reorg dependencyManagement to subprojects. Prepare to drop plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/132;>#132) https://github.com/slachiewicz;>@slachiewicz Bump org.ow2.asm:asm from 9.5 to 9.6 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/129;>#129) https://github.com/dependabot;>@dependabot Bump maven-invoker-plugin from 3.5.1 to 3.6.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/125;>#125) https://github.com/dependabot;>@dependabot Bump xbean-reflect from 4.22 to 4.23 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/116;>#116) https://github.com/dependabot;>@dependabot Bump maven-plugin-annotations from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/104;>#104) https://github.com/dependabot;>@dependabot Bump maven-plugin-plugin from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/105;>#105) https://github.com/dependabot;>@dependabot Bump maven-project-info-reports-plugin from 3.4.2 to 3.4.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/102;>#102) https://github.com/dependabot;>@dependabot Bump asm from 9.4 to 9.5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/99;>#99) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/97;>#97) https://github.com/dependabot;>@dependabot Bump checkstyle from 9.2 to 9.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/96;>#96) https://github.com/dependabot;>@dependabot Bump maven-plugin-plugin from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/92;>#92) https://github.com/dependabot;>@dependabot Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/93;>#93) https://github.com/dependabot;>@dependabot Bump asm from 9.3 to 9.4 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/88;>#88) https://github.com/dependabot;>@dependabot Bump maven-project-info-reports-plugin from 3.4.1 to 3.4.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/85;>#85) https://github.com/dependabot;>@dependabot Bump maven-plugin-plugin from 3.7.0 to 3.7.1
[PR] Bump aetherVersion from 1.0.0.v20140518 to 1.1.0 [maven-doxia-sitetools]
dependabot[bot] opened a new pull request, #129: URL: https://github.com/apache/maven-doxia-sitetools/pull/129 Bumps `aetherVersion` from 1.0.0.v20140518 to 1.1.0. Updates `org.eclipse.aether:aether-api` from 1.0.0.v20140518 to 1.1.0 Updates `org.eclipse.aether:aether-impl` from 1.0.0.v20140518 to 1.1.0 Updates `org.eclipse.aether:aether-connector-basic` from 1.0.0.v20140518 to 1.1.0 Updates `org.eclipse.aether:aether-transport-wagon` from 1.0.0.v20140518 to 1.1.0 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump mavenVersion from 3.2.5 to 3.3.9 [maven-doxia-sitetools]
dependabot[bot] opened a new pull request, #128: URL: https://github.com/apache/maven-doxia-sitetools/pull/128 Bumps `mavenVersion` from 3.2.5 to 3.3.9. Updates `org.apache.maven:maven-artifact` from 3.2.5 to 3.3.9 Commits https://github.com/apache/maven/commit/bb52d8502b132ec0a5a3f4c09453c07478323dc5;>bb52d85 [maven-release-plugin] prepare release maven-3.3.9 https://github.com/apache/maven/commit/cf2f373ddb38215f7122f743d381ead7e346ed2d;>cf2f373 [MNG-5882] Nonportable shell constructs cause bin/mvn errors on Debian https://github.com/apache/maven/commit/1953284925616e691fb881c5e3fa8fbdd1830385;>1953284 [MNG-5840] A regression had crept in and was missed as the intergration tests... https://github.com/apache/maven/commit/2f7daeff5802174c7b4ff8a4d2ac019b6406d03b;>2f7daef [MNG-5871] refactoring: improved empty urls handling https://github.com/apache/maven/commit/406a46fd83e9b620d34e5f49cc132e06a3a00898;>406a46f [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/cdd15915eb4b74ccab621e51aff9ada4f455a627;>cdd1591 [maven-release-plugin] prepare release maven-3.3.8 https://github.com/apache/maven/commit/f684761dee739b4ec8a7e6db5a0a6a0b809e66c9;>f684761 Fix for urls being empty in the POM and causing an out of bounds exception https://github.com/apache/maven/commit/508d97ec87526d5e308df0857c21546b4024801f;>508d97e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/d48a49b3539e66e073e35cc6a5137a94d16465f2;>d48a49b [maven-release-plugin] prepare release maven-3.3.7 https://github.com/apache/maven/commit/b6c9bee1b60ff8ad142651052fb7729cfd206be3;>b6c9bee [MNG-5915] Upgrade Wagon version to 2.10 Additional commits viewable in https://github.com/apache/maven/compare/maven-3.2.5...maven-3.3.9;>compare view Updates `org.apache.maven:maven-core` from 3.2.5 to 3.3.9 Commits https://github.com/apache/maven/commit/bb52d8502b132ec0a5a3f4c09453c07478323dc5;>bb52d85 [maven-release-plugin] prepare release maven-3.3.9 https://github.com/apache/maven/commit/cf2f373ddb38215f7122f743d381ead7e346ed2d;>cf2f373 [MNG-5882] Nonportable shell constructs cause bin/mvn errors on Debian https://github.com/apache/maven/commit/1953284925616e691fb881c5e3fa8fbdd1830385;>1953284 [MNG-5840] A regression had crept in and was missed as the intergration tests... https://github.com/apache/maven/commit/2f7daeff5802174c7b4ff8a4d2ac019b6406d03b;>2f7daef [MNG-5871] refactoring: improved empty urls handling https://github.com/apache/maven/commit/406a46fd83e9b620d34e5f49cc132e06a3a00898;>406a46f [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/cdd15915eb4b74ccab621e51aff9ada4f455a627;>cdd1591 [maven-release-plugin] prepare release maven-3.3.8 https://github.com/apache/maven/commit/f684761dee739b4ec8a7e6db5a0a6a0b809e66c9;>f684761 Fix for urls being empty in the POM and causing an out of bounds exception https://github.com/apache/maven/commit/508d97ec87526d5e308df0857c21546b4024801f;>508d97e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/d48a49b3539e66e073e35cc6a5137a94d16465f2;>d48a49b [maven-release-plugin] prepare release maven-3.3.7 https://github.com/apache/maven/commit/b6c9bee1b60ff8ad142651052fb7729cfd206be3;>b6c9bee [MNG-5915] Upgrade Wagon version to 2.10 Additional commits viewable in https://github.com/apache/maven/compare/maven-3.2.5...maven-3.3.9;>compare view Updates `org.apache.maven:maven-compat` from 3.2.5 to 3.3.9 Commits https://github.com/apache/maven/commit/bb52d8502b132ec0a5a3f4c09453c07478323dc5;>bb52d85 [maven-release-plugin] prepare release maven-3.3.9 https://github.com/apache/maven/commit/cf2f373ddb38215f7122f743d381ead7e346ed2d;>cf2f373 [MNG-5882] Nonportable shell constructs cause bin/mvn errors on Debian https://github.com/apache/maven/commit/1953284925616e691fb881c5e3fa8fbdd1830385;>1953284 [MNG-5840] A regression had crept in and was missed as the intergration tests... https://github.com/apache/maven/commit/2f7daeff5802174c7b4ff8a4d2ac019b6406d03b;>2f7daef [MNG-5871] refactoring: improved empty urls handling https://github.com/apache/maven/commit/406a46fd83e9b620d34e5f49cc132e06a3a00898;>406a46f [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/cdd15915eb4b74ccab621e51aff9ada4f455a627;>cdd1591 [maven-release-plugin] prepare release maven-3.3.8 https://github.com/apache/maven/commit/f684761dee739b4ec8a7e6db5a0a6a0b809e66c9;>f684761 Fix for urls being empty in the POM and causing an out of bounds exception https://github.com/apache/maven/commit/508d97ec87526d5e308df0857c21546b4024801f;>508d97e [maven-release-plugin] prepare for next development iteration
[jira] [Commented] (MPLUGIN-502) NPE in EnhancedPluginDescriptorBuilder with Maven 4.x
[
https://issues.apache.org/jira/browse/MPLUGIN-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804462#comment-17804462
]
Slawomir Jaranowski commented on MPLUGIN-502:
-
Fix was in MINVOKER-313
https://github.com/apache/maven-invoker-plugin/pull/174
> NPE in EnhancedPluginDescriptorBuilder with Maven 4.x
> -
>
> Key: MPLUGIN-502
> URL: https://issues.apache.org/jira/browse/MPLUGIN-502
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.10.2, 3.11.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> With Maven 4.x (4.0.0-alpha-10) we have:
> {noformat}
> Caused by: java.lang.NullPointerException: Cannot invoke
> "org.codehaus.plexus.configuration.PlexusConfiguration.getChild(String)"
> because "this.configuration" is null
> at
> org.apache.maven.plugins.plugin.descriptor.EnhancedPluginDescriptorBuilder.build(EnhancedPluginDescriptorBuilder.java:75)
> at
> org.apache.maven.plugin.descriptor.PluginDescriptorBuilder.build(PluginDescriptorBuilder.java:63)
> at
> org.apache.maven.plugin.plugin.report.PluginReport.extractPluginDescriptor(PluginReport.java:163)
> at
> org.apache.maven.plugin.plugin.report.PluginReport.executeReport(PluginReport.java:148)
> at
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:289)
> {noformat}
> Also ITs in {{maven-plugin-report-plugin}} fails with Maven 4.x
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MINDEXER-215) Refresh download page
Slawomir Jaranowski created MINDEXER-215: Summary: Refresh download page Key: MINDEXER-215 URL: https://issues.apache.org/jira/browse/MINDEXER-215 Project: Maven Indexer Issue Type: Task Reporter: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPLUGIN-503) Preserve some goal prefixes as "reserved"
Tamas Cservenak created MPLUGIN-503: --- Summary: Preserve some goal prefixes as "reserved" Key: MPLUGIN-503 URL: https://issues.apache.org/jira/browse/MPLUGIN-503 Project: Maven Plugin Tools Issue Type: Task Components: Plugin Plugin Reporter: Tamas Cservenak The plugin should not allow ANY prefix to be used, we may come up with some prefixes that are not allowed. Example list: * script * mvn * mojo * etc... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804420#comment-17804420 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on PR #1358: URL: https://github.com/apache/maven/pull/1358#issuecomment-1881626709 @gnodet @michael-o SLF4J version 2.0.11 was released a few moments ago. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on PR #1358: URL: https://github.com/apache/maven/pull/1358#issuecomment-1881626709 @gnodet @michael-o SLF4J version 2.0.11 was released a few moments ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fixed a typo in ComparableVersionTest.java [maven]
oblivia-simplex opened a new pull request, #1363: URL: https://github.com/apache/maven/pull/1363 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804377#comment-17804377 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on PR #1358: URL: https://github.com/apache/maven/pull/1358#issuecomment-1881478240 Very nice. Let's wait for 2.0.11 release. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
michael-o commented on PR #1358: URL: https://github.com/apache/maven/pull/1358#issuecomment-1881478240 Very nice. Let's wait for 2.0.11 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804345#comment-17804345 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444839810 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @ceki there's a few more protected methods needed in order to be reusable from a different package, see https://github.com/qos-ch/slf4j/pull/385 > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444839810 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @ceki there's a few more protected methods needed in order to be reusable from a different package, see https://github.com/qos-ch/slf4j/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804326#comment-17804326 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444745560 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @michael-o > SLF4J used to warning when version of API and Impl weren't identical... Good point. Fortunately, the requested API version is returned by the **provider** in the `getResquestedVersion` method. So you should be good. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444745560 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @michael-o > SLF4J used to warning when version of API and Impl weren't identical... Good point. Fortunately, the requested API version is returned by the **provider** in the `getResquestedVersion` method. So you should be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804316#comment-17804316 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444724098 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @gnodet Also changed the access modifier of the constructor for SimpleLogger to protected. See [commit fe42ecb5f](https://github.com/qos-ch/slf4j/commit/fe42ecb5f74cdda9927fe0889229199a08d23ec8) > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444724098 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @gnodet Also changed the access modifier of the constructor for SimpleLogger to protected. See [commit fe42ecb5f](https://github.com/qos-ch/slf4j/commit/fe42ecb5f74cdda9927fe0889229199a08d23ec8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve transfer listener speed [maven]
michael-o commented on PR #1302: URL: https://github.com/apache/maven/pull/1302#issuecomment-1881105335 > I think this is a good change despite no "speedup" sensed: the original class uses `synchronized` on each listener method, meaning at one time only one thread can enter only one method... and this MAY (most probably is) coggle resolver when uses multiple threads. Yes, I used `synchronized` back them because it was guaranteed to work properly. I will review this this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve transfer listener speed [maven]
cstamas commented on PR #1302: URL: https://github.com/apache/maven/pull/1302#issuecomment-1881092448 I think this is a good change despite no "speedup" sensed: the original class uses `synchronized` on each listener method, meaning at one time only one thread can enter only one method... and this MAY (most probably is) coggle resolver when uses multiple threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be backported to slf4j 2.x ? @gnodet Yes, of course. Compared to the code in 2.0, it looks like only the `renderLevel` method was missing. I added it back in commit [7029a8b7fda ](https://github.com/qos-ch/slf4j/commit/7029a8b7fda826f425c740a847e97f4c0a063dbe) in the main branch (i.e the 2.0 branch). This should hopefully allow you to move to slf4j-simple version 2.0. Let me know if other changes are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804310#comment-17804310 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be backported to slf4j 2.x ? @gnodet Yes, of course. Compared to the code in 2.0, it looks like only the `renderLevel` method was missing. I added it back in commit [7029a8b7fda ](https://github.com/qos-ch/slf4j/commit/7029a8b7fda826f425c740a847e97f4c0a063dbe) in the main branch (i.e the 2.0 branch). This should hopefully allow you to move to slf4j-simple version 2.0. Let me know if other changes are needed. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804307#comment-17804307 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: q@gnodet Yes, of course. It looks like only the `renderLevel` method was missing. I added it back in commit [7029a8b7fda ](https://github.com/qos-ch/slf4j/commit/7029a8b7fda826f425c740a847e97f4c0a063dbe) in the main branch (i.e the 2.0 branch). This should allow you to move to slf4j-simple version 2.0. Let me know if other changes are needed. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: q@gnodet Yes, of course. It looks like only the `renderLevel` method was missing. I added it back in commit [7029a8b7fda ](https://github.com/qos-ch/slf4j/commit/7029a8b7fda826f425c740a847e97f4c0a063dbe) in the main branch (i.e the 2.0 branch). This should allow you to move to slf4j-simple version 2.0. Let me know if other changes are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804305#comment-17804305 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @gnodet Yes, of course. It looks like only the `renderLevel` method was missing. I added it back in commit 7029a8b7fda in the main branch (i.e the 2.0 branch). This should allow you to move to slf4j-simple version 2.0. Let me know if other changes are needed. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @gnodet Yes, of course. It looks like only the `renderLevel` method was missing. I added it back in commit 7029a8b7fda in the main branch (i.e the 2.0 branch). This should allow you to move to slf4j-simple version 2.0. Let me know if other changes are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444692629 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > @michael-o What warning are you thinking of? As long as you furnish the appropriate implementation of SLF4JServiceProvider, SLF4J 2.0 should be satisfied. SLF4J used to warning when version of API and Impl weren't identical... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804301#comment-17804301 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444691847 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected constructor. > > @ceki do you think this commit [qos-ch/slf4j@509c3444ac7](https://github.com/qos-ch/slf4j/commit/509c3444ac7) could be backported to slf4j 2.x ? Tags say it is...?! > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804303#comment-17804303 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444692629 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > @michael-o What warning are you thinking of? As long as you furnish the appropriate implementation of SLF4JServiceProvider, SLF4J 2.0 should be satisfied. SLF4J used to warning when version of API and Impl weren't identical... > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444691847 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected constructor. > > @ceki do you think this commit [qos-ch/slf4j@509c3444ac7](https://github.com/qos-ch/slf4j/commit/509c3444ac7) could be backported to slf4j 2.x ? Tags say it is...?! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804282#comment-17804282 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected constructor. @ceki do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be backported to slf4j 2.x ? > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804281#comment-17804281 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected constructor. @ceki do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be back ported to slf4j 2.x ? > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected constructor. @ceki do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be backported to slf4j 2.x ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804280#comment-17804280 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected method. @ceki do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be back ported to slf4j 2.x ? > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected constructor. @ceki do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be back ported to slf4j 2.x ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the package name is not trivial, as we extend `SimpleLogger` from slf4j 1.x which has a package protected method. @ceki do you think this commit https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be back ported to slf4j 2.x ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804279#comment-17804279 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444644182 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > Not really, at least not at runtime. The reason is that we're not really using slf4j simple directly, but we use our own provider which extends slf4j-simple. However, that one cannot be easily upgrade to 2.x as it's missing two key features: the ability to override the string used for displaying the log level, and the ability to more nicely format exceptions. > Those have been removed from 2.x. @gnodet I am not aware of this, in any case it was not done intentionally. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444644182 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > Not really, at least not at runtime. The reason is that we're not really using slf4j simple directly, but we use our own provider which extends slf4j-simple. However, that one cannot be easily upgrade to 2.x as it's missing two key features: the ability to override the string used for displaying the log level, and the ability to more nicely format exceptions. > Those have been removed from 2.x. @gnodet I am not aware of this, in any case it was not done intentionally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804277#comment-17804277 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444641468 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @michael-o What warning are you thinking of? As long as you furnish the appropriate implementation of SLF4JServiceProvider, SLF4J 2.0 should be satisfied. @gnodet I would recommend to use another package instead of org.slf4j.impl for example org.slf4j.maven in order JMPS/Jigsaw conflicts. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444641468 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @michael-o What warning are you thinking of? As long as you furnish the appropriate implementation of SLF4JServiceProvider, SLF4J 2.0 should be satisfied. @gnodet I would recommend to use another package instead of org.slf4j.impl for example org.slf4j.maven in order JMPS/Jigsaw conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804273#comment-17804273 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444634578 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: See https://jira.qos.ch/browse/SLF4J-394 > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444634578 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: See https://jira.qos.ch/browse/SLF4J-394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-archiver]
elharo merged PR #50: URL: https://github.com/apache/maven-archiver/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 40 to 41 [maven-archiver]
elharo merged PR #45: URL: https://github.com/apache/maven-archiver/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.1 [maven-archiver]
elharo merged PR #48: URL: https://github.com/apache/maven-archiver/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-archiver]
elharo merged PR #47: URL: https://github.com/apache/maven-archiver/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MCOMPILER-424) Annotation processor fails with AnnotationTypeMismatchException on Java 11 which targets Java 8
[
https://issues.apache.org/jira/browse/MCOMPILER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804269#comment-17804269
]
Marian Macik edited comment on MCOMPILER-424 at 1/8/24 1:15 PM:
Thank you [~kriegaex] for having a look at this as well. I didn't go that deep
during my investigation, but you are right, this issue is directly related to
Java itself. I would close this issue as there has been no response in three
and a half years anyway but I am not able to. May I just ask you to update the
comments section here once the JDK issue you reported is resolved/closed? Thank
you once again!
was (Author: mmacik):
Thank you [~kriegaex] for having a look at this as well. I didn't go that deep
during my investigation, but you are right, this issue is directly related to
Java itself. I will close this issue as there has been no response in three and
a half years anyway. May I just ask you to update the comments section here
once the JDK issue you reported is resolved/closed? Thank you once again!
> Annotation processor fails with AnnotationTypeMismatchException on Java 11
> which targets Java 8
> ---
>
> Key: MCOMPILER-424
> URL: https://issues.apache.org/jira/browse/MCOMPILER-424
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.8.1
> Environment: Apache Maven 3.6.3
> Java 11.0.7
>Reporter: Marian Macik
>Priority: Major
>
> When I configure the Maven Compiler Plugin running on Java 11 to target Java
> 8:
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
> 3.8.1
>
> 1.8
> 1.8
>
>
> {code}
> My compilation will fail with
> {{java.lang.annotation.AnnotationTypeMismatchException}} when I use an
> annotation processor.
> I investigated it a little bit and found out that this happens only in a very
> specific case which has to fulfil these criteria:
> 1. One annotation which has the second annotation as a parameter.
> 2. The second annotation has a parameter of type {{String[]}}.
> 3. Java 11 has the compilation target set to Java 8.
> The same scenario works without any issues when I configure the Maven
> Compiler Plugin with {{11}}.
> I debugged the code and when I set the Maven Compiler Plugin to source/target
> 1.8, I noticed changes in the *AnnotationProxyMaker$ValueVisitor#getValue()*
> method. In this case, on the line in the *getValue()* method
> {code:java}
> attr.accept(this);
> {code}
> the *attr* variable holds a *ClassReader$ArrayAttributeProxy* object (so the
> second annotation's String[] parameter is being handled) and then I can see a
> *ClassCastException* thrown inside the
> *ClassReader$ArrayAttributeProxy#accept()* method:
> {code:java}
> public void accept(Visitor v) {
> ((ProxyVisitor)v).visitArrayAttributeProxy(this); }
> {code}
> which says
> {noformat}
> class com.sun.tools.javac.model.AnnotationProxyMaker$ValueVisitor cannot be
> cast to class com.sun.tools.javac.jvm.ClassReader$ProxyVisitor
> (com.sun.tools.javac.model.AnnotationProxyMaker$ValueVisitor and
> com.sun.tools.javac.jvm.ClassReader$ProxyVisitor are in module jdk.compiler
> of loader 'app')
> {noformat}
> so the *Visitor v* (of type *AnnotationProxyMaker$ValueVisitor*) cannot be
> cast to *ClassReader$ProxyVisitor*, which is correct by looking at the source
> code, and then the exception is caught at the
> *{{AnnotationProxyMaker$ValueVisitor#visitCompound()}}* method which handles
> the whole second annotation (which the String[] parameter is a part of).
> After that, it fails with the *AnnotationTypeMismatchException*.
> Now, when I execute this with {{11}}, the *attr* variable
> holds an *Attribute$Array* object and its *accept()* method looks different:
> {code:java}
> public void accept(Visitor v) { v.visitArray(this); }
> {code}
> and the code executes perfectly fine.
> There is a workaround for this and it is pretty simple. You just need to add
> an import of the second annotation on the annotated class being processed by
> the processor, even if just the default value is used. Or, in case the
> annotated class is in the same package as the annotation itself, you just
> need to provide the default value explicitly, see:
> {code:java}
> package org.example;
> /*
> * Uncomment one of these lines and the annotation processor starts working.
> */
> //import org.example.MySecondAnnotation;
> @MyFirstAnnotation(
> //secondAnnotation = @MySecondAnnotation
> )
> public class AnnotatedClass {
> }
> {code}
> Now I don't know if the issue is with the Java compiler or the Maven Compiler
> Plugin, but if it is with the former, you can at least help me to contact the
> Java compiler developers or forward me to the correct Java compiler issue
>
[jira] [Commented] (MCOMPILER-424) Annotation processor fails with AnnotationTypeMismatchException on Java 11 which targets Java 8
[
https://issues.apache.org/jira/browse/MCOMPILER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804269#comment-17804269
]
Marian Macik commented on MCOMPILER-424:
Thank you [~kriegaex] for having a look at this as well. I didn't go that deep
during my investigation, but you are right, this issue is directly related to
Java itself. I will close this issue as there has been no response in three and
a half years anyway. May I just ask you to update the comments section here
once the JDK issue you reported is resolved/closed? Thank you once again!
> Annotation processor fails with AnnotationTypeMismatchException on Java 11
> which targets Java 8
> ---
>
> Key: MCOMPILER-424
> URL: https://issues.apache.org/jira/browse/MCOMPILER-424
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.8.1
> Environment: Apache Maven 3.6.3
> Java 11.0.7
>Reporter: Marian Macik
>Priority: Major
>
> When I configure the Maven Compiler Plugin running on Java 11 to target Java
> 8:
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
> 3.8.1
>
> 1.8
> 1.8
>
>
> {code}
> My compilation will fail with
> {{java.lang.annotation.AnnotationTypeMismatchException}} when I use an
> annotation processor.
> I investigated it a little bit and found out that this happens only in a very
> specific case which has to fulfil these criteria:
> 1. One annotation which has the second annotation as a parameter.
> 2. The second annotation has a parameter of type {{String[]}}.
> 3. Java 11 has the compilation target set to Java 8.
> The same scenario works without any issues when I configure the Maven
> Compiler Plugin with {{11}}.
> I debugged the code and when I set the Maven Compiler Plugin to source/target
> 1.8, I noticed changes in the *AnnotationProxyMaker$ValueVisitor#getValue()*
> method. In this case, on the line in the *getValue()* method
> {code:java}
> attr.accept(this);
> {code}
> the *attr* variable holds a *ClassReader$ArrayAttributeProxy* object (so the
> second annotation's String[] parameter is being handled) and then I can see a
> *ClassCastException* thrown inside the
> *ClassReader$ArrayAttributeProxy#accept()* method:
> {code:java}
> public void accept(Visitor v) {
> ((ProxyVisitor)v).visitArrayAttributeProxy(this); }
> {code}
> which says
> {noformat}
> class com.sun.tools.javac.model.AnnotationProxyMaker$ValueVisitor cannot be
> cast to class com.sun.tools.javac.jvm.ClassReader$ProxyVisitor
> (com.sun.tools.javac.model.AnnotationProxyMaker$ValueVisitor and
> com.sun.tools.javac.jvm.ClassReader$ProxyVisitor are in module jdk.compiler
> of loader 'app')
> {noformat}
> so the *Visitor v* (of type *AnnotationProxyMaker$ValueVisitor*) cannot be
> cast to *ClassReader$ProxyVisitor*, which is correct by looking at the source
> code, and then the exception is caught at the
> *{{AnnotationProxyMaker$ValueVisitor#visitCompound()}}* method which handles
> the whole second annotation (which the String[] parameter is a part of).
> After that, it fails with the *AnnotationTypeMismatchException*.
> Now, when I execute this with {{11}}, the *attr* variable
> holds an *Attribute$Array* object and its *accept()* method looks different:
> {code:java}
> public void accept(Visitor v) { v.visitArray(this); }
> {code}
> and the code executes perfectly fine.
> There is a workaround for this and it is pretty simple. You just need to add
> an import of the second annotation on the annotated class being processed by
> the processor, even if just the default value is used. Or, in case the
> annotated class is in the same package as the annotation itself, you just
> need to provide the default value explicitly, see:
> {code:java}
> package org.example;
> /*
> * Uncomment one of these lines and the annotation processor starts working.
> */
> //import org.example.MySecondAnnotation;
> @MyFirstAnnotation(
> //secondAnnotation = @MySecondAnnotation
> )
> public class AnnotatedClass {
> }
> {code}
> Now I don't know if the issue is with the Java compiler or the Maven Compiler
> Plugin, but if it is with the former, you can at least help me to contact the
> Java compiler developers or forward me to the correct Java compiler issue
> tracking system.
> I have also prepared a reproducer which shows this issue. It is available on
> GitHub [1] and includes a short README file with instructions on how to run
> it.
> Thanks for help!
> [1] [https://github.com/MarianMacik/JDK11-annotation-processor-reproducer]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-resources from 1.2.0 to 1.3.0 [maven-pmd-plugin]
elharo merged PR #140: URL: https://github.com/apache/maven-pmd-plugin/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804263#comment-17804263 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444594238 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Not really, at least not at runtime. The reason is that we're not really using slf4j simple directly, but we use our own provider. However, that one cannot be easily upgrade to 2.x as it's missing two key features: the ability to override the string used for displaying the log level, and the ability to more nicely format exceptions. Those have been removed from 2.x. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804264#comment-17804264 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444594238 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Not really, at least not at runtime. The reason is that we're not really using slf4j simple directly, but we use our own provider which extends slf4j-simple. However, that one cannot be easily upgrade to 2.x as it's missing two key features: the ability to override the string used for displaying the log level, and the ability to more nicely format exceptions. Those have been removed from 2.x. > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444594238 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Not really, at least not at runtime. The reason is that we're not really using slf4j simple directly, but we use our own provider which extends slf4j-simple. However, that one cannot be easily upgrade to 2.x as it's missing two key features: the ability to override the string used for displaying the log level, and the ability to more nicely format exceptions. Those have been removed from 2.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444594238 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Not really, at least not at runtime. The reason is that we're not really using slf4j simple directly, but we use our own provider. However, that one cannot be easily upgrade to 2.x as it's missing two key features: the ability to override the string used for displaying the log level, and the ability to more nicely format exceptions. Those have been removed from 2.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve transfer listener speed [maven]
michael-o commented on PR #1302: URL: https://github.com/apache/maven/pull/1302#issuecomment-1880955503 Can you quatify the speed improvement in percent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804259#comment-17804259 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444577122 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause a warning with SLF4J? SLF4J's approach is to keep them insync. ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause a warning with SLF4J? SLF4J's approach is to keep them in sync. @ceki, can you help? > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444577122 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause a warning with SLF4J? SLF4J's approach is to keep them insync. ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause a warning with SLF4J? SLF4J's approach is to keep them in sync. @ceki, can you help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7983) Update to Slf4j 2.x
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804257#comment-17804257 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444577122 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause a warning with SLF4J? > Update to Slf4j 2.x > --- > > Key: MNG-7983 > URL: https://issues.apache.org/jira/browse/MNG-7983 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444577122 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause a warning with SLF4J? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7982) Switch to enable transitivity in depMgr used by Maven
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7982: - Fix Version/s: 4.0.0-alpha-11 (was: 4.0.0-alpha-12) > Switch to enable transitivity in depMgr used by Maven > - > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > Resolver MRESOLVER-462 that is a boolean switch (to enable or disable -- as > before -- the transitivity in depMgr). > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7960) Artifact collection filtering
[
https://issues.apache.org/jira/browse/MNG-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7960:
-
Fix Version/s: 4.0.0-alpha-11
(was: 4.0.0-alpha-12)
> Artifact collection filtering
> -
>
> Key: MNG-7960
> URL: https://issues.apache.org/jira/browse/MNG-7960
> Project: Maven
> Issue Type: New Feature
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-11
>
>
> Exposed work from MRESOLVER-451 and MRESOLVER-460: allow for various
> filterings.
> User should be able to "tune" range processing. Also, as this affects
> resolution, ideally these "tuned" parameters should be stored along project,
> especially if project relies on these (ie. in {{.mvn/maven.config}}).
> Explanation: Maven is notoriously "bad" when ranges are being used. Hence,
> this issue introduces (range) version filtering support. The configuration
> accepts an "expression" (CSV) of filters. Supported filters are:
> * "h" (equivalent of "h(1)") or "h(N)" - that selects "top N" versions from
> range
> * "l" (equivalent of "l(1)") or "l(N)" - that selects "bottom N" versions
> from range
> * "s" snapshot filter: if root/project is snapshot, will allow snapshots in
> ranges, otherwise snapshot versions are filtered out (also see Resolver
> config {{aether.snapshotFilter}} present in Resolver 1.x but has no effect in
> Maven3 as it is not used).
> * "e(G:A:V)" exclusion, if range for G:A is processed, V is _excluded_ from
> range. V can be version range as well, then whole range is excluded.
> The built expressions are evaluated in-order, and filtering effect is
> accumulated. Hence, expression like "h(5),l" will return 5th highest version,
> etc.
> This depends on resolver release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7982) Switch to enable transitivity in depMgr used by Maven
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804247#comment-17804247 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1880869332 > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer side ? I don't quite understand: so _same project_ that is once built with Maven 4 and once with Maven 3? Or an artifact that is dependency once in Maven4 built project and once in Maven3 project? Or WDYM? > Switch to enable transitivity in depMgr used by Maven > - > > Key: MNG-7982 > URL: https://issues.apache.org/jira/browse/MNG-7982 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-12 > > > As seen in various issues (MRESOLVER-235, MNG-7003 and others), users are > calling out how depMgt should be handled in both cases: when building (it > is), and when consuming (it is not). > Resolver MRESOLVER-462 that is a boolean switch (to enable or disable -- as > before -- the transitivity in depMgr). > This depends on resolver release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1880869332 > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer side ? I don't quite understand: so _same project_ that is once built with Maven 4 and once with Maven 3? Or an artifact that is dependency once in Maven4 built project and once in Maven3 project? Or WDYM? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7173) MavenResolverModule is broken/incomplete
[ https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7173. Resolution: Won't Fix > MavenResolverModule is broken/incomplete > > > Key: MNG-7173 > URL: https://issues.apache.org/jira/browse/MNG-7173 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > > The MavenResolverModule is broken/incomplete since 3.6.2 (or 3.6.3). But as > we have no tests for it, this went completely unnoticed and is seen by > downstream clients only. > In maven-resolver-provider we need to: > a) fix the MavenResolverModule, make it complete (related to ModelBuilder > deps) > b) add tests to ensure it is "complete" > Note: maven-resolver demo snippets for guice, while used MavenResolverModule, > is and never will be in "lockstep", it used 3.5.0 of it, hence, the changes > in 3.6.2 were missed by it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7173) MavenResolverModule is broken/incomplete
[ https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804245#comment-17804245 ] ASF GitHub Bot commented on MNG-7173: - cstamas closed pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken URL: https://github.com/apache/maven/pull/479 > MavenResolverModule is broken/incomplete > > > Key: MNG-7173 > URL: https://issues.apache.org/jira/browse/MNG-7173 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > > The MavenResolverModule is broken/incomplete since 3.6.2 (or 3.6.3). But as > we have no tests for it, this went completely unnoticed and is seen by > downstream clients only. > In maven-resolver-provider we need to: > a) fix the MavenResolverModule, make it complete (related to ModelBuilder > deps) > b) add tests to ensure it is "complete" > Note: maven-resolver demo snippets for guice, while used MavenResolverModule, > is and never will be in "lockstep", it used 3.5.0 of it, hence, the changes > in 3.6.2 were missed by it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7173) MavenResolverModule is broken/incomplete
[ https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804246#comment-17804246 ] ASF GitHub Bot commented on MNG-7173: - cstamas commented on PR #479: URL: https://github.com/apache/maven/pull/479#issuecomment-1880864067 This PR is defunct, Guice modules were removed in https://github.com/apache/maven/pull/1282 > MavenResolverModule is broken/incomplete > > > Key: MNG-7173 > URL: https://issues.apache.org/jira/browse/MNG-7173 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > > The MavenResolverModule is broken/incomplete since 3.6.2 (or 3.6.3). But as > we have no tests for it, this went completely unnoticed and is seen by > downstream clients only. > In maven-resolver-provider we need to: > a) fix the MavenResolverModule, make it complete (related to ModelBuilder > deps) > b) add tests to ensure it is "complete" > Note: maven-resolver demo snippets for guice, while used MavenResolverModule, > is and never will be in "lockstep", it used 3.5.0 of it, hence, the changes > in 3.6.2 were missed by it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken [maven]
cstamas commented on PR #479: URL: https://github.com/apache/maven/pull/479#issuecomment-1880864067 This PR is defunct, Guice modules were removed in https://github.com/apache/maven/pull/1282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken [maven]
cstamas closed pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken URL: https://github.com/apache/maven/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [EXPERIMENT] Expose depMgr to use with Maven [maven]
cstamas commented on PR #1000: URL: https://github.com/apache/maven/pull/1000#issuecomment-1880858859 Superseded by https://github.com/apache/maven/pull/1357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [EXPERIMENT] Expose depMgr to use with Maven [maven]
cstamas closed pull request #1000: [EXPERIMENT] Expose depMgr to use with Maven URL: https://github.com/apache/maven/pull/1000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [EXPERIMENT] Jetty transport [maven]
cstamas commented on PR #886: URL: https://github.com/apache/maven/pull/886#issuecomment-1880854298 This PR experiment is done, resolver has now JDK (added to Maven) and Jetty transport. Simplest way to use Jetty is to just define it as extension in `.mvn/extensions.xml` and it will prevail as it has highest priority. Is not included in Maven distro by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [EXPERIMENT] Jetty transport [maven]
cstamas closed pull request #886: [EXPERIMENT] Jetty transport URL: https://github.com/apache/maven/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-502) NPE in EnhancedPluginDescriptorBuilder with Maven 4.x
[
https://issues.apache.org/jira/browse/MPLUGIN-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804233#comment-17804233
]
Michael Osipov commented on MPLUGIN-502:
Interesting, which of those commits do fix this issue?
> NPE in EnhancedPluginDescriptorBuilder with Maven 4.x
> -
>
> Key: MPLUGIN-502
> URL: https://issues.apache.org/jira/browse/MPLUGIN-502
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.10.2, 3.11.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> With Maven 4.x (4.0.0-alpha-10) we have:
> {noformat}
> Caused by: java.lang.NullPointerException: Cannot invoke
> "org.codehaus.plexus.configuration.PlexusConfiguration.getChild(String)"
> because "this.configuration" is null
> at
> org.apache.maven.plugins.plugin.descriptor.EnhancedPluginDescriptorBuilder.build(EnhancedPluginDescriptorBuilder.java:75)
> at
> org.apache.maven.plugin.descriptor.PluginDescriptorBuilder.build(PluginDescriptorBuilder.java:63)
> at
> org.apache.maven.plugin.plugin.report.PluginReport.extractPluginDescriptor(PluginReport.java:163)
> at
> org.apache.maven.plugin.plugin.report.PluginReport.executeReport(PluginReport.java:148)
> at
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:289)
> {noformat}
> Also ITs in {{maven-plugin-report-plugin}} fails with Maven 4.x
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7977) Do not resolve projects outside the reactor (revert MNG-1088)
[ https://issues.apache.org/jira/browse/MNG-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7977. Resolution: Fixed > Do not resolve projects outside the reactor (revert MNG-1088) > - > > Key: MNG-7977 > URL: https://issues.apache.org/jira/browse/MNG-7977 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7977) Do not resolve projects outside the reactor (revert MNG-1088)
[ https://issues.apache.org/jira/browse/MNG-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804227#comment-17804227 ] ASF GitHub Bot commented on MNG-7977: - gnodet merged PR #1330: URL: https://github.com/apache/maven/pull/1330 > Do not resolve projects outside the reactor (revert MNG-1088) > - > > Key: MNG-7977 > URL: https://issues.apache.org/jira/browse/MNG-7977 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7977] Fix reactor reader to not resolve any artifacts from projects being built outside the reactor [maven]
gnodet merged PR #1330: URL: https://github.com/apache/maven/pull/1330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Disable MNG-1088 test for MNG-7977 [maven-integration-testing]
gnodet merged PR #329: URL: https://github.com/apache/maven-integration-testing/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7995) Switch to JLine to provide line editing
[ https://issues.apache.org/jira/browse/MNG-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7995. Resolution: Fixed > Switch to JLine to provide line editing > --- > > Key: MNG-7995 > URL: https://issues.apache.org/jira/browse/MNG-7995 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7995) Switch to JLine to provide line editing
[ https://issues.apache.org/jira/browse/MNG-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804226#comment-17804226 ] ASF GitHub Bot commented on MNG-7995: - gnodet merged PR #1279: URL: https://github.com/apache/maven/pull/1279 > Switch to JLine to provide line editing > --- > > Key: MNG-7995 > URL: https://issues.apache.org/jira/browse/MNG-7995 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7995] Switch to JLine to provide line editing [maven]
gnodet merged PR #1279: URL: https://github.com/apache/maven/pull/1279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7995) Switch to JLine to provide line editing
Guillaume Nodet created MNG-7995: Summary: Switch to JLine to provide line editing Key: MNG-7995 URL: https://issues.apache.org/jira/browse/MNG-7995 Project: Maven Issue Type: New Feature Reporter: Guillaume Nodet Assignee: Guillaume Nodet Fix For: 4.0.0, 4.0.0-alpha-11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
