[jira] [Commented] (SUREFIRE-2147) JUnit5 DynamicContainer/DynamicTest report loses the hierarchical structure
[
https://issues.apache.org/jira/browse/SUREFIRE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808437#comment-17808437
]
Geoff Soutter commented on SUREFIRE-2147:
-
Had a quick look at 3.2.5 to see if any changes.
Not sure if I noticed before, but tried 3.2.5 on a real use case, which maps a
folder structure into Dynamic tests. Therefore I have parent Containers nested
inside child Containers. The current implementation seems to throw away the
parent containers, only the leaf container is shown in the report.
I think I can live with the rest of the behaviour, but throwing away "parent"
container names fundamentally breaks my use case.
Hopefully I can set aside some time to do contribute a PR for this (although
I've promised that a few times already and yet to deliver anything. Sigh).
> JUnit5 DynamicContainer/DynamicTest report loses the hierarchical structure
> ---
>
> Key: SUREFIRE-2147
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2147
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M7
>Reporter: Geoff Soutter
>Priority: Major
>
> h3. Description of the issue
> I created a simple example of JUnit5 DynamicContainer/DynamicTest
> {code:java}
> package samplepackage;
> ...
> public class SampleTest {
> @TestFactory
> Collection createDynamicTests() {
> List testList = new ArrayList<>();
> testList.add(DynamicTest.dynamicTest("test1", new MyExecutable()));
> testList.add(DynamicTest.dynamicTest("test2", new MyExecutable()));
> List root = new ArrayList<>();
> root.add(DynamicContainer.dynamicContainer("aFolder", testList));
> return root;
> }
> private static class MyExecutable implements Executable {
> @Override
> public void execute() throws Throwable {
> }
> }
> }
> {code}
> When I run this in IDEA. I get the following hierarchical structure in the UI
> treeview
> * SampleTest
> ** createDynamicTests()
> *** aFolder
> test1
> test2
> Here we can see that dynamic tests are represented by IDEA as nested children
> of the test method. We can open and close the "virtual packages" created as
> usual to explore in the dynamically created test results. It is not a "flat
> list".
> Using surefire 3.0.0-m7, with the example "phrased" reporter configuration
> enabled, it creates contents in surefire-reports like so:
> {code:java}
>classname="samplepackage.SampleTest" time="0.02"/>
>classname="samplepackage.SampleTest" time="0.001"/>
> {code}
> Here all the nested synthetic tests are created as synthetic "methods" of a
> single class in the HTML report. The DynamicContainer and DynamicTest names
> are injected into the synthetic "method" name. That is, from a reporting
> perspective, they are created as a flat list (also it seems the folder name
> is in the wrong place, it seems it should be on the left of the method name,
> eg "createDynamicTests() aFolder test1" in order for the report to match the
> internal structure).
> This doesn't scale nicely as the number of tests in the dynamically created
> "folder" structure grows. We can't view the different DynamicContainers
> separately in the rendered HTML reports. We can't get a breakdown on any
> particular DynamicContainer in the rendered HTML reports.
> h3. Solution Ideas
> I think what we want here is that dynamic tests using dynamic containers
> should have those container names structured as synthetic packages. This
> allows us the benefits of having the nested structure modelled correctly in
> the HTML report.
> That is, when mapping from DynamicTests to Java packages, we have:
> || Java Structure || Dynamic Test Structure ||
> | package identifier | DynamicContainer name |
> | simple class name | static placeholder (e.g. Tests) |
> | method name | DynamicTest name |
>
> I think we could do that by moving the method name and folder name from name=
> into classname= and adding a static placeholder for the classname.
> {code:java}
>classname="samplepackage.SampleTest.createDynamicTests().aFolder.Tests"/>
>classname="samplepackage.SampleTest.createDynamicTests().aFolder.Tests"/>
> {code}
> Or if we considered the java package is a distraction when using dynamic tests
> {code:java}
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8014) Maven concurrent model builder deadlocks
[ https://issues.apache.org/jira/browse/MNG-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808367#comment-17808367 ] Guillaume Nodet commented on MNG-8014: -- The current multithreaded project builder implementation is wrong. In its design, it can cause the fork join pool to deadlock. Deadlock can occur when a task is waiting for the result of another task that is waiting for the resources locked by the first task, resulting in a circular dependency. A way to solve the problem would be use async/await constructs: Java 8 introduced CompletableFuture, which provides async/await-like features. By utilising these constructs, we can asynchronously wait for multiple task results without blocking the ForkJoinPool's threads. > Maven concurrent model builder deadlocks > > > Key: MNG-8014 > URL: https://issues.apache.org/jira/browse/MNG-8014 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-10 >Reporter: Guillaume Nodet >Priority: Major > > Building [https://github.com/gnodet/quarkus/tree/maven-deadlock] with Maven > 4.0.0-alpha-12 deadlocks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHADE-465) Limit depth of transitive dependency promotion
Bryan Beaudreault created MSHADE-465:
Summary: Limit depth of transitive dependency promotion
Key: MSHADE-465
URL: https://issues.apache.org/jira/browse/MSHADE-465
Project: Maven Shade Plugin
Issue Type: Improvement
Reporter: Bryan Beaudreault
In order for a shaded jar to be a drop-in replacement,
promoteTransitiveDependencies should be true. This has an annoying side-effect
of flattening the dependency tree. For example, suppose you have a project
named MyShadeModule with the following dependency tree:
{code:java}
MyShadeModule
-> Module A
-> Module B
-> Module D
-> Module E
-> Module C {code}
Let's say you include Module A in the shaded jar. If
promoteTransitiveDependencies you'll end up with the following:
{code:java}
MyShadeModule
-> Module B
-> Module D
-> Module E
-> Module C {code}
This is a frustrating result, because let's you have Module B under
dependencyManagement in a downstream project. Which version you pin Module B to
might dictate which transitive dependencies it would normally include. For
example maybe Module B 1.0 depends on D and E, while 2.0 depends only on F. In
a normal non-shaded environment, your downstream project would end up depending
on modules B, F, and C. But if you depend on a shaded artifact, you end up with
modules B, D, E, F, C.
It would be preferable to limit the max depth of transitive promotion, so that
you can end up with the more accurate:
{code:java}
MyShadeModule
-> Module B
-> Module C {code}
If you import that module into a downstream project, maven will resolve the
transitive dependencies for Module B. This way you can take into account any
dependencyManagement in the downstream project.
I realize this may not be the desired behavior for everyone, so it might be
good to be a new config option.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] please add java 21 support [maven-pmd-plugin]
wac84s commented on PR #141: URL: https://github.com/apache/maven-pmd-plugin/pull/141#issuecomment-1899138459 @adangel Here is the line where I think my error is thrown and its thrown from the plugin. Will following those steps make that go away? The comments on the link you sent looks like its not straight forward. https://github.com/apache/maven-pmd-plugin/blob/10b45e7edb7d484714558da7f5ea7b534b446f24/src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java#L166 https://github.com/apache/maven-pmd-plugin/assets/141072080/43a2d667-25af-4332-9526-ceafd5a7c2bd;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-723) Optionally expose document location in Sink
[
https://issues.apache.org/jira/browse/DOXIA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808323#comment-17808323
]
ASF GitHub Bot commented on DOXIA-723:
--
kwin commented on code in PR #194:
URL: https://github.com/apache/maven-doxia/pull/194#discussion_r1457779802
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractLocator.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.sink.impl;
+
+import org.apache.maven.doxia.sink.Locator;
+
+/**
+ * @since 2.0.0
+ */
+public abstract class AbstractLocator implements Locator {
+
+private String reference;
+
+protected AbstractLocator(String reference) {
+super();
+this.reference = reference;
+}
+
+@Override
+public String getReference() {
+return reference;
+}
+
+@Override
+public String getLogPrefix() {
+return formatLocation(this);
+}
+
+/**
+ * Creates a string with line/column information. Inspired by
+ * {@code o.a.m.model.building.ModelProblemUtils.formatLocation(...)}.
+ *
+ * @param locator The locator must not be {@code null}.
+ * @return The formatted location or an empty string if unknown, never
{@code null}.
+ */
+public static String formatLocation(Locator locator) {
Review Comment:
Moved in
https://github.com/apache/maven-doxia/pull/194/commits/ed298b000c4f95578755e8233cd0a4fb59dc2e8c.
> Optionally expose document location in Sink
> ---
>
> Key: DOXIA-723
> URL: https://issues.apache.org/jira/browse/DOXIA-723
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Sink API
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Similar to http://www.saxproject.org/apidoc/org/xml/sax/Locator.html the Sink
> API should provide means to figure out the document location. This should be
> available whenever the Sink events are emitted from parsing a file.
> The locator should expose file name, line number and column number.
> This can be used enhance warning/errors as otherwise it is very hard to
> figure out the root cause of messages like
> https://github.com/apache/maven-doxia/blob/e01880801ca1283b86205e2f7064b9b4dbc84d54/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L930.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-723] Expose document location in Sink [maven-doxia]
kwin commented on code in PR #194:
URL: https://github.com/apache/maven-doxia/pull/194#discussion_r1457779802
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractLocator.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.sink.impl;
+
+import org.apache.maven.doxia.sink.Locator;
+
+/**
+ * @since 2.0.0
+ */
+public abstract class AbstractLocator implements Locator {
+
+private String reference;
+
+protected AbstractLocator(String reference) {
+super();
+this.reference = reference;
+}
+
+@Override
+public String getReference() {
+return reference;
+}
+
+@Override
+public String getLogPrefix() {
+return formatLocation(this);
+}
+
+/**
+ * Creates a string with line/column information. Inspired by
+ * {@code o.a.m.model.building.ModelProblemUtils.formatLocation(...)}.
+ *
+ * @param locator The locator must not be {@code null}.
+ * @return The formatted location or an empty string if unknown, never
{@code null}.
+ */
+public static String formatLocation(Locator locator) {
Review Comment:
Moved in
https://github.com/apache/maven-doxia/pull/194/commits/ed298b000c4f95578755e8233cd0a4fb59dc2e8c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-728) MarkdownSink: Support blockquotes
[ https://issues.apache.org/jira/browse/DOXIA-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808319#comment-17808319 ] Konrad Windszus commented on DOXIA-728: --- Let's call it an improvement. Right now blockquotes are silently ignored. > MarkdownSink: Support blockquotes > - > > Key: DOXIA-728 > URL: https://issues.apache.org/jira/browse/DOXIA-728 > Project: Maven Doxia > Issue Type: Improvement >Affects Versions: 2.0.0-M9 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-728) MarkdownSink: Support blockquotes
[ https://issues.apache.org/jira/browse/DOXIA-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-728: -- Issue Type: Improvement (was: Bug) > MarkdownSink: Support blockquotes > - > > Key: DOXIA-728 > URL: https://issues.apache.org/jira/browse/DOXIA-728 > Project: Maven Doxia > Issue Type: Improvement >Affects Versions: 2.0.0-M9 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-904) Drop go-offline goal
[ https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MDEP-904: - Description: The simplest and trivial way to "go offline" is to build the project with empty local repository and use that. There are two "go offline" mojos out there (ours and an independent one) and both suffer from issues like "annotation processor is not downloaded", etc. This will just become worse. But not only this: by NOT building but by artificially collecting artifacts needed for build and resolving them (not doable correctly, only "almost correctly") messes up the recorded contexts in the reverse dependency tree in local repository as well. Remember, Maven2 times are past, Maven3+ local repository is much much more than Maven2 local repository was, just a bunch a files... Related issues: * https://issues.apache.org/jira/browse/MRESOLVER-262 * https://issues.apache.org/jira/browse/MNG-7619 was: The simplest and trivial way to "go offline" is to build the project with empty local repository and use that. There are two "go offline" mojos out there (ours and an independent one) and both suffer from issues like "annotation processor is not downloaded", etc. This will just become worse. But not only this: by NOT building but by artificially collecting artifacts needed for build (not doable correctly, only "almost correctly") messes up the recorded contexts in the reverse dependency tree in local repository as well. Remember, Maven2 times are past, Maven3+ local repository is much much more than Maven2 local repository was, just a bunch a files... Related issues: * https://issues.apache.org/jira/browse/MRESOLVER-262 * https://issues.apache.org/jira/browse/MNG-7619 > Drop go-offline goal > > > Key: MDEP-904 > URL: https://issues.apache.org/jira/browse/MDEP-904 > Project: Maven Dependency Plugin > Issue Type: Task > Components: go-offline >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0 > > > The simplest and trivial way to "go offline" is to build the project with > empty local repository and use that. > There are two "go offline" mojos out there (ours and an independent one) and > both suffer from issues like "annotation processor is not downloaded", etc. > This will just become worse. But not only this: by NOT building but by > artificially collecting artifacts needed for build and resolving them (not > doable correctly, only "almost correctly") messes up the recorded contexts in > the reverse dependency tree in local repository as well. > Remember, Maven2 times are past, Maven3+ local repository is much much more > than Maven2 local repository was, just a bunch a files... > Related issues: > * https://issues.apache.org/jira/browse/MRESOLVER-262 > * https://issues.apache.org/jira/browse/MNG-7619 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MDEP-904) Drop go-offline goal
Tamas Cservenak created MDEP-904: Summary: Drop go-offline goal Key: MDEP-904 URL: https://issues.apache.org/jira/browse/MDEP-904 Project: Maven Dependency Plugin Issue Type: Task Components: go-offline Reporter: Tamas Cservenak Fix For: 4.0.0 The simplest and trivial way to "go offline" is to build the project with empty local repository and use that. There are two "go offline" mojos out there (ours and an independent one) and both suffer from issues like "annotation processor is not downloaded", etc. This will just become worse. But not only this: by NOT building but by artificially collecting artifacts needed for build (not doable correctly, only "almost correctly") messes up the recorded contexts in the reverse dependency tree in local repository as well. Remember, Maven2 times are past, Maven3+ local repository is much much more than Maven2 local repository was, just a bunch a files... Related issues: * https://issues.apache.org/jira/browse/MRESOLVER-262 * https://issues.apache.org/jira/browse/MNG-7619 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8021) The user properties and system properties on session should be immutable
[ https://issues.apache.org/jira/browse/MNG-8021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808280#comment-17808280 ] Tamas Cservenak commented on MNG-8021: -- Component: API, so this is about new V4 API > The user properties and system properties on session should be immutable > > > Key: MNG-8021 > URL: https://issues.apache.org/jira/browse/MNG-8021 > Project: Maven > Issue Type: Bug > Components: API >Affects Versions: 4.0.0-alpha-12 >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-13 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-728) MarkdownSink: Support blockquotes
[ https://issues.apache.org/jira/browse/DOXIA-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808279#comment-17808279 ] Michael Osipov commented on DOXIA-728: -- is this a bug or a new feature? > MarkdownSink: Support blockquotes > - > > Key: DOXIA-728 > URL: https://issues.apache.org/jira/browse/DOXIA-728 > Project: Maven Doxia > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8021) The user properties and system properties on session should be immutable
[ https://issues.apache.org/jira/browse/MNG-8021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808278#comment-17808278 ] Michael Osipov commented on MNG-8021: - Why is this a bug and what is the rationale behind this? > The user properties and system properties on session should be immutable > > > Key: MNG-8021 > URL: https://issues.apache.org/jira/browse/MNG-8021 > Project: Maven > Issue Type: Bug > Components: API >Affects Versions: 4.0.0-alpha-12 >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-13 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2233) Unable to create file for report (File name too long)
[
https://issues.apache.org/jira/browse/SUREFIRE-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808261#comment-17808261
]
Filipe Roque commented on SUREFIRE-2233:
{code:java}
❯ cat target/surefire-reports/2024-01-15T22-47-50_794-jvmRun1.dumpstream
# Created at 2024-01-15T22:47:51.248
ForkStarter IOException: Unable to create file for report:
/home/froque/workspace/testes/long-filenames/target/surefire-reports/package1.subpackage2.subpackage3.subpackage4.subpackage5.subpackage6.subpackage7.TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName.txt
(File name too long).
org.apache.maven.plugin.surefire.booterclient.output.MultipleFailureException:
Unable to create file for report:
/home/froque/workspace/testes/long-filenames/target/surefire-reports/package1.subpackage2.subpackage3.subpackage4.subpackage5.subpackage6.subpackage7.TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName.txt
(File name too long)
at
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.(ThreadedStreamConsumer.java:59)
at
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.(ThreadedStreamConsumer.java:107)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:546)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1241)
at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1090)
at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:910)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
at
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
at
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:206)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:283)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:226)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:407)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:348)
Suppressed: org.apache.maven.surefire.api.report.ReporterException: Unable
to create file for report:
/home/froque/workspace/testes/long-filenames/target/surefire-reports/package1.subpackage2.subpackage3.subpackage4.subpackage5.subpackage6.subpackage7.TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName.txt
(File name too long)
at
org.apache.maven.plugin.surefire.report.FileReporter.testSetCompleted(FileReporter.java:98)
at
org.apache.maven.plugin.surefire.report.FileReporter.testSetCompleted(FileReporter.java:42)
at
org.apache.maven.plugin.surefire.report.TestSetRunListener.testSetCompleted(TestSetRunListener.java:192)
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient$TestSetCompletedListener.handle(ForkClient.java:143)
at
[jira] [Created] (MNG-8021) The user properties and system properties on session should be immutable
Guillaume Nodet created MNG-8021: Summary: The user properties and system properties on session should be immutable Key: MNG-8021 URL: https://issues.apache.org/jira/browse/MNG-8021 Project: Maven Issue Type: Bug Components: API Affects Versions: 4.0.0-alpha-12 Reporter: Guillaume Nodet Fix For: 4.0.0-alpha-13 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808246#comment-17808246
]
ASF GitHub Bot commented on MNG-8006:
-
cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457526016
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.util.Map;
+
+import org.apache.maven.api.*;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * @since 4.0.0
+ */
+@Experimental
+public interface Properties extends Service {
+
+/**
+ * Creates a {@link org.apache.maven.api.Project} from a POM file.
Review Comment:
you did not refresh? You create comments that are outdated from start
:smile:
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808248#comment-17808248
]
ASF GitHub Bot commented on MNG-8006:
-
cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457527102
##
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##
@@ -73,15 +74,12 @@ public interface Session {
Map getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- *
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
Review Comment:
Added
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]
cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457526016
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.util.Map;
+
+import org.apache.maven.api.*;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * @since 4.0.0
+ */
+@Experimental
+public interface Properties extends Service {
+
+/**
+ * Creates a {@link org.apache.maven.api.Project} from a POM file.
Review Comment:
you did not refresh? You create comments that are outdated from start
:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457524210
##
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##
@@ -133,4 +134,10 @@ default String getId() {
@Nonnull
List getRemotePluginRepositories();
+
+/**
+ * Returns the effective project properties.
+ */
+@Nonnull
+Map getProperties();
Review Comment:
Ah, it's already immutable. It should be written in the javadoc. And maybe
point to `ProjectManager#setProperty` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808242#comment-17808242
]
ASF GitHub Bot commented on MNG-8006:
-
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457522507
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.util.Map;
+
+import org.apache.maven.api.*;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * @since 4.0.0
+ */
+@Experimental
+public interface Properties extends Service {
+
+/**
+ * Creates a {@link org.apache.maven.api.Project} from a POM file.
Review Comment:
Irrelevant copy/paste
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808243#comment-17808243
]
ASF GitHub Bot commented on MNG-8006:
-
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457524210
##
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##
@@ -133,4 +134,10 @@ default String getId() {
@Nonnull
List getRemotePluginRepositories();
+
+/**
+ * Returns the effective project properties.
+ */
+@Nonnull
+Map getProperties();
Review Comment:
Ah, it's already immutable. It should be written in the javadoc. And maybe
point to `ProjectManager#setProperty` ?
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808238#comment-17808238
]
ASF GitHub Bot commented on MNG-8006:
-
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457521290
##
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##
@@ -73,15 +74,12 @@ public interface Session {
Map getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- *
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
Review Comment:
Add `@see Properties#effectiveProperties(Project)` ?
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457522507
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.util.Map;
+
+import org.apache.maven.api.*;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * @since 4.0.0
+ */
+@Experimental
+public interface Properties extends Service {
+
+/**
+ * Creates a {@link org.apache.maven.api.Project} from a POM file.
Review Comment:
Irrelevant copy/paste
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808239#comment-17808239
]
ASF GitHub Bot commented on MNG-8006:
-
cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457521519
##
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##
@@ -73,15 +74,12 @@ public interface Session {
Map getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- *
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
*/
@Nonnull
-Map getEffectiveProperties();
+Map getEffectiveProperties(@Nullable Project project);
Review Comment:
Just did that with last two "javadoc" commit: ... each call returns "new
copy" of ...
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457520316
##
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##
@@ -73,15 +74,12 @@ public interface Session {
Map getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- *
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
*/
@Nonnull
-Map getEffectiveProperties();
+Map getEffectiveProperties(@Nullable Project project);
Review Comment:
We should specify if this map is mutable or not, and if mutable, if a new
map is created each time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]
cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457521519
##
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##
@@ -73,15 +74,12 @@ public interface Session {
Map getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- *
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
*/
@Nonnull
-Map getEffectiveProperties();
+Map getEffectiveProperties(@Nullable Project project);
Review Comment:
Just did that with last two "javadoc" commit: ... each call returns "new
copy" of ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808236#comment-17808236
]
ASF GitHub Bot commented on MNG-8006:
-
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457520316
##
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##
@@ -73,15 +74,12 @@ public interface Session {
Map getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- *
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
*/
@Nonnull
-Map getEffectiveProperties();
+Map getEffectiveProperties(@Nullable Project project);
Review Comment:
We should specify if this map is mutable or not, and if mutable, if a new
map is created each time.
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808234#comment-17808234
]
ASF GitHub Bot commented on MNG-8006:
-
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457519372
##
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##
@@ -133,4 +134,10 @@ default String getId() {
@Nonnull
List getRemotePluginRepositories();
+
+/**
+ * Returns the effective project properties.
+ */
+@Nonnull
+Map getProperties();
Review Comment:
I don't think introducing a mutable aspect here is a good idea. This map
should be made immutable imho.
Modifying project properties can be done using the `ProjectManager`.
> Provide a SPI so that extension can interact with user properties at session
> creation time
> --
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457519372
##
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##
@@ -133,4 +134,10 @@ default String getId() {
@Nonnull
List getRemotePluginRepositories();
+
+/**
+ * Returns the effective project properties.
+ */
+@Nonnull
+Map getProperties();
Review Comment:
I don't think introducing a mutable aspect here is a good idea. This map
should be made immutable imho.
Modifying project properties can be done using the `ProjectManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1287) Improve logging to understand why test run failed and report the right failed category
[ https://issues.apache.org/jira/browse/SUREFIRE-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808228#comment-17808228 ] Duo Zhang commented on SUREFIRE-1287: - [~tibordigana] There is an example https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/PR_20JDK8_20Hadoop3_20Check_20Report/ The build fails with 'There was a timeout in the fork', but I can not find any broken tests. We use surefire version 3.1.0. Thanks. > Improve logging to understand why test run failed and report the right failed > category > -- > > Key: SUREFIRE-1287 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1287 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Samarth Jain >Assignee: Tibor Digana >Priority: Major > Fix For: Backlog > > > As part of our automated jenkins builds that run after every checkin, we have > been seeing a lot of these failures: > Failed to execute goal > org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify > (ParallelStatsEnabledTest) on project phoenix-core: There was a timeout or > other error in the fork > Sample run: > https://builds.apache.org/job/Phoenix-master/1420/console > Unfortunately that bit of error information doesn't really help. It would be > good to know why exactly the fork timed out or failed. What we do know is > that some of the tests in the Junit category ParallelStatsDisabledTest failed > to complete. However, failsafe incorrectly reports the failed category as the > first category that ran. In this case it happened to be > ParallelStatsEnabledTest. Also to note is the fact that failsafe kicks off > next category run even before all the tests in the current category have > finished. I am not sure if that is by design or a bug. > FYI, [~jamestaylor]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIA-728) MarkdownSink: Support blockquotes
Konrad Windszus created DOXIA-728: - Summary: MarkdownSink: Support blockquotes Key: DOXIA-728 URL: https://issues.apache.org/jira/browse/DOXIA-728 Project: Maven Doxia Issue Type: Bug Affects Versions: 2.0.0-M9 Reporter: Konrad Windszus Assignee: Konrad Windszus -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-727) MarkdownSink: Incorrect escaping inside code spans
[
https://issues.apache.org/jira/browse/DOXIA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808225#comment-17808225
]
ASF GitHub Bot commented on DOXIA-727:
--
kwin opened a new pull request, #197:
URL: https://github.com/apache/maven-doxia/pull/197
Code cleanup to keep track of surrounding element contexts Remove redundant
flags
Get rid of deprecated classes
> MarkdownSink: Incorrect escaping inside code spans
> --
>
> Key: DOXIA-727
> URL: https://issues.apache.org/jira/browse/DOXIA-727
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to https://spec.commonmark.org/0.30/#backslash-escapes
> bq. Backslash escapes do not work in code blocks, code spans, autolinks, or
> raw HTML
> Currently the escaping is not disabled between {{Sink.inline(...)}} and
> {{Sink.inline(...)}} with "code" semantics (also used from
> {{Sink.monospaced()}}) (emits a code span) but only in between
> {{Sink.verbatim()}} and {{Sink.verbatim()_}} (emits a code block).
> autolinks and raw HTML are currently either never emitted or don't use
> escaping
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-379) Support PMD 7.0.0
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808218#comment-17808218
]
Andreas Dangel commented on MPMD-379:
-
[~chonton] In order to use PMD 7.0.0-rc4 (and later) with maven-pmd-plugin,
please follow the instructions at [pmd/pmd#4478
(comment)|https://github.com/pmd/pmd/discussions/4478#discussioncomment-7607566]
> Support PMD 7.0.0
> -
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7
> most likely means, that only PMD 7 will be supported onwards (no backwards
> compatibility supported).
> wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
>
> A snapshot version that is compatible with the current 7.0.0 release
> candidates is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
> {code:java}
>
> apache.snapshots
> Apache Snapshot Repository
> https://repository.apache.org/snapshots
>
> false
>
>
> true
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] Add Apple M1 build. [maven-mvnd]
radeva commented on issue #337: URL: https://github.com/apache/maven-mvnd/issues/337#issuecomment-1898412128 @ppalaga You can try [FlyCI](https://www.flyci.net/)'s M1 and M2 runners. They are on average 2x faster and 2x cheaper than GitHub's **AND** we have a **free tier for OSS projects** (see below). # Install Instructions 1. Install [FlyCI app](https://github.com/apps/flyci-prod) and 2. Easily replace one line of code and start using FlyCI runners: ```diff jobs: ci: -runs-on: macos-latest +runs-on: flyci-macos-large-latest-m1 steps: - name: Checkout repo uses: actions/checkout@v4 ``` # 500 mins/month Free for Public Repos Since your repo is public, FlyCI offers **500 mins/month of free M1 runner usage** with the `flyci-macos-large-latest-m1` runner for public projects. Don't hesitate to contact us in case the free tier doesn't suit your needs or you experience any issues with the runners. Our team is here to support you! Best Regards, Veselina Radeva Product Manager at [FlyCI](https://flyci.net/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8005] Add test for ide WorkspaceReader [maven-integration-testing]
cstamas merged PR #332: URL: https://github.com/apache/maven-integration-testing/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8005.
Resolution: Fixed
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808158#comment-17808158
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas merged PR #1385:
URL: https://github.com/apache/maven/pull/1385
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas merged PR #1385: URL: https://github.com/apache/maven/pull/1385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808145#comment-17808145
]
ASF GitHub Bot commented on MNG-8005:
-
gnodet closed pull request #1372: [MNG-8005] do not ignore ide WorkspaceReader
URL: https://github.com/apache/maven/pull/1372
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] do not ignore ide WorkspaceReader [maven]
gnodet closed pull request #1372: [MNG-8005] do not ignore ide WorkspaceReader URL: https://github.com/apache/maven/pull/1372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808141#comment-17808141
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457262151
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Fixed and also simplified, now chained WS omits possible null entries in
collection, thus all these become one liner.
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457262151
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Fixed and also simplified, now chained WS omits possible null entries in
collection, thus all these become one liner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808139#comment-17808139
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457256038
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Fixed.
But your comment is wrong: session factory _never used_ chained WSReader, it
was ONLY the default maven using it. Before this PR, the session could be
inited with request WS (if non null) OR the ide WS (that may be null).
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457256038
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Fixed.
But your comment is wrong: session factory _never used_ chained WSReader, it
was ONLY the default maven using it. Before this PR, the session could be
inited with request WS (if non null) OR the ide WS (that may be null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808136#comment-17808136
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457251737
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
yes, clearly IS possible (as copy of "origina" request is used), fixing...
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457251737
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
yes, clearly IS possible (as copy of "origina" request is used), fixing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808134#comment-17808134
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457250235
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Oh, you mean IF request has one as well? Hm, let me recheck is that
possible...
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457250235
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Oh, you mean IF request has one as well? Hm, let me recheck is that
possible...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808133#comment-17808133
]
ASF GitHub Bot commented on MNG-8005:
-
gnodet commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457247820
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Yes, I don't question the change or responsibilities, but a possible change
in behaviour.
The caller is `BootstrapCoreExtensionManager` and now responsible to set the
workspace reader on the session. What I'm wondering is if this leads back to
the same behaviour... I think before this PR, the workspace reader is to set a
chained one, now, it's only the `ide` one...
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
gnodet commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457247820
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Yes, I don't question the change or responsibilities, but a possible change
in behaviour.
The caller is `BootstrapCoreExtensionManager` and now responsible to set the
workspace reader on the session. What I'm wondering is if this leads back to
the same behaviour... I think before this PR, the workspace reader is to set a
chained one, now, it's only the `ide` one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808129#comment-17808129
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457239404
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
With this PR session factory does NOT set any workspace reader anymore (read
PR description and see code), it is _caller duty_
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457239404
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
With this PR session factory does NOT set any workspace reader anymore (read
PR description and see code), it is _caller duty_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-8005:
Assignee: Tamas Cservenak
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808127#comment-17808127
]
ASF GitHub Bot commented on MNG-8005:
-
gnodet commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457237963
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Won't that override the existing chained workspace reader ? is that the
intent ?
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8005] Fix workspace reader drop bug [maven]
gnodet commented on code in PR #1385:
URL: https://github.com/apache/maven/pull/1385#discussion_r1457237963
##
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java:
##
@@ -77,24 +79,29 @@ public class BootstrapCoreExtensionManager {
private final ClassRealm parentRealm;
+private final WorkspaceReader ideWorkspaceReader;
+
@Inject
public BootstrapCoreExtensionManager(
DefaultPluginDependenciesResolver pluginDependenciesResolver,
DefaultRepositorySystemSessionFactory
repositorySystemSessionFactory,
CoreExports coreExports,
-PlexusContainer container) {
+PlexusContainer container,
+@Nullable @Named("ide") WorkspaceReader ideWorkspaceReader) {
this.pluginDependenciesResolver = pluginDependenciesResolver;
this.repositorySystemSessionFactory = repositorySystemSessionFactory;
this.coreExports = coreExports;
this.classWorld = ((DefaultPlexusContainer) container).getClassWorld();
this.parentRealm = container.getContainerRealm();
+this.ideWorkspaceReader = ideWorkspaceReader;
}
public List loadCoreExtensions(
MavenExecutionRequest request, Set providedArtifacts,
List extensions)
throws Exception {
try (CloseableSession repoSession = repositorySystemSessionFactory
.newRepositorySessionBuilder(request)
+.setWorkspaceReader(ideWorkspaceReader)
Review Comment:
Won't that override the existing chained workspace reader ? is that the
intent ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808113#comment-17808113
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas commented on PR #1372:
URL: https://github.com/apache/maven/pull/1372#issuecomment-1898154815
Proposed PR that is a bit broader (but performs bigger and IMHO "proper"
cleanup in this area): https://github.com/apache/maven/pull/1385
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808112#comment-17808112
]
ASF GitHub Bot commented on MNG-8005:
-
cstamas opened a new pull request, #1385:
URL: https://github.com/apache/maven/pull/1385
Maven4 seems sets but then drops/overrides some workspace readers. Partially
due hazy borders who or what manages them, as role is split between session
factory and session factory caller.
Changes:
* session factory does NOTHING re workspace readers, it becomes fully the
caller duty
* two spots calling (default maven, extension bootstrap) are now fully in
charge to properly setup workspace readers
---
https://issues.apache.org/jira/browse/MNG-8005
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8005) IDE WorkspaceReader is ignored in Maven 4
[
https://issues.apache.org/jira/browse/MNG-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8005:
-
Fix Version/s: 4.0.0-alpha-13
(was: 4.0.x-candidate)
> IDE WorkspaceReader is ignored in Maven 4
> -
>
> Key: MNG-8005
> URL: https://issues.apache.org/jira/browse/MNG-8005
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-10
>Reporter: Jonas Rutishauser
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Since maven-4.0.0-alpha-4 the {{@Named("ide") WorkspaceReader}} (and the one
> from the {{MavenExecutionRequest}}) is no longer used.
> The [last
> commit|https://github.com/apache/maven/commit/f77de570b789d6e0c48c7d5001fdb4d9f663187c]
> of MNG-7646 introduced this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNG-8005] Fix workspace reader drop bug [maven]
cstamas opened a new pull request, #1385: URL: https://github.com/apache/maven/pull/1385 Maven4 seems sets but then drops/overrides some workspace readers. Partially due hazy borders who or what manages them, as role is split between session factory and session factory caller. Changes: * session factory does NOTHING re workspace readers, it becomes fully the caller duty * two spots calling (default maven, extension bootstrap) are now fully in charge to properly setup workspace readers --- https://issues.apache.org/jira/browse/MNG-8005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[ https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8006: Assignee: Tamas Cservenak > Provide a SPI so that extension can interact with user properties at session > creation time > -- > > Key: MNG-8006 > URL: https://issues.apache.org/jira/browse/MNG-8006 > Project: Maven > Issue Type: New Feature > Components: API >Reporter: Guillaume Nodet >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-13 > > > To cleanly support > [os-maven-plugin|https://github.com/trustin/os-maven-plugin/] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8006) Provide a SPI so that extension can interact with user properties at session creation time
[ https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8006: - Fix Version/s: 4.0.0 4.0.0-alpha-13 (was: 4.0.x-candidate) > Provide a SPI so that extension can interact with user properties at session > creation time > -- > > Key: MNG-8006 > URL: https://issues.apache.org/jira/browse/MNG-8006 > Project: Maven > Issue Type: New Feature > Components: API >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-13 > > > To cleanly support > [os-maven-plugin|https://github.com/trustin/os-maven-plugin/] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6399) Lift JDK minimum to JDK 8
[ https://issues.apache.org/jira/browse/MNG-6399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808085#comment-17808085 ] ASF GitHub Bot commented on MNG-6399: - cstamas commented on PR #1382: URL: https://github.com/apache/maven/pull/1382#issuecomment-1898028397 Related issue https://issues.apache.org/jira/browse/MNG-8011 > Lift JDK minimum to JDK 8 > - > > Key: MNG-6399 > URL: https://issues.apache.org/jira/browse/MNG-6399 > Project: Maven > Issue Type: Task >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0 > > Attachments: maven-3.9.6-zip-content.png > > > I would like to lift the minimum of Maven Core to JDK 8 (I think it's time).. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6399] Lift JDK minimum to JDK 8 [maven]
cstamas commented on PR #1382: URL: https://github.com/apache/maven/pull/1382#issuecomment-1898028397 Related issue https://issues.apache.org/jira/browse/MNG-8011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2233) Unable to create file for report (File name too long)
[
https://issues.apache.org/jira/browse/SUREFIRE-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808065#comment-17808065
]
Michael Osipov commented on SUREFIRE-2233:
--
What does the dump file say?
> Unable to create file for report (File name too long)
> --
>
> Key: SUREFIRE-2233
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2233
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.2.5
> Environment: Linux with encripted home using ecryptfs
>Reporter: Filipe Roque
>Priority: Major
>
> surefire tries to create report files where the filename includes the package.
> On Linux with eCryptfs, it easily fails with _File name too long_ ([What is
> the maximum allowed filename (and folder) size with
> eCryptfs?|https://unix.stackexchange.com/questions/32795/what-is-the-maximum-allowed-filename-and-folder-size-with-ecryptfs/32834]),
> without failing the maven build.
>
> * Should this error fail the build ?
> * What is the solution for this, besides shorter packages and file names, or
> non encrypted file systems ?
> ** Maybe create sub directories under target/surefire-reports matching the
> packages
> ** shorten the filename like logback
> ([https://logback.qos.ch/manual/layouts.html#conversionWord])
>
> *pom.xml*
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> org.example
> long-filenames
> 1.0-SNAPSHOT
>
>21
>21
>UTF-8
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> 5.10.1
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.2.5
>
>
>
>
> {code}
> {*}src/test/java/package1/subpackage2/subpackage3/subpackage4/subpackage5/subpackage6/subpackage7/TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName.java{*}{*}{{*}}
>
> {code:java}
> package
> package1.subpackage2.subpackage3.subpackage4.subpackage5.subpackage6.subpackage7;
> import org.junit.jupiter.api.Assertions;
> import org.junit.jupiter.api.Test;
> public class
> TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName {
> @Test
> public void test() {
>Assertions.assertTrue(true);
> }
> }
> {code}
>
>
>
>
> {code:java}
> ❯ /opt/maven/apache-maven-3.9.5/bin/mvn clean test
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -< org.example:long-filenames
> >-
> [INFO] Building long-filenames 1.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- clean:3.2.0:clean (default-clean) @ long-filenames ---
> [INFO] Deleting /home/froque/workspace/testes/long-filenames/target
> [INFO]
> [INFO] --- resources:3.3.1:resources (default-resources) @ long-filenames ---
> [INFO] Copying 0 resource from src/main/resources to target/classes
> [INFO]
> [INFO] --- compiler:3.11.0:compile (default-compile) @ long-filenames ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- resources:3.3.1:testResources (default-testResources) @
> long-filenames ---
> [INFO] skip non existing resourceDirectory
> /home/froque/workspace/testes/long-filenames/src/test/resources
> [INFO]
> [INFO] --- compiler:3.11.0:testCompile (default-testCompile) @ long-filenames
> ---
> [INFO] Changes detected - recompiling the module! :source
> [INFO] Compiling 1 source file with javac [debug target 21] to
> target/test-classes
> [INFO]
> [INFO] --- surefire:3.2.5:test (default-test) @ long-filenames ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running
> package1.subpackage2.subpackage3.subpackage4.subpackage5.subpackage6.subpackage7.TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName
> [WARNING] ForkStarter IOException: Unable to create file for report:
> /home/froque/workspace/testes/long-filenames/target/surefire-reports/package1.subpackage2.subpackage3.subpackage4.subpackage5.subpackage6.subpackage7.TestWithAVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongFileName.txt
> (File name too long). See the dump file
> /home/froque/workspace/testes/long-filenames/target/surefire-reports/2024-01-15T22-47-50_794-jvmRun1.dumpstream
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
[jira] [Commented] (DOXIASITETOOLS-327) Support multi-language for menu "name"
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808064#comment-17808064
]
Michael Osipov commented on DOXIASITETOOLS-327:
---
Because you supply a whole tree of docs and resources, not just {{site.xml}},
you can also have localized reports. All that wouldn't work out of one site
descriptor.
> Support multi-language for menu "name"
> --
>
> Key: DOXIASITETOOLS-327
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-327
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M16
>Reporter: Abel Salgado Romero
>Priority: Minor
> Fix For: waiting-for-feedback
>
> Attachments: image-2024-01-16-23-19-41-511.png
>
>
> The new v2.0.x-MX added multi-lang / locale support to build pages, but seems
> the `site.xml` does not allow to change the name of a menu element.
> For example, a page with "en" and "es" versions and menu "Hello", will show
> "Hello" in the Spanish site too, no way to specify "Hola".
>
> I peeked at the code and I see two options:
> # Modify MenuItem to allow a sub name element like ` locale="es">Hola`
> # Allow injection of language ResourceBundle properties in the current
> element: ``
> I like the second and will try to explore that, I saw the generated code
> provides a transformer method for values, just need to find how to inject
> custom logic there 樂
> !image-2024-01-16-23-19-41-511.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
