[PR] Update GitHub actions to v4 [maven]
slawekjaranowski opened a new pull request, #1472: URL: https://github.com/apache/maven/pull/1472 Avoid warning like: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` and be up to-day -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on code in PR #177:
URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1572746343
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.PathMatcher;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import org.apache.maven.doxia.parser.Parser;
+import org.apache.maven.doxia.siterenderer.ParserConfigurator;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.codehaus.plexus.PlexusContainer;
+import
org.codehaus.plexus.component.configurator.ComponentConfigurationException;
+import org.codehaus.plexus.component.configurator.ComponentConfigurator;
+import
org.codehaus.plexus.component.repository.exception.ComponentLifecycleException;
+import
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+
+/**
+ * Configures a parser based on a {@link PlexusConfiguration} for a particular
parser id and optionally matching one of multiple patterns.
+ * It internally leverages the {@link ComponentConfigurator} for calling the
right methods inside the parser implementation.
+ */
+public class ParserConfiguratorImpl implements ParserConfigurator, Closeable {
+
+private static final class ParserConfigurationKey {
+
+ParserConfigurationKey(String parserId, PlexusConfiguration
patternsConfiguration) {
+this(parserId,
PlexusConfigurationUtils.getStringArrayValues(patternsConfiguration));
+}
+
+ParserConfigurationKey(String parserId, Collection patterns) {
+this.parserId = parserId;
+// lazily populate all matchers
+matchers = patterns.stream()
+.map(p -> FileSystems.getDefault().getPathMatcher(p))
+.collect(Collectors.toList());
Review Comment:
I wonder how this might deviate from what we use to match path patterns. I
not opposing, just mentioning. People are used the stuff we have with Plexus
matching. Keep that in mind.
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.PathMatcher;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import org.apache.maven.doxia.parser.Parser;
+import org.apache.maven.doxia.siterenderer.ParserConfigurator;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.codehaus.plexus.PlexusContainer;
+import
org.codehaus.plexus.component.configurator.ComponentConfigurationException;
+import org.codehaus.plexus.component.configurator.ComponentConfigurator;
+import
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839082#comment-17839082
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on code in PR #177:
URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1572746343
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.PathMatcher;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import org.apache.maven.doxia.parser.Parser;
+import org.apache.maven.doxia.siterenderer.ParserConfigurator;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.codehaus.plexus.PlexusContainer;
+import
org.codehaus.plexus.component.configurator.ComponentConfigurationException;
+import org.codehaus.plexus.component.configurator.ComponentConfigurator;
+import
org.codehaus.plexus.component.repository.exception.ComponentLifecycleException;
+import
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+
+/**
+ * Configures a parser based on a {@link PlexusConfiguration} for a particular
parser id and optionally matching one of multiple patterns.
+ * It internally leverages the {@link ComponentConfigurator} for calling the
right methods inside the parser implementation.
+ */
+public class ParserConfiguratorImpl implements ParserConfigurator, Closeable {
+
+private static final class ParserConfigurationKey {
+
+ParserConfigurationKey(String parserId, PlexusConfiguration
patternsConfiguration) {
+this(parserId,
PlexusConfigurationUtils.getStringArrayValues(patternsConfiguration));
+}
+
+ParserConfigurationKey(String parserId, Collection patterns) {
+this.parserId = parserId;
+// lazily populate all matchers
+matchers = patterns.stream()
+.map(p -> FileSystems.getDefault().getPathMatcher(p))
+.collect(Collectors.toList());
Review Comment:
I wonder how this might deviate from what we use to match path patterns. I
not opposing, just mentioning. People are used the stuff we have with Plexus
matching. Keep that in mind.
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.PathMatcher;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import org.apache.maven.doxia.parser.Parser;
+import org.apache.maven.doxia.siterenderer.ParserConfigurator;
+import
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on code in PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1572744522 ## src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java: ## @@ -94,6 +97,37 @@ public abstract class AbstractSiteRenderingMojo extends AbstractSiteDescriptorMo @Parameter private Map attributes; +/** + * Parser configurations (per matching Doxia markup source file path patterns). + * Each configuration item has the following format: + * + * + * parserId + * configurations + * configuration + * patterns + * patternglob:***.md/pattern!-- is either glob or regex syntax with the according prefix -- + * /patterns + * !-- all configurations apart from pattern are directly applied to the underlying parser -- + * emitCommentstrue/emitComments!-- false by default -- + * emitAnchorsForIndexableEntriesfalse/emitAnchorsForIndexableEntries!-- true by default -- + * /configuration + * /configurations + * /parserId + * + * The configuration is only applied if both + * + * the parser id matches the parser used for a specific markup source file and + * one of the given patterns matches the Doxia markup source file path (or no pattern is given at all). + * + * + * The first matching configuration wins (i.e. is applied). + * @since 4.0.0 + * @see java.nio.file.FileSystem#getPathMatcher(String) FileSystem.getPathMatcher(String) for the supported patterns + */ +@Parameter +private Map> parserConfigurations; Review Comment: Do you want to support `*` parser? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839078#comment-17839078
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on code in PR #177:
URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1572744522
##
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##
@@ -94,6 +97,37 @@ public abstract class AbstractSiteRenderingMojo extends
AbstractSiteDescriptorMo
@Parameter
private Map attributes;
+/**
+ * Parser configurations (per matching Doxia markup source file path
patterns).
+ * Each configuration item has the following format:
+ *
+ *
+ * parserId
+ * configurations
+ * configuration
+ * patterns
+ * patternglob:***.md/pattern!
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8100) Upgrade default plugin bindings
[
https://issues.apache.org/jira/browse/MNG-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MNG-8100:
-
Description:
{noformat}
3.9.x
compiler3.11.0 -> 3.13.0
surefire3.2.2 -> 3.2.5
jar 3.3.0 -> 3.4.1
plugin 3.9.0 -> 3.12.0
4.x
compiler3.11.0 -> 3.13.0
surefire3.1.2 -> 3.2.5
jar 3.3.0 -> 3.4.1
plugin 3.9.0 -> 3.12.0
{noformat}
> Upgrade default plugin bindings
> ---
>
> Key: MNG-8100
> URL: https://issues.apache.org/jira/browse/MNG-8100
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.7, 4.0.0-alpha-14
>
>
> {noformat}
> 3.9.x
> compiler3.11.0 -> 3.13.0
> surefire3.2.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> 4.x
> compiler3.11.0 -> 3.13.0
> surefire3.1.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8101) Upgrade Parent to 42
Slawomir Jaranowski created MNG-8101: Summary: Upgrade Parent to 42 Key: MNG-8101 URL: https://issues.apache.org/jira/browse/MNG-8101 Project: Maven Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.9.7, 4.0.0-alpha-14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8100) Upgrade default plugin bindings
[ https://issues.apache.org/jira/browse/MNG-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MNG-8100: Assignee: Slawomir Jaranowski > Upgrade default plugin bindings > --- > > Key: MNG-8100 > URL: https://issues.apache.org/jira/browse/MNG-8100 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.7, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8100) Upgrade default plugin bindings
Slawomir Jaranowski created MNG-8100: Summary: Upgrade default plugin bindings Key: MNG-8100 URL: https://issues.apache.org/jira/browse/MNG-8100 Project: Maven Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Fix For: 3.9.7, 4.0.0-alpha-14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump resolverVersion from 1.9.18 to 1.9.19 [maven-deploy-plugin]
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/maven-deploy-plugin/pull/53 Bumps `resolverVersion` from 1.9.18 to 1.9.19. Updates `org.apache.maven.resolver:maven-resolver-api` from 1.9.18 to 1.9.19 Release notes Sourced from https://github.com/apache/maven-resolver/releases;>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12353946;>Release Notes - Maven Resolver - Version 1.9.19 What's Changed [1.9.x][MRESOLVER-483] Fix path concatenation logic by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/420;>apache/maven-resolver#420 [1.9.x] [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455;>#455) by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/461;>apache/maven-resolver#461 [1.9.x] Update dependencies by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/462;>apache/maven-resolver#462 [1.9.x] [MRESOLVER-536] Do not belly up if FS does not support setting mtime by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/469;>apache/maven-resolver#469 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19;>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19 Commits https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56;>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0;>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469;>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c;>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462;>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7;>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455;>#455) (https://redirect.github.com/apache/maven-resolver/issues/461;>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c;>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420;>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde;>a3e620d Use one Maven in CI https://github.com/apache/maven-resolver/commit/fff4bdf92fe10937975623db27a69ced5d1efcd1;>fff4bdf [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19;>compare view Updates `org.apache.maven.resolver:maven-resolver-util` from 1.9.18 to 1.9.19 Release notes Sourced from https://github.com/apache/maven-resolver/releases;>org.apache.maven.resolver:maven-resolver-util's releases. 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12353946;>Release Notes - Maven Resolver - Version 1.9.19 What's Changed [1.9.x][MRESOLVER-483] Fix path concatenation logic by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/420;>apache/maven-resolver#420 [1.9.x] [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455;>#455) by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/461;>apache/maven-resolver#461 [1.9.x] Update dependencies by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/462;>apache/maven-resolver#462 [1.9.x] [MRESOLVER-536] Do not belly up if FS does not support setting mtime by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/469;>apache/maven-resolver#469 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19;>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19 Commits https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56;>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0;>adadd42 [MRESOLVER-536] Do not belly up if FS does not
[jira] [Commented] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output
[
https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839071#comment-17839071
]
ASF GitHub Bot commented on MSITE-1006:
---
michael-o opened a new pull request, #183:
URL: https://github.com/apache/maven-site-plugin/pull/183
…tput
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSITE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSITE-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> MSITE-723 causes duplicate document rendering and log output
>
>
> Key: MSITE-1006
> URL: https://issues.apache.org/jira/browse/MSITE-1006
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration
>Affects Versions: 4.0.0-M13
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-M14
>
>
> Consider the following output:
> {noformat}
> ...
> [INFO] --- maven-site-plugin:3.12.1:site (default-site) @ doxia-skin-model ---
> [INFO] configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.5
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.5:
> index, summary, dependency-info, modules, team, scm, issue-management,
> mailing-lists, dependency-management, dependencies, dependency-convergence,
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site with default locale English (en)
> [INFO] Relativizing decoration links with respect to localized project URL:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-skin-model/
> [INFO] Rendering content with
> org.apache.maven.skins:maven-fluido-skin:jar:1.11.2 skin.
> [INFO] Skipped "About" report
> (maven-project-info-reports-plugin:3.4.5:index), file "index.html" already
> exists.
> [INFO] Rendering 2 Doxia documents: 1 apt, 1 xdoc
> [INFO] Generating "Summary" report ---
> maven-project-info-reports-plugin:3.4.5:summary
> [INFO] Generating "Dependency Information" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-info
> [INFO] Generating "Team" report ---
> maven-project-info-reports-plugin:3.4.5:team
> [INFO] Generating "Source Code Management" report ---
> maven-project-info-reports-plugin:3.4.5:scm
> [INFO] Generating "Issue Management" report ---
> maven-project-info-reports-plugin:3.4.5:issue-management
> [INFO] Generating "Mailing Lists" report---
> maven-project-info-reports-plugin:3.4.5:mailing-lists
> [INFO] Generating "Dependency Management" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-management
> [INFO] Generating "Dependencies" report ---
> maven-project-info-reports-plugin:3.4.5:dependencies
> [INFO] Generating "Dependency Convergence" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-convergence
> [INFO] Generating "CI Management" report---
> maven-project-info-reports-plugin:3.4.5:ci-management
> [INFO] Generating "Plugin Management"
[PR] [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… [maven-site-plugin]
michael-o opened a new pull request, #183: URL: https://github.com/apache/maven-site-plugin/pull/183 …tput Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839070#comment-17839070
]
ASF GitHub Bot commented on DOXIASITETOOLS-324:
---
michael-o commented on code in PR #140:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1572710975
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.siterenderer;
+
+import java.nio.file.Path;
+
+import org.apache.maven.doxia.parser.Parser;
+
+/**
+ * Interface which allows to configure a particular {@link Parser} before it
is being used.
+ */
+public interface ParserConfigurator {
+
+/**
+ * Configures the given parser, which is afterwards used to parse the
source file with the given path.
Review Comment:
`parser which`
> Allow configuration of parser per markup
>
>
> Key: DOXIASITETOOLS-324
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324
> Project: Maven Doxia Sitetools
> Issue Type: New Feature
> Components: Site renderer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the Doxia parsers being used for the Doxia markup sources have a
> fix configuration
> (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324).
> It would be beneficial to allow to dynamically configure the parsers (based
> on a matching markup source path pattern)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]
michael-o commented on code in PR #140:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1572710975
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.siterenderer;
+
+import java.nio.file.Path;
+
+import org.apache.maven.doxia.parser.Parser;
+
+/**
+ * Interface which allows to configure a particular {@link Parser} before it
is being used.
+ */
+public interface ParserConfigurator {
+
+/**
+ * Configures the given parser, which is afterwards used to parse the
source file with the given path.
Review Comment:
`parser which`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839058#comment-17839058
]
Michael Osipov commented on MSHARED-1382:
-
Will happily review a PR with [~sjaranowski].
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839051#comment-17839051
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o opened a new pull request, #150:
URL: https://github.com/apache/maven-doxia-sitetools/pull/150
…le aware
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o opened a new pull request, #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150 …le aware -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
Michael Osipov created DOXIASITETOOLS-336:
-
Summary: Make SiteRenderingContext#siteDirectories editable aware
Key: DOXIASITETOOLS-336
URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
Project: Maven Doxia Sitetools
Issue Type: Improvement
Components: Site renderer
Affects Versions: 2.0.0-M16
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.0.0, 2.0.0-M18
Right now you cannot qualify a {{siteDirectory}} whether the content is
editable or generated. You need to perform multiple calls with distinct
{{SiteRenderingContexts}}. This causes computational overhead is hacks like
MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven-mvnd]
dependabot[bot] commented on PR #942: URL: https://github.com/apache/maven-mvnd/pull/942#issuecomment-2066716893 Looks like org.codehaus.mojo:build-helper-maven-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven-mvnd]
dependabot[bot] closed pull request #942: Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 URL: https://github.com/apache/maven-mvnd/pull/942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven-mvnd]
cstamas commented on PR #942: URL: https://github.com/apache/maven-mvnd/pull/942#issuecomment-2066715525 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.40.0 to 2.43.0 [maven-mvnd]
dependabot[bot] commented on PR #948: URL: https://github.com/apache/maven-mvnd/pull/948#issuecomment-2066701975 Looks like com.diffplug.spotless:spotless-maven-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.40.0 to 2.43.0 [maven-mvnd]
dependabot[bot] closed pull request #948: Bump com.diffplug.spotless:spotless-maven-plugin from 2.40.0 to 2.43.0 URL: https://github.com/apache/maven-mvnd/pull/948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump groovy.version from 4.0.13 to 4.0.21 [maven-mvnd]
dependabot[bot] closed pull request #949: Bump groovy.version from 4.0.13 to 4.0.21 URL: https://github.com/apache/maven-mvnd/pull/949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump groovy.version from 4.0.13 to 4.0.21 [maven-mvnd]
dependabot[bot] commented on PR #949: URL: https://github.com/apache/maven-mvnd/pull/949#issuecomment-2066701868 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.gmavenplus:gmavenplus-plugin from 3.0.0 to 3.0.2 [maven-mvnd]
dependabot[bot] closed pull request #944: Bump org.codehaus.gmavenplus:gmavenplus-plugin from 3.0.0 to 3.0.2 URL: https://github.com/apache/maven-mvnd/pull/944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-plugin-api from 3.9.0 to 3.9.6 [maven-mvnd]
dependabot[bot] closed pull request #945: Bump org.apache.maven:maven-plugin-api from 3.9.0 to 3.9.6 URL: https://github.com/apache/maven-mvnd/pull/945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.gmavenplus:gmavenplus-plugin from 3.0.0 to 3.0.2 [maven-mvnd]
dependabot[bot] commented on PR #944: URL: https://github.com/apache/maven-mvnd/pull/944#issuecomment-2066701834 Looks like org.codehaus.gmavenplus:gmavenplus-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-plugin-api from 3.9.0 to 3.9.6 [maven-mvnd]
dependabot[bot] commented on PR #945: URL: https://github.com/apache/maven-mvnd/pull/945#issuecomment-2066701830 Looks like org.apache.maven:maven-plugin-api is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.graalvm.buildtools:native-maven-plugin from 0.9.23 to 0.10.1 [maven-mvnd]
dependabot[bot] closed pull request #941: Bump org.graalvm.buildtools:native-maven-plugin from 0.9.23 to 0.10.1 URL: https://github.com/apache/maven-mvnd/pull/941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.graalvm.buildtools:native-maven-plugin from 0.9.23 to 0.10.1 [maven-mvnd]
dependabot[bot] commented on PR #941: URL: https://github.com/apache/maven-mvnd/pull/941#issuecomment-2066701741 Looks like org.graalvm.buildtools:native-maven-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump io.takari.maven:takari-smart-builder from 0.6.4 to 0.6.5 [maven-mvnd]
dependabot[bot] closed pull request #940: Bump io.takari.maven:takari-smart-builder from 0.6.4 to 0.6.5 URL: https://github.com/apache/maven-mvnd/pull/940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump io.takari.maven:takari-smart-builder from 0.6.4 to 0.6.5 [maven-mvnd]
dependabot[bot] commented on PR #940: URL: https://github.com/apache/maven-mvnd/pull/940#issuecomment-2066701640 Looks like io.takari.maven:takari-smart-builder is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]
cstamas merged PR #933: URL: https://github.com/apache/maven-mvnd/pull/933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to build (dependabot reported) and other stuff [maven-mvnd]
cstamas merged PR #951: URL: https://github.com/apache/maven-mvnd/pull/951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] maven.config ${session.rootDirectory} interpolation is not working [maven-mvnd]
cstamas closed issue #910: maven.config ${session.rootDirectory} interpolation
is not working
URL: https://github.com/apache/maven-mvnd/issues/910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Update most comment (dependabot reported) and other stuff [maven-mvnd]
cstamas opened a new pull request, #951: URL: https://github.com/apache/maven-mvnd/pull/951 Most of cumulative things dependabot reported, plus more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/setup-java from 3 to 4 [maven-mvnd]
dependabot[bot] closed pull request #937: Bump actions/setup-java from 3 to 4 URL: https://github.com/apache/maven-mvnd/pull/937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/checkout from 3 to 4 [maven-mvnd]
dependabot[bot] commented on PR #935: URL: https://github.com/apache/maven-mvnd/pull/935#issuecomment-2066580563 Looks like actions/checkout is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonid Rozenblyum updated MSHARED-1382:
---
Description:
Let's add support for {{--no-snapshot-updates}} in
{{org.apache.maven.shared.invoker.InvocationRequest}}
Currently {{InvocationRequest}} supports just the {{'-U'}} mvn option which is
not enough: it's possible to force the snapshots update or keep default maven
policy on this.
But it's not possible to prevent snapshots updates which is highly desired
under some circumstances (e.g. for CI reproducibility).
NOTE: I may contribute a PR.
was:
Let's add support for `--no-snapshot-updates` in
`org.apache.maven.shared.invoker.InvocationRequest`
Currently `InvocationRequest` supports just the `-U` mvn option which is not
enough: it's possible to force the snapshots update or keep default maven
policy on this.
But it's not possible to prevent snapshots updates which is highly desired
under some circumstances (e.g. for CI reproducibility).
NOTE: I may contribute a PR.
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for {{--no-snapshot-updates}} in
> {{org.apache.maven.shared.invoker.InvocationRequest}}
>
> Currently {{InvocationRequest}} supports just the {{'-U'}} mvn option which
> is not enough: it's possible to force the snapshots update or keep default
> maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonid Rozenblyum updated MSHARED-1382:
---
Description:
Let's add support for *{{--no-snapshot-updates}}* in
*{{org.apache.maven.shared.invoker.InvocationRequest}}*
Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option which
is not enough: it's possible to force the snapshots update or keep default
maven policy on this.
But it's not possible to prevent snapshots updates which is highly desired
under some circumstances (e.g. for CI reproducibility).
NOTE: I may contribute a PR.
was:
Let's add support for {{--no-snapshot-updates}} in
{{org.apache.maven.shared.invoker.InvocationRequest}}
Currently {{InvocationRequest}} supports just the {{'-U'}} mvn option which is
not enough: it's possible to force the snapshots update or keep default maven
policy on this.
But it's not possible to prevent snapshots updates which is highly desired
under some circumstances (e.g. for CI reproducibility).
NOTE: I may contribute a PR.
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump actions/cache from 3 to 4 [maven-mvnd]
dependabot[bot] closed pull request #936: Bump actions/cache from 3 to 4 URL: https://github.com/apache/maven-mvnd/pull/936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/download-artifact from 3 to 4 [maven-mvnd]
dependabot[bot] closed pull request #938: Bump actions/download-artifact from 3 to 4 URL: https://github.com/apache/maven-mvnd/pull/938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/cache from 3 to 4 [maven-mvnd]
dependabot[bot] commented on PR #936: URL: https://github.com/apache/maven-mvnd/pull/936#issuecomment-2066581294 Looks like actions/cache is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/download-artifact from 3 to 4 [maven-mvnd]
dependabot[bot] commented on PR #938: URL: https://github.com/apache/maven-mvnd/pull/938#issuecomment-2066581194 Looks like actions/download-artifact is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/setup-java from 3 to 4 [maven-mvnd]
dependabot[bot] commented on PR #937: URL: https://github.com/apache/maven-mvnd/pull/937#issuecomment-2066580744 Looks like actions/setup-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 3 to 4 [maven-mvnd]
dependabot[bot] closed pull request #939: Bump actions/upload-artifact from 3 to 4 URL: https://github.com/apache/maven-mvnd/pull/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/checkout from 3 to 4 [maven-mvnd]
dependabot[bot] closed pull request #935: Bump actions/checkout from 3 to 4 URL: https://github.com/apache/maven-mvnd/pull/935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 3 to 4 [maven-mvnd]
dependabot[bot] commented on PR #939: URL: https://github.com/apache/maven-mvnd/pull/939#issuecomment-2066580613 Looks like actions/upload-artifact is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Cumulative update of GH flow [maven-mvnd]
cstamas merged PR #950: URL: https://github.com/apache/maven-mvnd/pull/950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
Leonid Rozenblyum created MSHARED-1382: -- Summary: Maven-invoker: support '--no-snapshot-updates' Key: MSHARED-1382 URL: https://issues.apache.org/jira/browse/MSHARED-1382 Project: Maven Shared Components Issue Type: Improvement Components: maven-invoker Affects Versions: maven-invoker-3.2.0 Reporter: Leonid Rozenblyum Let's add support for `--no-snapshot-updates` in `org.apache.maven.shared.invoker.InvocationRequest` Currently `InvocationRequest` supports just the `-U` mvn option which is not enough: it's possible to force the snapshots update or keep default maven policy on this. But it's not possible to prevent snapshots updates which is highly desired under some circumstances (e.g. for CI reproducibility). NOTE: I may contribute a PR. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Cumulative update of GH flow [maven-mvnd]
gzm55 commented on PR #950: URL: https://github.com/apache/maven-mvnd/pull/950#issuecomment-2066545303 > @gzm55 Thanks a lot! It seems it worked, ubuntu job is green... yeah, new graalvm introduce new api dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Cumulative update of GH flow [maven-mvnd]
cstamas commented on PR #950: URL: https://github.com/apache/maven-mvnd/pull/950#issuecomment-2066541405 @gzm55 Thanks a lot! It seems it worked, ubuntu job is green... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
Kevin Buntrock created MBUILDCACHE-86: - Summary: Bugfix and enhancements with the restoration of outputs on disk Key: MBUILDCACHE-86 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 Project: Maven Build Cache Extension Issue Type: Improvement Reporter: Kevin Buntrock *Fixes :* * Files containing an underscore in their name can't be restored in the cache directory correctly (not in the same directory location). * The cache is able to extract/restore files in locations outside the project. I guess the extraction part is not a vulnerability since someone with commit permissions can guess other ways to extract data. But the possibility of restoring at any place on the disk looks pretty dangerous to me if a remote cache server is compromised. *Enhancements :* * Possibility to restore artefacts on disk, with a dedicated property : maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the project directory, as opposed to the cache directory. ** IDE integration and use of the cache locally in developement is way easier. It is now possible to retrieve a cached jar in the "target" directory. * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Cumulative update of GH flow [maven-mvnd]
gzm55 commented on PR #950: URL: https://github.com/apache/maven-mvnd/pull/950#issuecomment-2066482154 > @gzm55 help! @cstamas try append this line to client/src/main/resources/glibc/glibc.redef ``` pthread_mutex_trylock pthread_mutex_trylock@GLIBC_2.2.5 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838975#comment-17838975 ] ASF GitHub Bot commented on MPMD-379: - lapostoj commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066441436 Ah my bad I didn't know that part of the process! Sounds great then! > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: next-release > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
lapostoj commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066441436 Ah my bad I didn't know that part of the process! Sounds great then! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838950#comment-17838950 ] ASF GitHub Bot commented on MPMD-379: - slawekjaranowski commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066313975 @lapostoj - release under vote - https://lists.apache.org/thread/d0lkjhqv8ddwkw7vz7brlgv93mv1n86n > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: next-release > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
slawekjaranowski commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066313975 @lapostoj - release under vote - https://lists.apache.org/thread/d0lkjhqv8ddwkw7vz7brlgv93mv1n86n -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8090) If a POM (or parent POM) declares a repository, it should be checked during model building
[ https://issues.apache.org/jira/browse/MNG-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8090: - Fix Version/s: (was: 4.0.0) (was: 4.0.0-alpha-14) > If a POM (or parent POM) declares a repository, it should be checked during > model building > -- > > Key: MNG-8090 > URL: https://issues.apache.org/jira/browse/MNG-8090 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Priority: Major > > This is mostly a wish. > Assume you checked out a project, that uses a parent that is NOT available > from central. How to build such a project? > I know this sounds like a chicken-or-egg situation, but IMHO model builder > could utilize some "early" repo definition (maybe allow this only when there > is no interpolation happening?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8079) Maven Resolver breaks compatibility due Resolver breakage
[ https://issues.apache.org/jira/browse/MNG-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8079: Assignee: Tamas Cservenak > Maven Resolver breaks compatibility due Resolver breakage > - > > Key: MNG-8079 > URL: https://issues.apache.org/jira/browse/MNG-8079 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 4.0.0-alpha-13 >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > > Maven needs new Resolver release due MRESOLVER-515 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8083) Inconsitency with effective POM
[
https://issues.apache.org/jira/browse/MNG-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8083:
-
Fix Version/s: (was: 4.0.0-alpha-14)
> Inconsitency with effective POM
> ---
>
> Key: MNG-8083
> URL: https://issues.apache.org/jira/browse/MNG-8083
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-13
>Reporter: Guillaume Nodet
>Priority: Major
>
> When building Apache Camel with 4.0.0-alpha-13, the effective POM is not the
> same and profiles are not applied correctly.
> Running {{mvn -Pfastinstall}} does skip tests with Maven 3.9.6, but does not
> with Maven 4.0.0-alpha-13.
> {{mvn -Pfastinstall -f core/camel-util}} will execute tests when running on
> 4.0.x, but should not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8031: - Component/s: Core > Backport: Make Maven transfer listener used with Resolver more concurrent > friendly > -- > > Key: MNG-8031 > URL: https://issues.apache.org/jira/browse/MNG-8031 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-8007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838940#comment-17838940 ] ASF GitHub Bot commented on MNG-8031: - cstamas opened a new pull request, #1471: URL: https://github.com/apache/maven/pull/1471 Backport of simplex transfer listener. --- https://issues.apache.org/jira/browse/MNG-8031 > Backport: Make Maven transfer listener used with Resolver more concurrent > friendly > -- > > Key: MNG-8031 > URL: https://issues.apache.org/jira/browse/MNG-8031 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-8007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8019) Streamline update policy of pluginRepository/repository of Maven Central in Super POM
[
https://issues.apache.org/jira/browse/MNG-8019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8019.
> Streamline update policy of pluginRepository/repository of Maven Central in
> Super POM
> -
>
> Key: MNG-8019
> URL: https://issues.apache.org/jira/browse/MNG-8019
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.9.7
>
>
> The update policy is set to {{never}} for the Maven Central
> {{pluginRepository}}
> (https://github.com/apache/maven/blob/b23afbc9849d57b0a4ff0f2bdd3fff5520a95f7c/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml#L48)
> while it is the default (= {{daily}}) for the regular repository.
> Although it would be nice to set both to {{never}} this does not work with
> Resolver 1.x as that treats metadata and artifacts the same (but in fact
> metadata is constantly changing even for release repositories like Maven
> Central). This situation should improve with Resolver 2.x (Maven 4)
> (https://issues.apache.org/jira/browse/MRESOLVER-377).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838941#comment-17838941 ] ASF GitHub Bot commented on MPMD-379: - lapostoj commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066241133 Hey @adangel, thanks for getting the PR merged! I believe the new version has not been deployed and pushed to the mvn repository, any step missing there? > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: next-release > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
lapostoj commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066241133 Hey @adangel, thanks for getting the PR merged! I believe the new version has not been deployed and pushed to the mvn repository, any step missing there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8031: Assignee: Tamas Cservenak > Backport: Make Maven transfer listener used with Resolver more concurrent > friendly > -- > > Key: MNG-8031 > URL: https://issues.apache.org/jira/browse/MNG-8031 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-8007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-589) Compilation fails due to removed generated-sources after upgrade from 3.11.0 to 3.12.0+
[
https://issues.apache.org/jira/browse/MCOMPILER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838936#comment-17838936
]
Eric Hubert commented on MCOMPILER-589:
---
It looks like we can close the issue as invalid. It all seems to be caused by a
wrong/unintended configuration of the compiler plugin in the Maven project
which I think was a result of a non-optimal naming of the compiler plugin's
configuration parameter "generatedSourcesDirectory".
Other than the name may make suggest, it is only meant to be used for sources
generated by annotation processors (also properly documented via JavaDoc). With
this in mind, the above code (specifically the comments and the error message
make totally sense).
The project was configured like this:
{code}
${project.basedir}/generated-sources
{code}
placing annotation generated sources (if there were any) right next to other
generated sources instead of as by default in a subdirectory annotations. All
the years this configuration never caused issues, but with the added cleaning
of this directory before the compilation not only annotation processor
generated sources, but all sources were removed resulting in compilation errors.
> Compilation fails due to removed generated-sources after upgrade from 3.11.0
> to 3.12.0+
> ---
>
> Key: MCOMPILER-589
> URL: https://issues.apache.org/jira/browse/MCOMPILER-589
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.12.0, 3.12.1, 3.13.0
>Reporter: Eric Hubert
>Priority: Major
>
> After upgrading the used maven-compiler-plugin from 3.11.0 to 3.13.0 the
> class compilation fails, because generated resources are no longer present in
> the generated-sources folder.
> The project is setup in a way that during the generate-sources phase a plugin
> generates java sources which are stored in the configured generated-sources
> folder. Within the same phase these are added to the source using the
> build-helper-maven-plugin's add-source goal.
> When debugging the maven execution one can verify how the files are generated
> and placed in the correct folder. Once the maven-compiler-plugin > 3.11.0 is
> executed, the generated sources are deleted before the actual source code is
> compiled finally resulting in a compilation error. The issue can be
> reproduced with 3.12.1 and 3.12.0 and does not happen with 3.11.0.
> I did not yet find the time to debug the plugin, but briefly checked the
> release notes and found the ticket MCOMPILER-333 which might be the cause.
> Update: I now disabled incremental compilation by adding
> {code}
> -Dmaven.compiler.useIncrementalCompilation=false
> {code}
> on the command line to the Maven execution and all compiles fine and the
> generated-sources are used as expected. I think this way I put more evidence
> towards the changeset of MCOMPILER-333 to be the cause (therefore linking the
> ticket).
> I now also had a glance at the source code and have to admit that I do not
> really understand the reasoning of this change introducing an unconditional
> deletion of ALL files under generated-sources for incremental compilation
> (which is active by default). The generated sources are usually generated for
> a reason and must be processed during compilation. I'd expect this to break
> many use cases. What do I overlook here? I cannot see any direct relation to
> annotation processing as specified in the error message.
> {code}
> // MCOMPILER-333: Cleanup the generated source files created by
> annotation processing
> // to avoid issues with `javac` compiler when the source code is
> rebuild.
> if (getGeneratedSourcesDirectory() != null) {
> try (Stream walk =
> Files.walk(getGeneratedSourcesDirectory().toPath())) {
>
> walk.sorted(Comparator.reverseOrder()).map(Path::toFile).forEach(File::delete);
> // MCOMPILER-567: The directory must already exist
> because javac does not create it.
>
> Files.createDirectories(getGeneratedSourcesDirectory().toPath());
> } catch (IOException ex) {
> getLog().warn("I/O error deleting the annotation
> processing generated files: " + ex.getMessage());
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8030: - Component/s: Artifacts and Repositories > Backport: Add ability to ignore dependency repositories: mvn -itr > - > > Key: MNG-8030 > URL: https://issues.apache.org/jira/browse/MNG-8030 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-7980 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838930#comment-17838930 ] ASF GitHub Bot commented on MNG-8030: - cstamas opened a new pull request, #1469: URL: https://github.com/apache/maven/pull/1469 Backport of the Maven4 feature: ignore transitive repositories. --- https://issues.apache.org/jira/browse/MNG-8030 > Backport: Add ability to ignore dependency repositories: mvn -itr > - > > Key: MNG-8030 > URL: https://issues.apache.org/jira/browse/MNG-8030 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-7980 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8011) Minimize and make generic the README.txt
[ https://issues.apache.org/jira/browse/MNG-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8011: Assignee: Tamas Cservenak > Minimize and make generic the README.txt > > > Key: MNG-8011 > URL: https://issues.apache.org/jira/browse/MNG-8011 > Project: Maven > Issue Type: Task > Components: Bootstrap Build >Affects Versions: 3.9.6 >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > The current readme is totally outdated: > https://github.com/apache/maven/blob/master/apache-maven/README.txt > Java 1.3? > Cut down this README.txt and ideally just point it to release notes on site, > to lessen maintenance of this file. Less content, less effort needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8011) Minimize and make generic the README.txt
[ https://issues.apache.org/jira/browse/MNG-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838933#comment-17838933 ] ASF GitHub Bot commented on MNG-8011: - cstamas opened a new pull request, #1470: URL: https://github.com/apache/maven/pull/1470 The site already contains all the required information, point user at it. It would be insane for us to maintain all these information here as well (as example shows, it was totally outdated). Keep it short, and just keep pointers to proper info sources. --- https://issues.apache.org/jira/browse/MNG-8011 > Minimize and make generic the README.txt > > > Key: MNG-8011 > URL: https://issues.apache.org/jira/browse/MNG-8011 > Project: Maven > Issue Type: Task > Components: Bootstrap Build >Affects Versions: 3.9.6 >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > The current readme is totally outdated: > https://github.com/apache/maven/blob/master/apache-maven/README.txt > Java 1.3? > Cut down this README.txt and ideally just point it to release notes on site, > to lessen maintenance of this file. Less content, less effort needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8030: Assignee: Tamas Cservenak > Backport: Add ability to ignore dependency repositories: mvn -itr > - > > Key: MNG-8030 > URL: https://issues.apache.org/jira/browse/MNG-8030 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-7980 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Cumulative update of GH flow [maven-mvnd]
cstamas commented on PR #950: URL: https://github.com/apache/maven-mvnd/pull/950#issuecomment-2066161892 @gzm55 help! :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8094) Resolver 1.9.19
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8094: - Description: Resolver 1.9.19 release notes https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12353946 > Resolver 1.9.19 > --- > > Key: MNG-8094 > URL: https://issues.apache.org/jira/browse/MNG-8094 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Resolver 1.9.19 release notes > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12353946 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-8094] Resolver 1.9.19 [maven]
cstamas opened a new pull request, #1468: URL: https://github.com/apache/maven/pull/1468 That contains file locking bugfix. --- https://issues.apache.org/jira/browse/MNG-8094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8094) Resolver 1.9.19
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8094: Assignee: Tamas Cservenak > Resolver 1.9.19 > --- > > Key: MNG-8094 > URL: https://issues.apache.org/jira/browse/MNG-8094 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8094) Resolver 1.9.19
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838915#comment-17838915 ] ASF GitHub Bot commented on MNG-8094: - cstamas opened a new pull request, #1468: URL: https://github.com/apache/maven/pull/1468 That contains file locking bugfix. --- https://issues.apache.org/jira/browse/MNG-8094 > Resolver 1.9.19 > --- > > Key: MNG-8094 > URL: https://issues.apache.org/jira/browse/MNG-8094 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
