[jira] [Closed] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MBUILDCACHE-86. --- Assignee: Olivier Lamy Resolution: Fixed > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842550#comment-17842550 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- olamy merged PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104 > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
olamy merged PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hint about mvnrepository.com [maven-site]
rmannibucau commented on code in PR #518:
URL: https://github.com/apache/maven-site/pull/518#discussion_r1585894514
##
content/apt/guides/getting-started/index.apt:
##
@@ -910,7 +910,9 @@ mvn process-resources "-Dcommand.line.prop=hello again"
various plugins used to build the project). By default, the remote
repository Maven uses can be found (and browsed) at
{{https://repo.maven.apache.org/maven2/}}. You can also set up your own
remote repository (maybe a central repository for your company) to
use instead of or in addition to the default remote repository. For more
information on repositories you can refer to the
- {{{../introduction/introduction-to-repositories.html}Introduction to
Repositories}}.
+ {{{../introduction/introduction-to-repositories.html}Introduction to
Repositories}}. The best way to find information about dependencies is
Review Comment:
Maybe rephrase it to highlight it is not always in sync with central so
maybe something like "one aggregated way to find dependencies.but it can be
outdated" rather than "the best way"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.mockito:mockito-junit-jupiter from 4.11.0 to 5.11.0 [maven-invoker-plugin]
dependabot[bot] opened a new pull request, #230: URL: https://github.com/apache/maven-invoker-plugin/pull/230 Bumps [org.mockito:mockito-junit-jupiter](https://github.com/mockito/mockito) from 4.11.0 to 5.11.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>org.mockito:mockito-junit-jupiter's releases. v5.11.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 5.11.0 2024-03-01 - https://github.com/mockito/mockito/compare/v5.10.0...v5.11.0;>17 commit(s) by Aouichaoui Youssef, Franz Wong, Pranoti Durugkar, Róbert Papp, dependabot[bot] Fixes https://redirect.github.com/mockito/mockito/issues/3281;>#3281 : Add native method to exception message of MissingMethodI… [(https://redirect.github.com/mockito/mockito/issues/3283;>#3283)](https://redirect.github.com/mockito/mockito/pull/3283;>mockito/mockito#3283) MissingMethodInvocationException is thrown when mocking native method in 5.x [(https://redirect.github.com/mockito/mockito/issues/3281;>#3281)](https://redirect.github.com/mockito/mockito/issues/3281;>mockito/mockito#3281) Bump com.google.googlejavaformat:google-java-format from 1.19.2 to 1.20.0 [(https://redirect.github.com/mockito/mockito/issues/3277;>#3277)](https://redirect.github.com/mockito/mockito/pull/3277;>mockito/mockito#3277) Bump versions.bytebuddy from 1.14.11 to 1.14.12 [(https://redirect.github.com/mockito/mockito/issues/3272;>#3272)](https://redirect.github.com/mockito/mockito/pull/3272;>mockito/mockito#3272) Bump gradle/wrapper-validation-action from 2.1.0 to 2.1.1 [(https://redirect.github.com/mockito/mockito/issues/3268;>#3268)](https://redirect.github.com/mockito/mockito/pull/3268;>mockito/mockito#3268) Bump org.shipkit:shipkit-auto-version from 2.0.3 to 2.0.4 [(https://redirect.github.com/mockito/mockito/issues/3267;>#3267)](https://redirect.github.com/mockito/mockito/pull/3267;>mockito/mockito#3267) Bump gradle/wrapper-validation-action from 2.0.1 to 2.1.0 [(https://redirect.github.com/mockito/mockito/issues/3266;>#3266)](https://redirect.github.com/mockito/mockito/pull/3266;>mockito/mockito#3266) Bump org.junit.platform:junit-platform-launcher from 1.10.1 to 1.10.2 [(https://redirect.github.com/mockito/mockito/issues/3265;>#3265)](https://redirect.github.com/mockito/mockito/pull/3265;>mockito/mockito#3265) Bump gradle/wrapper-validation-action from 2.0.0 to 2.0.1 [(https://redirect.github.com/mockito/mockito/issues/3264;>#3264)](https://redirect.github.com/mockito/mockito/pull/3264;>mockito/mockito#3264) Bump org.assertj:assertj-core from 3.25.2 to 3.25.3 [(https://redirect.github.com/mockito/mockito/issues/3261;>#3261)](https://redirect.github.com/mockito/mockito/pull/3261;>mockito/mockito#3261) Bump versions.junitJupiter from 5.10.1 to 5.10.2 [(https://redirect.github.com/mockito/mockito/issues/3260;>#3260)](https://redirect.github.com/mockito/mockito/pull/3260;>mockito/mockito#3260) Bump gradle/wrapper-validation-action from 1.1.0 to 2.0.0 [(https://redirect.github.com/mockito/mockito/issues/3258;>#3258)](https://redirect.github.com/mockito/mockito/pull/3258;>mockito/mockito#3258) Fixes https://redirect.github.com/mockito/mockito/issues/3229;>#3229: Resolve test generic arguments [(https://redirect.github.com/mockito/mockito/issues/3257;>#3257)](https://redirect.github.com/mockito/mockito/pull/3257;>mockito/mockito#3257) Bump org.shipkit:shipkit-auto-version from 2.0.2 to 2.0.3 [(https://redirect.github.com/mockito/mockito/issues/3256;>#3256)](https://redirect.github.com/mockito/mockito/pull/3256;>mockito/mockito#3256) Use kvm on ubuntu instead of macos to run Android tests [(https://redirect.github.com/mockito/mockito/issues/3252;>#3252)](https://redirect.github.com/mockito/mockito/pull/3252;>mockito/mockito#3252) Fixes https://redirect.github.com/mockito/mockito/issues/3240;>#3240 : Renamed mockito bom artifact [(https://redirect.github.com/mockito/mockito/issues/3251;>#3251)](https://redirect.github.com/mockito/mockito/pull/3251;>mockito/mockito#3251) Remove shipkit workaround for generateChangelog [(https://redirect.github.com/mockito/mockito/issues/3250;>#3250)](https://redirect.github.com/mockito/mockito/pull/3250;>mockito/mockito#3250) Bump com.gradle.enterprise from 3.16.1 to 3.16.2 [(https://redirect.github.com/mockito/mockito/issues/3249;>#3249)](https://redirect.github.com/mockito/mockito/pull/3249;>mockito/mockito#3249) Mockito bom missing artifact in maven central for java21 [(https://redirect.github.com/mockito/mockito/issues/3240;>#3240)](https://redirect.github.com/mockito/mockito/issues/3240;>mockito/mockito#3240) @Captor test parameters don't work with primitive type arguments [(https://redirect.github.com/mockito/mockito/issues/3229;>#3229)](https://redirect.github.com/mockito/mockito/issues/3229;>mockito/mockito#3229) Gradle 8.2: work around fix for release publishing
Re: [PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-deploy-plugin]
CrazyHZM merged PR #55: URL: https://github.com/apache/maven-deploy-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842511#comment-17842511 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2087551261 > @kbuntrock #103 has been merged. Thanks! @olamy: rebased, ready to merge :) > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2087551261 > @kbuntrock #103 has been merged. Thanks! @olamy: rebased, ready to merge :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-script-interpreter from 1.4 to 1.5 [maven-invoker-plugin]
dependabot[bot] merged PR #221: URL: https://github.com/apache/maven-invoker-plugin/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842506#comment-17842506 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- olamy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2087302271 @kbuntrock #103 has been merged. Thanks! > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
olamy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2087302271 @kbuntrock #103 has been merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MBUILDCACHE-90) Configuration option to make mandatory the use of the clean phase in order to cache the build result
[ https://issues.apache.org/jira/browse/MBUILDCACHE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MBUILDCACHE-90. --- Resolution: Fixed > Configuration option to make mandatory the use of the clean phase in order to > cache the build result > > > Key: MBUILDCACHE-90 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-90 > Project: Maven Build Cache Extension > Issue Type: New Feature >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Minor > Labels: pull-request-available > Fix For: 1.2.0 > > > Add a configuration option to make mandatory the use of the clean phase in > order to cache the build result. > The goal is to offer the possibility of denying as much as possible the > possibility to cache a faulty build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-90) Configuration option to make mandatory the use of the clean phase in order to cache the build result
[ https://issues.apache.org/jira/browse/MBUILDCACHE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MBUILDCACHE-90: Fix Version/s: 1.2.0 > Configuration option to make mandatory the use of the clean phase in order to > cache the build result > > > Key: MBUILDCACHE-90 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-90 > Project: Maven Build Cache Extension > Issue Type: New Feature >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Minor > Labels: pull-request-available > Fix For: 1.2.0 > > > Add a configuration option to make mandatory the use of the clean phase in > order to cache the build result. > The goal is to offer the possibility of denying as much as possible the > possibility to cache a faulty build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-90] A "mandatory clean" option to enable the caching functionnality [maven-build-cache-extension]
olamy merged PR #103: URL: https://github.com/apache/maven-build-cache-extension/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MBUILDCACHE-90) Configuration option to make mandatory the use of the clean phase in order to cache the build result
[ https://issues.apache.org/jira/browse/MBUILDCACHE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MBUILDCACHE-90: --- Assignee: Olivier Lamy > Configuration option to make mandatory the use of the clean phase in order to > cache the build result > > > Key: MBUILDCACHE-90 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-90 > Project: Maven Build Cache Extension > Issue Type: New Feature >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Minor > Labels: pull-request-available > > Add a configuration option to make mandatory the use of the clean phase in > order to cache the build result. > The goal is to offer the possibility of denying as much as possible the > possibility to cache a faulty build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842490#comment-17842490 ] Tamas Cservenak edited comment on MRESOLVER-554 at 4/30/24 7:36 PM: One ask, if I may have: please pressure your artifact MRM provider, as since "parallel upload" was introduced, both major implementations (AF and Nx3, but not Nx2!) were reported to... well, nicely said: belly up during uploads. Basically, report this issue and let vendors fix their products :) was (Author: cstamas): One ask, if I may have: please pressure your artifact MRM provider, as since "parallel upload" was introduced, both major implementations (AF and Nx3,but not Nx2!) were reported to... well, nicely said: belly up during uploads. Basically, report this issue and let vendors fix their products :) > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842490#comment-17842490 ] Tamas Cservenak commented on MRESOLVER-554: --- One ask, if I may have: please pressure your artifact MRM provider, as since "parallel upload" was introduced, both major implementations (AF and Nx3,but not Nx2!) were reported to... well, nicely said: belly up during uploads. Basically, report this issue and let vendors fix their products :) > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842486#comment-17842486 ] ASF GitHub Bot commented on MRESOLVER-554: -- cstamas opened a new pull request, #489: URL: https://github.com/apache/maven-resolver/pull/489 Basic connector new config to be able to differentiate thread counts used for upload and download. --- https://issues.apache.org/jira/browse/MRESOLVER-554 > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-554: - Assignee: Tamas Cservenak > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-554: -- Fix Version/s: 2.0.0 2.0.0-beta-1 > Support configuration of upload/download threads individually > - > > Key: MRESOLVER-554 > URL: https://issues.apache.org/jira/browse/MRESOLVER-554 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Matt Nelson >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > Parallel deploys were introduced in MRESOLVER-32. The thread pool > configuration is shared for uploads and downloads. It has been observed in > our environment that uploads frequently error out when attempting to upload > with the default thread pool size(5), but conversely we don't see the same > errors for downloads. > The proposal is to support configuration of upload/download thread pools > individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842478#comment-17842478
]
Matt Nelson commented on MRESOLVER-554:
---
Disabling parallelPut was the immediate workaround.
With some testing it has been observed that 2-3 upload threads seems to be the
sweet spot on our artifact repository infra. But this causes the download
threads to now be constrained to the same parallelism as uploads.
For a ~90 module reactor deploying ~700 artifacts (jar, pom, site, javadoc,
source, etc...) these were the timings observed. When the infra is under
heavier load single threaded deploys have taken over 5 minutes for this reactor.
{noformat}
1 thread210 seconds
2 threads 180 seconds
3 threads 113 seconds
5 threads frequent errors(5xx and timeouts)
{noformat}
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Priority: Major
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Obvious copy-paste issue [maven-resolver]
cstamas merged PR #488: URL: https://github.com/apache/maven-resolver/pull/488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842467#comment-17842467
]
Tamas Cservenak commented on MRESOLVER-554:
---
Good idea. Still, you already have {{aether.connector.basic.parallelPut}} that
will disable "parallel upload". Is this not enough?
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Priority: Major
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MRESOLVER-554) Support configuration of upload/download threads individually
Matt Nelson created MRESOLVER-554: - Summary: Support configuration of upload/download threads individually Key: MRESOLVER-554 URL: https://issues.apache.org/jira/browse/MRESOLVER-554 Project: Maven Resolver Issue Type: Improvement Components: Resolver Reporter: Matt Nelson Parallel deploys were introduced in MRESOLVER-32. The thread pool configuration is shared for uploads and downloads. It has been observed in our environment that uploads frequently error out when attempting to upload with the default thread pool size(5), but conversely we don't see the same errors for downloads. The proposal is to support configuration of upload/download thread pools individually. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8062) Maven should factor in session close failure into build outcome
[
https://issues.apache.org/jira/browse/MNG-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8062.
Resolution: Fixed
After reviewing code, what is in place is enough: session close will throw
RuntimeEx, and it will end up as "internal error", as it should. In other
words, is fine what we have now.
> Maven should factor in session close failure into build outcome
> ---
>
> Key: MNG-8062
> URL: https://issues.apache.org/jira/browse/MNG-8062
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Since closeable session in Resolver 2.0, the close was implemented, but any
> possible failure during closing the session would "bubble up", instead to be
> handled.
> Maven should close and also handle any error that may happen during session
> close operation. The build outcome ("build success" or "build failure") is
> evaluated WAY BEFORE repository system session is closed, and this is wrong,
> as build should fail if session close failed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-8062) Maven should factor in session close failure into build outcome
[
https://issues.apache.org/jira/browse/MNG-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8062.
Resolution: Won't Fix
> Maven should factor in session close failure into build outcome
> ---
>
> Key: MNG-8062
> URL: https://issues.apache.org/jira/browse/MNG-8062
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
>
> Since closeable session in Resolver 2.0, the close was implemented, but any
> possible failure during closing the session would "bubble up", instead to be
> handled.
> Maven should close and also handle any error that may happen during session
> close operation. The build outcome ("build success" or "build failure") is
> evaluated WAY BEFORE repository system session is closed, and this is wrong,
> as build should fail if session close failed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (MNG-8062) Maven should factor in session close failure into build outcome
[
https://issues.apache.org/jira/browse/MNG-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reopened MNG-8062:
--
> Maven should factor in session close failure into build outcome
> ---
>
> Key: MNG-8062
> URL: https://issues.apache.org/jira/browse/MNG-8062
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
>
> Since closeable session in Resolver 2.0, the close was implemented, but any
> possible failure during closing the session would "bubble up", instead to be
> handled.
> Maven should close and also handle any error that may happen during session
> close operation. The build outcome ("build success" or "build failure") is
> evaluated WAY BEFORE repository system session is closed, and this is wrong,
> as build should fail if session close failed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8062) Maven should factor in session close failure into build outcome
[
https://issues.apache.org/jira/browse/MNG-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8062:
-
Fix Version/s: (was: 4.0.0)
(was: 4.0.0-beta-1)
> Maven should factor in session close failure into build outcome
> ---
>
> Key: MNG-8062
> URL: https://issues.apache.org/jira/browse/MNG-8062
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
>
> Since closeable session in Resolver 2.0, the close was implemented, but any
> possible failure during closing the session would "bubble up", instead to be
> handled.
> Maven should close and also handle any error that may happen during session
> close operation. The build outcome ("build success" or "build failure") is
> evaluated WAY BEFORE repository system session is closed, and this is wrong,
> as build should fail if session close failed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8062] Maven should factor in session close into result [maven]
cstamas closed pull request #1493: [MNG-8062] Maven should factor in session close into result URL: https://github.com/apache/maven/pull/1493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8073) Generated XSD files needs to have ASL2.0 license headers
[ https://issues.apache.org/jira/browse/MNG-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8073: Assignee: Tamas Cservenak > Generated XSD files needs to have ASL2.0 license headers > > > Key: MNG-8073 > URL: https://issues.apache.org/jira/browse/MNG-8073 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-alpha-13 >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > > Currently we were adding them manually during release process. > Maybe also collecting them to single place would be handy, instead to "hunt > them down" in checkout post release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8073) Generated XSD files needs to have ASL2.0 license headers
[ https://issues.apache.org/jira/browse/MNG-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842387#comment-17842387 ] Tamas Cservenak commented on MNG-8073: -- Pending, waits for modello release w/ feature added in PR above > Generated XSD files needs to have ASL2.0 license headers > > > Key: MNG-8073 > URL: https://issues.apache.org/jira/browse/MNG-8073 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-alpha-13 >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > > Currently we were adding them manually during release process. > Maybe also collecting them to single place would be handy, instead to "hunt > them down" in checkout post release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8062) Maven should factor in session close failure into build outcome
[
https://issues.apache.org/jira/browse/MNG-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-8062:
Assignee: Tamas Cservenak
> Maven should factor in session close failure into build outcome
> ---
>
> Key: MNG-8062
> URL: https://issues.apache.org/jira/browse/MNG-8062
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Since closeable session in Resolver 2.0, the close was implemented, but any
> possible failure during closing the session would "bubble up", instead to be
> handled.
> Maven should close and also handle any error that may happen during session
> close operation. The build outcome ("build success" or "build failure") is
> evaluated WAY BEFORE repository system session is closed, and this is wrong,
> as build should fail if session close failed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 [maven-dist-tool]
dependabot[bot] opened a new pull request, #55: URL: https://github.com/apache/maven-dist-tool/pull/55 Bumps [org.apache.maven.reporting:maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 4.0.0-M2 to 4.0.0-M14. Commits https://github.com/apache/maven-reporting-impl/commit/cefa8b026db16dab156d39cad7096a183046c467;>cefa8b0 [maven-release-plugin] prepare release maven-reporting-impl-4.0.0-M14 https://github.com/apache/maven-reporting-impl/commit/34de83672db5f01a3023d951db3366466d827f12;>34de836 [MSHARED-1361] Upgrade plugins and components (in ITs) (2) https://github.com/apache/maven-reporting-impl/commit/8464ab92499b37677eadf60ef4661bd9c847b0ac;>8464ab9 Bump org.junit:junit-bom from 5.10.1 to 5.10.2 https://github.com/apache/maven-reporting-impl/commit/e6db48408db861e3209748fe5ec10abd7dd25bfa;>e6db484 Add Dependabot config https://github.com/apache/maven-reporting-impl/commit/72181306bb0e12eed50c4ba4aec98dd76499df39;>7218130 [MSHARED-1348] Upgrade plugins and components (in ITs) https://github.com/apache/maven-reporting-impl/commit/cb3a836a2e0b1f85a97be34b071368d259f85c1a;>cb3a836 Add .checkstyle to .gitignore https://github.com/apache/maven-reporting-impl/commit/d45d1dd4d8f62e173a5b1534636b5f5cb24e0da0;>d45d1dd [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-reporting-impl/commit/311693ea727735311b69aaee71e41ae8daf144af;>311693e [maven-release-plugin] prepare release maven-reporting-impl-4.0.0-M13 https://github.com/apache/maven-reporting-impl/commit/9a71be714662d63d282ee1de50ed85619ac7e22b;>9a71be7 [MSHARED-1343] Make parameter outputDirectory read/write in AbstractMavenReport https://github.com/apache/maven-reporting-impl/commit/c8d4e89f03793674bf4de67455183ae816f67f81;>c8d4e89 [MSHARED-1327] Change default value of output directory in AbstractMavenReport Additional commits viewable in https://github.com/apache/maven-reporting-impl/compare/maven-reporting-impl-4.0.0-M2...maven-reporting-impl-4.0.0-M14;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-362) Use properties from parent for plugins versions in ITs
[ https://issues.apache.org/jira/browse/MINVOKER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842358#comment-17842358 ] ASF GitHub Bot commented on MINVOKER-362: - slawekjaranowski opened a new pull request, #229: URL: https://github.com/apache/maven-invoker-plugin/pull/229 by the way - replace pom.version with project.version https://issues.apache.org/jira/browse/MINVOKER-362 > Use properties from parent for plugins versions in ITs > -- > > Key: MINVOKER-362 > URL: https://issues.apache.org/jira/browse/MINVOKER-362 > Project: Maven Invoker Plugin > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run
[ https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MINVOKER-336: - Fix Version/s: 3.6.2 > .mvn/extensions.xml from main project is used in it projects run > > > Key: MINVOKER-336 > URL: https://issues.apache.org/jira/browse/MINVOKER-336 > Project: Maven Invoker Plugin > Issue Type: Bug >Affects Versions: 3.5.1 >Reporter: Olivier Lamy >Priority: Major > Labels: up-for-grabs > Fix For: 3.6.2 > > > if the main project contains some extensions in the top directory > .mvn/extensions.xml this directory will be used in IT projects run. > sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat > algorithm to find .mvn directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-335:
-
Fix Version/s: 3.6.2
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.2
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MINVOKER-362) Use properties from parent for plugins versions in ITs
Slawomir Jaranowski created MINVOKER-362: Summary: Use properties from parent for plugins versions in ITs Key: MINVOKER-362 URL: https://issues.apache.org/jira/browse/MINVOKER-362 Project: Maven Invoker Plugin Issue Type: Task Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.6.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINVOKER-284) Upgrade JUnit to version 5, drop maven-compat
[ https://issues.apache.org/jira/browse/MINVOKER-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-284. Resolution: Fixed > Upgrade JUnit to version 5, drop maven-compat > - > > Key: MINVOKER-284 > URL: https://issues.apache.org/jira/browse/MINVOKER-284 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Minor > Fix For: 3.6.2 > > > We can use new features and > [https://github.com/codehaus-plexus/plexus-testing] for integration tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINVOKER-284] Switch to JUnit5, drop maven-compat [maven-invoker-plugin]
slawekjaranowski merged PR #228: URL: https://github.com/apache/maven-invoker-plugin/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-284) Upgrade JUnit to version 5, drop maven-compat
[ https://issues.apache.org/jira/browse/MINVOKER-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842353#comment-17842353 ] ASF GitHub Bot commented on MINVOKER-284: - slawekjaranowski merged PR #228: URL: https://github.com/apache/maven-invoker-plugin/pull/228 > Upgrade JUnit to version 5, drop maven-compat > - > > Key: MINVOKER-284 > URL: https://issues.apache.org/jira/browse/MINVOKER-284 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Minor > Fix For: 3.6.2 > > > We can use new features and > [https://github.com/codehaus-plexus/plexus-testing] for integration tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8055) Investigate possible solutions for build number diffs on deploy
[
https://issues.apache.org/jira/browse/MNG-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8055:
-
Description:
The "snapshot freeze" is a common practice during development: simply use a
timestamped snapshot as dependency version instead of "-SNAPSHOT" ending one to
"freeze" given snapshot deploy.
This works for simple cases (one dependency, or "aligned" reactor).
But take a look at Resolver itself: it has new-old and added-gone-readded
modules, and their build numbers are different.
Problem is, that while timestamp is _same_ (deduced from session start), the
build number is determined from remote repository (deploy target) state.
This makes "snapshot lock down" impossible on long(er) running projects, like
Resolver itself is.
PR adds {{-Dmaven.buildNumber=N}} support, that is still just "half solution",
as one needs to figure out what N is (max+1 of all build numbers across all
modules being deployed), but at least allows fixing the situation.
was:
The "snapshot freeze" is a common practice during development: simply use a
timestamped snapshot as dependency version instead of "-SNAPSHOT" ending one to
"freeze" given snapshot deploy.
This works for simple cases (one dependency, or "aligned" reactor).
But take a look at Resolver itself: it has new-old and added-gone-readded
modules, and their build numbers are different.
Problem is, that while timestamp is _same_ (deduced from session start), the
build number is determined from remote repository (deploy target) state.
This makes "snapshot lock down" impossible on long(er) running projects, like
Resolver itself is.
> Investigate possible solutions for build number diffs on deploy
> ---
>
> Key: MNG-8055
> URL: https://issues.apache.org/jira/browse/MNG-8055
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7
>
>
> The "snapshot freeze" is a common practice during development: simply use a
> timestamped snapshot as dependency version instead of "-SNAPSHOT" ending one
> to "freeze" given snapshot deploy.
> This works for simple cases (one dependency, or "aligned" reactor).
> But take a look at Resolver itself: it has new-old and added-gone-readded
> modules, and their build numbers are different.
> Problem is, that while timestamp is _same_ (deduced from session start), the
> build number is determined from remote repository (deploy target) state.
> This makes "snapshot lock down" impossible on long(er) running projects, like
> Resolver itself is.
> PR adds {{-Dmaven.buildNumber=N}} support, that is still just "half
> solution", as one needs to figure out what N is (max+1 of all build numbers
> across all modules being deployed), but at least allows fixing the situation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-337] Move maven-compat to test scope [maven-doxia-sitetools]
cstamas merged PR #151: URL: https://github.com/apache/maven-doxia-sitetools/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix MNG-7819 IT [maven-integration-testing]
cstamas merged PR #339: URL: https://github.com/apache/maven-integration-testing/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842342#comment-17842342 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2085055768 Just for clarity, #103 should be merged first. > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2085055768 Just for clarity, #103 should be merged first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842335#comment-17842335
]
ASF GitHub Bot commented on MWRAPPER-91:
mnk commented on PR #137:
URL: https://github.com/apache/maven-wrapper/pull/137#issuecomment-2084997527
I found some improvements that I want to add, so I will create a new PR when
I have them in place.
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename once the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842334#comment-17842334
]
ASF GitHub Bot commented on MWRAPPER-91:
mnk closed pull request #137: [MWRAPPER-91] Add support for running mvnw in
parallel
URL: https://github.com/apache/maven-wrapper/pull/137
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename once the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MWRAPPER-91] Add support for running mvnw in parallel [maven-wrapper]
mnk commented on PR #137: URL: https://github.com/apache/maven-wrapper/pull/137#issuecomment-2084997527 I found some improvements that I want to add, so I will create a new PR when I have them in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-91] Add support for running mvnw in parallel [maven-wrapper]
mnk closed pull request #137: [MWRAPPER-91] Add support for running mvnw in parallel URL: https://github.com/apache/maven-wrapper/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-82) Fix menu items in site.xml
[ https://issues.apache.org/jira/browse/MBUILDCACHE-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842332#comment-17842332 ] Herve Boutemy commented on MBUILDCACHE-82: -- any more precise pointer? is there any PR? should we close this issue? > Fix menu items in site.xml > -- > > Key: MBUILDCACHE-82 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-82 > Project: Maven Build Cache Extension > Issue Type: Wish > Environment: Apache Maven 3.8.7 > Maven home: /usr/share/maven > Java version: 17.0.9, vendor: Oracle Corporation, runtime: > /usr/lib/jvm/jdk-17-oracle-x64 > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "6.5.0-14-generic", arch: "amd64", family: "unix" >Reporter: Mantale Antonio-Roberto >Priority: Minor > Labels: newbie, pull-request-available > > I was looking through maven documentation and then I noticed a typo on the > left menu panel on the screen. I detected in which file (site.xml) the issue > occurs and I identified how to solve the typo. I also noticed a commented > reference to another html file called faq.html. This comment should be > removed to maintain the quality of the product. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MBUILDCACHE-86: - Fix Version/s: 1.2.0 > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-93) Command line configuration to disable saving in cache
[ https://issues.apache.org/jira/browse/MBUILDCACHE-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MBUILDCACHE-93: - Fix Version/s: 1.2.0 > Command line configuration to disable saving in cache > - > > Key: MBUILDCACHE-93 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-93 > Project: Maven Build Cache Extension > Issue Type: New Feature >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Minor > Labels: pull-request-available > Fix For: 1.2.0 > > > Command line configuration to disable saving in cache. > We have already a configuration to : > - Disable totally any cache interaction > - Disable restoring from the cache > - Disable saving on the remote cache > But there is no configuration to disable "classic" saving to the cache. > Use case can be : > Having limited space on machine and therefore a limited number of saved build > allowed. > -> Restricting cache save to the "master" branch / configuring PR branch > build to benefits from the cache, but disallowing any save from them > It's personally a functionality I use since November and the cache hit rate > on my project with this technic is pretty nice. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-8111.
---
Resolution: Information Provided
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Fix MNG-7819 IT [maven-integration-testing]
cstamas opened a new pull request, #339: URL: https://github.com/apache/maven-integration-testing/pull/339 The goal of IT is to "excecise file locking with snapshots" and not to test model validation. The IT used dependency had an invalid parent POM w/ wrong packaging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
cstamas commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584317021
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
I consider nexus-staging-maven-plugin legacy, simply put, people should
avoid using it... all the benefits it (may) add, is that you don't have to log
into Nx UI and press "close" button. Simply put, not worth if you contrast that
to legacy burden it brings and have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842286#comment-17842286
]
ASF GitHub Bot commented on MPLUGIN-519:
cstamas commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584317021
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
I consider nexus-staging-maven-plugin legacy, simply put, people should
avoid using it... all the benefits it (may) add, is that you don't have to log
into Nx UI and press "close" button. Simply put, not worth if you contrast that
to legacy burden it brings and have.
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.12.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842283#comment-17842283
]
Leonidas Spyropoulos commented on MNG-8111:
---
OK I found the issue. I just re-read the buildspec [~sjaranowski] provided! My
issue was line-spearators which were different. You can close the issue - thank
you!
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584309813
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
We should be careful with it probably it is used by Nexus Staging Plugin
https://issues.apache.org/jira/browse/MPLUGIN-384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842281#comment-17842281
]
Tamas Cservenak edited comment on MNG-8111 at 4/30/24 7:59 AM:
---
That is strange, I just checked out maven-3.9.6 tag and rebuilt it w/o any
problem (Maven 3.9.6 and Maven 3.8.8 w/ Java 21.0.3 Temurin, Fedora 40).
was (Author: cstamas):
That is strange, I just checked out maven-3.9.6 tag and rebuilt it w/o any
problem (Maven 3.9.6, Java 21.0.3 Temurin, Fedora 40).
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842281#comment-17842281
]
Tamas Cservenak edited comment on MNG-8111 at 4/30/24 8:00 AM:
---
That is strange, I just checked out maven-3.9.6 tag and rebuilt it twice w/o
any problem (Maven 3.9.6 and Maven 3.8.8 w/ Java 21.0.3 Temurin, Fedora 40).
was (Author: cstamas):
That is strange, I just checked out maven-3.9.6 tag and rebuilt it w/o any
problem (Maven 3.9.6 and Maven 3.8.8 w/ Java 21.0.3 Temurin, Fedora 40).
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842282#comment-17842282
]
ASF GitHub Bot commented on MPLUGIN-519:
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584309813
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
We should be careful with it probably it is used by Nexus Staging Plugin
https://issues.apache.org/jira/browse/MPLUGIN-384
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.12.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842281#comment-17842281
]
Tamas Cservenak commented on MNG-8111:
--
That is strange, I just checked out maven-3.9.6 tag and rebuilt it w/o any
problem (Maven 3.9.6, Java 21.0.3 Temurin, Fedora 40).
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842280#comment-17842280
]
ASF GitHub Bot commented on MWRAPPER-91:
mnk opened a new pull request, #137:
URL: https://github.com/apache/maven-wrapper/pull/137
Maven wrapper may fail with various errors if two instances are executed in
parallel, and no Maven distribution is already present in the cache. This
change ensures that two instances downloading and unpacking Maven distribution
in parallel does not interfere with each other.
JIRA: MWRAPPER-91
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename once the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MWRAPPER-91] Add support for running mvnw in parallel [maven-wrapper]
mnk opened a new pull request, #137: URL: https://github.com/apache/maven-wrapper/pull/137 Maven wrapper may fail with various errors if two instances are executed in parallel, and no Maven distribution is already present in the cache. This change ensures that two instances downloading and unpacking Maven distribution in parallel does not interfere with each other. JIRA: MWRAPPER-91 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842279#comment-17842279
]
Leonidas Spyropoulos edited comment on MNG-8111 at 4/30/24 7:55 AM:
[~sjaranowski] that's helpful to know. But with JDK 21 now it fails to compile
due to spotless check. See attached build log with -X turned on.
[~michael-o] I think the JDK is probably the issue here. I'll provide a
diffoscope once I diffs with JDK21.
was (Author: JIRAUSER305261):
[~sjaranowski] that's helpful to know. But with JDK 21 now it fails to compile
due to spotless check. See attached build log with -X turned on.
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842279#comment-17842279
]
Leonidas Spyropoulos commented on MNG-8111:
---
[~sjaranowski] that's helpful to know. But with JDK 21 now it fails to compile
due to spotless check. See attached build log with -X turned on.
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonidas Spyropoulos updated MNG-8111:
--
Attachment: maven-3.9.6-1-x86_64-build.log
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
> Attachments: maven-3.9.6-1-x86_64-build.log
>
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[ https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842276#comment-17842276 ] ASF GitHub Bot commented on MPLUGIN-519: gnodet commented on code in PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584284340 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java: ## @@ -42,8 +42,8 @@ * to define plugin mapping in the group * * - * @see ArtifactRepositoryMetadata - * @see GroupRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata Review Comment: Maven-compat is still in the dependencies afaik. It has to be until we actually completely remove this mojo. > Update to Parent POM 42, prerequisite 3.6.3 > --- > > Key: MPLUGIN-519 > URL: https://issues.apache.org/jira/browse/MPLUGIN-519 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
gnodet commented on code in PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584284340 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java: ## @@ -42,8 +42,8 @@ * to define plugin mapping in the group * * - * @see ArtifactRepositoryMetadata - * @see GroupRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata Review Comment: Maven-compat is still in the dependencies afaik. It has to be until we actually completely remove this mojo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.resolver:maven-resolver-transport-http from 1.9.19 to 1.9.20 [maven-build-cache-extension]
dependabot[bot] opened a new pull request, #149: URL: https://github.com/apache/maven-build-cache-extension/pull/149 Bumps org.apache.maven.resolver:maven-resolver-transport-http from 1.9.19 to 1.9.20. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[ https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842267#comment-17842267 ] ASF GitHub Bot commented on MPLUGIN-519: michael-o commented on code in PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584257457 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java: ## @@ -42,8 +42,8 @@ * to define plugin mapping in the group * * - * @see ArtifactRepositoryMetadata - * @see GroupRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata Review Comment: These links will not work if Javadoc does not find the deps on the classpath. > Update to Parent POM 42, prerequisite 3.6.3 > --- > > Key: MPLUGIN-519 > URL: https://issues.apache.org/jira/browse/MPLUGIN-519 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
michael-o commented on code in PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1584257457 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java: ## @@ -42,8 +42,8 @@ * to define plugin mapping in the group * * - * @see ArtifactRepositoryMetadata - * @see GroupRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata + * @see org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata Review Comment: These links will not work if Javadoc does not find the deps on the classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaVersion from 2.0.0-M8 to 2.0.0-M10 [maven-site-plugin]
michael-o commented on PR #180: URL: https://github.com/apache/maven-site-plugin/pull/180#issuecomment-2084557408 Superseded by #185. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M9 to 4.0.0-M11 [maven-site-plugin]
michael-o commented on PR #182: URL: https://github.com/apache/maven-site-plugin/pull/182#issuecomment-2084556996 Superseded by #185. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaVersion from 2.0.0-M8 to 2.0.0-M10 [maven-site-plugin]
dependabot[bot] commented on PR #180: URL: https://github.com/apache/maven-site-plugin/pull/180#issuecomment-2084557552 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842266#comment-17842266
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on PR #177:
URL:
https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2084555013
I will happily review again after #185 has been merged.
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump doxiaSitetoolsVersion from 2.0.0-M16 to 2.0.0-M18 [maven-site-plugin]
dependabot[bot] commented on PR #184: URL: https://github.com/apache/maven-site-plugin/pull/184#issuecomment-2084556741 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaVersion from 2.0.0-M8 to 2.0.0-M10 [maven-site-plugin]
michael-o closed pull request #180: Bump doxiaVersion from 2.0.0-M8 to 2.0.0-M10 URL: https://github.com/apache/maven-site-plugin/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M9 to 4.0.0-M11 [maven-site-plugin]
dependabot[bot] commented on PR #182: URL: https://github.com/apache/maven-site-plugin/pull/182#issuecomment-2084557114 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M9 to 4.0.0-M11 [maven-site-plugin]
michael-o closed pull request #182: Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M9 to 4.0.0-M11 URL: https://github.com/apache/maven-site-plugin/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaSitetoolsVersion from 2.0.0-M16 to 2.0.0-M18 [maven-site-plugin]
michael-o commented on PR #184: URL: https://github.com/apache/maven-site-plugin/pull/184#issuecomment-2084556623 Superseded by #185. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaSitetoolsVersion from 2.0.0-M16 to 2.0.0-M18 [maven-site-plugin]
michael-o closed pull request #184: Bump doxiaSitetoolsVersion from 2.0.0-M16 to 2.0.0-M18 URL: https://github.com/apache/maven-site-plugin/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2084555013 I will happily review again after #185 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842263#comment-17842263 ] ASF GitHub Bot commented on MSITE-1003: --- michael-o opened a new pull request, #185: URL: https://github.com/apache/maven-site-plugin/pull/185 This closes #185 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 > * Upgrade to Commons IO 2.16.1 > * Upgrade to Jetty 9.4.54.v20240208 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MSITE-1003] Upgrade plugins and components (in ITs) [maven-site-plugin]
michael-o opened a new pull request, #185: URL: https://github.com/apache/maven-site-plugin/pull/185 This closes #185 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-1003: -- Description: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Reporting Exec 4.0.0-M13 * Upgrade to Maven Plugin Tools 3.12.0 * Upgrade to Commons IO 2.16.1 * Upgrade to Jetty 9.4.54.v20240208 was: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Reporting Exec 4.0.0-M13 * Upgrade to Maven Plugin Tools 3.12.0 > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 > * Upgrade to Commons IO 2.16.1 > * Upgrade to Jetty 9.4.54.v20240208 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-1003: -- Description: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Reporting Exec 4.0.0-M13 * Upgrade to Maven Plugin Tools 3.12.0 was: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Reporting Exec 4.0.0-M13 * Upgrade to Maven Plugin Tools 3.12.0 * Upgrade to Maven JXR Plugin 3.3.2 > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8111) Version 3.9.6 is not reproducible
[
https://issues.apache.org/jira/browse/MNG-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842259#comment-17842259
]
Michael Osipov commented on MNG-8111:
-
[~artafinde], what does diffoscope say?
> Version 3.9.6 is not reproducible
> -
>
> Key: MNG-8111
> URL: https://issues.apache.org/jira/browse/MNG-8111
> Project: Maven
> Issue Type: Bug
> Components: Core, General
>Affects Versions: 3.9.6
> Environment: Arch Linux updated (29/04/2024)
>Reporter: Leonidas Spyropoulos
>Priority: Major
> Labels: reproducibility
>
> Version 3.9.6 is not reproducible. It seems like the compiled classes are
> different.
> - JDK used: OpenJDK version 8.412.u08
> - Command line used:
> {code:bash}
> mvn package \
> -DbuildNumber="bc0240f3c744dd6b6ec2920b3cd08dcc295161ae" \
> -Dline.separator=$'\r\n' \
> -Dproject.build.sourceEncoding=UTF-8 -e \
> -Dmaven.repo.local="./repo" \
> -DskipTests
> {code}
> buildNumber is found from:
> {code}
> bsdtar xOf <(bsdtar xOf apache-maven-3.9.6-bin.tar.gz
> apache-maven-3.9.6/lib/maven-core-3.9.6.jar) \
> org/apache/maven/messages/build.properties | grep buildNumber | cut -d=
> -f2 | tr -cd '[:print:]'
> {code}
> Relevant issue: https://issues.apache.org/jira/browse/MNG-6276
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
