Re: [PR] Adjustments in new API related to PathType [maven]
rmannibucau commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590207944 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.DocumentationTool; Review Comment: api shouldn't depend on that since it is a generic path setup and there we make it depending on a single consumer so look fishy and not very promishing to be as generic as intended -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attribute
[
https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-8116:
Summary: Plugin configuration can randomly fail in case of method
overloading as it doesn't take into account implementation attribute (was:
Plugin configuration can randomly fail in case of method overloading as it
doesn't take into account implementation attriute)
> Plugin configuration can randomly fail in case of method overloading as it
> doesn't take into account implementation attribute
> -
>
> Key: MNG-8116
> URL: https://issues.apache.org/jira/browse/MNG-8116
> Project: Maven
> Issue Type: Task
> Components: Plugin Requests
>Affects Versions: 3.9.6
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.7
>
>
> Originally discovered via a Jetty bug report see
> https://github.com/jetty/jetty.project/issues/11732
> The bean to configured have the following overloading method naming:
> * public void setExtraClasspath(String extraClasspath)
> * public void setExtraClasspath(List extraClasspath)
> The plugin configuration:
>
> ${basedir}/config
>
> even forcing the implementation attribute doesn't help
>
>implementation="java.lang.String">${basedir}/config
>
> The fix is implemented via the PR
> https://github.com/eclipse/sisu.plexus/pull/52
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[ https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843516#comment-17843516 ] ASF GitHub Bot commented on MINVOKER-335: - michael-o commented on PR #231: URL: https://github.com/apache/maven-invoker-plugin/pull/231#issuecomment-2094497350 This IT is incomplete because the GHA Windows runners are configured not like a regular machine. It fails for me: ``` Running pre-build script: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\setup.groovy java.nio.file.FileSystemException: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\src\it\clone-symlinks\testDirLink: Dem Client fehlt ein erforderliches Recht. at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsFileSystemProvider.createSymbolicLink(WindowsFileSystemProvider.java:585) at java.nio.file.Files.createSymbolicLink(Files.java:1043) at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321) at Script1.run(Script1.groovy:31) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:460) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:495) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:469) at org.apache.maven.shared.scriptinterpreter.GroovyScriptInterpreter.evaluateScript(GroovyScriptInterpreter.java:69) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:223) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:160) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1823) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1545) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.lambda$runBuilds$4(AbstractInvokerMojo.java:1307) at org.apache.maven.plugins.invoker.JobExecutor.lambda$forEach$0(JobExecutor.java:63) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) Running post-build script: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\verify.groovy java.nio.file.NoSuchFileException: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\target\it\clone-symlinks\testDirLink at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:79) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsLinkSupport.readLink(WindowsLinkSupport.java:56) at sun.nio.fs.WindowsFileSystemProvider.readSymbolicLink(WindowsFileSystemProvider.java:628) at java.nio.file.Files.readSymbolicLink(Files.java:1432) at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321) at Script1.run(Script1.groovy:25) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:460) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:495) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:469) at org.apache.maven.shared.scriptinterpreter.GroovyScriptInterpreter.evaluateScript(GroovyScriptInterpreter.java:69) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:223) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:160) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runPostBuildHook(AbstractInvokerMojo.java:1905) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1886) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1545) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.lambda$runBuilds$4(AbstractInvokerMojo.java:1307) at org.apache.maven.plugins.invoker.JobExecutor.lambda$forEach$0(JobExecutor.java:63) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) ``` You cannot create a symlink on Windows unless you have an
Re: [PR] [MINVOKER-335] Preserve symlinks for copied files [maven-invoker-plugin]
michael-o commented on PR #231: URL: https://github.com/apache/maven-invoker-plugin/pull/231#issuecomment-2094497350 This IT is incomplete because the GHA Windows runners are configured not like a regular machine. It fails for me: ``` Running pre-build script: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\setup.groovy java.nio.file.FileSystemException: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\src\it\clone-symlinks\testDirLink: Dem Client fehlt ein erforderliches Recht. at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsFileSystemProvider.createSymbolicLink(WindowsFileSystemProvider.java:585) at java.nio.file.Files.createSymbolicLink(Files.java:1043) at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321) at Script1.run(Script1.groovy:31) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:460) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:495) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:469) at org.apache.maven.shared.scriptinterpreter.GroovyScriptInterpreter.evaluateScript(GroovyScriptInterpreter.java:69) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:223) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:160) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1823) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1545) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.lambda$runBuilds$4(AbstractInvokerMojo.java:1307) at org.apache.maven.plugins.invoker.JobExecutor.lambda$forEach$0(JobExecutor.java:63) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) Running post-build script: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\verify.groovy java.nio.file.NoSuchFileException: D:\Entwicklung\Projekte\maven-invoker-plugin\target\it\MINVOKER-335-symlinks-in-source\target\it\clone-symlinks\testDirLink at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:79) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsLinkSupport.readLink(WindowsLinkSupport.java:56) at sun.nio.fs.WindowsFileSystemProvider.readSymbolicLink(WindowsFileSystemProvider.java:628) at java.nio.file.Files.readSymbolicLink(Files.java:1432) at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321) at Script1.run(Script1.groovy:25) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:460) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:495) at groovy.lang.GroovyShell.evaluate(GroovyShell.java:469) at org.apache.maven.shared.scriptinterpreter.GroovyScriptInterpreter.evaluateScript(GroovyScriptInterpreter.java:69) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:223) at org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:160) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runPostBuildHook(AbstractInvokerMojo.java:1905) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1886) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1545) at org.apache.maven.plugins.invoker.AbstractInvokerMojo.lambda$runBuilds$4(AbstractInvokerMojo.java:1307) at org.apache.maven.plugins.invoker.JobExecutor.lambda$forEach$0(JobExecutor.java:63) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) ``` You cannot create a symlink on Windows unless you have an elevated shell or developer mode. See: https://www.reddit.com/r/Batch/comments/p8m0bn/creating_smbolic_link_symlink_without_admin/ You need to create a selector script which tries to create a symlink, if it succeeds you can continue
[PR] Adjustments in new API related to PathType [maven]
desruisseaux opened a new pull request, #1501: URL: https://github.com/apache/maven/pull/1501 This pull request makes the following changes in API related to `PathType`. Those changes are for supporting the development of the Maven compiler plugin: * Add new artifact types for annotation processor paths: * `PROCESSOR` * `MODULAR_PROCESSOR` * `CLASSPATH_PROCESSOR` * Establish a relationship between `org.apache.maven.api.JavaPathType` and `javax.tools.StandardLocation`: * New `location()` public method returning `Optional`. * New `valueOf(JavaFileManager.Location location)` public static method (converse of the above). * New _"Relationship with Java compiler standard location"_ section in class Javadoc. * Modify the return type of `option(Iterable paths)` from `String` to `String[]`. * Delete `DependencyResolverResult.option(PathType)` because it appeared to not be needed. * Add `DependencyResolverResult.warningForFilenameBasedAutomodules()` as a helper for managing the _"Filename-based automodules detected on the module-path: Please don't publish this project to a public artifact repository"_ warning. This warning already exists in Maven 3. All methods removed or changed were new in Maven 4-alpha, so there is no compatibility break with stable releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843508#comment-17843508 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094396908 Reminds of https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243030 > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094396908 Reminds of https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843506#comment-17843506 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094373023 There it is: https://github.com/apache/maven-pmd-plugin/actions/runs/8953082426/job/24591196710#step:6:1942 > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094373023 There it is: https://github.com/apache/maven-pmd-plugin/actions/runs/8953082426/job/24591196710#step:6:1942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843505#comment-17843505 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094372771 @mkolesnikov Please rework this with a followup PR. for now, the flow is broken. > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094372771 @mkolesnikov Please rework this with a followup PR. for now, the flow is broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843504#comment-17843504
]
ASF GitHub Bot commented on MPMD-379:
-
michael-o commented on code in PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#discussion_r1590128034
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -155,46 +149,50 @@ private CpdResult run() throws MavenReportException {
CPDConfiguration cpdConfiguration = new CPDConfiguration();
cpdConfiguration.setMinimumTileSize(request.getMinimumTokens());
+cpdConfiguration.setIgnoreAnnotations(request.isIgnoreAnnotations());
+cpdConfiguration.setIgnoreLiterals(request.isIgnoreLiterals());
+cpdConfiguration.setIgnoreIdentifiers(request.isIgnoreIdentifiers());
-Language cpdLanguage;
-if ("java".equals(request.getLanguage()) || null ==
request.getLanguage()) {
-cpdLanguage = new JavaLanguage(request.getLanguageProperties());
-} else if ("javascript".equals(request.getLanguage())) {
-cpdLanguage = new EcmascriptLanguage();
-} else if ("jsp".equals(request.getLanguage())) {
-cpdLanguage = new JSPLanguage();
-} else {
-cpdLanguage =
LanguageFactory.createLanguage(request.getLanguage(),
request.getLanguageProperties());
+String languageId = request.getLanguage();
+if ("javascript".equals(languageId)) {
+languageId = "ecmascript";
+} else if (languageId == null) {
+languageId = "java"; // default
}
+Language cpdLanguage =
cpdConfiguration.getLanguageRegistry().getLanguageById(languageId);
-cpdConfiguration.setLanguage(cpdLanguage);
-cpdConfiguration.setSourceEncoding(request.getSourceEncoding());
+cpdConfiguration.setOnlyRecognizeLanguage(cpdLanguage);
+
cpdConfiguration.setSourceEncoding(Charset.forName(request.getSourceEncoding()));
-CPD cpd = new CPD(cpdConfiguration);
-try {
-cpd.add(request.getFiles());
-} catch (IOException e) {
-throw new MavenReportException(e.getMessage(), e);
-}
+request.getFiles().forEach(f ->
cpdConfiguration.addInputPath(f.toPath()));
LOG.debug("Executing CPD...");
-cpd.go();
-LOG.debug("CPD finished.");
// always create XML format. we need to output it even if the file
list is empty or we have no duplications
// so the "check" goals can check for violations
-writeXmlReport(cpd);
+try (CpdAnalysis cpd = CpdAnalysis.create(cpdConfiguration)) {
+cpd.performAnalysis(report -> {
+try {
+writeXmlReport(report);
-// html format is handled by maven site report, xml format has already
been rendered
-String format = request.getFormat();
-if (!"html".equals(format) && !"xml".equals(format)) {
-writeFormattedReport(cpd);
+// html format is handled by maven site report, xml format
has already been rendered
+String format = request.getFormat();
+if (!"html".equals(format) && !"xml".equals(format)) {
+writeFormattedReport(report);
+}
+} catch (MavenReportException e) {
+LOG.error("Error while writing CPD report", e);
+}
+});
+} catch (IOException e) {
+LOG.error("Error while executing CPD", e);
Review Comment:
This is a bad change
> Upgrade to use PMD 7.0.0 by default
> ---
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.22.0
>
>
> Add support for the new major version of PMD.
> This gives support for analyzing Java 21 code.
> The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact
> end-users, if they use custom rulesets (see
> [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html])
> or if they override the dependencies to upgrade PMD at runtime and currently
> use PMD 6.x (see
> [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]).
>
> Most likely, end-users have to review their rulesets and migrate them to PMD
> 7. Rules might have been renamed or replaced. See
> [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and
> [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] .
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on code in PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#discussion_r1590128034
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -155,46 +149,50 @@ private CpdResult run() throws MavenReportException {
CPDConfiguration cpdConfiguration = new CPDConfiguration();
cpdConfiguration.setMinimumTileSize(request.getMinimumTokens());
+cpdConfiguration.setIgnoreAnnotations(request.isIgnoreAnnotations());
+cpdConfiguration.setIgnoreLiterals(request.isIgnoreLiterals());
+cpdConfiguration.setIgnoreIdentifiers(request.isIgnoreIdentifiers());
-Language cpdLanguage;
-if ("java".equals(request.getLanguage()) || null ==
request.getLanguage()) {
-cpdLanguage = new JavaLanguage(request.getLanguageProperties());
-} else if ("javascript".equals(request.getLanguage())) {
-cpdLanguage = new EcmascriptLanguage();
-} else if ("jsp".equals(request.getLanguage())) {
-cpdLanguage = new JSPLanguage();
-} else {
-cpdLanguage =
LanguageFactory.createLanguage(request.getLanguage(),
request.getLanguageProperties());
+String languageId = request.getLanguage();
+if ("javascript".equals(languageId)) {
+languageId = "ecmascript";
+} else if (languageId == null) {
+languageId = "java"; // default
}
+Language cpdLanguage =
cpdConfiguration.getLanguageRegistry().getLanguageById(languageId);
-cpdConfiguration.setLanguage(cpdLanguage);
-cpdConfiguration.setSourceEncoding(request.getSourceEncoding());
+cpdConfiguration.setOnlyRecognizeLanguage(cpdLanguage);
+
cpdConfiguration.setSourceEncoding(Charset.forName(request.getSourceEncoding()));
-CPD cpd = new CPD(cpdConfiguration);
-try {
-cpd.add(request.getFiles());
-} catch (IOException e) {
-throw new MavenReportException(e.getMessage(), e);
-}
+request.getFiles().forEach(f ->
cpdConfiguration.addInputPath(f.toPath()));
LOG.debug("Executing CPD...");
-cpd.go();
-LOG.debug("CPD finished.");
// always create XML format. we need to output it even if the file
list is empty or we have no duplications
// so the "check" goals can check for violations
-writeXmlReport(cpd);
+try (CpdAnalysis cpd = CpdAnalysis.create(cpdConfiguration)) {
+cpd.performAnalysis(report -> {
+try {
+writeXmlReport(report);
-// html format is handled by maven site report, xml format has already
been rendered
-String format = request.getFormat();
-if (!"html".equals(format) && !"xml".equals(format)) {
-writeFormattedReport(cpd);
+// html format is handled by maven site report, xml format
has already been rendered
+String format = request.getFormat();
+if (!"html".equals(format) && !"xml".equals(format)) {
+writeFormattedReport(report);
+}
+} catch (MavenReportException e) {
+LOG.error("Error while writing CPD report", e);
+}
+});
+} catch (IOException e) {
+LOG.error("Error while executing CPD", e);
Review Comment:
This is a bad change -- it swallows the exception, build continues.
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -155,46 +149,50 @@ private CpdResult run() throws MavenReportException {
CPDConfiguration cpdConfiguration = new CPDConfiguration();
cpdConfiguration.setMinimumTileSize(request.getMinimumTokens());
+cpdConfiguration.setIgnoreAnnotations(request.isIgnoreAnnotations());
+cpdConfiguration.setIgnoreLiterals(request.isIgnoreLiterals());
+cpdConfiguration.setIgnoreIdentifiers(request.isIgnoreIdentifiers());
-Language cpdLanguage;
-if ("java".equals(request.getLanguage()) || null ==
request.getLanguage()) {
-cpdLanguage = new JavaLanguage(request.getLanguageProperties());
-} else if ("javascript".equals(request.getLanguage())) {
-cpdLanguage = new EcmascriptLanguage();
-} else if ("jsp".equals(request.getLanguage())) {
-cpdLanguage = new JSPLanguage();
-} else {
-cpdLanguage =
LanguageFactory.createLanguage(request.getLanguage(),
request.getLanguageProperties());
+String languageId = request.getLanguage();
+if ("javascript".equals(languageId)) {
+languageId = "ecmascript";
+} else if (languageId == null) {
+languageId = "java"; // default
}
+Language cpdLanguage =
cpdConfiguration.getLanguageRegistry().getLanguageById(languageId);
-
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843503#comment-17843503
]
ASF GitHub Bot commented on MPMD-379:
-
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392
This change introduced now a failing test which did no bubble up in CI, but
should have:
```
[INFO] Running org.apache.maven.plugins.pmd.CpdReportTest
org.apache.maven.reporting.MavenReportException: Can't find CPD custom
format xhtml: java.lang.ClassNotFoundException
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.createRenderer(CpdExecutor.java:251)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.writeFormattedReport(CpdExecutor.java:226)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.lambda$run$1(CpdExecutor.java:181)
at
net.sourceforge.pmd.cpd.CpdAnalysis.performAnalysis(CpdAnalysis.java:203)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.run(CpdExecutor.java:174)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.execute(CpdExecutor.java:64)
at
org.apache.maven.plugins.pmd.CpdReport.executeCpd(CpdReport.java:204)
at
org.apache.maven.plugins.pmd.CpdReport.canGenerateReport(CpdReport.java:156)
at
org.apache.maven.reporting.AbstractMavenReport.execute(AbstractMavenReport.java:143)
at
org.apache.maven.plugins.pmd.AbstractPmdReportTestCase.generateReport(AbstractPmdReportTestCase.java:119)
at
org.apache.maven.plugins.pmd.CpdReportTest.testInvalidFormat(CpdReportTest.java:129)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:177)
at junit.framework.TestCase.runBare(TestCase.java:142)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:130)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at junit.framework.TestSuite.run(TestSuite.java:236)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
Caused by: java.lang.ClassNotFoundException: xhtml
at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.createRenderer(CpdExecutor.java:247)
... 31 more
```
Verififed against `maven-pmd-plugin-3.21.2`.
The acutal reason is this change:
```
+} catch (MavenReportException e) {
+LOG.error("Error while writing CPD report", e);
+}
```
and the reason why it does not bubble up is because
`org.apache.maven.plugins.pmd.CpdReportTest.testInvalidFormat()` does
```
} catch (Exception e) {
assertTrue(true);
}
```
There is an exception thrown because the test file des not set
`localRepository` parameter:
```
D:\Entwicklung\Projekte\maven-pmd-plugin [master ≡ +0 ~1 -0 !]> git diff -U0
diff --git
a/src/test/resources/unit/invalid-format/cpd-invalid-format-plugin-config.xml
b/src/test/resources/unit/invalid-format/cpd-invalid-format-plugin-config.xml
index e3cff6c2..aca6d08e 100644
-
> Upgrade to use PMD 7.0.0 by default
> ---
>
> Key: MPMD-379
>
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392
This change introduced now a failing test which did no bubble up in CI, but
should have:
```
[INFO] Running org.apache.maven.plugins.pmd.CpdReportTest
org.apache.maven.reporting.MavenReportException: Can't find CPD custom
format xhtml: java.lang.ClassNotFoundException
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.createRenderer(CpdExecutor.java:251)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.writeFormattedReport(CpdExecutor.java:226)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.lambda$run$1(CpdExecutor.java:181)
at
net.sourceforge.pmd.cpd.CpdAnalysis.performAnalysis(CpdAnalysis.java:203)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.run(CpdExecutor.java:174)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.execute(CpdExecutor.java:64)
at
org.apache.maven.plugins.pmd.CpdReport.executeCpd(CpdReport.java:204)
at
org.apache.maven.plugins.pmd.CpdReport.canGenerateReport(CpdReport.java:156)
at
org.apache.maven.reporting.AbstractMavenReport.execute(AbstractMavenReport.java:143)
at
org.apache.maven.plugins.pmd.AbstractPmdReportTestCase.generateReport(AbstractPmdReportTestCase.java:119)
at
org.apache.maven.plugins.pmd.CpdReportTest.testInvalidFormat(CpdReportTest.java:129)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:177)
at junit.framework.TestCase.runBare(TestCase.java:142)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:130)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at junit.framework.TestSuite.run(TestSuite.java:236)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
Caused by: java.lang.ClassNotFoundException: xhtml
at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at
org.apache.maven.plugins.pmd.exec.CpdExecutor.createRenderer(CpdExecutor.java:247)
... 31 more
```
Verififed against `maven-pmd-plugin-3.21.2`.
The acutal reason is this change:
```
+} catch (MavenReportException e) {
+LOG.error("Error while writing CPD report", e);
+}
```
and the reason why it does not bubble up is because
`org.apache.maven.plugins.pmd.CpdReportTest.testInvalidFormat()` does
```
} catch (Exception e) {
assertTrue(true);
}
```
There is an exception thrown because the test file des not set
`localRepository` parameter:
```
D:\Entwicklung\Projekte\maven-pmd-plugin [master ≡ +0 ~1 -0 !]> git diff -U0
diff --git
a/src/test/resources/unit/invalid-format/cpd-invalid-format-plugin-config.xml
b/src/test/resources/unit/invalid-format/cpd-invalid-format-plugin-config.xml
index e3cff6c2..aca6d08e 100644
---
a/src/test/resources/unit/invalid-format/cpd-invalid-format-plugin-config.xml
+++
b/src/test/resources/unit/invalid-format/cpd-invalid-format-plugin-config.xml
@@ -38,0 +39 @@ under the License.
+ ${localRepository}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094369580 > @michael-o please abstain from statements like these. Any contribution is welcome, and mistakes do happen (yes, squashing the PR would be good, but this is not the end of the world). @adangel Thank you! I don't a problem with the change, it is pefectly fine. The merge what I totally dislike. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843502#comment-17843502 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094369580 > @michael-o please abstain from statements like these. Any contribution is welcome, and mistakes do happen (yes, squashing the PR would be good, but this is not the end of the world). @adangel Thank you! I don't a problem with the change, it is pefectly fine. The merge what I totally dislike. > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843501#comment-17843501 ] ASF GitHub Bot commented on MPMD-379: - cstamas commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094367940 @michael-o please abstain from statements like these. Any contribution is welcome, and mistakes do happen (yes, squashing the PR would be good, but this is not the end of the world). @adangel Thank you! > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
cstamas commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094367940 @michael-o please abstain from statements like these. Any contribution is welcome, and mistakes do happen (yes, squashing the PR would be good, but this is not the end of the world). @adangel Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843500#comment-17843500 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094353945 @adangel That merge was a pile of junk. You imported all intermediate work into master making it impossible to trace down the actual change. Don't do that again please, always squash and rebase first. Clearly a -1 for the methodology. > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094353945 @adangel That merge was a pile of junk. You imported all intermediate work into master making it impossible to trace down the actual change. Don't do that again please, always squash and rebase first. Clearly a -1 for the methodology. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output
[
https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSITE-1006.
-
Resolution: Fixed
Fixed with
[b3a063b17f2a2a15b02b179b84103e0bf6330c87|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=b3a063b17f2a2a15b02b179b84103e0bf6330c87].
> MSITE-723 causes duplicate document rendering and log output
>
>
> Key: MSITE-1006
> URL: https://issues.apache.org/jira/browse/MSITE-1006
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration
>Affects Versions: 4.0.0-M13
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-M14
>
>
> Consider the following output:
> {noformat}
> ...
> [INFO] --- maven-site-plugin:3.12.1:site (default-site) @ doxia-skin-model ---
> [INFO] configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.5
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.5:
> index, summary, dependency-info, modules, team, scm, issue-management,
> mailing-lists, dependency-management, dependencies, dependency-convergence,
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site with default locale English (en)
> [INFO] Relativizing decoration links with respect to localized project URL:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-skin-model/
> [INFO] Rendering content with
> org.apache.maven.skins:maven-fluido-skin:jar:1.11.2 skin.
> [INFO] Skipped "About" report
> (maven-project-info-reports-plugin:3.4.5:index), file "index.html" already
> exists.
> [INFO] Rendering 2 Doxia documents: 1 apt, 1 xdoc
> [INFO] Generating "Summary" report ---
> maven-project-info-reports-plugin:3.4.5:summary
> [INFO] Generating "Dependency Information" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-info
> [INFO] Generating "Team" report ---
> maven-project-info-reports-plugin:3.4.5:team
> [INFO] Generating "Source Code Management" report ---
> maven-project-info-reports-plugin:3.4.5:scm
> [INFO] Generating "Issue Management" report ---
> maven-project-info-reports-plugin:3.4.5:issue-management
> [INFO] Generating "Mailing Lists" report---
> maven-project-info-reports-plugin:3.4.5:mailing-lists
> [INFO] Generating "Dependency Management" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-management
> [INFO] Generating "Dependencies" report ---
> maven-project-info-reports-plugin:3.4.5:dependencies
> [INFO] Generating "Dependency Convergence" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-convergence
> [INFO] Generating "CI Management" report---
> maven-project-info-reports-plugin:3.4.5:ci-management
> [INFO] Generating "Plugin Management" report---
> maven-project-info-reports-plugin:3.4.5:plugin-management
> [INFO] Generating "Plugins" report ---
> maven-project-info-reports-plugin:3.4.5:plugins
> [INFO] Generating "Distribution Management" report ---
> maven-project-info-reports-plugin:3.4.5:distribution-management
> [INFO] Rendering 1 generated Doxia document: 1 xdoc
> ...
> {noformat}
> Let's locate these two handwritten documents:
> {noformat}
> ~/var/Projekte/maven-doxia-sitetools (master =)
> $ tree doxia-skin-model/src/site/
> doxia-skin-model/src/site/
> ├── apt
> │ └── index.apt
> └── site.xml
> 2 directories, 2 files
> {noformat}
> There aren't. This is caused by MSITE-723 which add generated documents for
> the first round of rendering (non-editable ones), then does the rendering,
> does reports and then allows generated documents to overwrite report output
> by running generated rendering again.
> This is suboptimal since it causes:
> * Duplicate rendering
> * Deceiving log output
> * Maven Fluido Skin generates an "Edit Button" for such content sind the
> editable flag is set to true:
> view-source:https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-2.0.0-M16/doxia-skin-model/skin.html
> The solution to the problem is to flag the document renderer for such output
> with Sitetools to allow unconditional overwrite. We need to fix Doxia
> Sitetools first and then we can fix in this plugin.
> Block in question:
> https://github.com/apache/maven-site-plugin/blob/036997f9a70b7394d9a9771ede04a686aca834e1/src/main/java/org/apache/maven/plugins/site/render/SiteMojo.java#L123-L167
> This needs to be {{true}}:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/xref/org/apache/maven/doxia/siterenderer/DoxiaDocumentRenderer.html#L61
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output
[
https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843472#comment-17843472
]
ASF GitHub Bot commented on MSITE-1006:
---
asfgit merged PR #183:
URL: https://github.com/apache/maven-site-plugin/pull/183
> MSITE-723 causes duplicate document rendering and log output
>
>
> Key: MSITE-1006
> URL: https://issues.apache.org/jira/browse/MSITE-1006
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration
>Affects Versions: 4.0.0-M13
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-M14
>
>
> Consider the following output:
> {noformat}
> ...
> [INFO] --- maven-site-plugin:3.12.1:site (default-site) @ doxia-skin-model ---
> [INFO] configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.5
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.5:
> index, summary, dependency-info, modules, team, scm, issue-management,
> mailing-lists, dependency-management, dependencies, dependency-convergence,
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site with default locale English (en)
> [INFO] Relativizing decoration links with respect to localized project URL:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-skin-model/
> [INFO] Rendering content with
> org.apache.maven.skins:maven-fluido-skin:jar:1.11.2 skin.
> [INFO] Skipped "About" report
> (maven-project-info-reports-plugin:3.4.5:index), file "index.html" already
> exists.
> [INFO] Rendering 2 Doxia documents: 1 apt, 1 xdoc
> [INFO] Generating "Summary" report ---
> maven-project-info-reports-plugin:3.4.5:summary
> [INFO] Generating "Dependency Information" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-info
> [INFO] Generating "Team" report ---
> maven-project-info-reports-plugin:3.4.5:team
> [INFO] Generating "Source Code Management" report ---
> maven-project-info-reports-plugin:3.4.5:scm
> [INFO] Generating "Issue Management" report ---
> maven-project-info-reports-plugin:3.4.5:issue-management
> [INFO] Generating "Mailing Lists" report---
> maven-project-info-reports-plugin:3.4.5:mailing-lists
> [INFO] Generating "Dependency Management" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-management
> [INFO] Generating "Dependencies" report ---
> maven-project-info-reports-plugin:3.4.5:dependencies
> [INFO] Generating "Dependency Convergence" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-convergence
> [INFO] Generating "CI Management" report---
> maven-project-info-reports-plugin:3.4.5:ci-management
> [INFO] Generating "Plugin Management" report---
> maven-project-info-reports-plugin:3.4.5:plugin-management
> [INFO] Generating "Plugins" report ---
> maven-project-info-reports-plugin:3.4.5:plugins
> [INFO] Generating "Distribution Management" report ---
> maven-project-info-reports-plugin:3.4.5:distribution-management
> [INFO] Rendering 1 generated Doxia document: 1 xdoc
> ...
> {noformat}
> Let's locate these two handwritten documents:
> {noformat}
> ~/var/Projekte/maven-doxia-sitetools (master =)
> $ tree doxia-skin-model/src/site/
> doxia-skin-model/src/site/
> ├── apt
> │ └── index.apt
> └── site.xml
> 2 directories, 2 files
> {noformat}
> There aren't. This is caused by MSITE-723 which add generated documents for
> the first round of rendering (non-editable ones), then does the rendering,
> does reports and then allows generated documents to overwrite report output
> by running generated rendering again.
> This is suboptimal since it causes:
> * Duplicate rendering
> * Deceiving log output
> * Maven Fluido Skin generates an "Edit Button" for such content sind the
> editable flag is set to true:
> view-source:https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-2.0.0-M16/doxia-skin-model/skin.html
> The solution to the problem is to flag the document renderer for such output
> with Sitetools to allow unconditional overwrite. We need to fix Doxia
> Sitetools first and then we can fix in this plugin.
> Block in question:
> https://github.com/apache/maven-site-plugin/blob/036997f9a70b7394d9a9771ede04a686aca834e1/src/main/java/org/apache/maven/plugins/site/render/SiteMojo.java#L123-L167
> This needs to be {{true}}:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/xref/org/apache/maven/doxia/siterenderer/DoxiaDocumentRenderer.html#L61
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output
[
https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843471#comment-17843471
]
ASF GitHub Bot commented on MSITE-1006:
---
asfgit closed pull request #183: [MSITE-1006] MSITE-723 causes duplicate
document rendering and log ou…
URL: https://github.com/apache/maven-site-plugin/pull/183
> MSITE-723 causes duplicate document rendering and log output
>
>
> Key: MSITE-1006
> URL: https://issues.apache.org/jira/browse/MSITE-1006
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration
>Affects Versions: 4.0.0-M13
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-M14
>
>
> Consider the following output:
> {noformat}
> ...
> [INFO] --- maven-site-plugin:3.12.1:site (default-site) @ doxia-skin-model ---
> [INFO] configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.5
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.5:
> index, summary, dependency-info, modules, team, scm, issue-management,
> mailing-lists, dependency-management, dependencies, dependency-convergence,
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site with default locale English (en)
> [INFO] Relativizing decoration links with respect to localized project URL:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-skin-model/
> [INFO] Rendering content with
> org.apache.maven.skins:maven-fluido-skin:jar:1.11.2 skin.
> [INFO] Skipped "About" report
> (maven-project-info-reports-plugin:3.4.5:index), file "index.html" already
> exists.
> [INFO] Rendering 2 Doxia documents: 1 apt, 1 xdoc
> [INFO] Generating "Summary" report ---
> maven-project-info-reports-plugin:3.4.5:summary
> [INFO] Generating "Dependency Information" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-info
> [INFO] Generating "Team" report ---
> maven-project-info-reports-plugin:3.4.5:team
> [INFO] Generating "Source Code Management" report ---
> maven-project-info-reports-plugin:3.4.5:scm
> [INFO] Generating "Issue Management" report ---
> maven-project-info-reports-plugin:3.4.5:issue-management
> [INFO] Generating "Mailing Lists" report---
> maven-project-info-reports-plugin:3.4.5:mailing-lists
> [INFO] Generating "Dependency Management" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-management
> [INFO] Generating "Dependencies" report ---
> maven-project-info-reports-plugin:3.4.5:dependencies
> [INFO] Generating "Dependency Convergence" report ---
> maven-project-info-reports-plugin:3.4.5:dependency-convergence
> [INFO] Generating "CI Management" report---
> maven-project-info-reports-plugin:3.4.5:ci-management
> [INFO] Generating "Plugin Management" report---
> maven-project-info-reports-plugin:3.4.5:plugin-management
> [INFO] Generating "Plugins" report ---
> maven-project-info-reports-plugin:3.4.5:plugins
> [INFO] Generating "Distribution Management" report ---
> maven-project-info-reports-plugin:3.4.5:distribution-management
> [INFO] Rendering 1 generated Doxia document: 1 xdoc
> ...
> {noformat}
> Let's locate these two handwritten documents:
> {noformat}
> ~/var/Projekte/maven-doxia-sitetools (master =)
> $ tree doxia-skin-model/src/site/
> doxia-skin-model/src/site/
> ├── apt
> │ └── index.apt
> └── site.xml
> 2 directories, 2 files
> {noformat}
> There aren't. This is caused by MSITE-723 which add generated documents for
> the first round of rendering (non-editable ones), then does the rendering,
> does reports and then allows generated documents to overwrite report output
> by running generated rendering again.
> This is suboptimal since it causes:
> * Duplicate rendering
> * Deceiving log output
> * Maven Fluido Skin generates an "Edit Button" for such content sind the
> editable flag is set to true:
> view-source:https://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-2.0.0-M16/doxia-skin-model/skin.html
> The solution to the problem is to flag the document renderer for such output
> with Sitetools to allow unconditional overwrite. We need to fix Doxia
> Sitetools first and then we can fix in this plugin.
> Block in question:
> https://github.com/apache/maven-site-plugin/blob/036997f9a70b7394d9a9771ede04a686aca834e1/src/main/java/org/apache/maven/plugins/site/render/SiteMojo.java#L123-L167
> This needs to be {{true}}:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/xref/org/apache/maven/doxia/siterenderer/DoxiaDocumentRenderer.html#L61
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… [maven-site-plugin]
asfgit merged PR #183: URL: https://github.com/apache/maven-site-plugin/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… [maven-site-plugin]
asfgit closed pull request #183: [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… URL: https://github.com/apache/maven-site-plugin/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINVOKER-366) Require Maven 3.6.3
Slawomir Jaranowski created MINVOKER-366: Summary: Require Maven 3.6.3 Key: MINVOKER-366 URL: https://issues.apache.org/jira/browse/MINVOKER-366 Project: Maven Invoker Plugin Issue Type: Improvement Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.7.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-365) Allow to pre-build script to set user properties
[ https://issues.apache.org/jira/browse/MINVOKER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843444#comment-17843444 ] ASF GitHub Bot commented on MINVOKER-365: - slawekjaranowski opened a new pull request, #236: URL: https://github.com/apache/maven-invoker-plugin/pull/236 https://issues.apache.org/jira/browse/MINVOKER-365 > Allow to pre-build script to set user properties > > > Key: MINVOKER-365 > URL: https://issues.apache.org/jira/browse/MINVOKER-365 > Project: Maven Invoker Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > We can have a scenario when in pre-build script we run a mock server, eg by > WireMock or simply by other tools. > In such situation we have a random a use random port for listening > connection, so we need pass it to Maven execution. > Other simple scenario is when we create a temporary file with test data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[ https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843436#comment-17843436 ] ASF GitHub Bot commented on MSHARED-1390: - slawekjaranowski opened a new pull request, #76: URL: https://github.com/apache/maven-invoker/pull/76 https://issues.apache.org/jira/browse/MSHARED-1390 > Deprecate InvocationRequest#setGoals > > > Key: MSHARED-1390 > URL: https://issues.apache.org/jira/browse/MSHARED-1390 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-3.3.0 > > > We should avoid parsing command line arguments. > Raw arguments should be used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1390) Deprecate InvocationRequest#setGoals
Slawomir Jaranowski created MSHARED-1390: Summary: Deprecate InvocationRequest#setGoals Key: MSHARED-1390 URL: https://issues.apache.org/jira/browse/MSHARED-1390 Project: Maven Shared Components Issue Type: Improvement Components: maven-invoker Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: maven-invoker-3.3.0 We should avoid parsing command line arguments. Raw arguments should be used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1389) Refresh download page
[ https://issues.apache.org/jira/browse/MSHARED-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1389. Resolution: Fixed > Refresh download page > - > > Key: MSHARED-1389 > URL: https://issues.apache.org/jira/browse/MSHARED-1389 > Project: Maven Shared Components > Issue Type: Task > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1389] Refresh download page [maven-invoker]
slawekjaranowski merged PR #75: URL: https://github.com/apache/maven-invoker/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MSHARED-1382.
Fix Version/s: maven-invoker-next-release
Assignee: Slawomir Jaranowski
Resolution: Fixed
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-next-release
>
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-364. Resolution: Fixed > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843424#comment-17843424 ] ASF GitHub Bot commented on MINVOKER-364: - slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235 > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[
https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843396#comment-17843396
]
ASF GitHub Bot commented on MNG-8084:
-
hboutemy opened a new pull request, #1500:
URL: https://github.com/apache/maven/pull/1500
fixes `./${user.home}` directory creation during tests execution
that is after running `mvn clean test`, I get
```
$ git status
On branch master
Your branch is up to date with 'origin/master'.
Untracked files:
(use "git add ..." to include in what will be committed)
maven-api-impl/${user.home}/
```
> Make the v4 api usable outside the Maven runtime
>
>
> Key: MNG-8084
> URL: https://issues.apache.org/jira/browse/MNG-8084
> Project: Maven
> Issue Type: New Feature
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
