[jira] [Updated] (MNG-8123) Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
[
https://issues.apache.org/jira/browse/MNG-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MNG-8123:
---
Affects Version/s: 4.0.0-beta-2
> Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
> ---
>
> Key: MNG-8123
> URL: https://issues.apache.org/jira/browse/MNG-8123
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-beta-2
>Reporter: Filipe Roque
>Priority: Major
>
> {code:java}
> ❯ mvn --version
> Apache Maven 4.0.0-beta-2 (828faba81940a8d2f2e5cfab6f60e35d1ab61ca0)
> Maven home: /opt/maven/apache-maven-4.0.0-beta-2
> Java version: 22.0.1, vendor: Eclipse Adoptium, runtime:
> /usr/lib/jvm/temurin-22-jdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "6.5.0-28-generic", arch: "amd64", family: "unix"
> {code}
> project created with
> {code:java}
> mvn archetype:generate {code}
> Adding maven cache extension
> {code:java}
> cat .mvn/extensions.xml
> http://maven.apache.org/EXTENSIONS/1.0.0;>
>
> org.apache.maven.extensions
> maven-build-cache-extension
> 1.2.0
>
>
> {code}
> Fails with:
> {code:java}
> ❯ mvn compile [INFO] Cache configuration is not available at configured path
> /home/froque/workspace/testes/project1/.mvn/maven-build-cache-config.xml,
> cache is enabled with defaults [INFO] Using XX hash algorithm for cache
> [ERROR] Internal error: com.google.inject.ProvisionException: Unable to
> provision, see the following errors: [ERROR] [ERROR] 1)
> [Guice/NullInjectedIntoNonNullable]: null returned by binding at
> LocatorWiring [ERROR] but the 3rd parameter of
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
> [ERROR] at LocatorWiring [ERROR] at
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) [ERROR] \_
> for 3rd parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] at
> CacheControllerImpl.(CacheControllerImpl.java:156) [ERROR] \_ for
> 10th parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] while locating
> CacheControllerImpl [ERROR] while locating Object annotated with * [ERROR]
> at LocatorWiring [ERROR] at
> CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) [ERROR]
> \_ for 2nd parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] while locating
> CacheLifecycleParticipant [ERROR] while locating Object annotated with *
> [ERROR] [ERROR] Learn more: [ERROR]
> https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE [ERROR]
> [ERROR] 1 error [ERROR] [ERROR] == [ERROR] Full
> classname legend: [ERROR] == [ERROR] CacheControllerImpl:
> "org.apache.maven.buildcache.CacheControllerImpl" [ERROR]
> CacheLifecycleParticipant:
> "org.apache.maven.buildcache.CacheLifecycleParticipant" [ERROR]
> LifecyclePhasesHelper:
> "org.apache.maven.buildcache.LifecyclePhasesHelper" [ERROR] LocatorWiring:
> "org.eclipse.sisu.wire.LocatorWiring" [ERROR] PlexusBindingModule:
> "org.eclipse.sisu.plexus.PlexusBindingModule" [ERROR] WireModule:
> "org.eclipse.sisu.wire.WireModule" [ERROR]
> [ERROR] End of classname legend: [ERROR] [ERROR] ->
> [Help 1] org.apache.maven.InternalErrorException: Internal error:
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:1) [Guice/NullInjectedIntoNonNullable]: null returned by binding at
> LocatorWiring but the 3rd parameter of
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
> at LocatorWiring at
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) \_ for 3rd
> parameter at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
> WireModule -> PlexusBindingModule at
> CacheControllerImpl.(CacheControllerImpl.java:156) \_ for 10th
> parameter at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
> WireModule ->
[jira] [Commented] (MNG-7883) Also print groupId and version in the Reactor Build Order
[
https://issues.apache.org/jira/browse/MNG-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847157#comment-17847157
]
ASF GitHub Bot commented on MNG-7883:
-
monniechuang opened a new pull request, #1511:
URL: https://github.com/apache/maven/pull/1511
**JIRA Issue**: [MNG-7883](https://issues.apache.org/jira/browse/MNG)
**Description**:
This pull request addresses the enhancement described in JIRA issue
MNG-7883. The goal is to improve the readability and completeness of the
Reactor Build Order output by including `groupId` and `version` information for
each module. This change is necessary to provide developers with more detailed
information about the modules being built, which can help in debugging and
understanding the build process.
**Changes Made**:
- Modified the `ExecutionEventLogger` class to include `groupId` and
`version` information in the Reactor Build Order output.
- Updated the `sessionStarted` method to format the output with the new
information, ensuring clarity and consistency.
**Implementation Details**:
- The `sessionStarted` method in `ExecutionEventLogger` was updated to
construct a formatted string containing the `groupId`, `artifactId`, and
`version` for each module.
- Adjusted the spacing and alignment to ensure the output remains clear and
readable.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Also print groupId and version in the Reactor Build Order
> -
>
> Key: MNG-7883
> URL: https://issues.apache.org/jira/browse/MNG-7883
> Project: Maven
> Issue Type: Improvement
> Components: Reactor and Workspace
>Reporter: Reto Hoehener
>Priority: Trivial
>
> This would be useful information when debugging a build process:
> {code:java}
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] my-groupmy-parent1.0.0-SNAPSHOT
> [pom]
> [INFO] my-groupmy-lib 1.0.0-SNAPSHOT
> [jar]
> [INFO] my-groupmy-app 1.0.4
> [jar] {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNG-7883] Also print groupId and version in the Reactor Build Order [maven]
monniechuang opened a new pull request, #1511: URL: https://github.com/apache/maven/pull/1511 **JIRA Issue**: [MNG-7883](https://issues.apache.org/jira/browse/MNG) **Description**: This pull request addresses the enhancement described in JIRA issue MNG-7883. The goal is to improve the readability and completeness of the Reactor Build Order output by including `groupId` and `version` information for each module. This change is necessary to provide developers with more detailed information about the modules being built, which can help in debugging and understanding the build process. **Changes Made**: - Modified the `ExecutionEventLogger` class to include `groupId` and `version` information in the Reactor Build Order output. - Updated the `sessionStarted` method to format the output with the new information, ensuring clarity and consistency. **Implementation Details**: - The `sessionStarted` method in `ExecutionEventLogger` was updated to construct a formatted string containing the `groupId`, `artifactId`, and `version` for each module. - Adjusted the spacing and alignment to ensure the output remains clear and readable. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7902) sort plugins in validation report
[ https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847151#comment-17847151 ] ASF GitHub Bot commented on MNG-7902: - yuehcw opened a new pull request, #1510: URL: https://github.com/apache/maven/pull/1510 **Summary** This pull request addresses the JIRA issue [MNG-7902](https://issues.apache.org/jira/browse/MNG-7902). The goal of this change is to enhance the readability and usability of the validation report by sorting the plugins in a case-insensitive manner. Currently, the report outputs the content of a set of plugins without sorting them, which can result in a random order, making it difficult for users to locate specific entries or identify patterns. **Changes Made** Added sorting logic: Implemented a sorting mechanism to order plugins case-insensitively in the validation report. Updated `reportSessionCollectedValidationIssues` function: Modified this function to include the sorting logic for plugins before they are logged. **Why This Change Is Necessary** By sorting the plugins in the validation report, developers can easily scan through the list to find specific entries or identify changes. This enhancement improves the readability and usability of the report, especially in scenarios where users need to review or troubleshoot plugin configurations. **How the Change Was Implemented** The sorting logic was added to the `reportSessionCollectedValidationIssues` function in the `DefaultPluginValidationManager` class. The plugins are sorted using `Map.Entry.comparingByKey(String.CASE_INSENSITIVE_ORDER)` before they are logged. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > sort plugins in validation report > - > > Key: MNG-7902 > URL: https://issues.apache.org/jira/browse/MNG-7902 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Michael Keppler >Priority: Minor > Attachments: image-2023-10-07-13-33-27-762.png > > > Please don't ever output the content of a Set for consumption by humans > without sorting it first. The order is otherwise "random". Sorting (case > insensitive) makes the same output easier to read, especially when trying to > find one specific entry (e.g. "Did we fix plugin foo already?") > !image-2023-10-07-13-33-27-762.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-7902] Sort plugins in the validation report [maven]
yuehcw opened a new pull request, #1510: URL: https://github.com/apache/maven/pull/1510 **Summary** This pull request addresses the JIRA issue [MNG-7902](https://issues.apache.org/jira/browse/MNG-7902). The goal of this change is to enhance the readability and usability of the validation report by sorting the plugins in a case-insensitive manner. Currently, the report outputs the content of a set of plugins without sorting them, which can result in a random order, making it difficult for users to locate specific entries or identify patterns. **Changes Made** Added sorting logic: Implemented a sorting mechanism to order plugins case-insensitively in the validation report. Updated `reportSessionCollectedValidationIssues` function: Modified this function to include the sorting logic for plugins before they are logged. **Why This Change Is Necessary** By sorting the plugins in the validation report, developers can easily scan through the list to find specific entries or identify changes. This enhancement improves the readability and usability of the report, especially in scenarios where users need to review or troubleshoot plugin configurations. **How the Change Was Implemented** The sorting logic was added to the `reportSessionCollectedValidationIssues` function in the `DefaultPluginValidationManager` class. The plugins are sorted using `Map.Entry.comparingByKey(String.CASE_INSENSITIVE_ORDER)` before they are logged. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.eclipse.jetty:jetty-bom from 10.0.20 to 10.0.21 [maven-resolver]
dependabot[bot] opened a new pull request, #494: URL: https://github.com/apache/maven-resolver/pull/494 Bumps [org.eclipse.jetty:jetty-bom](https://github.com/jetty/jetty.project) from 10.0.20 to 10.0.21. Release notes Sourced from https://github.com/jetty/jetty.project/releases;>org.eclipse.jetty:jetty-bom's releases. 10.0.21 Special Thanks to the following Eclipse Jetty community members https://github.com/shaoxt;>@shaoxt (Sheldon Shao) https://github.com/MarcinKozak005;>@MarcinKozak005 (Marcin Kozak) Changelog https://redirect.github.com/jetty/jetty.project/issues/11782;>#11782 - HttpExchange retained by HttpSenderOverHTTP which caused memory leak (https://github.com/shaoxt;>@shaoxt) https://redirect.github.com/jetty/jetty.project/issues/11634;>#11634 - Socks5Proxy does not support IP addresses with IP segments above 127 (https://github.com/MarcinKozak005;>@MarcinKozak005) https://redirect.github.com/jetty/jetty.project/issues/10805;>#10805 - Jetty response with an invalid HTTP2 packet if the client set the hpack table size as 0 https://redirect.github.com/jetty/jetty.project/issues/11527;>#11527 - Reduce ByteBuffer churning in HttpOutput https://redirect.github.com/jetty/jetty.project/issues/11656;>#11656 Upgrade jetty-quiche-native to version 0.21.0 Commits https://github.com/jetty/jetty.project/commit/12306d38ad57ba40dfb2b850a2900ff2de8e0357;>12306d3 Updating to version 10.0.21 https://github.com/jetty/jetty.project/commit/f2af974549be3c654638260f85cf12da8488ac8a;>f2af974 last Jetty 10 release last as we do not want a huge VERSION.TXT https://github.com/jetty/jetty.project/commit/cbc9f2b5476b0509028f957ef70a9dc3a648f527;>cbc9f2b enable maven stack trace if failure https://github.com/jetty/jetty.project/commit/1995b5ea591fd5db442eee4321913ec612eabf17;>1995b5e HttpExchange/HttpRequest got retained by HttpSenderOverHTTP (https://redirect.github.com/jetty/jetty.project/issues/11782;>#11782) https://github.com/jetty/jetty.project/commit/e594703a72fa59d9e96b9c7fe23f5f3ad75363be;>e594703 [10.0.x] Bump the integration-deps group with 2 updates https://github.com/jetty/jetty.project/commit/f8c087f1b5ccd5b55f7668d266d330818a663c76;>f8c087f hazelcast upgrade would need more work https://github.com/jetty/jetty.project/commit/55fa036dac40bd0792351e2569a9079535e7f727;>55fa036 revert git scm upgrade which break the build https://github.com/jetty/jetty.project/commit/762ccf2cd137eb62a1c74bf354d15270c431d21f;>762ccf2 [10.0.x] Bump the dev-dependencies group with 20 updates https://github.com/jetty/jetty.project/commit/b0b0a3104bf2a0bf9e9a3aa5347bc98983c6b0a6;>b0b0a31 [10.0.x] Bump the build-deps group with 10 updates https://github.com/jetty/jetty.project/commit/284de515644d7be2b6d407ad4490a7a5b8f49fe7;>284de51 fix broken xrefs in the documentation that need resolved before the antora mi... Additional commits viewable in https://github.com/jetty/jetty.project/compare/jetty-10.0.20...jetty-10.0.21;>compare view Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | | org.eclipse.jetty:jetty-bom | [>= 12.a, < 13] | | org.eclipse.jetty:jetty-bom | [>= 11.a, < 12] | [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close
[PR] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.0 [maven-dependency-plugin]
dependabot[bot] opened a new pull request, #392: URL: https://github.com/apache/maven-dependency-plugin/pull/392 Bumps [org.apache.maven.shared:maven-dependency-analyzer](https://github.com/apache/maven-dependency-analyzer) from 1.13.2 to 1.14.0. Release notes Sourced from https://github.com/apache/maven-dependency-analyzer/releases;>org.apache.maven.shared:maven-dependency-analyzer's releases. 1.14.0 What's Changed [MSHARED-1248] update commons-io to 2.13.0 by https://github.com/elharo;>@elharo in https://redirect.github.com/apache/maven-dependency-analyzer/pull/93;>apache/maven-dependency-analyzer#93 Fix compiler warnings by https://github.com/garydgregory;>@garydgregory in https://redirect.github.com/apache/maven-dependency-analyzer/pull/94;>apache/maven-dependency-analyzer#94 [MSHARED-1248] maven-dependency-analyzer should log instead of failing by https://github.com/garydgregory;>@garydgregory in https://redirect.github.com/apache/maven-dependency-analyzer/pull/89;>apache/maven-dependency-analyzer#89 Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.0 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/95;>apache/maven-dependency-analyzer#95 update to commons-io 2.14.0 by https://github.com/elharo;>@elharo in https://redirect.github.com/apache/maven-dependency-analyzer/pull/96;>apache/maven-dependency-analyzer#96 Bump org.ow2.asm:asm from 9.5 to 9.6 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/97;>apache/maven-dependency-analyzer#97 remove unused variable by https://github.com/elharo;>@elharo in https://redirect.github.com/apache/maven-dependency-analyzer/pull/98;>apache/maven-dependency-analyzer#98 Bump commons-io:commons-io from 2.14.0 to 2.15.1 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/100;>apache/maven-dependency-analyzer#100 Bump org.assertj:assertj-bom from 3.24.2 to 3.25.1 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/104;>apache/maven-dependency-analyzer#104 [MSHARED-1347] Include invoke dynamic bootstrap types in analysis by https://github.com/vbreivik;>@vbreivik in https://redirect.github.com/apache/maven-dependency-analyzer/pull/102;>apache/maven-dependency-analyzer#102 Bump org.assertj:assertj-bom from 3.25.1 to 3.25.2 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/105;>apache/maven-dependency-analyzer#105 [MSHARED-1356] Upgrade Parent to 41 by https://github.com/slawekjaranowski;>@slawekjaranowski in https://redirect.github.com/apache/maven-dependency-analyzer/pull/110;>apache/maven-dependency-analyzer#110 Bump org.junit:junit-bom from 5.10.1 to 5.10.2 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/108;>apache/maven-dependency-analyzer#108 Bump org.assertj:assertj-bom from 3.25.2 to 3.25.3 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/107;>apache/maven-dependency-analyzer#107 Use new property for maven-plugin-tools version by https://github.com/slawekjaranowski;>@slawekjaranowski in https://redirect.github.com/apache/maven-dependency-analyzer/pull/111;>apache/maven-dependency-analyzer#111 Bump commons-io:commons-io from 2.15.1 to 2.16.0 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/113;>apache/maven-dependency-analyzer#113 [MSHARED-1372] Bump org.ow2.asm:asm from 9.6 to 9.7 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/112;>apache/maven-dependency-analyzer#112 [MSHARED-1272] Bump commons-io:commons-io from 2.16.0 to 2.16.1 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/114;>apache/maven-dependency-analyzer#114 [MSHARED-1356] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/115;>apache/maven-dependency-analyzer#115 Update GitHub Actions by dependabot by https://github.com/slawekjaranowski;>@slawekjaranowski in https://redirect.github.com/apache/maven-dependency-analyzer/pull/116;>apache/maven-dependency-analyzer#116 Bump com.google.guava:guava from 30.1.1-android to 32.0.0-android in /src/it/jarWithCompileDependency/project2 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/apache/maven-dependency-analyzer/pull/117;>apache/maven-dependency-analyzer#117 [MSHARED-1395] Remove dependency on commons-io by
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847107#comment-17847107
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames opened a new pull request, #391:
URL: https://github.com/apache/maven-dependency-plugin/pull/391
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Same as #325, will squash and update commit in the end, once everything is
fixed.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
This is a continuation of #325, which adds JSON output type to the
maven-depdenceny-plugin with the goal tree.
The tests were disabled in the previous fork, to enable the tests (in a
working state) this is rebased to the current master (2024-05-16), if the
history looks weird (have some 'double' commits, unsure how to solve it). Two
tests exists.
[Discussion:
IOException](https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1590864832)
The JsonDependencyNodeVisitor now uses the PrintWriter which swallows
IOExceptions, as the other Node Visitors do. Could not get it to throw an
IOException due to the function being defined in the interface without throwing
an Exception, unsure if this can be solved without a larger rework?
[Discussion: Circular
Dependency](https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1590867632)
I have added a test for circular dependency, as well as a visited set to stop
infinite recursion. This currently exists silently, but I feel there should be
some sort of Exception or warning. Due to the same reason as above (interface
not throwing exception) I could not find a way to do this nicely. Guessing
RuntimeException("Detected Circular Dependency") is not an option? Happy to
receive help with ideas/suggestions/opinions!
I think all other requested changes from #325 are addressed.
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames opened a new pull request, #391:
URL: https://github.com/apache/maven-dependency-plugin/pull/391
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Same as #325, will squash and update commit in the end, once everything is
fixed.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
This is a continuation of #325, which adds JSON output type to the
maven-depdenceny-plugin with the goal tree.
The tests were disabled in the previous fork, to enable the tests (in a
working state) this is rebased to the current master (2024-05-16), if the
history looks weird (have some 'double' commits, unsure how to solve it). Two
tests exists.
[Discussion:
IOException](https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1590864832)
The JsonDependencyNodeVisitor now uses the PrintWriter which swallows
IOExceptions, as the other Node Visitors do. Could not get it to throw an
IOException due to the function being defined in the interface without throwing
an Exception, unsure if this can be solved without a larger rework?
[Discussion: Circular
Dependency](https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1590867632)
I have added a test for circular dependency, as well as a visited set to stop
infinite recursion. This currently exists silently, but I feel there should be
some sort of Exception or warning. Due to the same reason as above (interface
not throwing exception) I could not find a way to do this nicely. Guessing
RuntimeException("Detected Circular Dependency") is not an option? Happy to
receive help with ideas/suggestions/opinions!
I think all other requested changes from #325 are addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847101#comment-17847101
]
ASF GitHub Bot commented on MINVOKER-351:
-
slawekjaranowski commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2116213655
@michael-o there is a problem with special chars ... they are not escaped /
removed by the plexus-xml
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would
Re: [PR] Fix section indents [maven-site]
slawekjaranowski commented on PR #528: URL: https://github.com/apache/maven-site/pull/528#issuecomment-2116214715 last comments was on wrong PR ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2116213655 @michael-o there is a problem with special chars ... they are not escaped / removed by the plexus-xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix section indents [maven-site]
michael-o commented on PR #528: URL: https://github.com/apache/maven-site/pull/528#issuecomment-2116199630 > @michael-o there is a problem with special chars ... they are not escaped / removed by the plexus-xml Which? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix section indents [maven-site]
slawekjaranowski commented on PR #528: URL: https://github.com/apache/maven-site/pull/528#issuecomment-2116197031 @michael-o there is a problem with special chars ... they are not escaped / removed by the plexus-xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-doxia]
dependabot[bot] closed pull request #213: Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 URL: https://github.com/apache/maven-doxia/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-doxia]
dependabot[bot] commented on PR #213: URL: https://github.com/apache/maven-doxia/pull/213#issuecomment-2116196579 Looks like org.xmlunit:xmlunit-core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-doxia]
michael-o commented on PR #213: URL: https://github.com/apache/maven-doxia/pull/213#issuecomment-2116195968 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump xmlunitVersion from 2.9.1 to 2.10.0 [maven-doxia]
asfgit merged PR #212: URL: https://github.com/apache/maven-doxia/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump xmlunitVersion from 2.9.1 to 2.10.0 [maven-doxia]
michael-o commented on PR #212: URL: https://github.com/apache/maven-doxia/pull/212#issuecomment-2116191920 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-text from 1.11.0 to 1.12.0 [maven-doxia]
asfgit merged PR #211: URL: https://github.com/apache/maven-doxia/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-text from 1.11.0 to 1.12.0 [maven-doxia]
michael-o commented on PR #211: URL: https://github.com/apache/maven-doxia/pull/211#issuecomment-2116188604 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-doxia]
dependabot[bot] commented on PR #209: URL: https://github.com/apache/maven-doxia/pull/209#issuecomment-2116186193 OK, I won't notify you about org.codehaus.plexus:plexus-utils again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-doxia]
michael-o commented on PR #209: URL: https://github.com/apache/maven-doxia/pull/209#issuecomment-2116186100 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-doxia]
dependabot[bot] closed pull request #209: Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 URL: https://github.com/apache/maven-doxia/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-doxia]
dependabot[bot] commented on PR #209: URL: https://github.com/apache/maven-doxia/pull/209#issuecomment-2116185553 Sorry, the command you entered is not valid for this pull request. Please check the syntax and try again. Valid commands: For single dependency PRs, use commands like: `@dependabot ignore this major version` `@dependabot ignore this minor version` `@dependabot ignore this dependency` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-doxia]
michael-o commented on PR #209: URL: https://github.com/apache/maven-doxia/pull/209#issuecomment-2116185434 @dependabot ignore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-737) [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not extract document titles anymore
[
https://issues.apache.org/jira/browse/DOXIA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847098#comment-17847098
]
ASF GitHub Bot commented on DOXIA-737:
--
michael-o opened a new pull request, #214:
URL: https://github.com/apache/maven-doxia/pull/214
…ault does not extract document titles anymore
This closes #214
> [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not
> extract document titles anymore
> --
>
> Key: DOXIA-737
> URL: https://issues.apache.org/jira/browse/DOXIA-737
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M11
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Blocker
> Fix For: 2.0.0, 2.0.0-M12
>
>
> While working on https://github.com/apache/maven-site/pull/525 the following
> happens:
> Title before:
> {project} -- {document}
> Title now:
> {project}
> The document title is not extracted from the document anymore.
> If I do the following:
> {noformat}
> diff --git
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
>
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> index 544b6b9..b6a7d1d 100644
> ---
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> +++
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
> if (!isConfigured) {
> // DOXIASITETOOLS-146 don't render comments from source
> markup
> parser.setEmitComments(false);
> -parser.setEmitAnchorsForIndexableEntries(true);
> }
> // TODO: DOXIA-111: the filter used here must be checked
> generally.
> {noformat}
> Everything works again. I bet that the {{SiteRendererSink}} does not work
> well with the new approach in Doxia.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-doxia]
dependabot[bot] closed pull request #210: Bump org.apache.maven:maven-parent from 41 to 42 URL: https://github.com/apache/maven-doxia/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-doxia]
dependabot[bot] commented on PR #210: URL: https://github.com/apache/maven-doxia/pull/210#issuecomment-2116176182 Looks like org.apache.maven:maven-parent is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-doxia]
michael-o commented on PR #210: URL: https://github.com/apache/maven-doxia/pull/210#issuecomment-2116175122 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [DOXIA-737] [REGRESSION] Making EmitAnchorsForIndexableEntries by def… [maven-doxia]
michael-o opened a new pull request, #214: URL: https://github.com/apache/maven-doxia/pull/214 …ault does not extract document titles anymore This closes #214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-737) [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not extract document titles anymore
[
https://issues.apache.org/jira/browse/DOXIA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847096#comment-17847096
]
Michael Osipov commented on DOXIA-737:
--
Found it, truly a regression. {{IndexingSink}} was not passing the title text
to the super class.
> [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not
> extract document titles anymore
> --
>
> Key: DOXIA-737
> URL: https://issues.apache.org/jira/browse/DOXIA-737
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M11
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Blocker
> Fix For: 2.0.0, 2.0.0-M12
>
>
> While working on https://github.com/apache/maven-site/pull/525 the following
> happens:
> Title before:
> {project} -- {document}
> Title now:
> {project}
> The document title is not extracted from the document anymore.
> If I do the following:
> {noformat}
> diff --git
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
>
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> index 544b6b9..b6a7d1d 100644
> ---
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> +++
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
> if (!isConfigured) {
> // DOXIASITETOOLS-146 don't render comments from source
> markup
> parser.setEmitComments(false);
> -parser.setEmitAnchorsForIndexableEntries(true);
> }
> // TODO: DOXIA-111: the filter used here must be checked
> generally.
> {noformat}
> Everything works again. I bet that the {{SiteRendererSink}} does not work
> well with the new approach in Doxia.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-737) [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not extract document titles anymore
[
https://issues.apache.org/jira/browse/DOXIA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-737:
-
Fix Version/s: 2.0.0-M12
2.0.0
> [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not
> extract document titles anymore
> --
>
> Key: DOXIA-737
> URL: https://issues.apache.org/jira/browse/DOXIA-737
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M11
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Blocker
> Fix For: 2.0.0, 2.0.0-M12
>
>
> While working on https://github.com/apache/maven-site/pull/525 the following
> happens:
> Title before:
> {project} -- {document}
> Title now:
> {project}
> The document title is not extracted from the document anymore.
> If I do the following:
> {noformat}
> diff --git
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
>
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> index 544b6b9..b6a7d1d 100644
> ---
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> +++
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
> if (!isConfigured) {
> // DOXIASITETOOLS-146 don't render comments from source
> markup
> parser.setEmitComments(false);
> -parser.setEmitAnchorsForIndexableEntries(true);
> }
> // TODO: DOXIA-111: the filter used here must be checked
> generally.
> {noformat}
> Everything works again. I bet that the {{SiteRendererSink}} does not work
> well with the new approach in Doxia.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Moved] (DOXIA-737) [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not extract document titles anymore
[
https://issues.apache.org/jira/browse/DOXIA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov moved DOXIASITETOOLS-339 to DOXIA-737:
-
Component/s: Core
(was: Site renderer)
Key: DOXIA-737 (was: DOXIASITETOOLS-339)
Affects Version/s: 2.0.0-M11
(was: 2.0.0-M18)
Project: Maven Doxia (was: Maven Doxia Sitetools)
> [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not
> extract document titles anymore
> --
>
> Key: DOXIA-737
> URL: https://issues.apache.org/jira/browse/DOXIA-737
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M11
>Reporter: Michael Osipov
>Priority: Blocker
>
> While working on https://github.com/apache/maven-site/pull/525 the following
> happens:
> Title before:
> {project} -- {document}
> Title now:
> {project}
> The document title is not extracted from the document anymore.
> If I do the following:
> {noformat}
> diff --git
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
>
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> index 544b6b9..b6a7d1d 100644
> ---
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> +++
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
> if (!isConfigured) {
> // DOXIASITETOOLS-146 don't render comments from source
> markup
> parser.setEmitComments(false);
> -parser.setEmitAnchorsForIndexableEntries(true);
> }
> // TODO: DOXIA-111: the filter used here must be checked
> generally.
> {noformat}
> Everything works again. I bet that the {{SiteRendererSink}} does not work
> well with the new approach in Doxia.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (DOXIA-737) [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not extract document titles anymore
[
https://issues.apache.org/jira/browse/DOXIA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned DOXIA-737:
Assignee: Michael Osipov
> [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not
> extract document titles anymore
> --
>
> Key: DOXIA-737
> URL: https://issues.apache.org/jira/browse/DOXIA-737
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M11
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Blocker
>
> While working on https://github.com/apache/maven-site/pull/525 the following
> happens:
> Title before:
> {project} -- {document}
> Title now:
> {project}
> The document title is not extracted from the document anymore.
> If I do the following:
> {noformat}
> diff --git
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
>
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> index 544b6b9..b6a7d1d 100644
> ---
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> +++
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
> if (!isConfigured) {
> // DOXIASITETOOLS-146 don't render comments from source
> markup
> parser.setEmitComments(false);
> -parser.setEmitAnchorsForIndexableEntries(true);
> }
> // TODO: DOXIA-111: the filter used here must be checked
> generally.
> {noformat}
> Everything works again. I bet that the {{SiteRendererSink}} does not work
> well with the new approach in Doxia.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847094#comment-17847094
]
ASF GitHub Bot commented on MINVOKER-351:
-
michael-o commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2116149385
I don't understand this because it looks logically wrong. The model does not
care how it is marshaled, shouldn't the XML writer do this?
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
michael-o commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2116149385 I don't understand this because it looks logically wrong. The model does not care how it is marshaled, shouldn't the XML writer do this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-348) Build job report is truncated
[
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847090#comment-17847090
]
Slawomir Jaranowski commented on MINVOKER-348:
--
In [https://github.com/apache/maven-invoker-plugin/pull/242]
I added {{{}StringEscapeUtils.escapeXml10{}}}:
{code:java}
buildJob.setFailureMessage(StringEscapeUtils.escapeXml10(e.getMessage()));
{code}
I hope this help
> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
>
> result="failure-post-hook" time="42.662"
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
> Assertion failed:
> assert log.text.contains("BUILD SUCCESS")
>| ||
>| |false
>| '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -< io.micronaut.build.examples:test-resources
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test)
> on project micronaut-maven-integration-tests: Failed to read report file:
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
> no more data available - expected end tags to
> close start tag from line 3 and start tag from
> line 2, parser stopped on START_TAG seen ...t part of the build
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MINVOKER-348) Build job report is truncated
[
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MINVOKER-348:
Assignee: Slawomir Jaranowski
> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
>
> result="failure-post-hook" time="42.662"
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
> Assertion failed:
> assert log.text.contains("BUILD SUCCESS")
>| ||
>| |false
>| '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -< io.micronaut.build.examples:test-resources
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test)
> on project micronaut-maven-integration-tests: Failed to read report file:
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
> no more data available - expected end tags to
> close start tag from line 3 and start tag from
> line 2, parser stopped on START_TAG seen ...t part of the build
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINVOKER-348) Build job report is truncated
[
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-348:
-
Fix Version/s: 3.7.0
(was: waiting-for-feedback)
> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
>
> result="failure-post-hook" time="42.662"
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
> Assertion failed:
> assert log.text.contains("BUILD SUCCESS")
>| ||
>| |false
>| '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -< io.micronaut.build.examples:test-resources
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test)
> on project micronaut-maven-integration-tests: Failed to read report file:
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
> no more data available - expected end tags to
> close start tag from line 3 and start tag from
> line 2, parser stopped on START_TAG seen ...t part of the build
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847089#comment-17847089
]
ASF GitHub Bot commented on MINVOKER-351:
-
slawekjaranowski opened a new pull request, #242:
URL: https://github.com/apache/maven-invoker-plugin/pull/242
- use StringEscapeUtils.escapeXml10 form commons-text
https://issues.apache.org/jira/browse/MINVOKER-351
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by
[jira] [Closed] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin
[
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINVOKER-307.
Resolution: Fixed
> invoker should also support the @{ } syntax like the surefire plugin
>
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late'
> resolution of maven properties (not at POM evaluation time but at plugin
> execution time). See
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
> for details.
>
> It would be great if the invoker plugin would support the same syntax for the
> configuration setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin
[
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847088#comment-17847088
]
ASF GitHub Bot commented on MINVOKER-307:
-
slawekjaranowski merged PR #241:
URL: https://github.com/apache/maven-invoker-plugin/pull/241
> invoker should also support the @{ } syntax like the surefire plugin
>
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late'
> resolution of maven properties (not at POM evaluation time but at plugin
> execution time). See
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
> for details.
>
> It would be great if the invoker plugin would support the same syntax for the
> configuration setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MINVOKER-307] Support `@{..}` syntax in mavenOpts [maven-invoker-plugin]
slawekjaranowski merged PR #241: URL: https://github.com/apache/maven-invoker-plugin/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MINVOKER-351:
Assignee: Slawomir Jaranowski
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the
> complement of allowed characters but there may exist more efficient solutions.
> * Consider
[PR] Fix section indents [maven-site]
michael-o opened a new pull request, #528: URL: https://github.com/apache/maven-site/pull/528 Factored out from the other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINDEXER-223) Upgrade slf4j to version 2.0.13
[ https://issues.apache.org/jira/browse/MINDEXER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-223. Resolution: Fixed > Upgrade slf4j to version 2.0.13 > --- > > Key: MINDEXER-223 > URL: https://issues.apache.org/jira/browse/MINDEXER-223 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-222) RR backend in case of GAVCE search should use Last-Modified HTTP header
[ https://issues.apache.org/jira/browse/MINDEXER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-222. Resolution: Fixed > RR backend in case of GAVCE search should use Last-Modified HTTP header > --- > > Key: MINDEXER-222 > URL: https://issues.apache.org/jira/browse/MINDEXER-222 > Project: Maven Indexer > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > > And fill out Record last modified field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINDEXER-222) RR backend in case of GAVCE search should use Last-Modified HTTP header
[ https://issues.apache.org/jira/browse/MINDEXER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847080#comment-17847080 ] ASF GitHub Bot commented on MINDEXER-222: - cstamas merged PR #364: URL: https://github.com/apache/maven-indexer/pull/364 > RR backend in case of GAVCE search should use Last-Modified HTTP header > --- > > Key: MINDEXER-222 > URL: https://issues.apache.org/jira/browse/MINDEXER-222 > Project: Maven Indexer > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > > And fill out Record last modified field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINDEXER-223) Upgrade slf4j to version 2.0.13
[ https://issues.apache.org/jira/browse/MINDEXER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847079#comment-17847079 ] ASF GitHub Bot commented on MINDEXER-223: - cstamas merged PR #365: URL: https://github.com/apache/maven-indexer/pull/365 > Upgrade slf4j to version 2.0.13 > --- > > Key: MINDEXER-223 > URL: https://issues.apache.org/jira/browse/MINDEXER-223 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINDEXER-222] RR backend in case of GAVCE search should reuse LastModified HTTP header [maven-indexer]
cstamas merged PR #364: URL: https://github.com/apache/maven-indexer/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MINDEXER-223] Update SLF4J to 2.0.13 [maven-indexer]
cstamas merged PR #365: URL: https://github.com/apache/maven-indexer/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
[
https://issues.apache.org/jira/browse/MNG-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MNG-8122.
---
Resolution: Not A Bug
> `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output
> dependency trees from all projects
> --
>
> Key: MNG-8122
> URL: https://issues.apache.org/jira/browse/MNG-8122
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Core
>Affects Versions: 4.0.0-alpha-12, 4.0.0-alpha-13
>Reporter: Benjamin Marwell
>Priority: Major
>
> When running this command:
> {code:bash}
> ./mvnw versions:display-dependency-updates -ntp -Prun-its
> -DallowMajorUpdates=true
> -Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
> -pl .
> ─╯
> {code}
> with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
> dependency trees on all projects.
> When switching back to v3.9.6, this does not happen.
> h2. Expected outcome
> Only display updates from root project
> h2. Actual outcome
> ignores? parameter {{-pl .}}
> h2. Versions
> dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
[
https://issues.apache.org/jira/browse/MNG-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847066#comment-17847066
]
Benjamin Marwell commented on MNG-8122:
---
Oh you are right! Karl Heinz actually mentioned `-N` to me the other day. Sorry
for the fuzz...
> `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output
> dependency trees from all projects
> --
>
> Key: MNG-8122
> URL: https://issues.apache.org/jira/browse/MNG-8122
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Core
>Affects Versions: 4.0.0-alpha-12, 4.0.0-alpha-13
>Reporter: Benjamin Marwell
>Priority: Major
>
> When running this command:
> {code:bash}
> ./mvnw versions:display-dependency-updates -ntp -Prun-its
> -DallowMajorUpdates=true
> -Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
> -pl .
> ─╯
> {code}
> with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
> dependency trees on all projects.
> When switching back to v3.9.6, this does not happen.
> h2. Expected outcome
> Only display updates from root project
> h2. Actual outcome
> ignores? parameter {{-pl .}}
> h2. Versions
> dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
[
https://issues.apache.org/jira/browse/MNG-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847051#comment-17847051
]
Slawomir Jaranowski commented on MNG-8122:
--
Can be caused by different in -pl options -
https://maven.apache.org/guides/mini/guide-multiple-modules-4.html
> `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output
> dependency trees from all projects
> --
>
> Key: MNG-8122
> URL: https://issues.apache.org/jira/browse/MNG-8122
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Core
>Affects Versions: 4.0.0-alpha-12, 4.0.0-alpha-13
>Reporter: Benjamin Marwell
>Priority: Major
>
> When running this command:
> {code:bash}
> ./mvnw versions:display-dependency-updates -ntp -Prun-its
> -DallowMajorUpdates=true
> -Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
> -pl .
> ─╯
> {code}
> with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
> dependency trees on all projects.
> When switching back to v3.9.6, this does not happen.
> h2. Expected outcome
> Only display updates from root project
> h2. Actual outcome
> ignores? parameter {{-pl .}}
> h2. Versions
> dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINDEXER-222) RR backend in case of GAVCE search should use Last-Modified HTTP header
[
https://issues.apache.org/jira/browse/MINDEXER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847050#comment-17847050
]
ASF GitHub Bot commented on MINDEXER-222:
-
slawekjaranowski commented on code in PR #364:
URL: https://github.com/apache/maven-indexer/pull/364#discussion_r1603806948
##
search-backend-remoterepository/src/test/java/org/apache/maven/search/backend/remoterepository/internal/RemoteRepositorySearchBackendImplTest.java:
##
@@ -172,6 +173,21 @@ public void gav() throws IOException {
dumpPage(searchResponse);
}
+@Test
+public void gave() throws IOException {
+// LIST GAVCEs
+SearchRequest searchRequest = new SearchRequest(BooleanQuery.and(
+FieldQuery.fieldQuery(MAVEN.GROUP_ID,
"org.apache.maven.plugins"),
+FieldQuery.fieldQuery(MAVEN.ARTIFACT_ID, "maven-clean-plugin"),
+FieldQuery.fieldQuery(MAVEN.VERSION, "3.1.0"),
+FieldQuery.fieldQuery(MAVEN.FILE_EXTENSION, "jar")));
+RemoteRepositorySearchResponse searchResponse =
backend.search(searchRequest);
+assertThat(searchResponse.getTotalHits(), equalTo(1));
+assertNotNull(searchResponse.getPage().get(0).getLastUpdated());
Review Comment:
I would to like a use one framework ...
so hamcrest or Assertions from JUnit in all place in one test class
> RR backend in case of GAVCE search should use Last-Modified HTTP header
> ---
>
> Key: MINDEXER-222
> URL: https://issues.apache.org/jira/browse/MINDEXER-222
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 7.1.3
>
>
> And fill out Record last modified field.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MINDEXER-222] RR backend in case of GAVCE search should reuse LastModified HTTP header [maven-indexer]
slawekjaranowski commented on code in PR #364:
URL: https://github.com/apache/maven-indexer/pull/364#discussion_r1603806948
##
search-backend-remoterepository/src/test/java/org/apache/maven/search/backend/remoterepository/internal/RemoteRepositorySearchBackendImplTest.java:
##
@@ -172,6 +173,21 @@ public void gav() throws IOException {
dumpPage(searchResponse);
}
+@Test
+public void gave() throws IOException {
+// LIST GAVCEs
+SearchRequest searchRequest = new SearchRequest(BooleanQuery.and(
+FieldQuery.fieldQuery(MAVEN.GROUP_ID,
"org.apache.maven.plugins"),
+FieldQuery.fieldQuery(MAVEN.ARTIFACT_ID, "maven-clean-plugin"),
+FieldQuery.fieldQuery(MAVEN.VERSION, "3.1.0"),
+FieldQuery.fieldQuery(MAVEN.FILE_EXTENSION, "jar")));
+RemoteRepositorySearchResponse searchResponse =
backend.search(searchRequest);
+assertThat(searchResponse.getTotalHits(), equalTo(1));
+assertNotNull(searchResponse.getPage().get(0).getLastUpdated());
Review Comment:
I would to like a use one framework ...
so hamcrest or Assertions from JUnit in all place in one test class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MINDEXER-223) Upgrade slf4j to version 2.0.13
[ https://issues.apache.org/jira/browse/MINDEXER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847049#comment-17847049 ] ASF GitHub Bot commented on MINDEXER-223: - slawekjaranowski commented on code in PR #365: URL: https://github.com/apache/maven-indexer/pull/365#discussion_r1603801988 ## pom.xml: ## @@ -111,8 +111,8 @@ under the License. 3.9.6 1.9.20 3.2.1 -3.2.1 -2.0.9 +3.2.5 Review Comment: This should be taken from parent > Upgrade slf4j to version 2.0.13 > --- > > Key: MINDEXER-223 > URL: https://issues.apache.org/jira/browse/MINDEXER-223 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINDEXER-223] Update SLF4J to 2.0.13 [maven-indexer]
slawekjaranowski commented on code in PR #365: URL: https://github.com/apache/maven-indexer/pull/365#discussion_r1603801988 ## pom.xml: ## @@ -111,8 +111,8 @@ under the License. 3.9.6 1.9.20 3.2.1 -3.2.1 -2.0.9 +3.2.5 Review Comment: This should be taken from parent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-indexer]
slawekjaranowski commented on PR #358: URL: https://github.com/apache/maven-indexer/pull/358#issuecomment-2115869592 we need add a `plexus-xml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)
[
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847036#comment-17847036
]
ASF GitHub Bot commented on MNG-8121:
-
michael-o commented on PR #1508:
URL: https://github.com/apache/maven/pull/1508#issuecomment-2115783498
> This is what I proposed in
[bc03b17](https://github.com/apache/maven/commit/bc03b1762f6fab02985145e70bf6edd97102e2dc)
(even together with test cases and this was declined by @michael-o back then
in [#645
(comment)](https://github.com/apache/maven/pull/645#issuecomment-1001510028)).
Can we please add some test cases?
I must admit that I lost track completely...
> NullPointerException at
> org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
>
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-3
>
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of
> a plugin did not have a goalPrefix set.
>
> At least, this is my interpretation of what is going on.
>
> Background
> -
>
> I have an open-source project at
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1]
> with the following coordinates:
>
> com.googlecode.cmake-maven-project
> cmake
>
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced
> to set "" because of
> https://issues.apache.org/jira/browse/MPLUGIN-450 and
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>
> In my particular case, I set "cmake-binaries" inside
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following
> exception stack trace:
>
>
> {noformat}
> java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:99)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:59)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:56)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:399)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:294)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:202)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:393)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:131)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> (AbstractDeployStrategy.java:213)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
> (StagingDeployStrategy.java:125)
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute
> (DeployMojo.java:213)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126){noformat}
>
> I assume that this is caused by {{preExisting.getPrefix()}} returning null,
> but I have no idea why this is happening. Perhaps this is caused by previous
> versions not have a goalPrefix set? Shouldn't the implementation handle this
> possibility?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8121] Fix NPE in metadata merge [maven]
michael-o commented on PR #1508: URL: https://github.com/apache/maven/pull/1508#issuecomment-2115783498 > This is what I proposed in [bc03b17](https://github.com/apache/maven/commit/bc03b1762f6fab02985145e70bf6edd97102e2dc) (even together with test cases and this was declined by @michael-o back then in [#645 (comment)](https://github.com/apache/maven/pull/645#issuecomment-1001510028)). Can we please add some test cases? I must admit that I lost track completely... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8078) BOM POM import warnings are emitted on scopes and exclusions
[
https://issues.apache.org/jira/browse/MNG-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MNG-8078:
---
Summary: BOM POM import warnings are emitted on scopes and exclusions
(was: BOM warnings are emitted on scopes and exclusions)
> BOM POM import warnings are emitted on scopes and exclusions
>
>
> Key: MNG-8078
> URL: https://issues.apache.org/jira/browse/MNG-8078
> Project: Maven
> Issue Type: Bug
> Components: Core, Errors
>Affects Versions: 4.0.0-alpha-13
> Environment: Any
>Reporter: Lenny Primak
>Priority: Minor
>
> There a couple of scenarios that are generating warnings that should not:
> * BOM dependency entries that have a different scope
> * BOM dependency entries that have exclusions
> There are many scenarios where multiple BOMs declare the same dependency
> versions, although in slightly different ways. Many of these are transient,
> and very hard to figure out in the first place. Warnings lead to multiple
> unnecessary exclusions and are forcing modifications to POM where they are
> not needed.
> The above entries should not generate a warning, because the dependencies are
> not conflicting.
> Examples (BOM):
> {code:java}
>
>
> ...
>
> org.junit.jupiter
> junit-jupiter-api
> ${junit.version}
> test
>
>
> org.junit.jupiter
> junit-jupiter-params
> ${junit.version}
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> ${junit.version}
> test
>
> ...
>
>
> {code}
>
> Warnings:
> {code:java}
> [WARNING] Some problems were encountered while building the effective model
> for 'com.flowlogix:hope-website:war:1.x-SNAPSHOT'
> [WARNING] Ignored POM import for: org.slf4j:jcl-over-slf4j:jar:2.0.12@test as
> already imported org.slf4j:jcl-over-slf4j:jar:2.0.12@compile. Add a the
> conflicting managed dependency directly to the dependencyManagement section
> of the POM.
> WARNING] Ignored POM import for:
> net.bytebuddy:byte-buddy:jar:1.14.12@compile[1 exclusions] as already
> imported net.bytebuddy:byte-buddy:jar:1.14.12@compile. Add a the conflicting
> managed dependency directly to the dependencyManagement section of the POM.
> [WARNING] Ignored POM import for:
> net.bytebuddy:byte-buddy-agent:jar:1.14.12@compile[1 exclusions] as already
> imported net.bytebuddy:byte-buddy-agent:jar:1.14.12@compile. Add a the
> conflicting managed dependency directly to the dependencyManagement section
> of the POM.
> [WARNING] Ignored POM import for:
> org.junit.jupiter:junit-jupiter-api:jar:5.10.2@compile[1 exclusions] as
> already imported org.junit.jupiter:junit-jupiter-api:jar:5.10.2@test. Add a
> the conflicting managed dependency directly to the dependencyManagement
> section of the POM.
> [WARNING] Ignored POM import for:
> org.junit.jupiter:junit-jupiter-engine:jar:5.10.2@compile[1 exclusions] as
> already imported org.junit.jupiter:junit-jupiter-engine:jar:5.10.2@test. Add
> a the conflicting managed dependency directly to the dependencyManagement
> section of the POM.
> [WARNING] Ignored POM import for:
> org.junit.jupiter:junit-jupiter-params:jar:5.10.2@compile[1 exclusions] as
> already imported org.junit.jupiter:junit-jupiter-params:jar:5.10.2@test. Add
> a the conflicting managed dependency directly to the dependencyManagement
> section of the POM. {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Add hint about mvnrepository.com [maven-site]
tamaro-skaljic closed pull request #518: Add hint about mvnrepository.com URL: https://github.com/apache/maven-site/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-223) Upgrade slf4j to version 2.0.13
[ https://issues.apache.org/jira/browse/MINDEXER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-223: Assignee: Tamas Cservenak > Upgrade slf4j to version 2.0.13 > --- > > Key: MINDEXER-223 > URL: https://issues.apache.org/jira/browse/MINDEXER-223 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8124) Allow regex usage in any profile activation key/value
Gili created MNG-8124: - Summary: Allow regex usage in any profile activation key/value Key: MNG-8124 URL: https://issues.apache.org/jira/browse/MNG-8124 Project: Maven Issue Type: Improvement Components: Profiles Affects Versions: 3.9.6 Reporter: Gili Following up on https://issues.apache.org/jira/browse/MNG-5726 I'd like to request allowing the use of regex for any key/value pair. For example, one should be able to use regex in property names or values, OS names or values, etc. Justification: Many users have been asking for the ability to logically-OR multiple conditions. Allowing the use of regex will go a long way in resolving those use-cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINDEXER-223) Upgrade slf4j to version 2.0.13
[ https://issues.apache.org/jira/browse/MINDEXER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846997#comment-17846997 ] ASF GitHub Bot commented on MINDEXER-223: - cstamas opened a new pull request, #365: URL: https://github.com/apache/maven-indexer/pull/365 And (build) surefire to 3.2.5 --- https://issues.apache.org/jira/browse/MINDEXER-223 > Upgrade slf4j to version 2.0.13 > --- > > Key: MINDEXER-223 > URL: https://issues.apache.org/jira/browse/MINDEXER-223 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-223) Upgrade slf4j to version 2.0.13
Tamas Cservenak created MINDEXER-223: Summary: Upgrade slf4j to version 2.0.13 Key: MINDEXER-223 URL: https://issues.apache.org/jira/browse/MINDEXER-223 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINDEXER-222) RR backend in case of GAVCE search should use Last-Modified HTTP header
[ https://issues.apache.org/jira/browse/MINDEXER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846993#comment-17846993 ] ASF GitHub Bot commented on MINDEXER-222: - cstamas opened a new pull request, #364: URL: https://github.com/apache/maven-indexer/pull/364 And fill it in Record. --- https://issues.apache.org/jira/browse/MINDEXER-222 > RR backend in case of GAVCE search should use Last-Modified HTTP header > --- > > Key: MINDEXER-222 > URL: https://issues.apache.org/jira/browse/MINDEXER-222 > Project: Maven Indexer > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > > And fill out Record last modified field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-222) RR backend in case of GAVCE search should use Last-Modified HTTP header
[ https://issues.apache.org/jira/browse/MINDEXER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-222: Assignee: Tamas Cservenak > RR backend in case of GAVCE search should use Last-Modified HTTP header > --- > > Key: MINDEXER-222 > URL: https://issues.apache.org/jira/browse/MINDEXER-222 > Project: Maven Indexer > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > > And fill out Record last modified field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINDEXER-206) Search Backend SMO and RR handle different Artifact.extension
[ https://issues.apache.org/jira/browse/MINDEXER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MINDEXER-206: - Fix Version/s: (was: 7.1.3) > Search Backend SMO and RR handle different Artifact.extension > - > > Key: MINDEXER-206 > URL: https://issues.apache.org/jira/browse/MINDEXER-206 > Project: Maven Indexer > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > > The two backends should not force caller to construct Query differently, but > handle their own implementation specifics silently. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-222) RR backend in case of GAVCE search should use Last-Modified HTTP header
Tamas Cservenak created MINDEXER-222: Summary: RR backend in case of GAVCE search should use Last-Modified HTTP header Key: MINDEXER-222 URL: https://issues.apache.org/jira/browse/MINDEXER-222 Project: Maven Indexer Issue Type: Improvement Reporter: Tamas Cservenak Fix For: 7.1.3 And fill out Record last modified field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846986#comment-17846986
]
ASF GitHub Bot commented on MDEP-799:
-
elharo commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1603507976
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -127,6 +127,24 @@ public void _testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void _testTreeJsonSerialzing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"testGroupId\": \"project\""));
Review Comment:
That makes sense.
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1603507976
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -127,6 +127,24 @@ public void _testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void _testTreeJsonSerialzing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"testGroupId\": \"project\""));
Review Comment:
That makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846973#comment-17846973
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1603482791
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -127,6 +127,24 @@ public void _testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void _testTreeJsonSerialzing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"testGroupId\": \"project\""));
Review Comment:
I want to double check: do you mean `contents.contains("...")`?
Due to indentation the string might not be in the list of strings, but a
substring of an element, which the `findString`-method seems to be created for
in the same file.
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846974#comment-17846974 ] ASF GitHub Bot commented on MDEP-799: - LogFlames commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-2115406368 Hi, I'm working on getting this merged and incorporating the requested changes. Unfortunately I don't have access to Martin's fork and will need to create a new PR. Will build on Martin's branch and try to update all changes beforehand to make the transition as smooth as possible. > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Priority: Major > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-2115406368 Hi, I'm working on getting this merged and incorporating the requested changes. Unfortunately I don't have access to Martin's fork and will need to create a new PR. Will build on Martin's branch and try to update all changes beforehand to make the transition as smooth as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1603482791
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -127,6 +127,24 @@ public void _testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void _testTreeJsonSerialzing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"testGroupId\": \"project\""));
Review Comment:
I want to double check: do you mean `contents.contains("...")`?
Due to indentation the string might not be in the list of strings, but a
substring of an element, which the `findString`-method seems to be created for
in the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-8123) Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
[
https://issues.apache.org/jira/browse/MNG-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Filipe Roque updated MNG-8123:
--
Description:
{code:java}
❯ mvn --version
Apache Maven 4.0.0-beta-2 (828faba81940a8d2f2e5cfab6f60e35d1ab61ca0)
Maven home: /opt/maven/apache-maven-4.0.0-beta-2
Java version: 22.0.1, vendor: Eclipse Adoptium, runtime:
/usr/lib/jvm/temurin-22-jdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-28-generic", arch: "amd64", family: "unix"
{code}
project created with
{code:java}
mvn archetype:generate {code}
Adding maven cache extension
{code:java}
cat .mvn/extensions.xml
http://maven.apache.org/EXTENSIONS/1.0.0;>
org.apache.maven.extensions
maven-build-cache-extension
1.2.0
{code}
Fails with:
{code:java}
❯ mvn compile [INFO] Cache configuration is not available at configured path
/home/froque/workspace/testes/project1/.mvn/maven-build-cache-config.xml, cache
is enabled with defaults [INFO] Using XX hash algorithm for cache [ERROR]
Internal error: com.google.inject.ProvisionException: Unable to provision, see
the following errors: [ERROR] [ERROR] 1) [Guice/NullInjectedIntoNonNullable]:
null returned by binding at LocatorWiring [ERROR] but the 3rd parameter of
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
[ERROR] at LocatorWiring [ERROR] at
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) [ERROR] \_
for 3rd parameter [ERROR] at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed by:
WireModule -> PlexusBindingModule [ERROR] at
CacheControllerImpl.(CacheControllerImpl.java:156) [ERROR] \_ for
10th parameter [ERROR] at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed by:
WireModule -> PlexusBindingModule [ERROR] while locating CacheControllerImpl
[ERROR] while locating Object annotated with * [ERROR] at LocatorWiring
[ERROR] at
CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) [ERROR]
\_ for 2nd parameter [ERROR] at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed by:
WireModule -> PlexusBindingModule [ERROR] while locating
CacheLifecycleParticipant [ERROR] while locating Object annotated with *
[ERROR] [ERROR] Learn more: [ERROR]
https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE [ERROR]
[ERROR] 1 error [ERROR] [ERROR] == [ERROR] Full classname
legend: [ERROR] == [ERROR] CacheControllerImpl:
"org.apache.maven.buildcache.CacheControllerImpl" [ERROR]
CacheLifecycleParticipant:
"org.apache.maven.buildcache.CacheLifecycleParticipant" [ERROR]
LifecyclePhasesHelper: "org.apache.maven.buildcache.LifecyclePhasesHelper"
[ERROR] LocatorWiring: "org.eclipse.sisu.wire.LocatorWiring"
[ERROR] PlexusBindingModule:
"org.eclipse.sisu.plexus.PlexusBindingModule" [ERROR] WireModule:
"org.eclipse.sisu.wire.WireModule" [ERROR] [ERROR]
End of classname legend: [ERROR] [ERROR] -> [Help 1]
org.apache.maven.InternalErrorException: Internal error:
com.google.inject.ProvisionException: Unable to provision, see the following
errors:1) [Guice/NullInjectedIntoNonNullable]: null returned by binding at
LocatorWiring but the 3rd parameter of
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
at LocatorWiring at
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) \_ for 3rd
parameter at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
WireModule -> PlexusBindingModule at
CacheControllerImpl.(CacheControllerImpl.java:156) \_ for 10th
parameter at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
WireModule -> PlexusBindingModule while locating CacheControllerImpl while
locating Object annotated with * at LocatorWiring at
CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) \_
for 2nd parameter at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
WireModule -> PlexusBindingModule while locating CacheLifecycleParticipant
while locating Object annotated with *Learn more:
https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE1
[jira] [Created] (MNG-8123) Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
Filipe Roque created MNG-8123:
-
Summary: Maven 4.0.0-beta-2 fails with maven-build-cache-extension
1.2.0
Key: MNG-8123
URL: https://issues.apache.org/jira/browse/MNG-8123
Project: Maven
Issue Type: Bug
Reporter: Filipe Roque
{code:java}
❯ mvn --version
Apache Maven 4.0.0-beta-2 (828faba81940a8d2f2e5cfab6f60e35d1ab61ca0)
Maven home: /opt/maven/apache-maven-4.0.0-beta-2
Java version: 22.0.1, vendor: Eclipse Adoptium, runtime:
/usr/lib/jvm/temurin-22-jdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-28-generic", arch: "amd64", family: "unix"
{code}
project created with
{code:java}
mvn archetype:generate {code}
Adding maven cache extension
{code:java}
cat .mvn/extensions.xml
http://maven.apache.org/EXTENSIONS/1.0.0;>
org.apache.maven.extensions
maven-build-cache-extension
1.2.0
{code}
Fails with:
{code:java}
❯ mvn compile [INFO] Cache configuration is not available at configured path
/home/froque/workspace/testes/project1/.mvn/maven-build-cache-config.xml, cache
is enabled with defaults [INFO] Using XX hash algorithm for cache [ERROR]
Internal error: com.google.inject.ProvisionException: Unable to provision, see
the following errors: [ERROR] [ERROR] 1) [Guice/NullInjectedIntoNonNullable]:
null returned by binding at LocatorWiring [ERROR] but the 3rd parameter of
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
[ERROR] at LocatorWiring [ERROR] at
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) [ERROR] \_
for 3rd parameter [ERROR] at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed by:
WireModule -> PlexusBindingModule [ERROR] at
CacheControllerImpl.(CacheControllerImpl.java:156) [ERROR] \_ for
10th parameter [ERROR] at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed by:
WireModule -> PlexusBindingModule [ERROR] while locating CacheControllerImpl
[ERROR] while locating Object annotated with * [ERROR] at LocatorWiring
[ERROR] at
CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) [ERROR]
\_ for 2nd parameter [ERROR] at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed by:
WireModule -> PlexusBindingModule [ERROR] while locating
CacheLifecycleParticipant [ERROR] while locating Object annotated with *
[ERROR] [ERROR] Learn more: [ERROR]
https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE [ERROR]
[ERROR] 1 error [ERROR] [ERROR] == [ERROR] Full classname
legend: [ERROR] == [ERROR] CacheControllerImpl:
"org.apache.maven.buildcache.CacheControllerImpl" [ERROR]
CacheLifecycleParticipant:
"org.apache.maven.buildcache.CacheLifecycleParticipant" [ERROR]
LifecyclePhasesHelper: "org.apache.maven.buildcache.LifecyclePhasesHelper"
[ERROR] LocatorWiring: "org.eclipse.sisu.wire.LocatorWiring"
[ERROR] PlexusBindingModule:
"org.eclipse.sisu.plexus.PlexusBindingModule" [ERROR] WireModule:
"org.eclipse.sisu.wire.WireModule" [ERROR] [ERROR]
End of classname legend: [ERROR] [ERROR] -> [Help 1]
org.apache.maven.InternalErrorException: Internal error:
com.google.inject.ProvisionException: Unable to provision, see the following
errors:1) [Guice/NullInjectedIntoNonNullable]: null returned by binding at
LocatorWiring but the 3rd parameter of
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
at LocatorWiring at
LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) \_ for 3rd
parameter at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
WireModule -> PlexusBindingModule at
CacheControllerImpl.(CacheControllerImpl.java:156) \_ for 10th
parameter at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
WireModule -> PlexusBindingModule while locating CacheControllerImpl while
locating Object annotated with * at LocatorWiring at
CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) \_
for 2nd parameter at
ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
WireModule -> PlexusBindingModule while locating CacheLifecycleParticipant
Re: [PR] Bump com.google.guava:guava from 33.1.0-jre to 33.2.0-jre [maven-indexer]
cstamas merged PR #363: URL: https://github.com/apache/maven-indexer/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null
[
https://issues.apache.org/jira/browse/MJAVADOC-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MJAVADOC-793:
-
Fix Version/s: 3.6.4
> java.lang.NullPointerException: Cannot invoke "String.length()" because
> "text" is null
> --
>
> Key: MJAVADOC-793
> URL: https://issues.apache.org/jira/browse/MJAVADOC-793
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Gary D. Gregory
>Priority: Blocker
> Fix For: 3.6.4
>
>
> Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
> See:
> * Failing PR: https://github.com/apache/commons-compress/pull/528
> * Build log:
> [https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
> Or:
> # git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
> # git checkout 542cc5a602a9128932e3fb75503383e481141e7e
> # Edit pom.xml and set the parent POM to version 70
> # Run 'mvn javadoc:javadoc' causes:
> {noformat}
> [INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 8.434 s
> [INFO] Finished at: 2024-05-16T09:36:02-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
> project commons-compress: Execution default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc
> (default-cli) on project commons-compress: Execution default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null
> at
[jira] [Updated] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null
[
https://issues.apache.org/jira/browse/MJAVADOC-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated MJAVADOC-793:
-
Description:
Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
See:
* Failing PR: https://github.com/apache/commons-compress/pull/528
* Build log:
[https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
Or:
# git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
# git checkout 542cc5a602a9128932e3fb75503383e481141e7e
# Edit pom.xml and set the parent POM to version 70
# Run 'mvn javadoc:javadoc' causes:
{noformat}
[INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 8.434 s
[INFO] Finished at: 2024-05-16T09:36:02-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
project commons-compress: Execution default-cli of goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
invoke "String.length()" because "text" is null -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
project commons-compress: Execution default-cli of goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
invoke "String.length()" because "text" is null
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:333)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:77)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:568)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:283)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:226)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:407)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:348)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc
failed: Cannot invoke "String.length()" because "text" is null
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:133)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
[jira] [Created] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null
Gary D. Gregory created MJAVADOC-793:
Summary: java.lang.NullPointerException: Cannot invoke
"String.length()" because "text" is null
Key: MJAVADOC-793
URL: https://issues.apache.org/jira/browse/MJAVADOC-793
Project: Maven Javadoc Plugin
Issue Type: Bug
Affects Versions: 3.6.3
Reporter: Gary D. Gregory
Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
See:
* Failing PR: https://github.com/apache/commons-compress/pull/528
* Build log:
[https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
Or:
# git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
# git checkout 542cc5a602a9128932e3fb75503383e481141e7e
# Edit pom.xml and set the parent POM to version 70
# Run 'mvn javadoc:javadoc' causes:
{noformat}
[INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 8.434 s
[INFO] Finished at: 2024-05-16T09:36:02-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
project commons-compress: Execution default-cli of goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
invoke "String.length()" because "text" is null -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
project commons-compress: Execution default-cli of goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
invoke "String.length()" because "text" is null
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:333)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:77)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:568)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:283)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:226)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:407)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:348)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc
failed: Cannot invoke "String.length()" because "text" is null
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:133)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at
Re: [PR] Bump org.apache.maven.doxia:doxia-tools from 41 to 42 [maven-doxia-converter]
slachiewicz merged PR #68: URL: https://github.com/apache/maven-doxia-converter/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] If Maven Daemon executes in 0.2s, the summary output might be printed too early [maven-mvnd]
bmarwell commented on issue #995: URL: https://github.com/apache/maven-mvnd/issues/995#issuecomment-2115183023 I could not reproduce it anymore, even though it ran in 1.8s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix message when building because of a clean state [maven-compiler-plugin]
gnodet opened a new pull request, #242: URL: https://github.com/apache/maven-compiler-plugin/pull/242 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] If Maven Daemon executes in 0.2s, the summary output might be printed too early [maven-mvnd]
bmarwell opened a new issue, #995: URL: https://github.com/apache/maven-mvnd/issues/995 Hi, at a demo at JCON, our build ran in 0.2s (using the cache extension). The Summary output at the end was not the last to be printed; mvnd was not done printing other entries from the buffer yet, so I had to scroll up for the project summary. This does usually not happen, because usually it takes 0.6 seconds to complete. So, there is a timing issue. Maven Daemon should wait at least until the buffer has been emptied to the console. Will try to grab a screenshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
Benjamin Marwell created MNG-8122:
-
Summary: `versions:display-dependency-updates -pl .` on Maven 4
alpha-13 will output dependency trees from all projects
Key: MNG-8122
URL: https://issues.apache.org/jira/browse/MNG-8122
Project: Maven
Issue Type: Bug
Components: Command Line, Core
Affects Versions: 4.0.0-alpha-13, 4.0.0-alpha-12
Reporter: Benjamin Marwell
When running this command:
{code:bash}
./mvnw versions:display-dependency-updates -ntp -Prun-its
-DallowMajorUpdates=true
-Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
-pl .
─╯
{code}
with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
dependency trees on all projects.
When switching back to v3.9.6, this does not happen.
h2. Expected outcome
Only display updates from root project
h2. Actual outcome
ignores? parameter {{-pl .}}
h2. Versions
dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Fix packaging not found [maven]
wendigo commented on PR #1507: URL: https://github.com/apache/maven/pull/1507#issuecomment-2114703095 Locally it works flawlessly :) Thanks @gnodet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MJAVADOC-792) Generating Javadoc using does not work if the project URL contains the # character
Roman Huber created MJAVADOC-792: Summary: Generating Javadoc using does not work if the project URL contains the # character Key: MJAVADOC-792 URL: https://issues.apache.org/jira/browse/MJAVADOC-792 Project: Maven Javadoc Plugin Issue Type: Bug Components: jar, javadoc Affects Versions: 3.6.3 Reporter: Roman Huber See this issue for a full description: [https://github.com/assertj/assertj/issues/3476] Maybe the project URL isn't the best choice there, but the Maven Javadoc plugin still shouldn't fail the build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Fix packaging not found [maven]
wendigo commented on PR #1507: URL: https://github.com/apache/maven/pull/1507#issuecomment-2114577125 I couldn't test it through the wrapper: ``` grep distributionUrl .mvn/wrapper/maven-wrapper.properties distributionUrl=https://repository.apache.org/content/repositories/snapshots/org/apache/maven/apache-maven/4.0.0-beta-3-SNAPSHOT/apache-maven-4.0.0-beta-3-20240515.173255-2-bin.zip ./mvnw: line 246: /var/folders/n4/vl45d5rn5n1_yk_pl5xkpd38gn/T/tmp.CNmLdxlcJH/apache-maven-4.0.0-beta-3-20240515.173255-2/mvnw.url: No such file or directory ``` I'm testing it locally now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix packaging not found [maven]
gnodet merged PR #1507: URL: https://github.com/apache/maven/pull/1507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MBUILDCACHE-78) Maven reactor doesn't work well for a multimodule project when enabling build cache
[ https://issues.apache.org/jira/browse/MBUILDCACHE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongxin Liang updated MBUILDCACHE-78: - Description: In a multimodule project, as a simplest example: [https://github.com/honnix/cache|https://github.com/honnix/cache] , "mvn compile" with build cache enabled doesn't play well with Maven reactor. A few scenarios I have tested in the provided repro example: # With a clean environment (no build cache, no "mvn install" have been done) ## Run "mvn compile" and everything works ## Modify (putting a random empty line will suffice) class "B" in module "b" ## Run "mvn compile" again, and now it fails when trying to download snapshot of module "a" from maven central (after failing to find that in my local repo) # With a clean environment (no build cache) ## Run "mvn install" and everything works ## Modify class "A" in module "a" to rename the method ## Run "mvn compile" for the first time, and it fails to compile due to renaming of the method in class "A" ## Run "mvn compile" for the second time, nothing fails but apparent the code is still wrong; run more "mvn compile" and still nothing fails ## Running "mvn install" fails the build due to compilation error I'm not entirely sure I am doing things properly and I'm not sure whether the config is correct either (I took the example as [https://maven.apache.org/extensions/maven-build-cache-extension/maven-build-cache-config.xml] with modification to disable remote cache). was: In a multimodule project, as a simplest example: [https://github.com/honnix/cache|https://github.com/honnix/cache),] , "mvn compile" with build cache enabled doesn't play well with Maven reactor. A few scenarios I have tested in the provided repro example: # With a clean environment (no build cache, no "mvn install" have been done) ## Run "mvn compile" and everything works ## Modify (putting a random empty line will suffice) class "B" in module "b" ## Run "mvn compile" again, and now it fails when trying to download snapshot of module "a" from maven central (after failing to find that in my local repo) # With a clean environment (no build cache) ## Run "mvn install" and everything works ## Modify class "A" in module "a" to rename the method ## Run "mvn compile" for the first time, and it fails to compile due to renaming of the method in class "A" ## Run "mvn compile" for the second time, nothing fails but apparent the code is still wrong; run more "mvn compile" and still nothing fails ## Running "mvn install" fails the build due to compilation error I'm not entirely sure I am doing things properly and I'm not sure whether the config is correct either (I took the example as [https://maven.apache.org/extensions/maven-build-cache-extension/maven-build-cache-config.xml] with modification to disable remote cache). > Maven reactor doesn't work well for a multimodule project when enabling build > cache > --- > > Key: MBUILDCACHE-78 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-78 > Project: Maven Build Cache Extension > Issue Type: Bug >Affects Versions: 1.1.0 > Environment: macOS Sonama, Java 17, Maven 3.9.6 >Reporter: Hongxin Liang >Priority: Critical > > In a multimodule project, as a simplest example: > [https://github.com/honnix/cache|https://github.com/honnix/cache] , "mvn > compile" with build cache enabled doesn't play well with Maven reactor. A few > scenarios I have tested in the provided repro example: > # With a clean environment (no build cache, no "mvn install" have been done) > ## Run "mvn compile" and everything works > ## Modify (putting a random empty line will suffice) class "B" in module "b" > ## Run "mvn compile" again, and now it fails when trying to download > snapshot of module "a" from maven central (after failing to find that in my > local repo) > # With a clean environment (no build cache) > ## Run "mvn install" and everything works > ## Modify class "A" in module "a" to rename the method > ## Run "mvn compile" for the first time, and it fails to compile due to > renaming of the method in class "A" > ## Run "mvn compile" for the second time, nothing fails but apparent the > code is still wrong; run more "mvn compile" and still nothing fails > ## Running "mvn install" fails the build due to compilation error > I'm not entirely sure I am doing things properly and I'm not sure whether the > config is correct either (I took the example as > [https://maven.apache.org/extensions/maven-build-cache-extension/maven-build-cache-config.xml] > with modification to disable remote cache). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-78) Maven reactor doesn't work well for a multimodule project when enabling build cache
[ https://issues.apache.org/jira/browse/MBUILDCACHE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongxin Liang updated MBUILDCACHE-78: - Description: In a multimodule project, as a simplest example: [https://github.com/honnix/cache|https://github.com/honnix/cache),] , "mvn compile" with build cache enabled doesn't play well with Maven reactor. A few scenarios I have tested in the provided repro example: # With a clean environment (no build cache, no "mvn install" have been done) ## Run "mvn compile" and everything works ## Modify (putting a random empty line will suffice) class "B" in module "b" ## Run "mvn compile" again, and now it fails when trying to download snapshot of module "a" from maven central (after failing to find that in my local repo) # With a clean environment (no build cache) ## Run "mvn install" and everything works ## Modify class "A" in module "a" to rename the method ## Run "mvn compile" for the first time, and it fails to compile due to renaming of the method in class "A" ## Run "mvn compile" for the second time, nothing fails but apparent the code is still wrong; run more "mvn compile" and still nothing fails ## Running "mvn install" fails the build due to compilation error I'm not entirely sure I am doing things properly and I'm not sure whether the config is correct either (I took the example as [https://maven.apache.org/extensions/maven-build-cache-extension/maven-build-cache-config.xml] with modification to disable remote cache). was: In a multimodule project, as a simplest example: [https://github.com/honnix/cache|https://github.com/honnix/cache),],"mvn compile" with build cache enabled doesn't play well with Maven reactor. A few scenarios I have tested in the provided repro example: # With a clean environment (no build cache, no "mvn install" have been done) ## Run "mvn compile" and everything works ## Modify (putting a random empty line will suffice) class "B" in module "b" ## Run "mvn compile" again, and now it fails when trying to download snapshot of module "a" from maven central (after failing to find that in my local repo) # With a clean environment (no build cache) ## Run "mvn install" and everything works ## Modify class "A" in module "a" to rename the method ## Run "mvn compile" for the first time, and it fails to compile due to renaming of the method in class "A" ## Run "mvn compile" for the second time, nothing fails but apparent the code is still wrong; run more "mvn compile" and still nothing fails ## Running "mvn install" fails the build due to compilation error I'm not entirely sure I am doing things properly and I'm not sure whether the config is correct either (I took the example as [https://maven.apache.org/extensions/maven-build-cache-extension/maven-build-cache-config.xml] with modification to disable remote cache). > Maven reactor doesn't work well for a multimodule project when enabling build > cache > --- > > Key: MBUILDCACHE-78 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-78 > Project: Maven Build Cache Extension > Issue Type: Bug >Affects Versions: 1.1.0 > Environment: macOS Sonama, Java 17, Maven 3.9.6 >Reporter: Hongxin Liang >Priority: Critical > > In a multimodule project, as a simplest example: > [https://github.com/honnix/cache|https://github.com/honnix/cache),] , "mvn > compile" with build cache enabled doesn't play well with Maven reactor. A few > scenarios I have tested in the provided repro example: > # With a clean environment (no build cache, no "mvn install" have been done) > ## Run "mvn compile" and everything works > ## Modify (putting a random empty line will suffice) class "B" in module "b" > ## Run "mvn compile" again, and now it fails when trying to download > snapshot of module "a" from maven central (after failing to find that in my > local repo) > # With a clean environment (no build cache) > ## Run "mvn install" and everything works > ## Modify class "A" in module "a" to rename the method > ## Run "mvn compile" for the first time, and it fails to compile due to > renaming of the method in class "A" > ## Run "mvn compile" for the second time, nothing fails but apparent the > code is still wrong; run more "mvn compile" and still nothing fails > ## Running "mvn install" fails the build due to compilation error > I'm not entirely sure I am doing things properly and I'm not sure whether the > config is correct either (I took the example as > [https://maven.apache.org/extensions/maven-build-cache-extension/maven-build-cache-config.xml] > with modification to disable remote cache). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Fix packaging not found [maven]
wendigo commented on PR #1507: URL: https://github.com/apache/maven/pull/1507#issuecomment-2114289417 @gnodet I can test with a snapshot - please share a link to the build (zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix packaging not found [maven]
gnodet commented on PR #1507: URL: https://github.com/apache/maven/pull/1507#issuecomment-2114111999 @cstamas @wendigo this will hopefully fix the problem in beta-2 for trino. I'd like to merge it and have https://github.com/trinodb/trino/pull/21966 point to the snapshot repository... ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
