[jira] [Commented] (MRELEASE-1144) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MRELEASE-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853451#comment-17853451 ] ASF GitHub Bot commented on MRELEASE-1144: -- michael-o commented on PR #216: URL: https://github.com/apache/maven-release/pull/216#issuecomment-2156250872 Resolution problem is gone, but still for some reason junit is added as a test dep to subproject2 which does not make sense... > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MRELEASE-1144 > URL: https://issues.apache.org/jira/browse/MRELEASE-1144 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853450#comment-17853450
]
Jim Hughes commented on MNG-8148:
-
Hi [~Sergey Nuyanzin], I think this is a duplicate of
https://issues.apache.org/jira/browse/MRESOLVER-164 and/or
https://issues.apache.org/jira/browse/MNG-7049
Separately, [~xiangli1996] had a possible idea here back in 2021 (on
MRESOLVER-164):
https://github.com/confluentinc/maven/commit/f81c48db1cfbf99bbe9bf1d04cd3ad762fbd508c#diff-d905c76518b903b34f0a537c[…]7e21c004a09475a2ebd4b4328aR135
I tried to move things along; I think we'd need to write a nice IT case to
resolve this issue.
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> {noformat}
> and
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
> at
&
[jira] [Commented] (MRELEASE-1144) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MRELEASE-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853448#comment-17853448 ] ASF GitHub Bot commented on MRELEASE-1144: -- michael-o commented on PR #216: URL: https://github.com/apache/maven-release/pull/216#issuecomment-2156224489 I think I have found it, stay put... > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MRELEASE-1144 > URL: https://issues.apache.org/jira/browse/MRELEASE-1144 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1144) Upgrade to Parent 42 and Maven 3.6.3
[
https://issues.apache.org/jira/browse/MRELEASE-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853447#comment-17853447
]
ASF GitHub Bot commented on MRELEASE-1144:
--
michael-o commented on PR #216:
URL: https://github.com/apache/maven-release/pull/216#issuecomment-2156217725
@cstamas Can you help and have a look at the failure? subproject2 depends on
subproject1 (in compile scope) which has junit in test scope, but some some
reason that is dragged into subproject1 as test as well.
The code which builds is:
```
protected List createReactorProjects(String sourcePath,
String targetPath, String executionRoot)
throws Exception {
final Path testCaseRootFrom =
Paths.get(getBasedir(),
"src/test/resources").resolve(Paths.get("projects", sourcePath));
final Path testCaseRootTo = getWorkingDirectory(targetPath);
// Recopy the test resources since they are modified in some tests
Files.walkFileTree(testCaseRootFrom, new SimpleFileVisitor() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes
attrs) throws IOException {
Path relPath = testCaseRootFrom.relativize(file);
if (!relPath.toFile().getName().startsWith("expected-")) {
Files.createDirectories(testCaseRootTo.resolve(relPath).getParent());
Files.copy(file, testCaseRootTo.resolve(relPath),
StandardCopyOption.REPLACE_EXISTING);
}
return FileVisitResult.CONTINUE;
}
});
Path projectFile;
if (executionRoot == null) {
projectFile = testCaseRootTo.resolve("pom.xml");
} else {
projectFile = testCaseRootTo.resolve(Paths.get(executionRoot,
"pom.xml"));
}
List repos = Collections.singletonList(
new DefaultArtifactRepository("central",
getRemoteRepositoryURL(), new DefaultRepositoryLayout()));
Repository repository = new Repository();
repository.setId("central");
repository.setUrl(getRemoteRepositoryURL());
Profile profile = new Profile();
profile.setId("profile");
profile.addRepository(repository);
ProjectBuildingRequest buildingRequest = new
DefaultProjectBuildingRequest();
buildingRequest.setLocalRepository(localRepository);
buildingRequest.setRemoteRepositories(repos);
buildingRequest.setPluginArtifactRepositories(repos);
buildingRequest.setRepositoryMerging(RepositoryMerging.REQUEST_DOMINANT);
DefaultRepositorySystemSession repositorySession = new
DefaultRepositorySystemSession();
repositorySession.setLocalRepositoryManager(new
SimpleLocalRepositoryManagerFactory()
.newInstance(repositorySession, new
LocalRepository(localRepository.getBasedir(;
buildingRequest.setRepositorySession(repositorySession);
buildingRequest.addProfile(profile);
buildingRequest.setActiveProfileIds(Collections.singletonList(profile.getId()));
buildingRequest.setResolveDependencies(true);
List buildingResults =
projectBuilder.build(Collections.singletonList(projectFile.toFile()), true,
buildingRequest);
List reactorProjects = new ArrayList<>();
for (ProjectBuildingResult buildingResult : buildingResults) {
reactorProjects.add(buildingResult.getProject());
}
WorkspaceReader simpleReactorReader = new
SimpleReactorWorkspaceReader(reactorProjects);
repositorySession.setWorkspaceReader(simpleReactorReader);
ProjectSorter sorter = new ProjectSorter(reactorProjects);
reactorProjects = sorter.getSortedProjects();
List resolvedProjects = new
ArrayList<>(reactorProjects.size());
for (MavenProject project : reactorProjects) {
MavenProject resolvedProject =
projectBuilder.build(project.getFile(),
buildingRequest).getProject();
// from LifecycleDependencyResolver
if (resolvedProject.getDependencyArtifacts() == null) {
try {
resolvedProject.setDependencyArtifacts(
resolvedProject.createArtifacts(artifactFactory,
null, null));
} catch (InvalidDependencyVersionException e) {
throw new LifecycleExecutionException(e);
}
}
// TODO understand why this is working ... :-)
[jira] [Created] (MRELEASE-1144) Upgrade to Parent 42 and Maven 3.6.3
Michael Osipov created MRELEASE-1144: Summary: Upgrade to Parent 42 and Maven 3.6.3 Key: MRELEASE-1144 URL: https://issues.apache.org/jira/browse/MRELEASE-1144 Project: Maven Release Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1144) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MRELEASE-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853437#comment-17853437 ] ASF GitHub Bot commented on MRELEASE-1144: -- michael-o opened a new pull request, #216: URL: https://github.com/apache/maven-release/pull/216 This closes #216 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRELEASE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MRELEASE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MRELEASE-1144 > URL: https://issues.apache.org/jira/browse/MRELEASE-1144 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853434#comment-17853434 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1569: URL: https://github.com/apache/maven/pull/1569#issuecomment-2156184540 @gnodet also, re caching, I think you are wrong (so resolver does _loads+builds_ same model for same GAV asked for different GACEVs) > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853433#comment-17853433 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1569: URL: https://github.com/apache/maven/pull/1569#issuecomment-2156182987 @gnodet pls take a peek: * 1st commit: "clean" port of 3.9.x change * 2nd commit: could not find any better place for this check, if you have better ideas, I am all ears > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853431#comment-17853431 ] ASF GitHub Bot commented on MNG-8141: - michael-o commented on PR #1569: URL: https://github.com/apache/maven/pull/1569#issuecomment-2156178481 lose, not loose > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853430#comment-17853430 ] ASF GitHub Bot commented on MNG-8141: - cstamas opened a new pull request, #1569: URL: https://github.com/apache/maven/pull/1569 And ArtifactDescriptorReader should not "toss away" but report WARNings (as in case of ERROR or FATAL MB throws). Part 1: port ArtifactDescriptorReader to not loose WARNs --- https://issues.apache.org/jira/browse/MNG-8141 > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-941) Deprecate dependency:sources in favor of dependency:resolve-sources
[
https://issues.apache.org/jira/browse/MDEP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853429#comment-17853429
]
ASF GitHub Bot commented on MDEP-941:
-
michael-o commented on code in PR #411:
URL:
https://github.com/apache/maven-dependency-plugin/pull/411#discussion_r1632106746
##
src/main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.resolvers;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.ResolutionScope;
+
+/**
+ * Goal that resolves the project source dependencies from the repository.
+ *
+ * @author mailto:bri...@apache.org;>Brian Fox
+ * @since 2.0-alpha2
+ * @deprecated in favor of {@code resolve-sources} mojo
+ */
+@Mojo(
+name = "sources",
+defaultPhase = LifecyclePhase.GENERATE_SOURCES,
+requiresDependencyResolution = ResolutionScope.TEST,
+threadSafe = true)
+@Deprecated
+public class OldResolveDependencySourcesMojo extends
ResolveDependencySourcesMojo {
+
+@Override
+protected void doExecute() throws MojoExecutionException {
+getLog().warn(
+"The goal 'dependency:sources' is deprecated for
removal in a future version of this plugin, please use
'dependency:resolve-sources' instead");
+super.doExecute();
+}
Review Comment:
Good catch. I will remove the log message.
> Deprecate dependency:sources in favor of dependency:resolve-sources
> ---
>
> Key: MDEP-941
> URL: https://issues.apache.org/jira/browse/MDEP-941
> Project: Maven Dependency Plugin
> Issue Type: Task
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> Unfortunately, the goal name does not really depict what the goal is doing,
> it fact it causes confusion as in MDEP-895. The name should clearly say that
> it *resolves* sources and does not collect (semantics is imporant). The new
> goal {{resolve-sources}} is functionally equivalent, but is just more
> expressive.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853428#comment-17853428 ] ASF GitHub Bot commented on MDEP-940: - michael-o commented on PR #410: URL: https://github.com/apache/maven-dependency-plugin/pull/410#issuecomment-2156174878 > > > > MAT is still on the CP, no? > > > > > > > > > Yes it is ... I do it step by step > > > > > > Alright, let's convert to a draft. > > Why draft ... we can merge step by step with small changes. I assumed that you wanted to work on a complete PR. If you think that PRs are seftcontained, that is fine. You decide. > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-838) "Artifact has not been packaged yet" error message is not very helpful
[ https://issues.apache.org/jira/browse/MDEP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853427#comment-17853427 ] ASF GitHub Bot commented on MDEP-838: - michael-o opened a new pull request, #412: URL: https://github.com/apache/maven-dependency-plugin/pull/412 …very helpful This closes #412 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > "Artifact has not been packaged yet" error message is not very helpful > -- > > Key: MDEP-838 > URL: https://issues.apache.org/jira/browse/MDEP-838 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Assignee: Michael Osipov >Priority: Major > Fix For: 3.7.0 > > > Today in a build i get the error > > Artifact has not been packaged yet. When used on reactor artifact, copy > > should be executed after packaging: see MDEP-187 > So I know something is wrong but ... > The error message should at best include > # The "not packed artifact" > # The possible location / reactor project > # Probably *why* it is not considered as packed (e.g does it has no artifact > file? Is it a directory? Something else?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853425#comment-17853425 ] Tamas Cservenak commented on MNG-8141: -- Fixed in 3.9.8, needs changes in master > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8131) Property replacement in dependency pom no longer works
[
https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8131.
Resolution: Fixed
Fixed by MNG-8147
> Property replacement in dependency pom no longer works
> --
>
> Key: MNG-8131
> URL: https://issues.apache.org/jira/browse/MNG-8131
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.7
> Environment: macOS 14.5 (23F79)
>Reporter: Taylor Smock
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.8
>
>
> h1. The problem:{{{}{}}}
> Classifiers in dependency poms are no longer replaced (either due to
> performing profile activation of a parent pom of the dependency, or not
> performing replacement of a property).{{{}{}}}
> Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
> # {{m{{{}vn archetype:generate
> -DarchetypeGroupId=org.openjfx
> -DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3
> -DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0
> -Djavafx-version=22.0.1{}
> # {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO]
> {}}}{{{}[INFO] -< org.openjfx:sample
> >-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]
> from pom.xml{}}}{{{}[INFO] [ jar
> ]-{}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
> (908 B at 1.9 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
> (8.4 kB at 165 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom
> (904 B at 21 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom
> (749 B at 17 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar
> (306 B at 6.8 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar
> (302 B at 2.4 kB/s){}}}{{{}Downloaded from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar
> (306 B at 2.4 kB/s){}}}{{{}[INFO]
> {}}}{{{}[INFO]
> BUILD FAILURE{}}}{{{}[INFO]
> {}}}{{{}[INFO]
> Total time: 1.378 s{}}}{{{}[INFO] Finished at:
> 2024-05-28T10:23:05-06:00{}}}{{{}[INFO]
> {}}}{{{}[ERROR]
> Failed to execute goal on project sample: Could not resolve dependencies for
> project org.openjfx:sample:jar:1.0.0: The following artifacts could not be
> resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 (absent),
> org.openjfx:javafx-graphics:jar:$
[jira] [Closed] (MNG-8147) Profile interpolation broke their evaluation in case of duplicate IDs
[
https://issues.apache.org/jira/browse/MNG-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8147.
Resolution: Fixed
> Profile interpolation broke their evaluation in case of duplicate IDs
> -
>
> Key: MNG-8147
> URL: https://issues.apache.org/jira/browse/MNG-8147
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.7
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.8
>
>
> To be clear: we talk about invalid POMs, as you cannot build using a POM that
> contains duplicate Profile ID (is caught and build failed by Maven itself).
> Sadly, POMs are being generated as well, with questionable qualities as it
> seems nothing validates them.
> The change for improvement MNG-8081 broke Maven Model Builder in a way, it
> cannot now properly build projects that have {_}duplicated profile IDs{_}.
> Again, these projects are anyway "just working by chance" (as some dependency
> POM is invalid), but 3.9.6 was building these projects just fine.
> The issue MNG-8141 is created to WARN end users about this.
> This issue should restore 3.9.7 breakage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8141) Model Builder should report if not sure about "fully correct" outcome
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853423#comment-17853423 ] ASF GitHub Bot commented on MNG-8141: - cstamas merged PR #1568: URL: https://github.com/apache/maven/pull/1568 > Model Builder should report if not sure about "fully correct" outcome > - > > Key: MNG-8141 > URL: https://issues.apache.org/jira/browse/MNG-8141 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > ModelBuilder is component building models (POM + interpolating + parent > inheritance and many many more things), but it should not rely that built > model "was validated", as it MAY NOT been validated: for "furthest" models it > builds, like a parent of a some-level-dependency we use MIN level of > validation (minimal validation). > Still, while the model builder builds, it relies on several aspects of the > model, and it should ensure that the "output" (built model) is correct. Model > Builder hence must be changed in way, that IF it detects any issue _during > building_ of the model, and IF it appears with even slightest possibility > that it cannot deliver "correct output", it must add WARNs to model building > result with proper messages. > One typical case is when model building injects activated profiles (as they > can deliver properties and extra plugins and what not) and activation code > detects a "problem", like for example duplicated profile IDs being used (this > IS catched by validation, but not on MIN level!), hence, model builder cannot > guarantee that built model IS correct. > This change is really only to make Maven emit WARNINGs if project being built > has some "far POMs" (like parent pom of a dependency of a first level > dependency, as in reproducer). If model builder cannot be "100% sure" it > built model correctly, it should be reported. Moreover, WARNs of model > building result were simply neglected so fat (lost). Having warnings like > these would reveal "invalid parent POM" early, as it is case in issue > MNG-8131 for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853422#comment-17853422 ] ASF GitHub Bot commented on MDEP-940: - slawekjaranowski commented on PR #410: URL: https://github.com/apache/maven-dependency-plugin/pull/410#issuecomment-2156168890 > > > MAT is still on the CP, no? > > > > > > Yes it is ... I do it step by step > > Alright, let's convert to a draft. Why draft ... we can merge step by step with small changes. > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-941) Deprecate dependency:sources in favor of dependency:resolve-sources
[
https://issues.apache.org/jira/browse/MDEP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853421#comment-17853421
]
ASF GitHub Bot commented on MDEP-941:
-
slawekjaranowski commented on code in PR #411:
URL:
https://github.com/apache/maven-dependency-plugin/pull/411#discussion_r1632102400
##
src/main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.resolvers;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.ResolutionScope;
+
+/**
+ * Goal that resolves the project source dependencies from the repository.
+ *
+ * @author mailto:bri...@apache.org;>Brian Fox
+ * @since 2.0-alpha2
+ * @deprecated in favor of {@code resolve-sources} mojo
+ */
+@Mojo(
+name = "sources",
+defaultPhase = LifecyclePhase.GENERATE_SOURCES,
+requiresDependencyResolution = ResolutionScope.TEST,
+threadSafe = true)
+@Deprecated
+public class OldResolveDependencySourcesMojo extends
ResolveDependencySourcesMojo {
+
+@Override
+protected void doExecute() throws MojoExecutionException {
+getLog().warn(
+"The goal 'dependency:sources' is deprecated for
removal in a future version of this plugin, please use
'dependency:resolve-sources' instead");
+super.doExecute();
+}
Review Comment:
We will have duble warning - one by Maven itself:
```
[WARNING] Goal 'sources' is deprecated: in favor of resolve-sources mojo
```
and second by plugin:
```
[WARNING] The goal 'dependency:sources' is deprecated for removal in a
future version of this plugin, please use 'dependency:resolve-sources' instead
```
We can extend info in docs and will be emited by Maven.
> Deprecate dependency:sources in favor of dependency:resolve-sources
> ---
>
> Key: MDEP-941
> URL: https://issues.apache.org/jira/browse/MDEP-941
> Project: Maven Dependency Plugin
> Issue Type: Task
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> Unfortunately, the goal name does not really depict what the goal is doing,
> it fact it causes confusion as in MDEP-895. The name should clearly say that
> it *resolves* sources and does not collect (semantics is imporant). The new
> goal {{resolve-sources}} is functionally equivalent, but is just more
> expressive.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853419#comment-17853419 ] ASF GitHub Bot commented on MDEP-940: - michael-o commented on PR #410: URL: https://github.com/apache/maven-dependency-plugin/pull/410#issuecomment-2156163382 > > MAT is still on the CP, no? > > Yes it is ... I do it step by step Alright, let's convert to a draft. > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853418#comment-17853418 ] ASF GitHub Bot commented on MDEP-940: - slawekjaranowski commented on PR #410: URL: https://github.com/apache/maven-dependency-plugin/pull/410#issuecomment-2156158703 > MAT is still on the CP, no? Yes it is ... I do it step by step > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-838) "Artifact has not been packaged yet" error message is not very helpful
[ https://issues.apache.org/jira/browse/MDEP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MDEP-838: Fix Version/s: 3.7.0 > "Artifact has not been packaged yet" error message is not very helpful > -- > > Key: MDEP-838 > URL: https://issues.apache.org/jira/browse/MDEP-838 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Priority: Major > Fix For: 3.7.0 > > > Today in a build i get the error > > Artifact has not been packaged yet. When used on reactor artifact, copy > > should be executed after packaging: see MDEP-187 > So I know something is wrong but ... > The error message should at best include > # The "not packed artifact" > # The possible location / reactor project > # Probably *why* it is not considered as packed (e.g does it has no artifact > file? Is it a directory? Something else?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-838) "Artifact has not been packaged yet" error message is not very helpful
[ https://issues.apache.org/jira/browse/MDEP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MDEP-838: Summary: "Artifact has not been packaged yet" error message is not very helpful (was: "Artifact has not been packaged yet" error message is not very helpful.) > "Artifact has not been packaged yet" error message is not very helpful > -- > > Key: MDEP-838 > URL: https://issues.apache.org/jira/browse/MDEP-838 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Priority: Major > > Today in a build i get the error > > Artifact has not been packaged yet. When used on reactor artifact, copy > > should be executed after packaging: see MDEP-187 > So I know something is wrong but ... > The error message should at best include > # The "not packed artifact" > # The possible location / reactor project > # Probably *why* it is not considered as packed (e.g does it has no artifact > file? Is it a directory? Something else?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MDEP-838) "Artifact has not been packaged yet" error message is not very helpful
[ https://issues.apache.org/jira/browse/MDEP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MDEP-838: --- Assignee: Michael Osipov > "Artifact has not been packaged yet" error message is not very helpful > -- > > Key: MDEP-838 > URL: https://issues.apache.org/jira/browse/MDEP-838 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Assignee: Michael Osipov >Priority: Major > Fix For: 3.7.0 > > > Today in a build i get the error > > Artifact has not been packaged yet. When used on reactor artifact, copy > > should be executed after packaging: see MDEP-187 > So I know something is wrong but ... > The error message should at best include > # The "not packed artifact" > # The possible location / reactor project > # Probably *why* it is not considered as packed (e.g does it has no artifact > file? Is it a directory? Something else?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MDEP-669) Optimize the documentation of of build-classpath-mojo
[ https://issues.apache.org/jira/browse/MDEP-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MDEP-669. --- Resolution: Fixed Fixed with [1d79937b583a9ef5450c39b0e369f26ea75bb361|https://gitbox.apache.org/repos/asf?p=maven-dependency-plugin.git;a=commit;h=1d79937b583a9ef5450c39b0e369f26ea75bb361]. > Optimize the documentation of of build-classpath-mojo > -- > > Key: MDEP-669 > URL: https://issues.apache.org/jira/browse/MDEP-669 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: build-classpath >Reporter: Xinrong Meng >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 3.7.0 > > > The documentation in > [https://maven.apache.org/plugins/maven-dependency-plugin/build-classpath-mojo.html#outputProperty] > is relatively confusing. > > `A property to set to the content of the classpath string.` would give users > illusions that they can use this parameter to modify the content of the > classpath string, rather than set the content of the classpath string to some > property. > > As far as I'm concerned, I wanted to embed classifier information in the > displayed classpath string, and I misunderstood this parameter until I > checked the source code of how it is defined. > > All in all, it would be great we could explicitly point it out that this > parameter sets the content of the classpath string to some property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-669) Optimize the documentation of of build-classpath-mojo
[ https://issues.apache.org/jira/browse/MDEP-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853416#comment-17853416 ] ASF GitHub Bot commented on MDEP-669: - asfgit closed pull request #283: [MDEP-669] Optimize the documentation of of build-classpath-mojo URL: https://github.com/apache/maven-dependency-plugin/pull/283 > Optimize the documentation of of build-classpath-mojo > -- > > Key: MDEP-669 > URL: https://issues.apache.org/jira/browse/MDEP-669 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: build-classpath >Reporter: Xinrong Meng >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 3.7.0 > > > The documentation in > [https://maven.apache.org/plugins/maven-dependency-plugin/build-classpath-mojo.html#outputProperty] > is relatively confusing. > > `A property to set to the content of the classpath string.` would give users > illusions that they can use this parameter to modify the content of the > classpath string, rather than set the content of the classpath string to some > property. > > As far as I'm concerned, I wanted to embed classifier information in the > displayed classpath string, and I misunderstood this parameter until I > checked the source code of how it is defined. > > All in all, it would be great we could explicitly point it out that this > parameter sets the content of the classpath string to some property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-941) Deprecate dependency:sources in favor of dependency:resolve-sources
[
https://issues.apache.org/jira/browse/MDEP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853415#comment-17853415
]
ASF GitHub Bot commented on MDEP-941:
-
michael-o opened a new pull request, #411:
URL: https://github.com/apache/maven-dependency-plugin/pull/411
…e-sources
This closes #411
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Deprecate dependency:sources in favor of dependency:resolve-sources
> ---
>
> Key: MDEP-941
> URL: https://issues.apache.org/jira/browse/MDEP-941
> Project: Maven Dependency Plugin
> Issue Type: Task
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> Unfortunately, the goal name does not really depict what the goal is doing,
> it fact it causes confusion as in MDEP-895. The name should clearly say that
> it *resolves* sources and does not collect (semantics is imporant). The new
> goal {{resolve-sources}} is functionally equivalent, but is just more
> expressive.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853414#comment-17853414
]
ASF GitHub Bot commented on MDEP-939:
-
michael-o commented on PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2156149098
FTR: All resolve ITs missing verifiers, this needs to be addressed as a
whole.
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-669) Optimize the documentation of of build-classpath-mojo
[ https://issues.apache.org/jira/browse/MDEP-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MDEP-669: Fix Version/s: 3.7.0 > Optimize the documentation of of build-classpath-mojo > -- > > Key: MDEP-669 > URL: https://issues.apache.org/jira/browse/MDEP-669 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: build-classpath >Reporter: Xinrong Meng >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 3.7.0 > > > The documentation in > [https://maven.apache.org/plugins/maven-dependency-plugin/build-classpath-mojo.html#outputProperty] > is relatively confusing. > > `A property to set to the content of the classpath string.` would give users > illusions that they can use this parameter to modify the content of the > classpath string, rather than set the content of the classpath string to some > property. > > As far as I'm concerned, I wanted to embed classifier information in the > displayed classpath string, and I misunderstood this parameter until I > checked the source code of how it is defined. > > All in all, it would be great we could explicitly point it out that this > parameter sets the content of the classpath string to some property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MDEP-669) Optimize the documentation of of build-classpath-mojo
[ https://issues.apache.org/jira/browse/MDEP-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MDEP-669: --- Assignee: Michael Osipov > Optimize the documentation of of build-classpath-mojo > -- > > Key: MDEP-669 > URL: https://issues.apache.org/jira/browse/MDEP-669 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: build-classpath >Reporter: Xinrong Meng >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > > The documentation in > [https://maven.apache.org/plugins/maven-dependency-plugin/build-classpath-mojo.html#outputProperty] > is relatively confusing. > > `A property to set to the content of the classpath string.` would give users > illusions that they can use this parameter to modify the content of the > classpath string, rather than set the content of the classpath string to some > property. > > As far as I'm concerned, I wanted to embed classifier information in the > displayed classpath string, and I misunderstood this parameter until I > checked the source code of how it is defined. > > All in all, it would be great we could explicitly point it out that this > parameter sets the content of the classpath string to some property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MDEP-941) Deprecate dependency:sources in favor of dependency:resolve-sources
Michael Osipov created MDEP-941:
---
Summary: Deprecate dependency:sources in favor of
dependency:resolve-sources
Key: MDEP-941
URL: https://issues.apache.org/jira/browse/MDEP-941
Project: Maven Dependency Plugin
Issue Type: Task
Components: sources
Affects Versions: 3.6.1
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 3.7.0
Unfortunately, the goal name does not really depict what the goal is doing, it
fact it causes confusion as in MDEP-895. The name should clearly say that it
*resolves* sources and does not collect (semantics is imporant). The new goal
{{resolve-sources}} is functionally equivalent, but is just more expressive.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853413#comment-17853413
]
ASF GitHub Bot commented on MDEP-939:
-
asfgit closed pull request #409: [MDEP-939] Lock down classifier in
dependency:sources goal
URL: https://github.com/apache/maven-dependency-plugin/pull/409
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MDEP-939.
---
Resolution: Fixed
Fixed with
[04c32164bcb3ecef6115616fee291d5ee071d370|https://gitbox.apache.org/repos/asf?p=maven-dependency-plugin.git;a=commit;h=04c32164bcb3ecef6115616fee291d5ee071d370].
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-713) dependency:tree should not log info the user doesn't ask for
[
https://issues.apache.org/jira/browse/MDEP-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MDEP-713:
Description:
I'm going to start this report here, though I kind of expect it slips into
core and a lot of other components. Suppose I run mvn dependency:tree on Guava.
As a user here's what I want to see (though probably minus the [INFO] prefix):
{noformat}
[INFO] com.google.guava:guava-gwt:jar:HEAD-jre-SNAPSHOT
[INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] +- com.google.guava:guava:jar:HEAD-jre-SNAPSHOT:compile
[INFO] | +-
com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
[INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile
[INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile
[INFO] +- com.google.elemental2:elemental2-promise:jar:1.0.0-RC1:compile
[INFO] | +- com.google.jsinterop:jsinterop-annotations:jar:1.0.2:compile
[INFO] | \- com.google.jsinterop:base:jar:1.0.0-RC1:compile
[INFO] +- com.google.guava:guava-testlib:jar:HEAD-jre-SNAPSHOT:test
[INFO] | \- junit:junit:jar:4.13:test
[INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- com.google.guava:guava-testlib:jar:tests:HEAD-jre-SNAPSHOT:test
[INFO] +- com.google.guava:guava-tests:jar:tests:HEAD-jre-SNAPSHOT:test
[INFO] +- com.google.gwt:gwt-dev:jar:2.8.2:provided
[INFO] | +- com.google.code.gson:gson:jar:2.6.2:provided
[INFO] | +- org.ow2.asm:asm:jar:5.0.3:provided
[INFO] | +- org.ow2.asm:asm-util:jar:5.0.3:provided
[INFO] | | \- org.ow2.asm:asm-tree:jar:5.0.3:provided
[INFO] | +- org.ow2.asm:asm-commons:jar:5.0.3:provided
[INFO] | +- colt:colt:jar:1.2.0:provided
[INFO] | +- ant:ant:jar:1.6.5:provided
[INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided
[INFO] | +- commons-io:commons-io:jar:2.4:provided
[INFO] | +- com.ibm.icu:icu4j:jar:50.1.1:provided
[INFO] | +- tapestry:tapestry:jar:4.0.2:provided
[INFO] | +- net.sourceforge.htmlunit:htmlunit:jar:2.19:provided
[INFO] | | +- xalan:xalan:jar:2.7.2:provided
[INFO] | | | \- xalan:serializer:jar:2.7.2:provided
[INFO] | | +- org.apache.commons:commons-lang3:jar:3.4:provided
[INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.1:provided
[INFO] | | | \- org.apache.httpcomponents:httpcore:jar:4.4.3:provided
[INFO] | | +- org.apache.httpcomponents:httpmime:jar:4.5.1:provided
[INFO] | | +- commons-codec:commons-codec:jar:1.10:provided
[INFO] | | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.17:provided
[INFO] | | +- xerces:xercesImpl:jar:2.11.0:provided
[INFO] | | | \- xml-apis:xml-apis:jar:1.4.01:provided
[INFO] | | +- net.sourceforge.nekohtml:nekohtml:jar:1.9.22:provided
[INFO] | | +- net.sourceforge.cssparser:cssparser:jar:0.9.18:provided
[INFO] | | +- commons-logging:commons-logging:jar:1.2:provided
[INFO] | | \-
org.eclipse.jetty.websocket:websocket-client:jar:9.2.13.v20150730:provided
[INFO] | | \-
org.eclipse.jetty.websocket:websocket-common:jar:9.2.13.v20150730:provided
[INFO] | |\-
org.eclipse.jetty.websocket:websocket-api:jar:9.2.13.v20150730:provided
[INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.14.v20151106:provided
[INFO] | | +- org.eclipse.jetty:jetty-xml:jar:9.2.14.v20151106:provided
[INFO] | | \- org.eclipse.jetty:jetty-servlet:jar:9.2.14.v20151106:provided
[INFO] | | \-
org.eclipse.jetty:jetty-security:jar:9.2.14.v20151106:provided
[INFO] | +- org.eclipse.jetty:jetty-servlets:jar:9.2.14.v20151106:provided
[INFO] | | +-
org.eclipse.jetty:jetty-continuation:jar:9.2.14.v20151106:provided
[INFO] | | +- org.eclipse.jetty:jetty-http:jar:9.2.14.v20151106:provided
[INFO] | | +- org.eclipse.jetty:jetty-util:jar:9.2.14.v20151106:provided
[INFO] | | \- org.eclipse.jetty:jetty-io:jar:9.2.14.v20151106:provided
[INFO] | +- org.eclipse.jetty:jetty-annotations:jar:9.2.14.v20151106:provided
[INFO] | | +- org.eclipse.jetty:jetty-plus:jar:9.2.14.v20151106:provided
[INFO] | | | \- org.eclipse.jetty:jetty-jndi:jar:9.2.14.v20151106:provided
[INFO] | | \- javax.annotation:javax.annotation-api:jar:1.2:provided
[INFO] | \- org.eclipse.jetty:apache-jsp:jar:9.2.14.v20151106:provided
[INFO] | +- org.eclipse.jetty:jetty-server:jar:9.2.14.v20151106:provided
[INFO] | +- org.eclipse.jetty.toolchain:jetty-schemas:jar:3.1.M0:provided
[INFO] | \- org.mortbay.jasper:apache-jsp:jar:8.0.9.M3:provided
[INFO] |\- org.mortbay.jasper:apache-el:jar:8.0.9.M3:provided
[INFO] +- com.google.gwt:gwt-user:jar:2.8.2:provided
[INFO] | +-
com.google.jsinterop:jsinterop-annotations:jar:sources:1.0.2:provided
[INFO] | +- javax.validation:validation-api:jar:1.0.0.GA:provided
[INFO] | +- javax.validation:validation-api:jar:sources:1.0.0.GA:provided
[INFO] | +- javax.servlet:javax.servlet-api:jar:3.1.0:provided
[INFO
[jira] [Commented] (MDEP-839) dependency:list should output a plain list whe used with a file
[
https://issues.apache.org/jira/browse/MDEP-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853408#comment-17853408
]
Michael Osipov commented on MDEP-839:
-
There is a workaround: Run Maven with {{-B}}.
> dependency:list should output a plain list whe used with a file
> ---
>
> Key: MDEP-839
> URL: https://issues.apache.org/jira/browse/MDEP-839
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Minor
>
> There is a parameter to redirect the output to a file:
> https://maven.apache.org/plugins/maven-dependency-plugin/list-mojo.html#outputFile
> This currently has some issues I would not expect when redirecting such
> content to a file:
> # First line in the file is empty
> # Second line says 'The following files have been resolved:'
> # next lines are indented
> # ANSI Escape Characters are emmited e.g. [36m -- module maven.core[0;1;33m
> (auto)[m
> What I would expect:
> Each line just contains the raw resolved dependency e.g.
> "org.apache.maven:maven-core:jar:3.8.6:provided" and no more content is
> printed out, especially no ANSI Escapes
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853407#comment-17853407 ] ASF GitHub Bot commented on MDEP-940: - michael-o commented on PR #410: URL: https://github.com/apache/maven-dependency-plugin/pull/410#issuecomment-2156104960 MAT is still on the CP, no? > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-900) dependency:resolve fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853406#comment-17853406
]
ASF GitHub Bot commented on MDEP-900:
-
michael-o commented on PR #406:
URL:
https://github.com/apache/maven-dependency-plugin/pull/406#issuecomment-2156104532
Closing this experiment, leaving the branch.
> dependency:resolve fails for multi-module project
> -
>
> Key: MDEP-900
> URL: https://issues.apache.org/jira/browse/MDEP-900
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: resolve
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing {{mvn dependency:resolve}} on a multi-module project it fails
> to retrieve artifacts for the modules themselves (which is not necessary as
> these can be installed by {{mvn install}} any time).
> This can be seen on an [OSS multi-module
> project|https://github.com/WASdev/sample.daytrader7]:
> {code:java}
> mvn dependency:resolve
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> [jar]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> [war]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample
> [pom]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR
> [ear]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> 1.0-SNAPSHOT [1/4]
> [INFO] from daytrader-ee7-ejb/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
> [INFO]
> [INFO] The following files have been resolved:
> [INFO] javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
> [INFO] com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail
> (auto)
> [INFO] javax.activation:activation:jar:1.1:provided -- module activation
> (auto)
> [INFO] javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module
> java.annotation [auto]
> [INFO]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> 1.0-SNAPSHOT [2/4]
> [INFO] from daytrader-ee7-web/pom.xml
> [INFO] [ war
> ]-
> [INFO]
>
> [INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample
> 1.0-SNAPSHOT:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [
> 0.402 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [
> 0.012 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.552 s
> [INFO] Finished at: 2023-11-14T12:37:02+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project daytrader-ee7-web: Could not
> resolve dependencies for project
> net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following
> artifacts could not be resolved:
> net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not
> find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409, and MDEP-895
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-900) dependency:resolve fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853405#comment-17853405
]
ASF GitHub Bot commented on MDEP-900:
-
michael-o closed pull request #406: [MDEP-900] dependency:resolve fails for
multi-module project
URL: https://github.com/apache/maven-dependency-plugin/pull/406
> dependency:resolve fails for multi-module project
> -
>
> Key: MDEP-900
> URL: https://issues.apache.org/jira/browse/MDEP-900
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: resolve
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing {{mvn dependency:resolve}} on a multi-module project it fails
> to retrieve artifacts for the modules themselves (which is not necessary as
> these can be installed by {{mvn install}} any time).
> This can be seen on an [OSS multi-module
> project|https://github.com/WASdev/sample.daytrader7]:
> {code:java}
> mvn dependency:resolve
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> [jar]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> [war]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample
> [pom]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR
> [ear]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> 1.0-SNAPSHOT [1/4]
> [INFO] from daytrader-ee7-ejb/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
> [INFO]
> [INFO] The following files have been resolved:
> [INFO] javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
> [INFO] com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail
> (auto)
> [INFO] javax.activation:activation:jar:1.1:provided -- module activation
> (auto)
> [INFO] javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module
> java.annotation [auto]
> [INFO]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> 1.0-SNAPSHOT [2/4]
> [INFO] from daytrader-ee7-web/pom.xml
> [INFO] [ war
> ]-
> [INFO]
>
> [INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample
> 1.0-SNAPSHOT:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [
> 0.402 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [
> 0.012 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.552 s
> [INFO] Finished at: 2023-11-14T12:37:02+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project daytrader-ee7-web: Could not
> resolve dependencies for project
> net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following
> artifacts could not be resolved:
> net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not
> find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409, and MDEP-895
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-895) dependency:sources fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853404#comment-17853404
]
Michael Osipov commented on MDEP-895:
-
Reverted with
[9fd4ed53b23e35de8ad8179e5b379acf3721ffbe|https://gitbox.apache.org/repos/asf?p=maven-dependency-plugin.git;a=commit;h=9fd4ed53b23e35de8ad8179e5b379acf3721ffbe].
> dependency:sources fails for multi-module project
> -
>
> Key: MDEP-895
> URL: https://issues.apache.org/jira/browse/MDEP-895
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing `mvn dependency:sources` on a multi-module project it fails to
> retrieve sources for the modules themselves (which is not necessary as the
> source code is provided locally already):
> {code:java}
> mvn dependency:sources
> ...
> [INFO] -< org.apache.maven.its.dependency:tree-multimodule-module-b
> >--
> [INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT
> [3/3]
> [INFO] from module-b/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
>
> [INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
> [INFO]
> [INFO] MultimoduleTest SUCCESS [ 0.390
> s]
> [INFO] MultimoduleTest Module A ... SUCCESS [ 0.063
> s]
> [INFO] MultimoduleTest Module B ... FAILURE [ 0.005
> s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.587 s
> [INFO] Finished at: 2023-11-09T10:38:16+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project tree-multimodule-module-b: Could
> not resolve dependencies for project
> org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT:
> The following artifacts could not be resolved:
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT
> (absent): Could not find artifact
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409.
> A test and PR is already prepared:
> https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1494) Make Provider surefire-junit47 default provider and deprecate surefire-junit4 Provider
[ https://issues.apache.org/jira/browse/SUREFIRE-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853403#comment-17853403 ] ASF GitHub Bot commented on SUREFIRE-1494: -- michael-o commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-2156100632 Anyone wants to pick this one up? > Make Provider surefire-junit47 default provider and deprecate surefire-junit4 > Provider > -- > > Key: SUREFIRE-1494 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1494 > Project: Maven Surefire > Issue Type: New Feature >Reporter: Tibor Digana >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2152) Allow to show name (not just index) of parameterized tests in console output
[
https://issues.apache.org/jira/browse/SUREFIRE-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853402#comment-17853402
]
ASF GitHub Bot commented on SUREFIRE-2152:
--
michael-o commented on PR #615:
URL: https://github.com/apache/maven-surefire/pull/615#issuecomment-2156100287
@s-rwe Do you want to pick this up again?
> Allow to show name (not just index) of parameterized tests in console output
>
>
> Key: SUREFIRE-2152
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2152
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M9
>Reporter: Ralph Weires
>Priority: Major
>
> When running parameterized tests with surefire (JUnit5 in my case), it can be
> tough to easily figure out which exact instances have failed, based on the
> console output. While I can - at least in some places in the console output
> (see also SUREFIRE-2151) - see the invocation ID of a failing test, I would
> generally also want to see the name of the failing parameters in question
> along with that (i.e. a representation of the actual arguments of the
> invocation, possibly customized by a developer with
> {_}@ParameterizedTest(name="..."){_})
> Especially for parameterized tests with large amounts of invocations, and/or
> where those actual arguments are only defined at runtime (e.g. via JUnit5
> {_}@MethodSource{_}), it can be very cumbersome to identify which precise
> instance caused a failure, based on the numeric invocation-ID alone.
> I have tried the different configurations introduced in 3.0.0-M4 (i.e. the
> ones described in
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#surefire-extensions-and-reports-configuration-for-displayname]
> / introduced with SUREFIRE-1546), but none of them seem to really change
> anything regarding the console reporting.
> So I would appreciate having the possibility (ideally with another
> configuration flag) to include the name of templated-tests such as
> _@ParameterizedTest_ (in addition to the invocation-ID) along when creating
> the test-name. Note that I am not really interested in any _@DisplayName_
> annotations (which is what SUREFIRE-1546 covered) - to me this is mainly
> about making it as easy as possible for developers to quickly identify which
> invocation caused a failure.
> I did actually prepare a patched surefire version that we have in use for
> this (albeit without a configuration flag to control this behavior, don't
> know how to do that). If that's something worth sharing, I'm happy to create
> a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1909) Support JUnit 5 reflection access by changing add-exports to add-opens
[
https://issues.apache.org/jira/browse/SUREFIRE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853400#comment-17853400
]
ASF GitHub Bot commented on SUREFIRE-1909:
--
michael-o commented on PR #461:
URL: https://github.com/apache/maven-surefire/pull/461#issuecomment-2156098250
Code has been merged and issue fixed.
> Support JUnit 5 reflection access by changing add-exports to add-opens
> --
>
> Key: SUREFIRE-1909
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1909
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M5
>Reporter: Christian Kohlschütter
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.3, 3.0.0-M6
>
> Attachments: surefire-jpms-bug.tar.gz
>
>
> Testing JUnit 5 classes of a JPMS-enabled project with Surefire may fail if a
> test class (or, for example, an abstract test base class) is not declared
> "public". I'm seeing the following error:
>
> {code:java}
> java.lang.reflect.InaccessibleObjectException: Unable to make public static
> void some.package.SomeClass.setupClass() throws java.io.IOException
> accessible: module some.module does not "opens some.package" to unnamed
> module @754ba872{code}
> This could be fixed by adding the recommended "{{opens some.package}}" to the
> project's module-info.java, however that is undesirable since it changes the
> project's behavior beyond just unit testing. Adding a secondary "test-only"
> module-info.java is also counterproductive since not all IDEs support this,
> and these two files would have to be kept in sync, which is non-trivial.
> An easy fix would be to change the "{{--add-exports-}}" VM parameter that
> surefire adds automatically to "{{-}}{{add-opens}}" in
> {{maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java}}
> This bug is particularly bad because PMD now specifically complains about
> junit5 classes marked as public instead of package-private; see
> [https://pmd.github.io/2021/05/29/PMD-6.35.0/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1909) Support JUnit 5 reflection access by changing add-exports to add-opens
[
https://issues.apache.org/jira/browse/SUREFIRE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853399#comment-17853399
]
ASF GitHub Bot commented on SUREFIRE-1909:
--
michael-o closed pull request #461: [SUREFIRE-1909] Replace --add-exports with
--add-opens
URL: https://github.com/apache/maven-surefire/pull/461
> Support JUnit 5 reflection access by changing add-exports to add-opens
> --
>
> Key: SUREFIRE-1909
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1909
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M5
>Reporter: Christian Kohlschütter
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.3, 3.0.0-M6
>
> Attachments: surefire-jpms-bug.tar.gz
>
>
> Testing JUnit 5 classes of a JPMS-enabled project with Surefire may fail if a
> test class (or, for example, an abstract test base class) is not declared
> "public". I'm seeing the following error:
>
> {code:java}
> java.lang.reflect.InaccessibleObjectException: Unable to make public static
> void some.package.SomeClass.setupClass() throws java.io.IOException
> accessible: module some.module does not "opens some.package" to unnamed
> module @754ba872{code}
> This could be fixed by adding the recommended "{{opens some.package}}" to the
> project's module-info.java, however that is undesirable since it changes the
> project's behavior beyond just unit testing. Adding a secondary "test-only"
> module-info.java is also counterproductive since not all IDEs support this,
> and these two files would have to be kept in sync, which is non-trivial.
> An easy fix would be to change the "{{--add-exports-}}" VM parameter that
> surefire adds automatically to "{{-}}{{add-opens}}" in
> {{maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java}}
> This bug is particularly bad because PMD now specifically complains about
> junit5 classes marked as public instead of package-private; see
> [https://pmd.github.io/2021/05/29/PMD-6.35.0/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853391#comment-17853391
]
Sergey Nuyanzin edited comment on MNG-8148 at 6/8/24 4:23 PM:
--
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and then
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range without putting others into DAG?
was (Author: sergey nuyanzin):
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and then
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range ?
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.Mojo
[jira] [Comment Edited] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853391#comment-17853391
]
Sergey Nuyanzin edited comment on MNG-8148 at 6/8/24 4:22 PM:
--
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and then
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range ?
was (Author: sergey nuyanzin):
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and them
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range ?
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(Mo
[jira] [Commented] (SUREFIRE-2248) Make "type" attribute on failures and errors in (surefire|failsafe)-test-report schema optional
[
https://issues.apache.org/jira/browse/SUREFIRE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853394#comment-17853394
]
ASF GitHub Bot commented on SUREFIRE-2248:
--
asfgit closed pull request #746: [SUREFIRE-2248] Make "type" attribute on
failures and errors in (sure…
URL: https://github.com/apache/maven-surefire/pull/746
> Make "type" attribute on failures and errors in
> (surefire|failsafe)-test-report schema optional
> ---
>
> Key: SUREFIRE-2248
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2248
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
>Affects Versions: 3.2.5
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>
> There are situations where a stack trace is not always available, in fact,
> the code path {{StatelessXmlReporter}} is structured in a way that it can
> lead to an empty/missing {{type}} from a stack trace. This would require to
> write a blank or a bogus value to satisfy the schema. This does not make
> sense. We should make this optional to better accommodate reality. See
> SUREFIRE-2232 for details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2248) Make "type" attribute on failures and errors in (surefire|failsafe)-test-report schema optional
[
https://issues.apache.org/jira/browse/SUREFIRE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2248.
Resolution: Fixed
Fixed with
[cad09319311326520e09b36cc95c06116901ec5e|https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=cad09319311326520e09b36cc95c06116901ec5e].
> Make "type" attribute on failures and errors in
> (surefire|failsafe)-test-report schema optional
> ---
>
> Key: SUREFIRE-2248
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2248
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
>Affects Versions: 3.2.5
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>
> There are situations where a stack trace is not always available, in fact,
> the code path {{StatelessXmlReporter}} is structured in a way that it can
> lead to an empty/missing {{type}} from a stack trace. This would require to
> write a blank or a bogus value to satisfy the schema. This does not make
> sense. We should make this optional to better accommodate reality. See
> SUREFIRE-2232 for details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2047) Upgrade to maven-common-artifact-filters 3.4.0
[
https://issues.apache.org/jira/browse/SUREFIRE-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2047.
Resolution: Fixed
Fixed with
[a88d786d7d9350b15dae47d8603e22748d8cdee1|https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=a88d786d7d9350b15dae47d8603e22748d8cdee1].
> Upgrade to maven-common-artifact-filters 3.4.0
> --
>
> Key: SUREFIRE-2047
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2047
> Project: Maven Surefire
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.0
>
>
> Currently we can't upgrade {{maven-common-artifact-filters}} to 3.2.0 due to
> MSHARED-1031
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2047) Upgrade to maven-common-artifact-filters 3.4.0
[
https://issues.apache.org/jira/browse/SUREFIRE-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853393#comment-17853393
]
ASF GitHub Bot commented on SUREFIRE-2047:
--
asfgit closed pull request #742: [SUREFIRE-2047] Upgrade to
maven-common-artifact-filters 3.4.0
URL: https://github.com/apache/maven-surefire/pull/742
> Upgrade to maven-common-artifact-filters 3.4.0
> --
>
> Key: SUREFIRE-2047
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2047
> Project: Maven Surefire
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.0
>
>
> Currently we can't upgrade {{maven-common-artifact-filters}} to 3.2.0 due to
> MSHARED-1031
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853391#comment-17853391
]
Sergey Nuyanzin commented on MNG-8148:
--
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and them
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range ?
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> {noformat}
> and
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:12
[jira] [Comment Edited] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853391#comment-17853391
]
Sergey Nuyanzin edited comment on MNG-8148 at 6/8/24 4:17 PM:
--
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and them
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range ?
was (Author: sergey nuyanzin):
After playing more and looking into code of maven and maven-resolver I realised
that there is a problem with dependencies, e.g. we have something like this
{code:xml}
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
[1.0.0-0, 3.0.0-0)
{code}
so there are several deps with very wide range (in each range there are
hundreds of internal versions).
It looks like with such ranges it tries to add all in conflict DAG and them
remove at some point of time, so first there is time consumption to grow maps
and then for GC...
I tried to shorter the range and it becomes much faster, so I guess this is the
root cause
I wonder if there is a way to say maven: pick only one the latest available
version from the range ?
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(Mo
[jira] [Comment Edited] (MPIR-455) dependencies goal: add support for multi-release JARs
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853390#comment-17853390 ] Michael Osipov edited comment on MPIR-455 at 6/8/24 4:06 PM: - That looks promising. What about bulletpoints like here? !screenshot-1.png! and instead of "Base" "Root" as described in JEP 238? was (Author: michael-o): That looks promising. What about bulletpoints like here: !screenshot-1.png! and instead of "Base" "Root" as described in JEP 238? > dependencies goal: add support for multi-release JARs > - > > Key: MPIR-455 > URL: https://issues.apache.org/jira/browse/MPIR-455 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.5, 3.5.0 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > Attachments: image-2024-01-04-21-12-54-861.png, > image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, > image-2024-06-08-11-11-22-722.png, screenshot-1.png > > > dependencies goal reports dependencies with multi-release support with the > highest version supported in the jar file, instead of the base version. > Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their > base version is 1.8. > !image-2024-01-04-21-12-54-861.png! > Because of this the lower "Total" rows report a wrong java version too. > > This depends on https://issues.apache.org/jira/browse/MSHARED-1256. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853390#comment-17853390 ] Michael Osipov commented on MPIR-455: - That looks promising. What about bulletpoints like here: !screenshot-1.png! and instead of "Base" "Root" as described in JEP 238? > dependencies goal: add support for multi-release JARs > - > > Key: MPIR-455 > URL: https://issues.apache.org/jira/browse/MPIR-455 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.5, 3.5.0 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > Attachments: image-2024-01-04-21-12-54-861.png, > image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, > image-2024-06-08-11-11-22-722.png, screenshot-1.png > > > dependencies goal reports dependencies with multi-release support with the > highest version supported in the jar file, instead of the base version. > Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their > base version is 1.8. > !image-2024-01-04-21-12-54-861.png! > Because of this the lower "Total" rows report a wrong java version too. > > This depends on https://issues.apache.org/jira/browse/MSHARED-1256. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-455) dependencies goal: add support for multi-release JARs
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-455: Attachment: screenshot-1.png > dependencies goal: add support for multi-release JARs > - > > Key: MPIR-455 > URL: https://issues.apache.org/jira/browse/MPIR-455 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.5, 3.5.0 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > Attachments: image-2024-01-04-21-12-54-861.png, > image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, > image-2024-06-08-11-11-22-722.png, screenshot-1.png > > > dependencies goal reports dependencies with multi-release support with the > highest version supported in the jar file, instead of the base version. > Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their > base version is 1.8. > !image-2024-01-04-21-12-54-861.png! > Because of this the lower "Total" rows report a wrong java version too. > > This depends on https://issues.apache.org/jira/browse/MSHARED-1256. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853382#comment-17853382 ] Gabriel Belingueres commented on MPIR-455: -- Yes I'm working on it right now...I can probably put a few more hours this weekend. I opened the numbers as suggested: First row is jar file information (file name, file size, and if jar is sealed). Next rows are base content and then all versioned content. WDYT? !image-2024-06-08-11-11-22-722.png|width=803,height=88! > dependencies goal: add support for multi-release JARs > - > > Key: MPIR-455 > URL: https://issues.apache.org/jira/browse/MPIR-455 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.5, 3.5.0 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > Attachments: image-2024-01-04-21-12-54-861.png, > image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, > image-2024-06-08-11-11-22-722.png > > > dependencies goal reports dependencies with multi-release support with the > highest version supported in the jar file, instead of the base version. > Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their > base version is 1.8. > !image-2024-01-04-21-12-54-861.png! > Because of this the lower "Total" rows report a wrong java version too. > > This depends on https://issues.apache.org/jira/browse/MSHARED-1256. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-455) dependencies goal: add support for multi-release JARs
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Belingueres updated MPIR-455: - Attachment: image-2024-06-08-11-11-22-722.png > dependencies goal: add support for multi-release JARs > - > > Key: MPIR-455 > URL: https://issues.apache.org/jira/browse/MPIR-455 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.5, 3.5.0 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > Attachments: image-2024-01-04-21-12-54-861.png, > image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, > image-2024-06-08-11-11-22-722.png > > > dependencies goal reports dependencies with multi-release support with the > highest version supported in the jar file, instead of the base version. > Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their > base version is 1.8. > !image-2024-01-04-21-12-54-861.png! > Because of this the lower "Total" rows report a wrong java version too. > > This depends on https://issues.apache.org/jira/browse/MSHARED-1256. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853379#comment-17853379 ] Michael Osipov commented on MPIR-455: - [~belingueres], please let me know your timeframe where you want to deliver the PR. I'd like to do a release in the next two weeks. > dependencies goal: add support for multi-release JARs > - > > Key: MPIR-455 > URL: https://issues.apache.org/jira/browse/MPIR-455 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.5, 3.5.0 >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > Attachments: image-2024-01-04-21-12-54-861.png, > image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png > > > dependencies goal reports dependencies with multi-release support with the > highest version supported in the jar file, instead of the base version. > Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their > base version is 1.8. > !image-2024-01-04-21-12-54-861.png! > Because of this the lower "Total" rows report a wrong java version too. > > This depends on https://issues.apache.org/jira/browse/MSHARED-1256. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853378#comment-17853378
]
ASF GitHub Bot commented on MDEP-939:
-
michael-o commented on code in PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632046244
##
src/it/projects/sources/test.properties:
##
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
I guess at least the build should not fail, but need to try...
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853372#comment-17853372 ] ASF GitHub Bot commented on MDEP-940: - slawekjaranowski opened a new pull request, #410: URL: https://github.com/apache/maven-dependency-plugin/pull/410 https://issues.apache.org/jira/browse/MDEP-940 > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (MDEP-940) Use Resolver API instead of m-a-t for resolving artifacts
[ https://issues.apache.org/jira/browse/MDEP-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski moved MNG-8149 to MDEP-940: --- Key: MDEP-940 (was: MNG-8149) Project: Maven Dependency Plugin (was: Maven) > Use Resolver API instead of m-a-t for resolving artifacts > - > > Key: MDEP-940 > URL: https://issues.apache.org/jira/browse/MDEP-940 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8149) Use Resolver API instead of m-a-t for resolving artifacts
Slawomir Jaranowski created MNG-8149: Summary: Use Resolver API instead of m-a-t for resolving artifacts Key: MNG-8149 URL: https://issues.apache.org/jira/browse/MNG-8149 Project: Maven Issue Type: Improvement Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853366#comment-17853366
]
ASF GitHub Bot commented on MDEP-939:
-
slawekjaranowski commented on code in PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632038544
##
src/it/projects/sources/test.properties:
##
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
and there are no assertions in this test
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853365#comment-17853365
]
ASF GitHub Bot commented on MDEP-939:
-
slawekjaranowski commented on code in PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632038356
##
src/it/projects/sources/test.properties:
##
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
this test can be useful ... even we have a read only property user still can
override it
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853355#comment-17853355
]
Sergey Nuyanzin edited comment on MNG-8148 at 6/8/24 10:08 AM:
---
sure here it is
{noformat}
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
{noformat}
demo project not sure, i will try to make something, let's see
was (Author: sergey nuyanzin):
sure here it is
{noformat}
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
{noformat}
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> {noformat}
> and
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.e
[jira] [Comment Edited] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853355#comment-17853355
]
Sergey Nuyanzin edited comment on MNG-8148 at 6/8/24 10:07 AM:
---
sure here it is
{noformat}
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
{noformat}
was (Author: sergey nuyanzin):
sure here it
{noformat}
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
{noformat}
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> {noformat}
> and
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.eclipse.aether.util.graph.t
[jira] [Commented] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853355#comment-17853355
]
Sergey Nuyanzin commented on MNG-8148:
--
sure here it
{noformat}
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
{noformat}
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> {noformat}
> and
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:1
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853356#comment-17853356
]
ASF GitHub Bot commented on MDEP-939:
-
michael-o commented on code in PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1632016770
##
src/it/projects/sources/test.properties:
##
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
Will do
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853354#comment-17853354
]
ASF GitHub Bot commented on MDEP-939:
-
michael-o commented on PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155942471
> > > Looks ok - even more `classifier` parameter disappears from plugin
documentation
> >
> >
> > This is a nice bonus or a bug in the Plugin Tools.
>
> works as expected - documentation was taken from the final class - as we
have read-only property is hidden
Perfect, thanks.
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853353#comment-17853353
]
Slawomir Jaranowski commented on MNG-8148:
--
Please provide output of: {{mvn -v}} a demo project will be also appreciated
and help to reproduce it.
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> and this is the thing which I faced. most of the times when the build was
> hanging
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
> tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
>java.lang.Thread.State: RUNNABLE
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
> at
> org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> {noformat}
> and
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246
[jira] [Updated] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated MNG-8148:
-
Description:
The project is relatively small (5 modules and maybe about 1k classes in total)
unfortunately it is private so I couldn't share the source
1 thing that may be makes sense to mention is that some modules generates code
for protobuf integration.
also I was able to take thread dump of maven build
and this is the thing which I faced. most of the times when the build was
hanging
{noformat}
"main" #1 prio=5 os_prio=31 cpu=394695.18ms elapsed=448.93s
tid=0x00015d80a800 nid=0x2403 runnable [0x00016dec4000]
java.lang.Thread.State: RUNNABLE
at
org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
at
org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
at
org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
at
org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
at
org.eclipse.aether.util.graph.transformer.ConflictMarker.analyze(ConflictMarker.java:133)
at
org.eclipse.aether.util.graph.transformer.ConflictMarker.transformGraph(ConflictMarker.java:63)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:58)
at
org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
at
org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
at
org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
at
org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
at
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
{noformat}
and
{noformat}
"main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
java.lang.Thread.State: RUNNABLE
at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
at
org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
at
org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
at
org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
at
org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
at
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(M
[jira] [Updated] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated MNG-8148:
-
Description:
The project is relatively small (5 modules and maybe about 1k classes in total)
unfortunately it is private so I couldn't share the source
1 thing that may be makes sense to mention is that some modules generates code
for protobuf integration.
also I was able to take thread dump of maven build
and this is the thing which I faced. most of the times when the build was
hanging
{noformat}
"main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
java.lang.Thread.State: RUNNABLE
at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
at
org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
at
org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
at
org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
at
org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
at
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:206)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.23/Native
Method)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@11.0.23/NativeMethodAccessorImpl.java:62)
at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.23/DelegatingMethodAccessorImpl.java:43)
{noformat}
any hints what to do to find the root cause would be welcome
was:
The project is relatively small (5 modules and maybe about 1k classes in total)
unfortunately it is private so I couldn't share the source
1 thing that may be makes sense to mention is that some modules generates code
for protobuf integration.
also I was able to take thread dump of maven build
{noformat}
"main" #1 prio=5 os_prio=31 cpu
[jira] [Created] (MNG-8148) DefaultProjectDependenciesResolver takes up to 5 minute for some modules of the project
Sergey Nuyanzin created MNG-8148:
Summary: DefaultProjectDependenciesResolver takes up to 5 minute
for some modules of the project
Key: MNG-8148
URL: https://issues.apache.org/jira/browse/MNG-8148
Project: Maven
Issue Type: Bug
Reporter: Sergey Nuyanzin
The project is relatively small (5 modules and maybe about 1k classes in total)
unfortunately it is private so I couldn't share the source
1 thing that may be makes sense to mention is that some modules generates code
for protobuf integration.
also I was able to take thread dump of maven build
{noformat}
"main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
java.lang.Thread.State: RUNNABLE
at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
at
org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
at
org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
at
org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
at
org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
at
org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
at
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:206)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.23/Native
Method)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@11.0.23/NativeMethodAccessorImpl.java:62)
at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.23/DelegatingMethodAccessorImpl.java:43)
{noformat}
any hints what to do to find the root cause would be welcome
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8148) DefaultProjectDependenciesResolver takes up to several minutes for some modules of the project
[
https://issues.apache.org/jira/browse/MNG-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated MNG-8148:
-
Summary: DefaultProjectDependenciesResolver takes up to several minutes for
some modules of the project (was: DefaultProjectDependenciesResolver takes up
to 5 minute for some modules of the project)
> DefaultProjectDependenciesResolver takes up to several minutes for some
> modules of the project
> --
>
> Key: MNG-8148
> URL: https://issues.apache.org/jira/browse/MNG-8148
> Project: Maven
> Issue Type: Bug
>Reporter: Sergey Nuyanzin
>Priority: Major
>
> The project is relatively small (5 modules and maybe about 1k classes in
> total)
> unfortunately it is private so I couldn't share the source
> 1 thing that may be makes sense to mention is that some modules generates
> code for protobuf integration.
> also I was able to take thread dump of maven build
> {noformat}
> "main" #1 prio=5 os_prio=31 cpu=456718.35ms elapsed=518.34s
> tid=0x000127811000 nid=0x2403 runnable [0x00016b3ac000]
>java.lang.Thread.State: RUNNABLE
> at java.util.HashMap.hash(java.base@11.0.23/HashMap.java:340)
> at java.util.LinkedHashMap.get(java.base@11.0.23/LinkedHashMap.java:440)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:110)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.buildConflitIdDAG(ConflictIdSorter.java:122)
> at
> org.eclipse.aether.util.graph.transformer.ConflictIdSorter.transformGraph(ConflictIdSorter.java:78)
> at
> org.eclipse.aether.util.graph.transformer.ConflictResolver.transformGraph(ConflictResolver.java:172)
> at
> org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer.transformGraph(ChainedDependencyGraphTransformer.java:71)
> at
> org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:246)
> at
> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:306)
> at
> org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:224)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:355)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:313)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
> at
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:283)
&
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853350#comment-17853350
]
ASF GitHub Bot commented on MDEP-939:
-
slawekjaranowski commented on PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155921545
> > Looks ok - even more `classifier` parameter disappears from plugin
documentation
>
> This is a nice bonus or a bug in the Plugin Tools.
works as expected - documentation was taken from the final class - as we
have read-only property is hidden
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853349#comment-17853349
]
ASF GitHub Bot commented on MDEP-939:
-
michael-o commented on PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155914096
> Looks ok - even more `classifier` parameter disappears from plugin
documentation
This is a nice bonus or a bug in the Plugin Tools.
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSHARED-1401) Refresh checkstyle rules
[ https://issues.apache.org/jira/browse/MSHARED-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1401: - Issue Type: Improvement (was: Task) > Refresh checkstyle rules > > > Key: MSHARED-1401 > URL: https://issues.apache.org/jira/browse/MSHARED-1401 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-resources >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-resources-6 > > > - add AvoidStarImport > - add setterCanReturnItsClass for HiddenField > - drop MagicNumber > - add OneStatementPerLine > - add UnusedLocalVariable -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1401) Refresh checkstyle rules
[ https://issues.apache.org/jira/browse/MSHARED-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1401. Resolution: Fixed > Refresh checkstyle rules > > > Key: MSHARED-1401 > URL: https://issues.apache.org/jira/browse/MSHARED-1401 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-resources >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-resources-6 > > > - add AvoidStarImport > - add setterCanReturnItsClass for HiddenField > - drop MagicNumber > - add OneStatementPerLine > - add UnusedLocalVariable -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1408) Refresh IntelliJ formater
[ https://issues.apache.org/jira/browse/MSHARED-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1408. Resolution: Fixed > Refresh IntelliJ formater > - > > Key: MSHARED-1408 > URL: https://issues.apache.org/jira/browse/MSHARED-1408 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-resources >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-resources-6 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1408) Refresh IntelliJ formater
[ https://issues.apache.org/jira/browse/MSHARED-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853348#comment-17853348 ] ASF GitHub Bot commented on MSHARED-1408: - slawekjaranowski commented on code in PR #14: URL: https://github.com/apache/maven-shared-resources/pull/14#discussion_r1631997194 ## src/main/resources/config/maven-idea-codestyle-2022.xml: ## @@ -123,7 +131,7 @@ under the License. - + Review Comment: ok, as it is for developer as help only I will merge. In case of any feedback we will simply update it. > Refresh IntelliJ formater > - > > Key: MSHARED-1408 > URL: https://issues.apache.org/jira/browse/MSHARED-1408 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-resources >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-resources-6 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1408) Refresh IntelliJ formater
[ https://issues.apache.org/jira/browse/MSHARED-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853347#comment-17853347 ] ASF GitHub Bot commented on MSHARED-1408: - slawekjaranowski merged PR #14: URL: https://github.com/apache/maven-shared-resources/pull/14 > Refresh IntelliJ formater > - > > Key: MSHARED-1408 > URL: https://issues.apache.org/jira/browse/MSHARED-1408 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-resources >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-resources-6 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853345#comment-17853345
]
ASF GitHub Bot commented on MDEP-939:
-
slawekjaranowski commented on PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#issuecomment-2155881459
Looks ok - even more `classifier` parameter disappears from plugin
documentation
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853342#comment-17853342
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2155868626
@gnodet @cstamas Probably I found a reason of missing `central` repo on list.
https://issues.apache.org/jira/browse/MNG-4645 - we drop central repo from
default super pom - so model doesn't have it
Next when list of repositories for project are build in method:
`org.apache.maven.project.DefaultProjectBuildingHelper#createArtifactRepositories`
mirror repositories with the same ID are skipped so we lost info about
`mirroredRepositories`
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * list-repositories/pom.xml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-381) MPMD-323-ruleset-basedir-jgitver is broken or flaky on JDK 17 windows
[
https://issues.apache.org/jira/browse/MPMD-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853295#comment-17853295
]
Michael Osipov commented on MPMD-381:
-
That is likely related to the drive letter being uppercase and lowercase.
> MPMD-323-ruleset-basedir-jgitver is broken or flaky on JDK 17 windows
> -
>
> Key: MPMD-381
> URL: https://issues.apache.org/jira/browse/MPMD-381
> Project: Maven PMD Plugin
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> {noformat}
> Error: 'other' has different root
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Running post-build script:
> D:\a\maven-pmd-plugin\maven-pmd-plugin\target\it\MPMD-323-ruleset-basedir-jgitver\verify.groovy
> Assertion failed:
> assert pmdXml.exists()
>| |
>| false
>
> D:\a\maven-pmd-plugin\maven-pmd-plugin\target\it\MPMD-323-ruleset-basedir-jgitver\target\pmd.xml
> at
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:436)
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
> at Script1.run(Script1.groovy:21)
> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:427)
> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:461)
> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:436)
> at
> org.apache.maven.shared.scriptinterpreter.GroovyScriptInterpreter.evaluateScript(GroovyScriptInterpreter.java:76)
> at
> org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:236)
> at
> org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:161)
> at
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runPostBuildHook(AbstractInvokerMojo.java:2154)
> at
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:2129)
> at
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1721)
> at
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.lambda$runBuilds$4(AbstractInvokerMojo.java:1431)
> at
> org.apache.maven.plugins.invoker.JobExecutor.lambda$null$1(JobExecutor.java:69)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> *** end build.log for: MPMD-323-ruleset-basedir-jgitver\pom.xml ***
> Error: -
> Error:
> [INFO] -
> [INFO] Build Summary:
> [INFO] Passed: 44, Failed: 1, Errors: 0, Skipped: 4
> [INFO] -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-528) Tone done report plugin console output
[
https://issues.apache.org/jira/browse/MPLUGIN-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853294#comment-17853294
]
Michael Osipov commented on MPLUGIN-528:
[~cstamas], [~hboutemy]
> Tone done report plugin console output
> --
>
> Key: MPLUGIN-528
> URL: https://issues.apache.org/jira/browse/MPLUGIN-528
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Reporting Plugin
>Affects Versions: 3.12.0, 3.13.1
>Reporter: Michael Osipov
>Priority: Major
>
> The report plugin writes too much at {{INFO}} level:
> {noformat}
> [WARNING] ^
> [INFO] Generating "Plugin Documentation" report ---
> maven-plugin-report-plugin:3.12.0:report
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> (1.4 kB at 20 kB/s)
> Downloaded from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> (862 B at 3.4 kB/s)
> [INFO] Detecting plugin requirements history for range [0,): 36 releases,
> from 2.0-alpha-2 to 3.22.0
> [INFO] - RequirementsHistory{version='3.22.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.21.2', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.21.0', maven='3.2.5', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.20.0/maven-pmd-plugin-3.20.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.20.0/maven-pmd-plugin-3.20.0.pom
> (15 kB at 363 kB/s)
> [INFO] - RequirementsHistory{version='3.20.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.19.0', maven='3.2.5', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.18.0/maven-pmd-plugin-3.18.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.18.0/maven-pmd-plugin-3.18.0.pom
> (15 kB at 392 kB/s)
> [INFO] - RequirementsHistory{version='3.18.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.17.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.16.0', maven='3.1.1', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.15.0/maven-pmd-plugin-3.15.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.15.0/maven-pmd-plugin-3.15.0.pom
> (14 kB at 313 kB/s)
> [INFO] - RequirementsHistory{version='3.15.0', maven='3.1.0', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0.pom
> (13 kB at 371 kB/s)
> [INFO] - RequirementsHistory{version='3.14.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.13.0/maven-pmd-plugin-3.13.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.13.0/maven-pmd-plugin-3.13.0.pom
> (12 kB at 213 kB/s)
> [INFO] - RequirementsHistory{version='3.13.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.12.0/maven-pmd-plugin-3.12.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.12.0/maven-pmd-plugin-3.12.0.pom
> (12 kB at 374 kB/s)
> [INFO] - RequirementsHistory{version='3.12.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.11.0/maven-pmd-plugin-3.11.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.11.0/maven-pmd-plugin-3.11.0.pom
> (13 kB at 341 kB/s)
> [INFO] - RequirementsHistory{version='3.11.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://re
[jira] [Created] (MPLUGIN-528) Tone done report plugin console output
Michael Osipov created MPLUGIN-528:
--
Summary: Tone done report plugin console output
Key: MPLUGIN-528
URL: https://issues.apache.org/jira/browse/MPLUGIN-528
Project: Maven Plugin Tools
Issue Type: Task
Components: Plugin Reporting Plugin
Affects Versions: 3.13.1
Reporter: Michael Osipov
The report plugin writes too much at {{INFO}} level:
{noformat}
[WARNING] ^
[INFO] Generating "Plugin Documentation" report ---
maven-plugin-report-plugin:3.12.0:report
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
Downloading from apache.snapshots:
https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
(1.4 kB at 20 kB/s)
Downloaded from apache.snapshots:
https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
(862 B at 3.4 kB/s)
[INFO] Detecting plugin requirements history for range [0,): 36 releases, from
2.0-alpha-2 to 3.22.0
[INFO] - RequirementsHistory{version='3.22.0', maven='3.2.5', jdk='8'}
[INFO] - RequirementsHistory{version='3.21.2', maven='3.2.5', jdk='8'}
[INFO] - RequirementsHistory{version='3.21.0', maven='3.2.5', jdk='8'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.20.0/maven-pmd-plugin-3.20.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.20.0/maven-pmd-plugin-3.20.0.pom
(15 kB at 363 kB/s)
[INFO] - RequirementsHistory{version='3.20.0', maven='3.2.5', jdk='8'}
[INFO] - RequirementsHistory{version='3.19.0', maven='3.2.5', jdk='8'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.18.0/maven-pmd-plugin-3.18.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.18.0/maven-pmd-plugin-3.18.0.pom
(15 kB at 392 kB/s)
[INFO] - RequirementsHistory{version='3.18.0', maven='3.2.5', jdk='8'}
[INFO] - RequirementsHistory{version='3.17.0', maven='3.2.5', jdk='8'}
[INFO] - RequirementsHistory{version='3.16.0', maven='3.1.1', jdk='8'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.15.0/maven-pmd-plugin-3.15.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.15.0/maven-pmd-plugin-3.15.0.pom
(14 kB at 313 kB/s)
[INFO] - RequirementsHistory{version='3.15.0', maven='3.1.0', jdk='8'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0.pom
(13 kB at 371 kB/s)
[INFO] - RequirementsHistory{version='3.14.0', maven='3.0', jdk='7'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.13.0/maven-pmd-plugin-3.13.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.13.0/maven-pmd-plugin-3.13.0.pom
(12 kB at 213 kB/s)
[INFO] - RequirementsHistory{version='3.13.0', maven='3.0', jdk='7'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.12.0/maven-pmd-plugin-3.12.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.12.0/maven-pmd-plugin-3.12.0.pom
(12 kB at 374 kB/s)
[INFO] - RequirementsHistory{version='3.12.0', maven='3.0', jdk='7'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.11.0/maven-pmd-plugin-3.11.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.11.0/maven-pmd-plugin-3.11.0.pom
(13 kB at 341 kB/s)
[INFO] - RequirementsHistory{version='3.11.0', maven='3.0', jdk='7'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.10.0/maven-pmd-plugin-3.10.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.10.0/maven-pmd-plugin-3.10.0.pom
(12 kB at 338 kB/s)
[INFO] - RequirementsHistory{version='3.10.0', maven='3.0', jdk='7'}
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.9.0/maven-pmd-plugin-3.9.0.pom
Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.9.0/maven-pmd-plugin-3.9.0.pom
(12 kB at 356 k
[jira] [Updated] (MPLUGIN-528) Tone done report plugin console output
[
https://issues.apache.org/jira/browse/MPLUGIN-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MPLUGIN-528:
---
Affects Version/s: 3.12.0
> Tone done report plugin console output
> --
>
> Key: MPLUGIN-528
> URL: https://issues.apache.org/jira/browse/MPLUGIN-528
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Reporting Plugin
>Affects Versions: 3.12.0, 3.13.1
>Reporter: Michael Osipov
>Priority: Major
>
> The report plugin writes too much at {{INFO}} level:
> {noformat}
> [WARNING] ^
> [INFO] Generating "Plugin Documentation" report ---
> maven-plugin-report-plugin:3.12.0:report
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> (1.4 kB at 20 kB/s)
> Downloaded from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-pmd-plugin/maven-metadata.xml
> (862 B at 3.4 kB/s)
> [INFO] Detecting plugin requirements history for range [0,): 36 releases,
> from 2.0-alpha-2 to 3.22.0
> [INFO] - RequirementsHistory{version='3.22.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.21.2', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.21.0', maven='3.2.5', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.20.0/maven-pmd-plugin-3.20.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.20.0/maven-pmd-plugin-3.20.0.pom
> (15 kB at 363 kB/s)
> [INFO] - RequirementsHistory{version='3.20.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.19.0', maven='3.2.5', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.18.0/maven-pmd-plugin-3.18.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.18.0/maven-pmd-plugin-3.18.0.pom
> (15 kB at 392 kB/s)
> [INFO] - RequirementsHistory{version='3.18.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.17.0', maven='3.2.5', jdk='8'}
> [INFO] - RequirementsHistory{version='3.16.0', maven='3.1.1', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.15.0/maven-pmd-plugin-3.15.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.15.0/maven-pmd-plugin-3.15.0.pom
> (14 kB at 313 kB/s)
> [INFO] - RequirementsHistory{version='3.15.0', maven='3.1.0', jdk='8'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0.pom
> (13 kB at 371 kB/s)
> [INFO] - RequirementsHistory{version='3.14.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.13.0/maven-pmd-plugin-3.13.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.13.0/maven-pmd-plugin-3.13.0.pom
> (12 kB at 213 kB/s)
> [INFO] - RequirementsHistory{version='3.13.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.12.0/maven-pmd-plugin-3.12.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.12.0/maven-pmd-plugin-3.12.0.pom
> (12 kB at 374 kB/s)
> [INFO] - RequirementsHistory{version='3.12.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.11.0/maven-pmd-plugin-3.11.0.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.11.0/maven-pmd-plugin-3.11.0.pom
> (13 kB at 341 kB/s)
> [INFO] - RequirementsHistory{version='3.11.0', maven='3.0', jdk='7'}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/
[jira] [Commented] (MDEP-939) Lock down classifier in dependency:sources goal
[
https://issues.apache.org/jira/browse/MDEP-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853292#comment-17853292
]
ASF GitHub Bot commented on MDEP-939:
-
michael-o commented on code in PR #409:
URL:
https://github.com/apache/maven-dependency-plugin/pull/409#discussion_r1631743763
##
src/it/projects/sources/test.properties:
##
@@ -16,3 +16,4 @@
# under the License.
outputFile = target/resolved.txt
+classifier = foo
Review Comment:
This may require a comment that it has no influence anymore...
> Lock down classifier in dependency:sources goal
> ---
>
> Key: MDEP-939
> URL: https://issues.apache.org/jira/browse/MDEP-939
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0
>
>
> At the moment the classifier in {{dependency:sources}} is only set to
> {{sources}} if nothing is passed from the user, but allowing passing
> contradicts the purpose of this goal. We should make this parameter read-only
> and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MDEP-939) Lock down classifier in dependency:sources goal
Michael Osipov created MDEP-939:
---
Summary: Lock down classifier in dependency:sources goal
Key: MDEP-939
URL: https://issues.apache.org/jira/browse/MDEP-939
Project: Maven Dependency Plugin
Issue Type: Improvement
Components: sources
Affects Versions: 3.6.1
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 3.7.0
At the moment the classifier in {{dependency:sources}} is only set to
{{sources}} if nothing is passed from the user, but allowing passing
contradicts the purpose of this goal. We should make this parameter read-only
and ignore any input to it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-796) Do not follow links for Java 12+
[
https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853289#comment-17853289
]
ASF GitHub Bot commented on MJAVADOC-796:
-
michael-o commented on PR #287:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/287#issuecomment-2155582625
See reasoning in JIRA issue and the linked one.
> Do not follow links for Java 12+
>
>
> Key: MJAVADOC-796
> URL: https://issues.apache.org/jira/browse/MJAVADOC-796
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> For years, we have been following redirects manually because {{javadoc}} was
> not able to. with Java 12 (JDK-8190312) is was implemented and our logic can
> be skipped when {{javadoc}} 12+ is used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-656) Following redirects breaks valid links
[ https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853286#comment-17853286 ] Michael Osipov commented on MJAVADOC-656: - I agree with your sentiment that a parameter will not really help. We need to duplicate the logic from the Javadoc tool for the time being. The tests in place for the redirect are pointless now because they rely on outbound resources and guess what, they have changed and don't send redirects anymore > Following redirects breaks valid links > -- > > Key: MJAVADOC-656 > URL: https://issues.apache.org/jira/browse/MJAVADOC-656 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.0.1, 3.2.0 >Reporter: Robert Važan >Priority: Minor > > Version 3.0.1 fixed #427 by following redirects. This feature unfortunately > breaks when HTTP server is configured as follows: > /apidocs/package-list -> 200 > /apidocs -> 301 /apidocs/com/example/package-summary.html > /apidocs/ -> 301 /apidocs/com/example/package-summary.html > /apidocs/com/example/package-summary.html -> 200 > Without following redirects (in version 3.0.0), the link is passed to javadoc > tool unchanged, the javadoc tool fetches /apidocs/package-list, and > everything works fine. Since 3.0.1, javadoc plugin follows one of the > redirects (/apidocs or /apidocs/), passes the package summary URL to javadoc > tool, which then fails like this: > [WARNING] javadoc: warning - Error fetching URL: > [https://example.com/apidocs/com/example/package-summary.html/] > And if you have failOnWarnings set to true, this will fail the whole build. > The solution is fairly simple. Construct the whole URL (.../package-list) and > follow redirects on that one. Then check whether the final destination ends > in /package-list, strip the /package-list suffix, and pass the result to the > javadoc tool. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-656) Following redirects breaks valid links
[ https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853285#comment-17853285 ] Michael Osipov commented on MJAVADOC-656: - First step: https://github.com/apache/maven-javadoc-plugin/pull/287 > Following redirects breaks valid links > -- > > Key: MJAVADOC-656 > URL: https://issues.apache.org/jira/browse/MJAVADOC-656 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.0.1, 3.2.0 >Reporter: Robert Važan >Priority: Minor > > Version 3.0.1 fixed #427 by following redirects. This feature unfortunately > breaks when HTTP server is configured as follows: > /apidocs/package-list -> 200 > /apidocs -> 301 /apidocs/com/example/package-summary.html > /apidocs/ -> 301 /apidocs/com/example/package-summary.html > /apidocs/com/example/package-summary.html -> 200 > Without following redirects (in version 3.0.0), the link is passed to javadoc > tool unchanged, the javadoc tool fetches /apidocs/package-list, and > everything works fine. Since 3.0.1, javadoc plugin follows one of the > redirects (/apidocs or /apidocs/), passes the package summary URL to javadoc > tool, which then fails like this: > [WARNING] javadoc: warning - Error fetching URL: > [https://example.com/apidocs/com/example/package-summary.html/] > And if you have failOnWarnings set to true, this will fail the whole build. > The solution is fairly simple. Construct the whole URL (.../package-list) and > follow redirects on that one. Then check whether the final destination ends > in /package-list, strip the /package-list suffix, and pass the result to the > javadoc tool. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-895) dependency:sources fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MDEP-895:
Fix Version/s: (was: 3.7.0)
> dependency:sources fails for multi-module project
> -
>
> Key: MDEP-895
> URL: https://issues.apache.org/jira/browse/MDEP-895
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing `mvn dependency:sources` on a multi-module project it fails to
> retrieve sources for the modules themselves (which is not necessary as the
> source code is provided locally already):
> {code:java}
> mvn dependency:sources
> ...
> [INFO] -< org.apache.maven.its.dependency:tree-multimodule-module-b
> >--
> [INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT
> [3/3]
> [INFO] from module-b/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
>
> [INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
> [INFO]
> [INFO] MultimoduleTest SUCCESS [ 0.390
> s]
> [INFO] MultimoduleTest Module A ... SUCCESS [ 0.063
> s]
> [INFO] MultimoduleTest Module B ... FAILURE [ 0.005
> s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.587 s
> [INFO] Finished at: 2023-11-09T10:38:16+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project tree-multimodule-module-b: Could
> not resolve dependencies for project
> org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT:
> The following artifacts could not be resolved:
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT
> (absent): Could not find artifact
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409.
> A test and PR is already prepared:
> https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-895) dependency:sources fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853284#comment-17853284
]
ASF GitHub Bot commented on MDEP-895:
-
michael-o commented on PR #349:
URL:
https://github.com/apache/maven-dependency-plugin/pull/349#issuecomment-212938
This PR will be reverted with #408.
> dependency:sources fails for multi-module project
> -
>
> Key: MDEP-895
> URL: https://issues.apache.org/jira/browse/MDEP-895
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing `mvn dependency:sources` on a multi-module project it fails to
> retrieve sources for the modules themselves (which is not necessary as the
> source code is provided locally already):
> {code:java}
> mvn dependency:sources
> ...
> [INFO] -< org.apache.maven.its.dependency:tree-multimodule-module-b
> >--
> [INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT
> [3/3]
> [INFO] from module-b/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
>
> [INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
> [INFO]
> [INFO] MultimoduleTest SUCCESS [ 0.390
> s]
> [INFO] MultimoduleTest Module A ... SUCCESS [ 0.063
> s]
> [INFO] MultimoduleTest Module B ... FAILURE [ 0.005
> s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.587 s
> [INFO] Finished at: 2023-11-09T10:38:16+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project tree-multimodule-module-b: Could
> not resolve dependencies for project
> org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT:
> The following artifacts could not be resolved:
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT
> (absent): Could not find artifact
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409.
> A test and PR is already prepared:
> https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (MDEP-895) dependency:sources fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reopened MDEP-895:
-
The applied change changes the semantics and contradicts the actual {{resolve}}
operation. The goal is poorly named. It should have been {{resolve-sources}}.
We will deprecate this one and create successor.
> dependency:sources fails for multi-module project
> -
>
> Key: MDEP-895
> URL: https://issues.apache.org/jira/browse/MDEP-895
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: sources
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 3.7.0
>
>
> When executing `mvn dependency:sources` on a multi-module project it fails to
> retrieve sources for the modules themselves (which is not necessary as the
> source code is provided locally already):
> {code:java}
> mvn dependency:sources
> ...
> [INFO] -< org.apache.maven.its.dependency:tree-multimodule-module-b
> >--
> [INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT
> [3/3]
> [INFO] from module-b/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
>
> [INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
> [INFO]
> [INFO] MultimoduleTest SUCCESS [ 0.390
> s]
> [INFO] MultimoduleTest Module A ... SUCCESS [ 0.063
> s]
> [INFO] MultimoduleTest Module B ... FAILURE [ 0.005
> s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.587 s
> [INFO] Finished at: 2023-11-09T10:38:16+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project tree-multimodule-module-b: Could
> not resolve dependencies for project
> org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT:
> The following artifacts could not be resolved:
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT
> (absent): Could not find artifact
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409.
> A test and PR is already prepared:
> https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-900) dependency:resolve fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853282#comment-17853282
]
Michael Osipov commented on MDEP-900:
-
For now, this is by design. See PR for reasons.
> dependency:resolve fails for multi-module project
> -
>
> Key: MDEP-900
> URL: https://issues.apache.org/jira/browse/MDEP-900
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: resolve
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing {{mvn dependency:resolve}} on a multi-module project it fails
> to retrieve artifacts for the modules themselves (which is not necessary as
> these can be installed by {{mvn install}} any time).
> This can be seen on an [OSS multi-module
> project|https://github.com/WASdev/sample.daytrader7]:
> {code:java}
> mvn dependency:resolve
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> [jar]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> [war]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample
> [pom]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR
> [ear]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> 1.0-SNAPSHOT [1/4]
> [INFO] from daytrader-ee7-ejb/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
> [INFO]
> [INFO] The following files have been resolved:
> [INFO] javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
> [INFO] com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail
> (auto)
> [INFO] javax.activation:activation:jar:1.1:provided -- module activation
> (auto)
> [INFO] javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module
> java.annotation [auto]
> [INFO]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> 1.0-SNAPSHOT [2/4]
> [INFO] from daytrader-ee7-web/pom.xml
> [INFO] [ war
> ]-
> [INFO]
>
> [INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample
> 1.0-SNAPSHOT:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [
> 0.402 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [
> 0.012 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.552 s
> [INFO] Finished at: 2023-11-14T12:37:02+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project daytrader-ee7-web: Could not
> resolve dependencies for project
> net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following
> artifacts could not be resolved:
> net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not
> find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409, and MDEP-895
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-900) dependency:resolve fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853281#comment-17853281
]
ASF GitHub Bot commented on MDEP-900:
-
michael-o commented on PR #406:
URL:
https://github.com/apache/maven-dependency-plugin/pull/406#issuecomment-2155545377
Revert is here: #408
> dependency:resolve fails for multi-module project
> -
>
> Key: MDEP-900
> URL: https://issues.apache.org/jira/browse/MDEP-900
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: resolve
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 3.7.0
>
>
> When executing {{mvn dependency:resolve}} on a multi-module project it fails
> to retrieve artifacts for the modules themselves (which is not necessary as
> these can be installed by {{mvn install}} any time).
> This can be seen on an [OSS multi-module
> project|https://github.com/WASdev/sample.daytrader7]:
> {code:java}
> mvn dependency:resolve
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> [jar]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> [war]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample
> [pom]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR
> [ear]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> 1.0-SNAPSHOT [1/4]
> [INFO] from daytrader-ee7-ejb/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
> [INFO]
> [INFO] The following files have been resolved:
> [INFO] javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
> [INFO] com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail
> (auto)
> [INFO] javax.activation:activation:jar:1.1:provided -- module activation
> (auto)
> [INFO] javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module
> java.annotation [auto]
> [INFO]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> 1.0-SNAPSHOT [2/4]
> [INFO] from daytrader-ee7-web/pom.xml
> [INFO] [ war
> ]-
> [INFO]
>
> [INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample
> 1.0-SNAPSHOT:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [
> 0.402 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [
> 0.012 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.552 s
> [INFO] Finished at: 2023-11-14T12:37:02+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project daytrader-ee7-web: Could not
> resolve dependencies for project
> net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following
> artifacts could not be resolved:
> net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not
> find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409, and MDEP-895
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-900) dependency:resolve fails for multi-module project
[
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MDEP-900:
Fix Version/s: (was: 3.7.0)
> dependency:resolve fails for multi-module project
> -
>
> Key: MDEP-900
> URL: https://issues.apache.org/jira/browse/MDEP-900
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: resolve
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
>
> When executing {{mvn dependency:resolve}} on a multi-module project it fails
> to retrieve artifacts for the modules themselves (which is not necessary as
> these can be installed by {{mvn install}} any time).
> This can be seen on an [OSS multi-module
> project|https://github.com/WASdev/sample.daytrader7]:
> {code:java}
> mvn dependency:resolve
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> [jar]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> [war]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample
> [pom]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR
> [ear]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module
> 1.0-SNAPSHOT [1/4]
> [INFO] from daytrader-ee7-ejb/pom.xml
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
> [INFO]
> [INFO] The following files have been resolved:
> [INFO] javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
> [INFO] com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail
> (auto)
> [INFO] javax.activation:activation:jar:1.1:provided -- module activation
> (auto)
> [INFO] javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module
> java.annotation [auto]
> [INFO]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module
> 1.0-SNAPSHOT [2/4]
> [INFO] from daytrader-ee7-web/pom.xml
> [INFO] [ war
> ]-
> [INFO]
>
> [INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample
> 1.0-SNAPSHOT:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [
> 0.402 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [
> 0.012 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.552 s
> [INFO] Finished at: 2023-11-14T12:37:02+01:00
> [INFO]
>
> [ERROR] Failed to execute goal on project daytrader-ee7-web: Could not
> resolve dependencies for project
> net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following
> artifacts could not be resolved:
> net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not
> find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409, and MDEP-895
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSKINS-248) If $bodyContent is empty HTML code is distorted
[
https://issues.apache.org/jira/browse/MSKINS-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853280#comment-17853280
]
ASF GitHub Bot commented on MSKINS-248:
---
michael-o opened a new pull request, #61:
URL: https://github.com/apache/maven-fluido-skin/pull/61
This closes #61
> If $bodyContent is empty HTML code is distorted
> ---
>
> Key: MSKINS-248
> URL: https://issues.apache.org/jira/browse/MSKINS-248
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-2.0.0-M9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-2.0.0, fluido-2.0.0-M10
>
>
> If {{$bodyContent}} is empty HTML code is distorted because Velocity does not
> expand the variable, but leaves the literal {{$bodyContent}}. We need to
> check it with an {{#if}} clause.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSKINS-248) If $bodyContent is empty HTML code is distorted
Michael Osipov created MSKINS-248:
-
Summary: If $bodyContent is empty HTML code is distorted
Key: MSKINS-248
URL: https://issues.apache.org/jira/browse/MSKINS-248
Project: Maven Skins
Issue Type: Bug
Components: Fluido Skin
Affects Versions: fluido-2.0.0-M9
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: fluido-2.0.0-M10, fluido-2.0.0
If {{$bodyContent}} is empty HTML code is distorted because Velocity does not
expand the variable, but leaves the literal {{$bodyContent}}. We need to check
it with an {{#if}} clause.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853279#comment-17853279
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski merged PR #407:
URL: https://github.com/apache/maven-dependency-plugin/pull/407
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
