[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941977#comment-15941977
]
Vladimir Schneider commented on DOXIA-554:
--
Hervé, My pleasure and thank you for guiding this newbie through doxia
intricacies.
Let me know if any issues come up that need addressing.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
>Assignee: Hervé Boutemy
> Fix For: 1.8
>
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932021#comment-15932021
]
Vladimir Schneider commented on DOXIA-554:
--
Thank you Hervé. All fixed. PR generated.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930963#comment-15930963
]
Vladimir Schneider commented on DOXIA-554:
--
Modified tests and flexmark-java options to not output extra formatting EOLs,
closer to pegdown's unformatted output. Now all passing.
Next hurdle:
{code}
[INFO] --- clirr-maven-plugin:2.7:check (default) @ doxia-module-markdown ---
[INFO] Comparing to version: 1.7
[ERROR] Unable to locate enclosing class
org.apache.maven.doxia.module.markdown.MarkdownParser for nested class
org.apache.maven.doxia.module.markdown.MarkdownParser$PegDownHtmlParser
[ERROR] 8001:
org.apache.maven.doxia.module.markdown.MarkdownToDoxiaHtmlSerializer: Class
org.apache.maven.doxia.module.markdown.MarkdownToDoxiaHtmlSerializer removed
{code}
The MarkdownToDoxiaHtmlSerializer should have never been public in the original
markdown module. It is purely an implementation detail. I also left the
PegDownHtmlParser class name as is to avoid more errors, although it should be
named MarkdownHtmlParser to make it independent of the parsing library.
Is there something I am missing in the configuration to allow an API breaking
change to be allowed for the module?
The alternative of leaving the dead class and dependency on pegdown does not
seem like the right solution.
My fork was updated with the changes to date.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930839#comment-15930839
]
Vladimir Schneider commented on DOXIA-554:
--
Thanks Marc. I got NetBeans installed and it builds and debugs out of the box.
I can use it. The PITA is that there is no Markdown plugin for NetBeans 8.2 and
even if there was it is underpowered. Having it running on NetBeans, I got it
working on IntelliJ, so I can use my Markdown plugin to see the HTML that will
be generated by the test.
I am now doing comparison between doxia 1.7 with pegdown and 1.8 with flexmark
to see why there are differences because I cannot see where the differences
would be from generated HTML by old pegdown and flexmark-java.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930768#comment-15930768
]
Vladimir Schneider commented on DOXIA-554:
--
Sorry I was not clear about the build error. It is coming from command line
'mvn clean package' attempt. The same command line in the svn clone works.
I too find that IntelliJ maven builds are not out of the box and usually create
parallel intellij project and module configuration that lets me work with it.
However, in this case I cannot build it using the command line which stops me
from being able to do more.
I will try Netbeans.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930389#comment-15930389
]
Vladimir Schneider commented on DOXIA-554:
--
I can build maven-doxia 1.7 cloned from svn repository.
However, I am encountering build issue for maven-doxia trunk branch cloned from
GitHub. I am getting:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce
(enforce-bytecode-version) on project doxia: Execution enforce-bytecode-version
of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
NullPointerException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce
(enforce-bytecode-version) on project doxia: Execution enforce-bytecode-version
of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
enforce-bytecode-version of goal
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: java.lang.NullPointerException
at
org.apache.maven.plugins.enforcer.EnforceBytecodeVersion.isBadArtifact(EnforceBytecodeVersion.java:221)
at
org.apache.maven.plugins.enforcer.EnforceBytecodeVersion.checkDependencies(EnforceBytecodeVersion.java:206)
at
org.apache.maven.plugins.enforcer.EnforceBytecodeVersion.handleArtifacts(EnforceBytecodeVersion.java:132)
at
org.apache.maven.plugins.enforcer.AbstractResolveDependencies.execute(AbstractResolveDependencies.java:77)
at
org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:193)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
... 21 more
{code}
I can build doxia-module-markdown on its own in the GitHub cloned branch but I
need to be able to build its dependencies so I can debug the module under
IntelliJ IDEA. Any help would be appreciated.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to
[jira] [Comment Edited] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906320#comment-15906320
]
Vladimir Schneider edited comment on DOXIA-554 at 3/11/17 10:06 PM:
Thanks Marc. The plugin config change works. The license replaced with ASF 2.
I did not setup a copyright config in IntelliJ so when I copied the code over
from another project it left the copyright as is.
I now have the build and test running but need to figure out the rendered HTML
differences because the tests do not match what pegdown generated. Looking into
it now.
was (Author: vsch):
Thanks Marc. The plugin config change works. The license replaced with ASF 2.
I did not setup a copyright config in IntelliJ so when I copied the code over
from another project it left the copyright as is.
I am now have the build and test running but need to figure out the rendered
HTML differences because the tests do not match what pegdown generated. Looking
into it now.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906320#comment-15906320
]
Vladimir Schneider commented on DOXIA-554:
--
Thanks Marc. The plugin config change works. The license replaced with ASF 2.
I did not setup a copyright config in IntelliJ so when I copied the code over
from another project it left the copyright as is.
I am now have the build and test running but need to figure out the rendered
HTML differences because the tests do not match what pegdown generated. Looking
into it now.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902131#comment-15902131
]
Vladimir Schneider commented on DOXIA-554:
--
I spoke prematurely. Still getting the enforcer failing on byte code version:
{code}
[INFO]
[INFO] Building Doxia :: Markdown Module 1.8-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-bytecode-version) @
doxia-module-markdown ---
[INFO] Restricted to JDK 1.6 yet org.nibor.autolink:autolink:jar:0.6.0:compile
contains org/nibor/autolink/Autolink.class targeted to JDK 1.7
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion
failed with message:
Found Banned Dependency: org.nibor.autolink:autolink:jar:0.6.0
Use 'mvn dependency:tree' to locate the source of the banned dependencies.
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 1.101 s
[INFO] Finished at: 2017-03-08T17:52:41-05:00
[INFO] Final Memory: 23M/464M
[INFO]
{code}
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896513#comment-15896513
]
Vladimir Schneider commented on DOXIA-554:
--
You can get the changes from https://github.com/vsch/maven-doxia where I
modified the doxia-module-markdown for flexmark-java parser.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896503#comment-15896503
]
Vladimir Schneider edited comment on DOXIA-554 at 3/5/17 7:37 PM:
--
I was referring to maven-doxia version. The pom.xml for maven-doxia has:
{noformat}
org.apache.maven.doxia
doxia
1.7
pom
{noformat}
Changing the JDK version for the module is not a problem. I dont know
how to direct the PR towards the right maven-doxia version since GitHub mirror
only has the trunk version 1.7
The git://git.apache.org/maven-doxia.git is exactly the same as the GitHub repo.
BTW, the change of the Markdown module to flexmark-java, with Java language
level 1.7, is complete and passing tests. The only hitch is what version to
assign to it and figuring out where to commit the changes an generate a PR.
was (Author: vsch):
I was referring to maven-doxia version. The pom.xml for maven-doxia has:
{noformat}
org.apache.maven.doxia
doxia
1.7
pom
{noformat}
Changing the JDK version for the module is not a problem. I dont know
how to direct the PR towards the right maven-doxia version since GitHub mirror
only has the trunk version 1.7
The [git://git.apache.org/maven-doxia.git|git://git.apache.org/maven-doxia.git
is exactly the same as the GitHub repo.
BTW, the change of the Markdown module to flexmark-java, with Java language
level 1.7, is complete and passing tests. The only hitch is what version to
assign to it and figuring out where to commit the changes an generate a PR.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896503#comment-15896503
]
Vladimir Schneider commented on DOXIA-554:
--
I was referring to maven-doxia version. The pom.xml for maven-doxia has:
{noformat}
org.apache.maven.doxia
doxia
1.7
pom
{noformat}
Changing the JDK version for the module is not a problem. I dont know
how to direct the PR towards the right maven-doxia version since GitHub mirror
only has the trunk version 1.7
The [git://git.apache.org/maven-doxia.git|git://git.apache.org/maven-doxia.git
is exactly the same as the GitHub repo.
BTW, the change of the Markdown module to flexmark-java, with Java language
level 1.7, is complete and passing tests. The only hitch is what version to
assign to it and figuring out where to commit the changes an generate a PR.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896422#comment-15896422
]
Vladimir Schneider commented on DOXIA-554:
--
Where can I get information on getting the source code for developing a
doxia-module-markdown for a version other than 1.7
I forked the GitHub mirror https://github.com/vsch/maven-doxia which is version
1.7 only
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895981#comment-15895981
]
Vladimir Schneider commented on DOXIA-554:
--
Someone should tell Travis CI. I tried running a build with JDK6 and got:
"Sun/Oracle JDK 6 is EOL since November 2012, and is no longer supported.
Please consider upgrading..."
[https://travis-ci.org/vsch/flexmark-java/builds/207718667|https://travis-ci.org/vsch/flexmark-java/builds/207718667]
I'll wait.
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895878#comment-15895878
]
Vladimir Schneider commented on DOXIA-554:
--
I encountered a show stopper. Doxia requires Java6 compatibility and
flexmark-java requires Java7.
I converted the source to Java6 but BitSet in JDK7 is missing some BitSet
methods. Additionally, org.nibor.autolink used by the autolink extension is
byte code level 7 not 6.
The missing BitSet methods I can get around but the byte code level of the
autolink dependency would require rewriting the extension without the library.
Considering that JDK6 has reached EOL in 2012 is there a good reason why Doxia
is still requiring JDK6 compatibility?
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-553) Replace pegdown due to deprecation and end of life notice
[
https://issues.apache.org/jira/browse/DOXIA-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895819#comment-15895819
]
Vladimir Schneider commented on DOXIA-553:
--
I encountered a show stopper. Doxia requires Java6 compatibility and
flexmark-java requires Java7.
I converted the source to Java6 but BitSet in JDK7 is missing some BitSet
methods. Additionally, org.nibor.autolink used by the autolink extension is
byte code level 7 not 6.
The missing BitSet methods I can get around but the byte code level of the
autolink dependency would require rewriting the extension without the library.
Considering that JDK6 has reached EOL in 2012 is there a good reason why Doxia
is still requiring JDK6 compatibility?
> Replace pegdown due to deprecation and end of life notice
> -
>
> Key: DOXIA-553
> URL: https://issues.apache.org/jira/browse/DOXIA-553
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
> Environment: maven plugin.
>Reporter: Marc Campbell
>
> On 2016.12.14, [{{sirthias/pegdown}}|https://github.com/sirthias/pegdown/]
> posted a deprecation notice that "pegdown has reached its end of life."
> The pegdown notice also gives reasons to consider
> [{{@vsch's}}|https://github.com/vsch]
> [{{flexmark-java}}|https://github.com/vsch/flexmark-java] as a replacement.
> See:
> https://github.com/sirthias/pegdown
> https://github.com/vsch/flexmark-java
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-554) Parsing time for Markdown documents can take very long and hang site generation
[
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888410#comment-15888410
]
Vladimir Schneider commented on DOXIA-554:
--
The issue with pegdown is more serious than that. The simplest pathological
case is consecutive [[[, each open bracket doubles
parsing time. 18 of these take 1.3 seconds to parse.
Parsing time is adversely affected by using typographic quotes extension with
unmatched quotes as you would encounter in languages that use an apostrophe.
I also ran across well formed markdown files from users that caused parsing
times over a minute and in some cases infinite loops.
These parsing issues were the reason I developed flexmark-java, a fork of
commonmark-java, to replace pegdown in my project.
I will work on a replacement for Markdown module that uses flexmark-java
instead of pegdown.
FYI, in flexmark-java pathological input of 100,000 [ parses in 68ms, 100,000 ]
in 57ms, 100,000 nested [ ] parse in 55ms. In commonmark-java pathological
input of 100,000 [ parses in 30ms, 100,000 ] in 30ms, 100,000 nested [ ] parse
in 43ms
> Parsing time for Markdown documents can take very long and hang site
> generation
> ---
>
> Key: DOXIA-554
> URL: https://issues.apache.org/jira/browse/DOXIA-554
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 1.7
>Reporter: Michael Benz
> Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological
> input runtime can even become exponential, which means that the parser either
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DOXIA-553) Replace pegdown due to deprecation and end of life notice
[
https://issues.apache.org/jira/browse/DOXIA-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888359#comment-15888359
]
Vladimir Schneider commented on DOXIA-553:
--
I am willing to provide a PR. I am setting up my dev environment now so I can
make the needed changes, test and generate a PR.
I migrated https://github.com/walokra/markdown-page-generator-plugin to
flexmark-java https://github.com/vsch/markdown-page-generator-plugin without
much trouble, since the library was developed as a replacement for pegdown in
my [IntelliJ plugin project|https://github.com/vsch/idea-multimarkdown]. I
don't expect any issues other than my lack of DOXIA and Maven plugin experience.
> Replace pegdown due to deprecation and end of life notice
> -
>
> Key: DOXIA-553
> URL: https://issues.apache.org/jira/browse/DOXIA-553
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
> Environment: maven plugin.
>Reporter: Marc Campbell
>
> On 2016.12.14, [{{sirthias/pegdown}}|https://github.com/sirthias/pegdown/]
> posted a deprecation notice that "pegdown has reached its end of life."
> The pegdown notice also gives reasons to consider
> [{{@vsch's}}|https://github.com/vsch]
> [{{flexmark-java}}|https://github.com/vsch/flexmark-java] as a replacement.
> See:
> https://github.com/sirthias/pegdown
> https://github.com/vsch/flexmark-java
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
