[PR] Remove hardcoded references to woodstox stax implementation [maven]
gnodet opened a new pull request, #1585: URL: https://github.com/apache/maven/pull/1585 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [2.x] Pre-release tidy-up [maven-mvnd]
cstamas opened a new pull request, #1011: URL: https://github.com/apache/maven-mvnd/pull/1011 Changes: * no source change * (build) expel all versions from child modules: they must be all top level depMgmt or pluginMgmt * (build) Top POM contains GAVs while child modules GA+scope. This tremendously simplifies maintenance. * (javadoc) fix Javadoc errors Updates: * use latest Maven 3.9.8-SNAPSHOT (TS locked version, controlled deploy by me) * AssertJ 3.26.0 * Takari Smart Builder 0.6.6 * Sisu 0.9.0.M3 * maven wrapper 3.3.2 w/ scripts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-classworlds from 2.7.0 to 2.8.0 [maven-plugin-tools]
gnodet merged PR #292: URL: https://github.com/apache/maven-plugin-tools/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.17 [maven-plugin-tools]
gnodet merged PR #294: URL: https://github.com/apache/maven-plugin-tools/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-plugin-tools]
gnodet merged PR #290: URL: https://github.com/apache/maven-plugin-tools/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet merged PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
belingueres commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1637256757
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
+"",
+"",
+sealedCellValue
+});
+
+JarVersionedRuntimes versionedRuntimes =
jarDetails.getVersionedRuntimes();
+Collection versionedRuntimeList =
+
versionedRuntimes.getVersionedRuntimeMap().values();
+
+// workaround to count the number of root content
entries
+Integer versionedNumEntries =
versionedRuntimeList.stream()
+.map(versionedRuntime ->
+versionedRuntime.getEntries().size())
+.reduce(0, Integer::sum);
+Integer rootContentNumEntries =
jarDetails.getNumEntries() - versionedNumEntries;
+
+// root content information row
+tableRow(hasSealed, new String[] {
+rootTag,
+"",
+rootContentNumEntries.toString(),
+String.valueOf(jarDetails.getNumClasses()),
+String.valueOf(jarDetails.getNumPackages()),
Review Comment:
classes, packages and jdkRevision in the JarData object belong to the root
content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
belingueres commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1637256426
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
+"",
+"",
+sealedCellValue
+});
+
+JarVersionedRuntimes versionedRuntimes =
jarDetails.getVersionedRuntimes();
+Collection versionedRuntimeList =
+
versionedRuntimes.getVersionedRuntimeMap().values();
+
+// workaround to count the number of root content
entries
Review Comment:
ok
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
+"",
+"",
+sealedCellValue
+});
+
+JarVersionedRuntimes versionedRuntimes =
jarDetails.getVersionedRuntimes();
+Collection versionedRuntimeList =
+
versionedRuntimes.getVersionedRuntimeMap().values();
+
+// workaround to count the number of root content
entries
+Integer versionedNumEntries =
versionedRuntimeList.stream()
+.map(versionedRuntime ->
+versionedRuntime.getEntries().size())
+.reduce(0, Integer::sum);
+Integer rootContentNumEntries =
jarDetails.getNumEntries() - versionedNumEntries;
+
+// root content information row
+tableRow(hasSealed, new String[] {
+rootTag,
+"",
+rootContentNumEntries.toString(),
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
belingueres commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1637256257
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
Review Comment:
I prefer to omit them, since the getNumClasses() and getNumPackages() are
already asociated to the root content. In addition, we cannot sum over the root
class/package names with the versioned class/package names because some of them
will be in more than one place, so putting a "total" in the first row seems
somewhat inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Remove checkstyle.violation.ignore [maven-parent]
slawekjaranowski merged PR #183: URL: https://github.com/apache/maven-parent/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove checkstyle.violation.ignore [maven-parent]
slawekjaranowski closed pull request #183: Remove checkstyle.violation.ignore URL: https://github.com/apache/maven-parent/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introduce property for maven-shared-resources version [maven-parent]
slawekjaranowski merged PR #182: URL: https://github.com/apache/maven-parent/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.6.1 to 3.7.0 [maven-apache-parent]
slawekjaranowski merged PR #231: URL: https://github.com/apache/maven-apache-parent/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre [maven]
gnodet merged PR #1582: URL: https://github.com/apache/maven/pull/1582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.17 [maven]
gnodet merged PR #1581: URL: https://github.com/apache/maven/pull/1581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Pre release tidy up [maven-mvnd]
cstamas opened a new pull request, #1010: URL: https://github.com/apache/maven-mvnd/pull/1010 Changes: * no source changes * (build) expel all versions from child modules: they must be all top level depMgmt or pluginMgmt * (build) Top POM contains GAVs while child modules GA+scope. This tremendously simplifies maintenance. * (javadoc) fix Javadoc errors Updates: * use latest Maven 3.9.8-SNAPSHOT (TS locked version, controlled deploy by me) * AssertJ 3.26.0 * Takari Smart Builder 0.6.6 * Sisu 0.9.0.M3 This brings mvnd-1.x in "releasable" state (once Maven 3.9.8 is out). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] update plexus-utils to 4.0.0 [maven-project-info-reports-plugin]
michael-o commented on PR #59: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#issuecomment-2163607205 Both come from parent, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski merged PR #1584: URL: https://github.com/apache/maven/pull/1584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository - extends ITs [maven-integration-testing]
slawekjaranowski merged PR #349: URL: https://github.com/apache/maven-integration-testing/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47') [maven-surefire]
dejan2609 commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-2162863913 > Thanks for the update. Does this outdated PR still makes sense? @michael-o Makes sense to put this old-timer to rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47') [maven-surefire]
dejan2609 closed pull request #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47') URL: https://github.com/apache/maven-surefire/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Skip specified attached artifacts from deploy [maven-deploy-plugin]
michaelboyles commented on PR #3: URL: https://github.com/apache/maven-deploy-plugin/pull/3#issuecomment-2162794307 My use-case is that I generate a Spring Boot fat JAR with `spring-boot-maven-plugin:repackage`, then I ZIP that together with a bunch of scripts etc. with `maven-assembly-plugin:single` to create a final ZIP. The ZIP is the thing I want to deploy, and I don't want to deploy the Spring Boot JAR. I can skip attaching the fat JAR (the plugin supports `false`) but all that does is leave the original JAR attached from `maven-jar-plugin`. There is no configuration to not attach that, and even if there was, there's a good chance doing so would break the Spring Boot plugin. I just want a simple way to tell deploy-plugin, "don't deploy something". I don't want to go down a rabbit hole trying to stop stuff being attached in the first place. I could imagine a world where someone wants an artifact to be install-able but not deploy-able. In which case, not attaching the artifact is not a solution. @khmarbaise Can you please comment on this? You wanted a real-world use-case, and 5 people have now given you theirs. It's disappointing that a PR has been ready to go for 6 years and is still sitting here. I checked through it and it looks like a high-quality change. It has tests and updates to documentation. I'm happy to fix the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47') [maven-surefire]
michael-o commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-2162559364 > @michael-o I forgot to mark this PR as stalled. > > Back in May 2021 (time flies!) I left a [comment](https://issues.apache.org/jira/browse/SUREFIRE-1494?focusedCommentId=17341601=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17341601) on JIRA related ticket that my priorities are changed (and hence I am not able to dedicate time for this). Thanks for the update. Does this outdated PR still makes sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47') [maven-surefire]
dejan2609 commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-2162510914 @michael-o I forgot to mark this PR as stalled. Back in May 2021 (time flies!) I left a [comment](https://issues.apache.org/jira/browse/SUREFIRE-1494?focusedCommentId=17341601=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17341601) on JIRA related ticket that my priorities are changed (and hence I am not able to dedicate time for this). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-7758] Report dependency problems for all repository - extends ITs [maven-integration-testing]
slawekjaranowski opened a new pull request, #349: URL: https://github.com/apache/maven-integration-testing/pull/349 (cherry picked from commit aaf6d01bf23b0c739f0daf970307d61a39e5b276) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7194] Test missing property evaluation [maven]
cstamas commented on PR #1570: URL: https://github.com/apache/maven/pull/1570#issuecomment-2162366566 I agree with @pzygielo to have this at least "documented at source level"... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski merged PR #1563: URL: https://github.com/apache/maven/pull/1563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository - extends ITs [maven-integration-testing]
slawekjaranowski merged PR #348: URL: https://github.com/apache/maven-integration-testing/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on code in PR #1563: URL: https://github.com/apache/maven/pull/1563#discussion_r1635985392 ## maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java: ## @@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request) result.setCollectionErrors(e.getResult().getExceptions()); throw new DependencyResolutionException( -result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e); +result, +"Could not collect dependencies for project " + project.getId(), +logger.isDebugEnabled() ? e : null); Review Comment: we can think about it ... how to reporting a problems to user but it is another issue for me, now I did as simple as possible we also have many other UGLY code ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2162327141 I am fine with the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on code in PR #1563: URL: https://github.com/apache/maven/pull/1563#discussion_r1635977250 ## maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java: ## @@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request) result.setCollectionErrors(e.getResult().getExceptions()); throw new DependencyResolutionException( -result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e); +result, +"Could not collect dependencies for project " + project.getId(), +logger.isDebugEnabled() ? e : null); Review Comment: VERY UGLY. I guess this needs a long term solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on code in PR #1563: URL: https://github.com/apache/maven/pull/1563#discussion_r1635975507 ## maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java: ## @@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request) result.setCollectionErrors(e.getResult().getExceptions()); throw new DependencyResolutionException( -result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e); +result, +"Could not collect dependencies for project " + project.getId(), +logger.isDebugEnabled() ? e : null); Review Comment: I hope that simply message will be more readable for user, if user need more details for debug or investigation can execute in verbose/debug mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on code in PR #1563: URL: https://github.com/apache/maven/pull/1563#discussion_r1635970698 ## maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java: ## @@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request) result.setCollectionErrors(e.getResult().getExceptions()); throw new DependencyResolutionException( -result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e); +result, +"Could not collect dependencies for project " + project.getId(), +logger.isDebugEnabled() ? e : null); Review Comment: without passing exception (current proposition) we will have: ``` [ERROR] Failed to execute goal on project test: Could not resolve dependencies for project org.apache.maven.its.mng3477:test:jar:1 [ERROR] dependency: org.apache.maven.its.mng3477:dep:jar:1.0 (compile) [ERROR] Could not find artifact org.apache.maven.its.mng3477:dep:jar:1.0 in maven-core-it (http://localhost:64468/repo) [ERROR] Could not find artifact org.apache.maven.its.mng3477:dep:jar:1.0 in central (http://localhost:64468/repo) [ERROR] -> [Help 1] ``` with exception will be as: ``` [ERROR] Failed to execute goal on project test: Could not resolve dependencies for project org.apache.maven.its.mng3477:test:jar:1 [ERROR] dependency: org.apache.maven.its.mng3477:dep:jar:1.0 (compile) [ERROR] Could not find artifact org.apache.maven.its.mng3477:dep:jar:1.0 in central (http://localhost:64398/repo) [ERROR] Could not find artifact org.apache.maven.its.mng3477:dep:jar:1.0 in maven-core-it (http://localhost:64398/repo): The following artifacts could not be resolved: org.apache.maven.its.mng3477:dep:jar:1.0 (absent): Could not find artifact org.apache.maven.its.mng3477:dep:jar:1.0 in central (http://localhost:64398/repo) [ERROR] -> [Help 1] ``` so it is a reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on code in PR #1563: URL: https://github.com/apache/maven/pull/1563#discussion_r1635943726 ## maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java: ## @@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request) result.setCollectionErrors(e.getResult().getExceptions()); throw new DependencyResolutionException( -result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e); +result, +"Could not collect dependencies for project " + project.getId(), +logger.isDebugEnabled() ? e : null); Review Comment: Without it some of message will be duplicated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on code in PR #1563: URL: https://github.com/apache/maven/pull/1563#discussion_r1635919336 ## maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java: ## @@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request) result.setCollectionErrors(e.getResult().getExceptions()); throw new DependencyResolutionException( -result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e); +result, +"Could not collect dependencies for project " + project.getId(), +logger.isDebugEnabled() ? e : null); Review Comment: I still have trouble understanding that. Maybe the caller code needs to change or the message rendered by this exception needs to be improved... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
michael-o commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1635907183
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
+"",
+"",
+sealedCellValue
+});
+
+JarVersionedRuntimes versionedRuntimes =
jarDetails.getVersionedRuntimes();
+Collection versionedRuntimeList =
+
versionedRuntimes.getVersionedRuntimeMap().values();
+
+// workaround to count the number of root content
entries
Review Comment:
Please add the ticket ref for MSHARED here.
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
+"",
+"",
+sealedCellValue
+});
+
+JarVersionedRuntimes versionedRuntimes =
jarDetails.getVersionedRuntimes();
+Collection versionedRuntimeList =
+
versionedRuntimes.getVersionedRuntimeMap().values();
+
+// workaround to count the number of root content
entries
+Integer versionedNumEntries =
versionedRuntimeList.stream()
+.map(versionedRuntime ->
+versionedRuntime.getEntries().size())
+.reduce(0, Integer::sum);
+Integer rootContentNumEntries =
jarDetails.getNumEntries() - versionedNumEntries;
+
+// root content information row
+tableRow(hasSealed, new String[] {
+rootTag,
+"",
+rootContentNumEntries.toString(),
Review Comment:
Make is `String#valueOf()` for consistency reasons
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
michael-o commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1635906351
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
-tableRow(hasSealed, new String[] {
-name,
-fileLength,
-String.valueOf(jarDetails.getNumEntries()),
-String.valueOf(jarDetails.getNumClasses()),
-String.valueOf(jarDetails.getNumPackages()),
-jdkRevisionCellValue,
-debugInformationCellValue,
-sealedCellValue
-});
+if (jarDetails.isMultiRelease()) {
+String htmlBullet = " ";
+String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+// general jar information row
+tableRow(hasSealed, new String[] {
+name,
+fileLength,
+String.valueOf(jarDetails.getNumEntries()),
+"",
+"",
Review Comment:
Does it make sense to omit num of classes/packages here? What do you think?
Hard to tell...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-8150] Remove unused locale argument from FileSizeFormat [maven]
pshevche commented on PR #1579: URL: https://github.com/apache/maven/pull/1579#issuecomment-2162232319 > @pshevche can you resolve the conflicts please? Thanks Thank you for taking care of it, @cstamas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.inject:guice from 6.0.0 to 7.0.0 [maven]
dependabot[bot] commented on PR #1528: URL: https://github.com/apache/maven/pull/1528#issuecomment-2162196806 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.inject:guice from 6.0.0 to 7.0.0 [maven]
gnodet closed pull request #1528: Bump com.google.inject:guice from 6.0.0 to 7.0.0 URL: https://github.com/apache/maven/pull/1528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature custom plugin configuration [maven]
rmannibucau commented on PR #1580: URL: https://github.com/apache/maven/pull/1580#issuecomment-2162162984 Hi, I'm not sure I link the description to the code: * code enables profiles as `-P` today but introducing yet another flag and tests are unrelated to that feature :thinking: * you can already have multiple plugin configurations either with profiles/properties or with executions if you need it in the same build Can you provide a test showing the behavior you want please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.6.1 to 3.7.0 [maven-apache-parent]
dependabot[bot] opened a new pull request, #231: URL: https://github.com/apache/maven-apache-parent/pull/231 Bumps [org.apache.maven.plugins:maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.6.1 to 3.7.0. Release notes Sourced from https://github.com/apache/maven-dependency-plugin/releases;>org.apache.maven.plugins:maven-dependency-plugin's releases. 3.7.0 https://issues.apache.org/jira/browse/MDEP-941;>[MDEP-941] - Deprecate dependency:sources in favor of dependency:resolv… (https://redirect.github.com/apache/maven-dependency-plugin/pull/411;>#411) https://github.com/michael-o;>@michael-o https://issues.apache.org/jira/browse/MDEP-838;>[MDEP-838] - Artifact has not been packaged yet error message is not … (https://redirect.github.com/apache/maven-dependency-plugin/pull/412;>#412) https://github.com/michael-o;>@michael-o https://issues.apache.org/jira/browse/MDEP-939;>[MDEP-939] - Lock down classifier in dependency:sources goal (https://redirect.github.com/apache/maven-dependency-plugin/pull/409;>#409) https://github.com/michael-o;>@michael-o Revert Fix sources goal for multimodule projects (https://redirect.github.com/apache/maven-dependency-plugin/pull/408;>#408) https://github.com/michael-o;>@michael-o https://issues.apache.org/jira/browse/MDEP-923;>[MDEP-923] - Move methods in place where are used (https://redirect.github.com/apache/maven-dependency-plugin/pull/407;>#407) https://github.com/slawekjaranowski;>@slawekjaranowski MDEP-938] Correct invalid property name and add deprecated old one (https://redirect.github.com/apache/maven-dependency-plugin/pull/404;>#404) https://github.com/hazendaz;>@hazendaz https://issues.apache.org/jira/browse/MDEP-835;>[MDEP-835] - Add optional dependency for tree IT (https://redirect.github.com/apache/maven-dependency-plugin/pull/403;>#403) https://github.com/slawekjaranowski;>@slawekjaranowski Add missing dependency (https://redirect.github.com/apache/maven-dependency-plugin/pull/401;>#401) https://github.com/michael-o;>@michael-o New features and improvements https://issues.apache.org/jira/browse/MDEP-799;>[MDEP-799] - tree: add optional output type json (https://redirect.github.com/apache/maven-dependency-plugin/pull/391;>#391) https://github.com/LogFlames;>@LogFlames https://issues.apache.org/jira/browse/MDEP-928;>[MDEP-928] - Allow excluding classes from dependency:analyze (https://redirect.github.com/apache/maven-dependency-plugin/pull/393;>#393) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MDEP-924;>[MDEP-924] - Get rid of maven-artifact-transfer from list-classes goal (https://redirect.github.com/apache/maven-dependency-plugin/pull/382;>#382) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MDEP-925;>[MDEP-925] - Require Maven 3.6.3 (https://redirect.github.com/apache/maven-dependency-plugin/pull/381;>#381) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MDEP-922;>[MDEP-922] - dependency:analyze-exclusions - should report issue only in current project (https://redirect.github.com/apache/maven-dependency-plugin/pull/378;>#378) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MDEP-917;>[MDEP-917] - dependency:analyze-exclusions - use Resolver API instead of ProjectBuilder (https://redirect.github.com/apache/maven-dependency-plugin/pull/374;>#374) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MDEP-317;>[MDEP-317] - add mojo to analyze invalid exclusions (https://redirect.github.com/apache/maven-dependency-plugin/pull/362;>#362) https://github.com/vbreivik;>@vbreivik https://issues.apache.org/jira/browse/MDEP-894;>[MDEP-894] - Use @Component only - fix tests (https://redirect.github.com/apache/maven-dependency-plugin/pull/360;>#360) https://github.com/michael-o;>@michael-o Bug Fixes https://issues.apache.org/jira/browse/MDEP-914;>[MDEP-914] - Fix link in collect goal description (https://redirect.github.com/apache/maven-dependency-plugin/pull/380;>#380) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MDEP-895;>[MDEP-895] - dependency:sources fails for multi-module project (https://redirect.github.com/apache/maven-dependency-plugin/pull/349;>#349) https://github.com/jmle;>@jmle https://issues.apache.org/jira/browse/MDEP-771;>[MDEP-771] - Remove broken 404 link (https://redirect.github.com/apache/maven-dependency-plugin/pull/344;>#344) https://github.com/elharo;>@elharo Dependency updates https://issues.apache.org/jira/browse/MDEP-936;>[MDEP-936] - Bump org.apache.maven.shared:maven-dependency-tree from 3.2.1 to 3.3.0
[PR] Bump org.apache.maven.shared:maven-shared-resources from 5 to 6 [maven-parent]
dependabot[bot] opened a new pull request, #187: URL: https://github.com/apache/maven-parent/pull/187 Bumps [org.apache.maven.shared:maven-shared-resources](https://github.com/apache/maven-shared-resources) from 5 to 6. Release notes Sourced from https://github.com/apache/maven-shared-resources/releases;>org.apache.maven.shared:maven-shared-resources's releases. 6 New features and improvements https://issues.apache.org/jira/browse/MSHARED-1408;>[MSHARED-1408] - Refresh IntelliJ formater (https://redirect.github.com/apache/maven-shared-resources/pull/14;>#14) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1401;>[MSHARED-1401] - Checkstyle add UnusedLocalVariable (https://redirect.github.com/apache/maven-shared-resources/pull/23;>#23) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1401;>[MSHARED-1401] - Checkstyle add OneStatementPerLine (https://redirect.github.com/apache/maven-shared-resources/pull/22;>#22) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1401;>[MSHARED-1401] - Checkstyle drop MagicNumber (https://redirect.github.com/apache/maven-shared-resources/pull/21;>#21) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1401;>[MSHARED-1401] - Checkstyle add setterCanReturnItsClass for HiddenField (https://redirect.github.com/apache/maven-shared-resources/pull/20;>#20) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1401;>[MSHARED-1401] - Checkstyle add AvoidStarImport (https://redirect.github.com/apache/maven-shared-resources/pull/19;>#19) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1171;>[MSHARED-1171] - New IntelliJ code style formatter (https://redirect.github.com/apache/maven-shared-resources/pull/6;>#6) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates https://issues.apache.org/jira/browse/MSHARED-1170;>[MSHARED-1170] - Bump org.apache.maven.shared:maven-shared-components from 41 to 42 (https://redirect.github.com/apache/maven-shared-resources/pull/13;>#13) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/apache/maven-shared-resources/pull/12;>#12) https://github.com/dependabot;>@dependabot Maintenance https://issues.apache.org/jira/browse/MSHARED-1401;>[MSHARED-1401] - Fix links in checkstyle configs (https://redirect.github.com/apache/maven-shared-resources/pull/18;>#18) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1409;>[MSHARED-1409] - Fix site links (https://redirect.github.com/apache/maven-shared-resources/pull/15;>#15) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1353;>[MSHARED-1353] - Update parent pom to 41 (https://redirect.github.com/apache/maven-shared-resources/pull/11;>#11) https://github.com/slachiewicz;>@slachiewicz Add GHA setup for Dependabot and CI build (https://redirect.github.com/apache/maven-shared-resources/pull/7;>#7) https://github.com/slachiewicz;>@slachiewicz Build Use only linux with build matrix (https://redirect.github.com/apache/maven-shared-resources/pull/17;>#17) https://github.com/slawekjaranowski;>@slawekjaranowski Add Release Drafter (https://redirect.github.com/apache/maven-shared-resources/pull/16;>#16) https://github.com/slawekjaranowski;>@slawekjaranowski Commits See full diff in https://github.com/apache/maven-shared-resources/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
[PR] Bump org.apache.maven.plugins:maven-pmd-plugin from 3.22.0 to 3.23.0 [maven-parent]
dependabot[bot] opened a new pull request, #186: URL: https://github.com/apache/maven-parent/pull/186 Bumps [org.apache.maven.plugins:maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.22.0 to 3.23.0. Commits https://github.com/apache/maven-pmd-plugin/commit/570fe170f5164b501add74e9f556250a5f2ea435;>570fe17 [maven-release-plugin] prepare release maven-pmd-plugin-3.23.0 https://github.com/apache/maven-pmd-plugin/commit/872fcd87d292abe9a28774201840651f98233142;>872fcd8 [MPMD-397] Upgrade to Maven 3.6.3 https://github.com/apache/maven-pmd-plugin/commit/76f7e114a8ac92898c0307daac8dea6a44a149bb;>76f7e11 [MPMD-395] Build doesn't fail for invalid CPD format (https://redirect.github.com/apache/maven-pmd-plugin/issues/150;>#150) https://github.com/apache/maven-pmd-plugin/commit/c54170707cfd0aec4b5d9ee6083230f2551cdaa4;>c541707 Add test parameter which caused exception to be swallowed https://github.com/apache/maven-pmd-plugin/commit/4afad98d229a6764d2ebdd246c037d1645c7cbb9;>4afad98 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.22.0...maven-pmd-plugin-3.23.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.woodstox:stax2-api from 4.2.1 to 4.2.2 [maven]
dependabot[bot] opened a new pull request, #1583: URL: https://github.com/apache/maven/pull/1583 Bumps [org.codehaus.woodstox:stax2-api](https://github.com/FasterXML/stax2-api) from 4.2.1 to 4.2.2. Commits https://github.com/FasterXML/stax2-api/commit/6bd3896d64a0bab3321586edcbc85e2c21c8012d;>6bd3896 [maven-release-plugin] prepare release stax2-api-4.2.2 https://github.com/FasterXML/stax2-api/commit/f5dc0fa739ac0264e58210d7aaa7f2a4c9fbde08;>f5dc0fa Prepare for 4.2.2 release https://github.com/FasterXML/stax2-api/commit/5465338c77725d5dd6f3baebca316ead5cee4559;>5465338 Update oss-parent dep to 55 https://github.com/FasterXML/stax2-api/commit/6f17845d8e53738d2fb47d3f2087907f30d7c559;>6f17845 Merge pull request https://redirect.github.com/FasterXML/stax2-api/issues/23;>#23 from c-uhland/c-uhland-patch-1 https://github.com/FasterXML/stax2-api/commit/0de887e386583eb4643f56f5862c27fda8fdca84;>0de887e Update pom.xml https://github.com/FasterXML/stax2-api/commit/de18149cbab555fde79bc2563e6a60a44f903fea;>de18149 Merge pull request https://redirect.github.com/FasterXML/stax2-api/issues/21;>#21 from TheSoundOfScience/patch-1 https://github.com/FasterXML/stax2-api/commit/c9a354a8068210424162c6fa570d3ac94c62de1f;>c9a354a Fix project description https://github.com/FasterXML/stax2-api/commit/00bdbfb852cae1ae9d76fbccf935a53a8a2a85d6;>00bdbfb Merge branch 'master' of github.com:FasterXML/stax2-api https://github.com/FasterXML/stax2-api/commit/34efee8ce8c5fe2680f62709ee1298ef94be3398;>34efee8 Fix 1 warning by lgtm.com wrt not closing resource https://github.com/FasterXML/stax2-api/commit/1c5ec2f46eb76648b0694a2b1281b57323fa6e3c;>1c5ec2f Merge pull request https://redirect.github.com/FasterXML/stax2-api/issues/20;>#20 from dthadi3/ppc64le Additional commits viewable in https://github.com/FasterXML/stax2-api/compare/stax2-api-4.2.1...stax2-api-4.2.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre [maven]
dependabot[bot] opened a new pull request, #1582: URL: https://github.com/apache/maven/pull/1582 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.2.0-jre to 33.2.1-jre. Release notes Sourced from https://github.com/google/guava/releases;>com.google.guava:guava's releases. 33.2.1 dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version33.2.1-jre/version !-- or, for Android: -- version33.2.1-android/version /dependency Jar files https://repo1.maven.org/maven2/com/google/guava/guava/33.2.1-jre/guava-33.2.1-jre.jar;>33.2.1-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.2.1-android/guava-33.2.1-android.jar;>33.2.1-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies;>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar;>failureaccess-1.0.1.jar Javadoc https://guava.dev/releases/33.2.1-jre/api/docs/;>33.2.1-jre https://guava.dev/releases/33.2.1-android/api/docs/;>33.2.1-android JDiff https://guava.dev/releases/33.2.1-jre/api/diffs/;>33.2.1-jre vs. 33.2.0-jre https://guava.dev/releases/33.2.1-android/api/diffs/;>33.2.1-android vs. 33.2.0-android https://guava.dev/releases/33.2.1-android/api/androiddiffs/;>33.2.1-android vs. 33.2.1-jre Changelog net: Changed InetAddress-String conversion methods to preserve the IPv6 scope ID if present. The scope ID can be necessary for IPv6-capable devices with multiple network interfaces. However, preserving it can also lead to problems for callers that rely on the returned values not to include the scope ID: Callers might compensate for the old behavior of the methods by appending the scope ID to a returned string themselves. If so, you can update your code to stop doing so at the same time as you upgrade Guava. Of, if your code might run against multiple versions of Guava, you can check whether Guava has included a scope ID before you add one yourself. Callers might pass the returned string to another system that does not understand scope IDs. If so, you can strip the scope ID off, whether by truncating the string form at a % character (leaving behind any trailing ] character in the case of forUriString) or by replacing the returned InetAddress with a new instance constructed by calling InetAddress.getByAddress(addr). java.net.InetAddress validates any provided scope ID against the interfaces available on the machine. As a result, methods in InetAddresses may now fail if the scope ID fails validation. Notable cases in which this may happen include: if the code runs in an Android app without networking permission if code passes InetAddress instances or strings across devices If this is not the behavior that you want, then you can strip off the scope ID from the input string before passing it to Guava, as discussed above. (3f61870ac6) Commits See full diff in https://github.com/google/guava/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you
[PR] Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.17 [maven]
dependabot[bot] opened a new pull request, #1581: URL: https://github.com/apache/maven/pull/1581 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.14.15 to 1.14.17. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.14.17 Avoid crashing of Android plugin when there are duplicate files for licenses or license notices. Byte Buddy 1.14.16 Update ASM and introduce support for Java 23. Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>net.bytebuddy:byte-buddy's changelog. 29. May 2024: version 1.14.17 Avoid crashing of Android plugin when there are duplicate files for licenses or license notices. 22. May 2024: version 1.14.16 Update ASM and introduce support for Java 23. Commits https://github.com/raphw/byte-buddy/commit/bfd4c21cbc6f2cab1a0de8700125099fd96b857c;>bfd4c21 [maven-release-plugin] prepare release byte-buddy-1.14.17 https://github.com/raphw/byte-buddy/commit/d179f5f172f2a4c5ea3fd2bb2a2565012de0ab2f;>d179f5f [release] Release new version https://github.com/raphw/byte-buddy/commit/dd1f6d33ad4f112104207100f8728c47ca4e6218;>dd1f6d3 Update checksums https://github.com/raphw/byte-buddy/commit/32a500ef2d960f43d2f5950d0402d58043984083;>32a500e Ignoring duplicate non-class files (https://redirect.github.com/raphw/byte-buddy/issues/1654;>#1654) https://github.com/raphw/byte-buddy/commit/f277f6ff5eb96f7f647164ae607acd645777d580;>f277f6f Update internal Byte Buddy and add release notes. https://github.com/raphw/byte-buddy/commit/fb00710511427eb21c9749f7ce06ac72bd789e68;>fb00710 [maven-release-plugin] prepare for next development iteration https://github.com/raphw/byte-buddy/commit/8f37644d35fdb1478d0982995f9cee9f7e2a91ff;>8f37644 [maven-release-plugin] prepare release byte-buddy-1.14.16 https://github.com/raphw/byte-buddy/commit/9e62bad5a1535a7ab16275652eac81ee5597833f;>9e62bad [release] Release new version https://github.com/raphw/byte-buddy/commit/6dc6b2ee59071ea88dbf9c3bbe4bf7df7aa95a69;>6dc6b2e Add checksums and fix build configuration. https://github.com/raphw/byte-buddy/commit/840bab42306b5d074a9265511480d2388cec1d84;>840bab4 Add missing checksums Additional commits viewable in https://github.com/raphw/byte-buddy/compare/byte-buddy-1.14.15...byte-buddy-1.14.17;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.25.0 to 1.26.0 [maven-surefire]
SavantDISelect commented on PR #722: URL: https://github.com/apache/maven-surefire/pull/722#issuecomment-2161878115 @dependabot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Remove unused locale argument from FileSizeFormat [maven]
cstamas merged PR #1579: URL: https://github.com/apache/maven/pull/1579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Remove unused locale argument from FileSizeFormat [maven]
cstamas commented on PR #1579: URL: https://github.com/apache/maven/pull/1579#issuecomment-2161582867 @pshevche can you resolve the conflicts please? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
cstamas merged PR #1575: URL: https://github.com/apache/maven/pull/1575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Backport TransferListener improvements for Maven 3.9.x [maven]
cstamas merged PR #1576: URL: https://github.com/apache/maven/pull/1576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] New feature custom plugin configuration [maven]
yuehcw opened a new pull request, #1580: URL: https://github.com/apache/maven/pull/1580 **Introduction** This PR introduces the "Custom Plugin Configuration Profiles" feature, which enhances the flexibility and maintainability of plugin management in Maven projects. By enabling users to define multiple configurations for a single plugin within the POM file, this feature caters to different environments or use cases without duplicating the entire POM file. **Motivation** Current Maven configurations apply globally and statically to projects, lacking the flexibility needed for different build environments or specific use cases. This limitation makes it cumbersome to manage builds that require different configurations for the same project. **Changes Proposed** - Profiles Section: Addition of a new section in the POM file for defining custom plugin configurations. - Profile Activation: Implementation of a mechanism to activate profiles based on conditions such as environment variables or system properties. This allows for dynamic configuration changes at build time without altering the POM structure for different scenarios. **Detailed Design** 1. POM File Changes: Introduce a section within the POM file. Each profile will have a unique ID and specified activation conditions. 2. Activation Mechanism: Users can activate a profile using the Maven command line, for example: mvn clean install -Denv=dev. **Benefits** - Flexibility: Enables tailored plugin configurations for different environments directly within the POM file. - Maintainability: Reduces complexity and enhances clarity by isolating environment-specific configurations. - Backward Compatibility: Ensures existing projects remain unaffected. Profiles are optional and only processed if defined. **Compatibility** This feature is designed to be backward compatible. Existing projects without defined profiles will operate as usual without any modification to their current behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-component-annotations from 2.1.0 to 2.2.0 [maven-surefire]
asfgit merged PR #747: URL: https://github.com/apache/maven-surefire/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-component-annotations from 2.1.0 to 2.2.0 [maven-surefire]
michael-o commented on PR #747: URL: https://github.com/apache/maven-surefire/pull/747#issuecomment-2161491398 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.25 to 1.27 [maven-surefire]
asfgit merged PR #748: URL: https://github.com/apache/maven-surefire/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.25 to 1.27 [maven-surefire]
michael-o commented on PR #748: URL: https://github.com/apache/maven-surefire/pull/748#issuecomment-2161489813 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2232] StatelessXmlReporter: handle failed test result without a throwable [maven-surefire]
asfgit closed pull request #716: [SUREFIRE-2232] StatelessXmlReporter: handle failed test result without a throwable URL: https://github.com/apache/maven-surefire/pull/716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2232] StatelessXmlReporter: handle failed test result without a throwable [maven-surefire]
dr29bart commented on PR #716: URL: https://github.com/apache/maven-surefire/pull/716#issuecomment-2161484463 > For me, this is fine now. Are you OK as well? yes, I am OK to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2232] StatelessXmlReporter: handle failed test result without a throwable [maven-surefire]
michael-o commented on code in PR #716:
URL: https://github.com/apache/maven-surefire/pull/716#discussion_r1635380077
##
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java:
##
@@ -522,6 +522,23 @@ public void testSyncOnDeferredFile() throws Exception {
assertThat((boolean) getInternalState(out, "closed")).isTrue();
}
+public void testReporterHandlesATestWithoutMessageAndWithEmptyStackTrace()
{
+StackTraceWriter stackTraceWriterOne = new
DeserializedStacktraceWriter(null, null, "");
+
+WrappedReportEntry testReport = new WrappedReportEntry(
+new SimpleReportEntry(
+NORMAL_RUN, 1L, getClass().getName(), null, "a test
name", null, stackTraceWriterOne, 5),
+ERROR,
+5,
+null,
+null);
+
+StatelessXmlReporter reporter = new StatelessXmlReporter(
+reportDir, null, false, 1, new HashMap<>(), XSD, "3.0", false,
false, false, false);
Review Comment:
This needs to be updated to 3.0.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPMD-399] Incorrect warning: The project X does not seem to be compi… [maven-pmd-plugin]
adangel commented on code in PR #154:
URL: https://github.com/apache/maven-pmd-plugin/pull/154#discussion_r1635338206
##
src/main/java/org/apache/maven/plugins/pmd/PmdReport.java:
##
@@ -513,23 +513,11 @@ private String determineAuxClasspath() throws
MavenReportException {
resolvedArtifact.getArtifact().getFile().toString());
}
-List projectClasspath = includeTests
-? localProject.getTestClasspathElements()
-: localProject.getCompileClasspathElements();
-
-// Add the project's target folder first
-classpath.addAll(projectClasspath);
-if (!localProject.isExecutionRoot()) {
-for (String path : projectClasspath) {
-File pathFile = new File(path);
-String[] children = pathFile.list();
-
-if (!pathFile.exists() || (children != null &&
children.length == 0)) {
-getLog().warn("The project " +
localProject.getArtifactId()
-+ " does not seem to be compiled. PMD
results might be inaccurate.");
Review Comment:
I don't know if that's possible without breaking anything... I _think_ it
has to do, that the goal `pmd` is also a reporting mojo (that was probably the
very first feature) as well as creating the pmd.xml file with the report, that
is used by the goal `verify` to maybe fail the build (`verify` forks `pmd`)
(and this feature was probably added on top just reusing the reporting
mojo...). Not sure how other plugins deal with this (e.g. checkstyle, spotbugs,
...). What I've seen is, that m-pmd-p tries to avoid being called multiple
times (which makes sense, it needs to run only once; see the
`canGenerateReport` method which actually executes PMD, and `executeReport`
only renders the result).
If we would add the fork to `compile` or `test-compile`, would the compile
phase be called multiple times? e.g. mvn verify -> compile -> pmd:check >>
pmd:pmd >> compile?
For the concrete issue MPMD-399, I would either remove the warning message
(and ignore this whole discussion: if m-pmd-p is used correctly, there are no
problems). Or try to improve the logic, when we issue the warning (we can
easily fix the target/classes and/or target/test-classes is missing/empty - but
there might be other cases. Maybe there is a different way to figure out, if
the project has been compiled already).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPMD-399] Incorrect warning: The project X does not seem to be compi… [maven-pmd-plugin]
michael-o commented on code in PR #154:
URL: https://github.com/apache/maven-pmd-plugin/pull/154#discussion_r1635331936
##
src/main/java/org/apache/maven/plugins/pmd/PmdReport.java:
##
@@ -513,23 +513,11 @@ private String determineAuxClasspath() throws
MavenReportException {
resolvedArtifact.getArtifact().getFile().toString());
}
-List projectClasspath = includeTests
-? localProject.getTestClasspathElements()
-: localProject.getCompileClasspathElements();
-
-// Add the project's target folder first
-classpath.addAll(projectClasspath);
-if (!localProject.isExecutionRoot()) {
-for (String path : projectClasspath) {
-File pathFile = new File(path);
-String[] children = pathFile.list();
-
-if (!pathFile.exists() || (children != null &&
children.length == 0)) {
-getLog().warn("The project " +
localProject.getArtifactId()
-+ " does not seem to be compiled. PMD
results might be inaccurate.");
Review Comment:
I have the feeling that the goals need a logical cleanup with
non-agggregate/aggregate compared to other plugins which need to for
something...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPMD-399] Incorrect warning: The project X does not seem to be compi… [maven-pmd-plugin]
michael-o commented on code in PR #154:
URL: https://github.com/apache/maven-pmd-plugin/pull/154#discussion_r1635302700
##
src/main/java/org/apache/maven/plugins/pmd/PmdReport.java:
##
@@ -513,23 +513,11 @@ private String determineAuxClasspath() throws
MavenReportException {
resolvedArtifact.getArtifact().getFile().toString());
}
-List projectClasspath = includeTests
-? localProject.getTestClasspathElements()
-: localProject.getCompileClasspathElements();
-
-// Add the project's target folder first
-classpath.addAll(projectClasspath);
-if (!localProject.isExecutionRoot()) {
-for (String path : projectClasspath) {
-File pathFile = new File(path);
-String[] children = pathFile.list();
-
-if (!pathFile.exists() || (children != null &&
children.length == 0)) {
-getLog().warn("The project " +
localProject.getArtifactId()
-+ " does not seem to be compiled. PMD
results might be inaccurate.");
Review Comment:
I see. Maybe this goal should fork `compile` or ` test-compile`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPMD-399] Incorrect warning: The project X does not seem to be compi… [maven-pmd-plugin]
adangel commented on code in PR #154:
URL: https://github.com/apache/maven-pmd-plugin/pull/154#discussion_r1635295738
##
src/main/java/org/apache/maven/plugins/pmd/PmdReport.java:
##
@@ -513,23 +513,11 @@ private String determineAuxClasspath() throws
MavenReportException {
resolvedArtifact.getArtifact().getFile().toString());
}
-List projectClasspath = includeTests
-? localProject.getTestClasspathElements()
-: localProject.getCompileClasspathElements();
-
-// Add the project's target folder first
-classpath.addAll(projectClasspath);
-if (!localProject.isExecutionRoot()) {
-for (String path : projectClasspath) {
-File pathFile = new File(path);
-String[] children = pathFile.list();
-
-if (!pathFile.exists() || (children != null &&
children.length == 0)) {
-getLog().warn("The project " +
localProject.getArtifactId()
-+ " does not seem to be compiled. PMD
results might be inaccurate.");
Review Comment:
I added this warning back then, because users were configuring pmd plugin in
a multi-module project with `aggregate=true`, which has the following effect:
PMD is run on the parent project first, then the modules are built - which is
simply the wrong order. PMD needs to be run _after_ the project is build.
See my comment here:
https://issues.apache.org/jira/browse/MPMD-277?focusedCommentId=16814718=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16814718
If we remove the warning, we should also remove it from the FAQ:
https://github.com/apache/maven-pmd-plugin/blob/70fcdd048ca933253f374e3282e5af874a096aa5/src/site/fml/faq.fml#L102-L135
Maybe the warning should only be output, when the executed goal is `pmd`?
The problem is, users can run "mvn clean pmd:pmd" and get false
positives/negatives. Alternatively PMD could throw/report errors, if it doesn't
find any classes it needs during analysis. I think, currently we don't report
these.
On another note: the parameter `typeResolution` should probably be
deprecated as PMD doesn't make sense anymore without typeresolution. There was
a time, when this was a new feature and not widely used by rules, but today
most rules depend on that (and the feature is always enabled in PMD but doesn't
work correctly if the auxclasspath is not provided or empty).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
michael-o commented on PR #70: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/70#issuecomment-2161306930 > Regarding the entry count, it seems to be a bug in the shared-jar library. The root version entries are not saved anywhere. However an easy workaround (until the next shared-jar version release with a fix) would be to take the difference between the total count and each version. In this case is 37-(9+9)=19 in the root. The total of 37 can be in the first row (showing file attributes). WDYT? That sounds quite reasonable! Can you create an issue with the library first, then tacke in MPIR and then add a comment around the dep entry in the POM that we depend on issue and code needs to be changed? That would be a way forward until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
michael-o commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1635270543
##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
pom.xml
${project.build.directory}/local-repo
+
+
${repository.proxy.url}
+
+ true
+
site
+
+org.codehaus.mojo
+mrm-maven-plugin
+1.6.0
+
+ repository.proxy.url
+
+
+ src/it/mrm/repository
+
Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]
michael-o commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1635269049
##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
pom.xml
${project.build.directory}/local-repo
+
+
${repository.proxy.url}
+
+ true
+
site
+
+org.codehaus.mojo
+mrm-maven-plugin
+1.6.0
Review Comment:
Weird, I bet I have seen it. Must be something else where I bumped this
plugin. Never mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
pshevche commented on code in PR #1575:
URL: https://github.com/apache/maven/pull/1575#discussion_r1635041449
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
-private Map transfers = new LinkedHashMap<>();
+private Map transfers
= new LinkedHashMap<>();
private FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH); // use
in a synchronized fashion
Review Comment:
Addressed in https://github.com/apache/maven/pull/1579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MNG-8150] Remove unused locale argument from FileSizeFormat [maven]
pshevche opened a new pull request, #1579: URL: https://github.com/apache/maven/pull/1579 ## Summary Addressing https://github.com/apache/maven/pull/1575#discussion_r1634977808 - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
pshevche commented on code in PR #1575:
URL: https://github.com/apache/maven/pull/1575#discussion_r1635035764
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
Review Comment:
Done in
https://github.com/apache/maven/pull/1575/commits/274f1807ab0fcef625efadb26aabcaa2be1fe31b
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
-private Map transfers = new LinkedHashMap<>();
+private Map transfers
= new LinkedHashMap<>();
Review Comment:
Done in
https://github.com/apache/maven/pull/1575/commits/274f1807ab0fcef625efadb26aabcaa2be1fe31b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160928042 > My proposal: let's split the issues, have two: one for Maven 3.9 and one for master. Let's merge whatever improvement we have for 3.9 to make 3.9.8 rollin' and see about master branches of Resolver and Maven later down the road. if we want it in 3.9 it is not necessary to split - after merge to master I simply cherry-pick it to 3.9.x branch when we have two PR we will have the same discussion twice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
gnodet commented on code in PR #1575:
URL: https://github.com/apache/maven/pull/1575#discussion_r1634979644
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
Review Comment:
Can we add a comment specifying that this class is not thread safe and
should only be used from a single thread, or wrapped in the
`SimplexTransferListener` ?
It would avoid having to look why this class is not thread safe (the
`StringBuffer` as a field makes that quite easy to spot).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Build with Maven4 [maven-deploy-plugin]
slawekjaranowski merged PR #57: URL: https://github.com/apache/maven-deploy-plugin/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build with Maven 4 [maven-install-plugin]
slawekjaranowski merged PR #66: URL: https://github.com/apache/maven-install-plugin/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]
gnodet commented on code in PR #1575:
URL: https://github.com/apache/maven/pull/1575#discussion_r1634977808
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
-private Map transfers = new LinkedHashMap<>();
+private Map transfers
= new LinkedHashMap<>();
private FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH); // use
in a synchronized fashion
Review Comment:
We need to get rid of the `Locale.ENGLISH` parameter which is unused, though
this can be done in a subsequent PR.
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
-private Map transfers = new LinkedHashMap<>();
+private Map transfers
= new LinkedHashMap<>();
Review Comment:
Those 3 fields should be `final`.
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -35,7 +35,7 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
Review Comment:
Can we add a comment specifying that this class is not thread safe and
should only be used from a single thread, or wrapped in the
`SimplexTransferListener` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
cstamas commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160659533 My proposal: let's split the issues, have two: one for Maven 3.9 and one for master. Let's merge whatever improvement we have for 3.9 to make 3.9.8 rollin' and see about master branches of Resolver and Maven later down the road. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
cstamas commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2160632765
Went thru resolver cobase, and we have 5 copies of this method:
```java
private static Throwable getCause(SomeType result) {
Throwable cause = null;
if (result != null && !result.getExceptions().isEmpty()) {
cause = result.getExceptions().get(0);
}
return cause;
}
```
And these methods are bad, as they blindly choose 1st exception as "cause"
in various scenarios. They are in classes:
* VersionResolutionException
* DependencyCollectionException
* ArtifactDescriptorException
* VersionRangeResolutionException
* (fifth is in ArtifactResolutionException but it is modified, is not
copy-pasta of this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
cstamas commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160612679 As I looked into, this is a problem that probably looks like this: Collector (CO, in resolver) -> ArtifactDescriptorReader (ADR, in maven) -> ArtifactResolver (AR, in resolver) What happens, is that CO during collecting, issues series of requests to ADR to build the graph, but ADR "forwards" these to AR (to resolve POM), and it fails. If you "rollback", you will see that AR throws ArtifactResolutionException that carries a list (repo, cause). So far all nice and dandy. But ADR loses them. Instead, it will create ArtifactDescriptorException w/o cause (so AR thrown ArtifactResolutionEx is lost), instead it uses result, and gets 1st exception from result as "cause". Finally, CO receives this exception and sets it as one single CollectionResult ex and throws DependencyCollectionException w/ result. The problem stems from here: https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorException.java#L35 As ADR wants to reuse this message, but to do so, it simply leaves out cause (ArtifactResolutionEx), instead it does this: https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorException.java#L76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160563105 > @michael-o is it any objections from you to merge without resolver fix ... resolver can be fixed later Let me please review/test again today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160510406 @michael-o is it any objections from you to merge without resolver fix ... resolver can be fixed later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
cstamas commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160420230 > @cstamas Is this a huge issue to fix in Resolver? Unsure, did not look yet, but IMHO is certainly something that would NOT happen in 1.9.x resolver but 2.0.0... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160397976 > > @slawekjaranowski Should I try again? > > you can - but result for connection problems will still show last / one repo I also changed reporting for missing plugins > > https://issues.apache.org/jira/browse/MRESOLVER-569 @cstamas Is this a huge issue to fix in Resolver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
slawekjaranowski commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160392977 > @slawekjaranowski Should I try again? you can - but result for connection problems will still show last / one repo I also changed reporting for missing plugins https://issues.apache.org/jira/browse/MRESOLVER-569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]
michael-o commented on PR #1563: URL: https://github.com/apache/maven/pull/1563#issuecomment-2160381041 @slawekjaranowski Should I try again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-testing from 1.0.0 to 1.3.0 [maven]
gnodet merged PR #1531: URL: https://github.com/apache/maven/pull/1531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove commons-io:commons-io dependency [maven]
gnodet merged PR #1578: URL: https://github.com/apache/maven/pull/1578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2232] StatelessXmlReporter: handle failed test result without a throwable [maven-surefire]
michael-o commented on PR #716: URL: https://github.com/apache/maven-surefire/pull/716#issuecomment-2160165869 @dr29bart I took the liberty to change your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.16.1 [maven]
gnodet commented on PR #1534: URL: https://github.com/apache/maven/pull/1534#issuecomment-2160152750 See #1578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.16.1 [maven]
dependabot[bot] commented on PR #1534: URL: https://github.com/apache/maven/pull/1534#issuecomment-2160152356 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.16.1 [maven]
gnodet closed pull request #1534: Bump commons-io:commons-io from 2.11.0 to 2.16.1 URL: https://github.com/apache/maven/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-component-annotations from 2.1.0 to 2.2.0 [maven-surefire]
michael-o commented on PR #747: URL: https://github.com/apache/maven-surefire/pull/747#issuecomment-2160115917 @cstamas Is this a safe upgrade from your PoV? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-surefire]
dependabot[bot] commented on PR #749: URL: https://github.com/apache/maven-surefire/pull/749#issuecomment-2160114691 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-surefire]
dependabot[bot] closed pull request #749: Bump resolverVersion from 1.4.1 to 1.9.20 URL: https://github.com/apache/maven-surefire/pull/749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-surefire]
michael-o commented on PR #749: URL: https://github.com/apache/maven-surefire/pull/749#issuecomment-2160114558 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove commons-io dependency [maven]
gnodet opened a new pull request, #1578: URL: https://github.com/apache/maven/pull/1578 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit:junit-bom from 5.10.1 to 5.10.2 [maven]
gnodet merged PR #1535: URL: https://github.com/apache/maven/pull/1535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.5.0 to 1.8.0 [maven]
gnodet merged PR #1537: URL: https://github.com/apache/maven/pull/1537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]
gnodet merged PR #1559: URL: https://github.com/apache/maven/pull/1559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]
gnodet commented on PR #1559: URL: https://github.com/apache/maven/pull/1559#issuecomment-2159869443 > I assume - but not sure at all - you speak about adding more concurrency or something like that but I'm not sure we can do it more than the resolution requested by the mojo itself - which needs to move to a list of custom string I guess now. When injecting into a field, we can use a single `pathScope`, however, we have the `dependencyResolutionPathScopes` field of the `@Mojo` annotation which can be used for informative purpose (as I explained above), and that one is defined in the javadoc as a comma separated list of pathScopes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]
rmannibucau commented on PR #1559: URL: https://github.com/apache/maven/pull/1559#issuecomment-2159787665 @gnodet ok, if we mix it with the binding/phase - execution has it - later it will work, :+1:, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
