[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2020-06-27 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147069#comment-17147069
 ] 

Herve Boutemy commented on DOXIA-555:
-

[~Abel S.Romero] your comment is perfect for DOXIA-614
= relates to "setup source filename or any other attributes to use for example 
to print warning/errors while parsing", but not related to current issue about 
footer for FO/PDF output

The common aspect is Doxia Sitetools (containing Doc Renderer) dependency on 
Doxia as shown in https://maven.apache.org/doxia/overview.html

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related [https://issues.apache.org/jira/browse/MPDF-81]
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> [FoAggregateSink.java#l737|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=blob;f=doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java;hb=HEAD#l737]
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> [http://maven.apache.org/xsd/document-1.0.1.xsd]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2020-06-27 Thread Abel Salgado Romero (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146832#comment-17146832
 ] 

Abel Salgado Romero commented on DOXIA-555:
---

Here is the example related to the use case [~slachiewicz] was mentioning -> 
[https://github.com/abelsromero/asciidoctor-maven-examples/tree/poc/show-doxia-error-without-source-file.]

Preamble: asciidoctor-maven-plugun has 2 modes, "Mojo" in which we do parse 
files manually, in this case we can get the source file and report it in the 
error. In the other mode, "site-integration" (class "AsciidoctorDoxiaParser") 
we extend "XhtmlParser" with provides the method "parse(Reader reader, Sink 
sink)" with no reference to the source file.

In this example, we show how under the same case in the site integration we 
cannot obtain the source file, so the user is left without a clue where to 
begin with.

To reproduce:
 # Clone
 # To see the error with filename in "mojo" go into "asciidoc-to-html-example" 
folder and run "mvn". You'll see the ERROR message pointing to "ERROR: 
example-manual.adoc" file.
 # To see the error without filename in th e"site" integration, go tino 
"asciidoc-maven-site-example" folder run "mvn site:site" and you' see "ERROR: 
line 42: ", with no way to see which file from the 3 in the project failed.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related [https://issues.apache.org/jira/browse/MPDF-81]
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> [FoAggregateSink.java#l737|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=blob;f=doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java;hb=HEAD#l737]
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> [http://maven.apache.org/xsd/document-1.0.1.xsd]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2020-06-16 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137935#comment-17137935
 ] 

Herve Boutemy commented on DOXIA-555:
-

you're right: without any help or interest to work together, I won't do 
anything given I have so many other things to do
removing me as assignee if it causes nobody else trying to work on the issue

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related [https://issues.apache.org/jira/browse/MPDF-81]
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> [FoAggregateSink.java#l737|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=blob;f=doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java;hb=HEAD#l737]
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> [http://maven.apache.org/xsd/document-1.0.1.xsd]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2020-06-16 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136465#comment-17136465
 ] 

Michael Osipov commented on DOXIA-555:
--

I guess no one. [~hboutemy], do you want to remove assignee if you aren't going 
to work on it anytime soon?

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related [https://issues.apache.org/jira/browse/MPDF-81]
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> [FoAggregateSink.java#l737|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=blob;f=doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java;hb=HEAD#l737]
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> [http://maven.apache.org/xsd/document-1.0.1.xsd]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2020-06-14 Thread Abel Salgado Romero (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135294#comment-17135294
 ] 

Abel Salgado Romero commented on DOXIA-555:
---

Hi, don't mean to bother, but is there any advancement in this? From the 
asciidoctor-maven-plugin we would be interested now that we are improving error 
reporting for the site module. However, we cannot point to the exact file yet.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related [https://issues.apache.org/jira/browse/MPDF-81]
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> [FoAggregateSink.java#l737|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=blob;f=doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java;hb=HEAD#l737]
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> [http://maven.apache.org/xsd/document-1.0.1.xsd]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2018-03-04 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385285#comment-16385285
 ] 

Hervé Boutemy commented on DOXIA-555:
-

I'll take away compatibility questions (which are part of some renaming not 
done currently...) and see the proposal:

1. o.a.m.doxia.siterenderer.RenderingContext definitely is part of 
doxia-site-renderer, to render a Doxia document as part of a site: I don't see 
where to put it in Doxia Core, and see its javadoc 
http://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/apidocs/org/apache/maven/doxia/siterenderer/DocumentRenderer.html

2. o.a.m.doxia.docrenderer.DocumentRendererContext API is completely different 
(see 
http://maven.apache.org/doxia/doxia-sitetools/doxia-doc-renderer/apidocs/org/apache/maven/doxia/docrenderer/DocumentRendererContext.html)
 and is about metadata for a "document" pdf that collects multiple Doxia 
"documents". Here, we should find a clear term for the "document" equivalent to 
a site. And I don't see where to put this API in Doxia Core, neither how it 
relates to the first API

and finally, on your third point "pas to parsers ... to use for example to 
print warning/errors while parsing", we could probably add a new method to 
Parser 
http://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/Parser.html
 and implement it in AbstractParser 
http://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/AbstractParser.html:
 I imagine every Parser uses AbstractParser, then the addition in the interface 
won't break compatibility
But this is IMHO a good idea to completely decouple from the previous ones => 
I'd propose a separate Jira issue



> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2018-03-04 Thread Sylwester Lachiewicz (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385231#comment-16385231
 ] 

Sylwester Lachiewicz commented on DOXIA-555:


We have:

doxia-doc-renderer - org.apache.maven.doxia.docrenderer.DocumentRendererContext

doxia-site-renderer - org.apache.maven.doxia.siterenderer.RenderingContext 
(with TODO rename to DocumentRenderingContext)

from this 2 RenderingContext looks better candidate to move to doxia-core and 
pass to parsers.

It would be also possible for other plugins/parsers to setup source filename or 
any other attributes to use for example to print warning/errors while parsing. 

 

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-09-09 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160007#comment-16160007
 ] 

Hervé Boutemy commented on DOXIA-555:
-

and if preferred, a GitHub PR can be used instead of patch attached to Jira 
issue: as you want

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-09-09 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160006#comment-16160006
 ] 

Hervé Boutemy commented on DOXIA-555:
-

regarding SNAPSHOTs, we don't have choice: we must use them to make change that 
are transverse to multiple components (here Doxia and Doxia Sitetools)

then regarding the cycle, which is the key issue: I did a schema to describe 
how Doxia Sitetools uses Doxia 
http://maven.apache.org/doxia/doxia-sitetools/index.html

IMHO, Doxia Sitetools should not inject a generic context to Doxia as Object, 
with Doxia getting content with reflection, knowing that the Object is from 
Doxia SItetool.
Instead Doxia should provide setters for useful properties as Strings, and 
Doxia Sitetool should call these setters: perhaps a configuration object would 
be useful, like DocumentProperties (which seems useful in case of FO or iText, 
which are inherently page/document oriented)

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-28 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027891#comment-16027891
 ] 

Michael Osipov commented on DOXIA-555:
--

We aren't using snapshots becasue it would make tests unpredictable and we 
cannot assume that people have direct access to the Apache Snapshots repo. As 
for the cycle, I need to take a look. [~hboutemy], do you have an opion on 
that? You know the code better than I do.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-28 Thread Alex O'Ree (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027803#comment-16027803
 ] 

Alex O'Ree commented on DOXIA-555:
--

for 2. it looks like it creates a dependency cycle. DocumentRendererContext is 
in module doxia-doc-renderer which depends on doxia-module-fo, we can't have 
doxia-module-fo depend on doxia-doc-renderer. "Fixing" this would require 
moving DocumentRendererContext  to another module to solve to the cyclic 
dependency issue.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-28 Thread Alex O'Ree (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027798#comment-16027798
 ] 

Alex O'Ree commented on DOXIA-555:
--

1. i set the version to snapshot so that i didn't pollute my local m2 cache. 
Out of curiosity, why aren't snapshots used? i can remove it from the patch file
2. the reflection call was because the class DocumentRendererContext is not on 
the classpath for the module fo. I was a bit hesitant about changing the 
dependency. I can rework that part if you want.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-28 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027750#comment-16027750
 ] 

Michael Osipov commented on DOXIA-555:
--

I am not convinced by the patch:

1. We don't use snapshots.
2. Why do you pass {{DocumentRendererContext}} as {{Object}} if you have it 
fully typed?

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-27 Thread Alex O'Ree (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027603#comment-16027603
 ] 

Alex O'Ree commented on DOXIA-555:
--

sure thing, i've actually got a functioning patch which i'll attach shortly but 
here's the quick summary
in: 
doxia\doxia-modules\doxia-module-fo\src\main\java\org\apache\maven\doxia\module\fo\FoAggregateSink.java
 - add/change the constructor to take a second parameter which is a reference 
to org.apache.maven.doxia.docrenderer.DocumentRendererContext
 - change the getFooter() code to check for the context for an override value, 
if present, return that value instead of the canned version

in: 
doxia-sitetools\doxia-doc-renderer\src\main\java\org\apache\maven\doxia\docrenderer\pdf\fo\FoPdfRenderer.java
 - change the call from   FoAggregateSink sink = new FoAggregateSink( writer ); 
to include the DocumentRendererContext

finally, some pom changes to override some of the versions. I had a lot of 
difficultly getting the dependency structure just right in order to test this 
but I did get it eventually

finally, in the maven pdf plugin, there's some code to gather some additional 
settings and add them to the DocumentRendererContext which enables the override.

Using this approach, no changes are needed for the document xsd. It's probably 
not the best solution but it seems to be the easier in the short term.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027515#comment-16027515
 ] 

Michael Osipov commented on DOXIA-555:
--

Can you briefly describe what needs to be changed with Doxia first?

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DOXIA-555) Footer overrides for FO/PDF outputs

2017-05-27 Thread Alex O'Ree (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027512#comment-16027512
 ] 

Alex O'Ree commented on DOXIA-555:
--

ping. I'm not sure who maintains Doxia, but in order to support custom 
header/footers on generated PDF documents, unfortunately it requires changing a 
number of different repositories both in doxia and for the maven-pdf-plugin 
(and versions of cut of all affected modules). I'm willing to do the work, but 
I'd at least like some concurrency from the maintainers that this is a feasible 
change that can be made.

> Footer overrides for FO/PDF outputs
> ---
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - FO
>Reporter: Alex O'Ree
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of 
> generated PDF documents. Currently, it looks like the footer is hard coded 
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf 
> descriptor document (maven-pdf-plugin). This would require a change in the 
> schema used for the pdf descriptor 
> http://maven.apache.org/xsd/document-1.0.1.xsd 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)