[jira] [Commented] (MNG-6241) colour output cannot be disabled from settings.xml or MAVEN_OPTS
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464477#comment-17464477
]
Michael Osipov commented on MNG-6241:
-
Your problem should now be fixed with MNG-7193.
> colour output cannot be disabled from settings.xml or MAVEN_OPTS
> -
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6241) colour output cannot be disabled from settings.xml or MAVEN_OPTS
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374290#comment-17374290
]
Michael Osipov commented on MNG-6241:
-
Using settings is unfortunately not possible because it comes much later than
the color configuration. See
{{org.apache.maven.cli.MavenCli.doMain(CliRequest)}}. It would require us to
first load the settings, get the flag and then process command line args.
What we could do it so extend the code to accept from system properties too.
System props => user props => command line option.
[~mirabilos], [~martinkanters], WDYT?
> colour output cannot be disabled from settings.xml or MAVEN_OPTS
>
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) colour output cannot be disabled from settings.xml or MAVEN_OPTS
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895458#comment-16895458
]
Michael Osipov commented on MNG-6241:
-
bq. Michael Osipov not in MAVEN_OPTS, only as explicit command line argument
(and there, -B is clearly the better choice).
I can confirm that. It is pretty weird.
We will likely need to revise all of this hodgepodge. [~hboutemy], WDYT?
> colour output cannot be disabled from settings.xml or MAVEN_OPTS
>
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MNG-6241) colour output cannot be disabled from settings.xml or MAVEN_OPTS
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895448#comment-16895448
]
Thorsten Glaser commented on MNG-6241:
--
[~michael-o] not in {{MAVEN_OPTS}}, only as explicit command line argument (and
there, {{-B}} is clearly the better choice).
Ideally, both {{-B}} and {{-Dstyle.color=never}} would have corresponding
{{settings.xml}} equivalents (and the former superset the latter), so one can
easily declare it on a Jenkins system without having to worry about individual
jobs overriding the environment variable.
> colour output cannot be disabled from settings.xml or MAVEN_OPTS
>
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MNG-6241) colour output cannot be disabled from settings.xml or MAVEN_OPTS
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892207#comment-16892207
]
Michael Osipov commented on MNG-6241:
-
Does {{-Dstyle.color=never}} not work?
> colour output cannot be disabled from settings.xml or MAVEN_OPTS
>
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MNG-6241) colour output cannot be disabled from settings.xml or MAVEN_OPTS
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057930#comment-16057930
]
Thorsten Glaser commented on MNG-6241:
--
To add insult to injury, the 「MessageUtils.setColorEnabled(false);」 call is
only in the CLI, meaning everything that calls Maven via something else (like
Jenkins) must change their own code as well (like
maven35-interceptor/src/main/java/org/apache/maven/cli/DefaultMavenExecutionRequestBuilder.java
in Jenkins).
Centralised parsing of a settings.xml entry and an environment variable (or
even a JVM -Doption) would certainly help here.
> colour output cannot be disabled from settings.xml or MAVEN_OPTS
>
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
