[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836779#comment-17836779
 ] 

Michael Osipov commented on MNG-8095:
-

This should have stayed open until the release notes are fixed.

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836649#comment-17836649
 ] 

Tamas Cservenak commented on MNG-8095:
--

Agreed, most probably release notes needs some better (or clearer) wording, 
that we mean 'maven configuration' and not ANY 'configuration' like plugin 
configuration is...

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836648#comment-17836648
 ] 

Karl Heinz Marbaise commented on MNG-8095:
--

Ok I have feared such a thing. That means we have to make the release notes 
more clear on that part... If I read "properties" and "configuration" which 
could be mistaken with the configuration of the plugins... Ok... 

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836645#comment-17836645
 ] 

Tamas Cservenak commented on MNG-8095:
--

Rel notes says specifically "implemented interpolation for configuration and 
command line".

So, in 3.9.x this is NOT a property (so cannot be refd from POM etc), ONLY from 
command line and .mvn/maven.config.

In 4.0 this IS fully fledged property, and can be referenced from POM as well.

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836633#comment-17836633
 ] 

Karl Heinz Marbaise commented on MNG-8095:
--

Yes the implementation between Maven 4 and Maven 3.X is different... 

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836629#comment-17836629
 ] 

Michael Osipov commented on MNG-8095:
-

I see now. I am certain that it is implemented differently than in Maven 4 and 
this is the result now.

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836628#comment-17836628
 ] 

Karl Heinz Marbaise commented on MNG-8095:
--

Apart from that the branch on 3.9.X contains refererences like this:
{code:java}
@Test
public void testPropertiesInterpolation() throws Exception {
// Arrange
CliRequest request = new CliRequest(
new String[] {
"-Dfoo=bar",
"-DvalFound=s${foo}i",
"-DvalNotFound=s${foz}i",
"-DvalRootDirectory=${session.rootDirectory}/.mvn/foo",
"-DvalTopDirectory=${session.topDirectory}/pom.xml",
"-f",
"${session.rootDirectory}/my-child",
"prefix:3.0.0:${foo}",
"validate"
},
null);
request.rootDirectory = Paths.get("myRootDirectory");
request.topDirectory = Paths.get("myTopDirectory");
{code}
and also the code in {{MavenCli.java}} contains 
((https://github.com/apache/maven/blob/maven-3.9.x/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1563):
{code:java}
protected static StringSearchInterpolator createInterpolator(CliRequest 
cliRequest, Properties... properties) {
StringSearchInterpolator interpolator = new StringSearchInterpolator();
interpolator.addValueSource(new AbstractValueSource(false) {
@Override
public Object getValue(String expression) {
if ("session.topDirectory".equals(expression)) {
Path topDirectory = cliRequest.topDirectory;
if (topDirectory != null) {
return topDirectory.toString();
} else {
throw new IllegalUseOfUndefinedProperty(expression);
}
} else if ("session.rootDirectory".equals(expression)) {
Path rootDirectory = cliRequest.rootDirectory;
if (rootDirectory != null) {
return rootDirectory.toString();
} else {
throw new IllegalUseOfUndefinedProperty(expression);
}
}
return null;
}
});
... 
{code}


> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] 

[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836624#comment-17836624
 ] 

Karl Heinz Marbaise commented on MNG-8095:
--

The release notes of Maven 3.9.2 on 
https://maven.apache.org/docs/3.9.2/release-notes.html saying something 
different..

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-12 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836622#comment-17836622
 ] 

Michael Osipov commented on MNG-8095:
-

??? I am genuinly confused. Those exist with Maven 4 only. How are they 
supposed to work with 3?

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.0, 3.9.1, 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)