[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843325#comment-17843325
]
ASF GitHub Bot commented on MSHARED-1382:
-
slawekjaranowski merged PR #74:
URL: https://github.com/apache/maven-invoker/pull/74
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842656#comment-17842656
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586330276
##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+// JUnit5: test methods don't need to be public
Review Comment:
Actually the `test` prefix is also redundant for `@Test` methods, yet here I
kept the project-wide convention...
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842645#comment-17842645
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum commented on PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088473729
@slawekjaranowski fixed. The cause of the difference was JAVA_HOME pointing
to JDK1.8, but we need JDK17 for building as in CI to get the `spotless` errors.
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842639#comment-17842639
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum commented on PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088460111
@slawekjaranowski thx I'll check it.
`mvn verify` was green at my PC (and `mvn -Prun-its verify` which is
suggested by README issues a warning about a not-existing profile).
I'll check what is run in CI and simulate it locally.
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842632#comment-17842632
]
ASF GitHub Bot commented on MSHARED-1382:
-
slawekjaranowski commented on PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088449184
@lrozenblyum - pleach check build result the same should be when you build
locally
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842629#comment-17842629
]
ASF GitHub Bot commented on MSHARED-1382:
-
slawekjaranowski commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586278359
##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+// JUnit5: test methods don't need to be public
Review Comment:
you can drop `public` modifier from other methods also
now on separate PR
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842614#comment-17842614
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum opened a new pull request, #74:
URL: https://github.com/apache/maven-invoker/pull/74
Added a possibility to request Maven not to execute the snapshots updates.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839058#comment-17839058
]
Michael Osipov commented on MSHARED-1382:
-
Will happily review a PR with [~sjaranowski].
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
