[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403718#comment-16403718
 ] 

ASF GitHub Bot commented on SUREFIRE-1490:
--

Github user asfgit closed the pull request at:

https://github.com/apache/maven-surefire/pull/175


> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 3.0.0-M1
>
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394427#comment-16394427
 ] 

ASF GitHub Bot commented on SUREFIRE-1490:
--

GitHub user Tibor17 opened a pull request:

https://github.com/apache/maven-surefire/pull/175

[SUREFIRE-1490] Change header of the Failsafe Report

Related to JIRA 
[SUREFIRE-1490](https://issues.apache.org/jira/browse/SUREFIRE-1490).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/maven-surefire SUREFIRE-1490

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #175


commit 6174be76f52ffc2873a18a5215f60767843d7479
Author: Tibor17 
Date:   2018-03-07T01:43:37Z

[SUREFIRE-1490] Change header of the Failsafe Report




> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 3.0.0-M1
>
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-04 Thread Tibor Digana (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385396#comment-16385396
 ] 

Tibor Digana commented on SUREFIRE-1490:


[~fedyafed]
It looked to me you meant these titles 
http://maven.apache.org/surefire/surefire-integration-tests/project-reports.html
but you meant 
http://maven.apache.org/surefire/surefire-integration-tests/failsafe-report.html
I will try to implement polymorphic Resource bundle where each MOJO would have 
own implementation of abstract methods - keys.

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-04 Thread Michael Osipov (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385178#comment-16385178
 ] 

Michael Osipov commented on SUREFIRE-1490:
--

[~fedyafed], correctly analyzed.

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-04 Thread Ivan Fedotov (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385175#comment-16385175
 ] 

Ivan Fedotov commented on SUREFIRE-1490:


[~tibor17], customized title can override this, but I meant default values, as  
[~michael-o] said.

By default, FailsafeReportMojo.getName uses "report.failsafe.name" from bundle.
 But by default SurefireReportGenerator.doGenerateReport uses 
"report.surefire.header" no matter what report is executed.

May be FailsafeReportMojo.getTitle should return something like 
"report.failsafe.header" from bundle by default?

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-04 Thread Michael Osipov (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385130#comment-16385130
 ] 

Michael Osipov commented on SUREFIRE-1490:
--

[~tibor17], are you sure that this is the case? The {{SurefireReportGenerator}} 
is used by {{AbstractSurefireReportMojo}} which is ther super class of the 
Failsafe Report. I think this is really an issue, it is not about 
customization, but simply wrong default values.

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-04 Thread Tibor Digana (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385106#comment-16385106
 ] 

Tibor Digana commented on SUREFIRE-1490:


[~fedyafed]
The surefire tests have Surefire Report. The failsafe have opposite. I did not 
see one for both in my practice. The ttile can be customized in version 
{{2.21.0}}. I supposed you wanted customization and mark this issue as an 
duplicate.

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-03 Thread Michael Osipov (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384737#comment-16384737
 ] 

Michael Osipov commented on SUREFIRE-1490:
--

Can you create a minimal example. I think you are referring to [this 
method|https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=blob;f=maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java;h=5929f799b2e791512f0a8f44edce7d91f36dd556;hb=HEAD#l79].
 This makes not difference between Surefire and Failsafe.

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)