[jira] Commented: (SUREFIRE-596) Junit test output is broken with junit4-7+
[ http://jira.codehaus.org/browse/SUREFIRE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=206571#action_206571 ] Kristian Rosenvold commented on SUREFIRE-596: - That's the svn integration in my IDE messing up, thanks for explaining Brett - I was honestly stumped and figured it was about choosing the right options for patch. I'm obviously not any good copy-paste coding; need to put that on my CV ;) Junit test output is broken with junit4-7+ --- Key: SUREFIRE-596 URL: http://jira.codehaus.org/browse/SUREFIRE-596 Project: Maven Surefire Issue Type: Bug Components: Junit 4.x support Affects Versions: 2.5 Environment: junit 4.7 Reporter: Kristian Rosenvold Assignee: Stephen Connolly Fix For: 2.5 Attachments: junit1.diff, junit2.diff, junit2.zip There is a bug in the log output for the junit4.7+ provider, where it just says Result null instead of outputting the proper surefire output. Additionally, the concurrent junit provider should really only be used when the user has requested some concurrent execution model in the configuration. Workaround at the moment is one of the following: A) Use surefire-2.4.3 until this is fixed B) Downgrade to junit 4.6 until this is fixed C) ignore the problem. This may be possible, but some CI systems also parse the output so it may break the build. The enclosed patch fixes both problems on svn trunk of surefire, and also includes updated integration tests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-596) Junit test output is broken with junit4-7+
[ http://jira.codehaus.org/browse/SUREFIRE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=206524#action_206524 ] Stephen Connolly commented on SUREFIRE-596: --- The patch is malformed, specifically: |=== |--- surefire-integration-tests/src/test/resources/concurrentjunit47/src/test/java/junit47/BasicTest.java (revision 0) |+++ surefire-integration-tests/src/test/resources/concurrentjunit47/src/test/java/junit47/BasicTest.java (working copy) -- File to patch: surefire-integration-tests/src/test/resources/concurrentjunit47/src/test/java/junit47/BasicTest.java patching file surefire-integration-tests/src/test/resources/concurrentjunit47/src/test/java/junit47/BasicTest.java Hunk #1 FAILED at 1. Hunk #2 FAILED at 35. 2 out of 2 hunks FAILED -- saving rejects to file surefire-integration-tests/src/test/resources/concurrentjunit47/src/test/java/junit47/BasicTest.java.rej patching file pom.xml Hunk #1 FAILED at 24. Hunk #2 FAILED at 56. 2 out of 2 hunks FAILED -- saving rejects to file pom.xml.rej Junit test output is broken with junit4-7+ --- Key: SUREFIRE-596 URL: http://jira.codehaus.org/browse/SUREFIRE-596 Project: Maven Surefire Issue Type: Bug Components: Junit 4.x support Affects Versions: 2.5 Environment: junit 4.7 Reporter: Kristian Rosenvold Attachments: junit1.diff There is a bug in the log output for the junit4.7+ provider, where it just says Result null instead of outputting the proper surefire output. Additionally, the concurrent junit provider should really only be used when the user has requested some concurrent execution model in the configuration. Workaround at the moment is one of the following: A) Use surefire-2.4.3 until this is fixed B) Downgrade to junit 4.6 until this is fixed C) ignore the problem. This may be possible, but some CI systems also parse the output so it may break the build. The enclosed patch fixes both problems on svn trunk of surefire, and also includes updated integration tests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-596) Junit test output is broken with junit4-7+
[ http://jira.codehaus.org/browse/SUREFIRE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=206561#action_206561 ] Brett Porter commented on SUREFIRE-596: --- not sure how it was generated, but somehow it thinks you added BasicTest as a new file, yet it contains diffs from a previous one (-package junit). Usually all that is needed is that a truly new file has svn add on it. Did you svn copy it from another location perhaps, or copy a .svn directory from another repository? Junit test output is broken with junit4-7+ --- Key: SUREFIRE-596 URL: http://jira.codehaus.org/browse/SUREFIRE-596 Project: Maven Surefire Issue Type: Bug Components: Junit 4.x support Affects Versions: 2.5 Environment: junit 4.7 Reporter: Kristian Rosenvold Attachments: junit1.diff, junit2.diff, junit2.zip There is a bug in the log output for the junit4.7+ provider, where it just says Result null instead of outputting the proper surefire output. Additionally, the concurrent junit provider should really only be used when the user has requested some concurrent execution model in the configuration. Workaround at the moment is one of the following: A) Use surefire-2.4.3 until this is fixed B) Downgrade to junit 4.6 until this is fixed C) ignore the problem. This may be possible, but some CI systems also parse the output so it may break the build. The enclosed patch fixes both problems on svn trunk of surefire, and also includes updated integration tests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
