Re: [PR] [MNG-8061] Maven: Require Java 17 [maven-parent]

2024-04-14 Thread via GitHub


bmarwell commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2054106342

   > and can we avoid MNG issue for a change that is related to Maven parent 
POM?
   
   Sure, both works for me. Will update soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8061] Maven: Require Java 17 [maven-parent]

2024-04-14 Thread via GitHub


hboutemy commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2053988528

   and can we avoid MNG issue for a change that is related to Maven parent POM?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8061] Maven: Require Java 17 [maven-parent]

2024-02-28 Thread via GitHub


olamy commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-1968578448

   > We can not bump JDK in parent ... it will have an impact for all plugins 
... but plugins should stay at JDK 8
   
   plugins parent can have 
   ```
   8
   ${javaVersion}
   ${javaVersion}
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8061] Maven: Require Java 17 [maven-parent]

2024-02-27 Thread via GitHub


olamy commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-1968268061

   this means all plugins will be 17 required.
   so all plugins upgrading to to this parent will not work for users of maven 
3.x and jdk 8/11.
   sounds an issue to solve as it would mean eventually having branches for 
plugins in case of major bugs and/or security issues.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8061] Maven: Require Java 17 [maven-parent]

2024-02-27 Thread via GitHub


bmarwell commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-1967616066

   Will redo this on maven-core first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org