Re: [PR] [MNG-8084] add di & api-impl [maven]
hboutemy merged PR #1461: URL: https://github.com/apache/maven/pull/1461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2074335291 > > I'm happy to update it if you tell me what remains to do: it's just a small update of an OpenOffice document, save as .svg and run the update `prepare-svg.sh` script > > > It's not readable unfortunately, but it started from generated graph, so it's correct with current master. > > > > > > BTW, I'd be interested to be able to create this type of automatic drawing as a reference > `mvn org.fusesource.mvnplugins:maven-graph-plugin:reactor -Dhide-version -Dhide-group-id -Dhide-scope=test -Dhide-transitive` gives the following: ![reactor-graph](https://github.com/apache/maven/assets/84022/f169795a-f77b-4594-8bb3-c7f3e02b6751) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2074304566 > I'm happy to update it if you tell me what remains to do: it's just a small update of an OpenOffice document, save as .svg and run the update `prepare-svg.sh` script > > > It's not readable unfortunately, but it started from generated graph, so it's correct with current master. > > BTW, I'd be interested to be able to create this type of automatic drawing as a reference `mvn org.fusesource.mvnplugins:maven-graph-plugin:reactor` does render something automatically... ![reactor-graph](https://github.com/apache/maven/assets/84022/5c08ebe7-3822-497f-9884-3a726dc3d48a) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
hboutemy commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2074207980 I'm happy to update it if you tell me what remains to do: it's just a small update of an OpenOffice document, save as .svg and run the update `prepare-svg.sh` script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
hboutemy commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2054170988 PR updated https://maven.apache.org/ref/4-LATEST/ objective of this PR is to show what we have today, that will help us define targets: schema will evolve when useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051624139 > ![maven-4 0 0-alpha-14-SNAPSHOT](https://private-user-images.githubusercontent.com/84022/321970671-021f8313-b34b-4b9b-95e1-ca6697745521.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI5MjI3MDgsIm5iZiI6MTcxMjkyMjQwOCwicGF0aCI6Ii84NDAyMi8zMjE5NzA2NzEtMDIxZjgzMTMtYjM0Yi00YjliLTk1ZTEtY2E2Njk3NzQ1NTIxLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDEyVDExNDY0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMxYzQwOGU4OTllNTZjYWNlMTMzMTFlMDc0Zjk2OTAwM2M5Mzc2NzE0NDBmNzRjYzhkMTU0YTg2YmZkMWYwMzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._SfX7Kr1noVKChnkU4nTEzkCp5I0vzeNivFk45WT03g) > > It's not readable unfortunately, but it started from generated graph, so it's correct with current master. Note that the ultimate goal would be, imho, to have a maven-compat3 with all the things from maven 3, and have `maven-core` not depend on the v3 artifacts / api anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051604730 ![maven-4 0 0-alpha-14-SNAPSHOT](https://github.com/apache/maven/assets/84022/021f8313-b34b-4b9b-95e1-ca6697745521) It's really readable unfortunately, but it started from generated graph, so it's correct with current master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2051576594 > Fwiw, this will be outdated with #1465 and later #1457 Also maven-compat is not used anymore (but only included in the distribution for compatibility). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
gnodet commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2039015662 Fwiw, this will be outdated with https://github.com/apache/maven/pull/1465 and later https://github.com/apache/maven/pull/1457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
cstamas commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2031641343 See https://github.com/apache/maven/pull/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
cstamas commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2028863603 Supplier is to be moved to api-impl, as it is not meant to be used in Maven (only in projects that "run maven without maven", ie. resolver integrations w/ maven models). The plan is to move supplier to api-impl, and have resolver supplier depends on api-impl instead. @gnodet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8084] add di & api-impl [maven]
hboutemy commented on PR #1461: URL: https://github.com/apache/maven/pull/1461#issuecomment-2028823359 notice that there is a chicken and egg problem between resolver and Maven: api-impl depends on resolver supplier, which depends on resolver-provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org