Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski merged PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski commented on code in PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#discussion_r1563159511 ## docs/pom.xml: ## @@ -82,11 +77,26 @@ under the License. + + +org.apache.maven.plugins +maven-install-plugin + + true + + + +org.apache.maven.plugins +maven-deploy-plugin + + true Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski commented on PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#issuecomment-2052473907 In ASF parent pom there is more trick about publishing documentation and publishing parent pom. For documentation perspective we need add some information to pom ... but we don't want to propagate it to child project. So current we have a special site-pom.xml which must by manually edited during release process. I trying to avoid such manual taks. https://maven.apache.org/developers/release/parent-pom-release.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
slawekjaranowski commented on code in PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#discussion_r1563147779 ## docs/pom.xml: ## @@ -82,11 +77,26 @@ under the License. + + +org.apache.maven.plugins +maven-install-plugin + + true + + + +org.apache.maven.plugins +maven-deploy-plugin + + true Review Comment: ok, good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]
ctubbsii commented on code in PR #210: URL: https://github.com/apache/maven-apache-parent/pull/210#discussion_r1563034471 ## docs/pom.xml: ## @@ -82,11 +77,26 @@ under the License. + + +org.apache.maven.plugins +maven-install-plugin + + true + + + +org.apache.maven.plugins +maven-deploy-plugin + + true Review Comment: Can these skips be done with a property instead? Seems like it would be less config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
