Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
cstamas commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061137170 Next attempt: https://github.com/apache/maven-wrapper/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
cstamas commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061129221 Yup, that is my problem as well: "not sure" :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
jorsol commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061121345 Since the default is now `only-mvnw`, maybe the current workaround is to simply remove the lines from: https://github.com/apache/maven-wrapper/blob/c9a3e67e5295c41b4a9bc4fd4babe81d20e7e18f/maven-wrapper-distribution/src/resources/mvnw.cmd#L156-L172 Or comment the `if ERRORLEVEL 1 goto error`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
cstamas commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061120774 Oh, got it now. Ok, am closing this one out then, as I missed the topic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
cstamas closed pull request #131: [MWRAPPER-103] Workaround: demote check to Warning URL: https://github.com/apache/maven-wrapper/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
jorsol commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061113392 The issue affects the `wrapperSha256Sum` from `mvnw`, not `only-mvnw`, actually the only-mvnw does not validate the `wrapperSha256Sum` since it doesn't download the jar. In the end, this is not the fix for the issue reported, the trouble is that `only-mvnw` does different things than `mvnw`, so it seems that using `only-mvnw` works and `mvnw` don't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
cstamas commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061082617 @jorsol eyes please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MWRAPPER-103] Workaround: demote check to Warning [maven-wrapper]
cstamas commented on PR #131: URL: https://github.com/apache/maven-wrapper/pull/131#issuecomment-2061082217 @gsmet eyes please. Disclaimer: I am not Win guy, so if you can bring on someone to verify, please do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
