[GitHub] nifi pull request #2089: Nifi-ldap-iaa support for PasswordComparisonAuthent...

[alopresto]

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2089#discussion_r143315312
  
--- Diff: 
nifi-nar-bundles/nifi-ldap-iaa-providers-bundle/nifi-ldap-iaa-providers/src/main/java/org/apache/nifi/ldap/LdapProvider.java
 ---
@@ -193,8 +192,41 @@ public final void onConfigured(final 
LoginIdentityProviderConfigurationContext c
 
 final LdapUserSearch userSearch = new 
FilterBasedLdapUserSearch(userSearchBase, userSearchFilter, context);
 
-// bind
-final BindAuthenticator authenticator = new 
BindAuthenticator(context);
+
+String rawAuthenticatorType = 
configurationContext.getProperty("Authenticator Type");
+AuthenticatorType authenticatorType;
+
+if (StringUtils.isBlank(rawAuthenticatorType))
--- End diff --

Similarly to above, braces are encouraged to be on the same line as control 
statements to reduce code height. You can download the checkstyle rules for 
your IDE and have them automatically applied. 


---

[GitHub] nifi pull request #2089: Nifi-ldap-iaa support for PasswordComparisonAuthent...

[alopresto]

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2089#discussion_r143315219
  
--- Diff: 
nifi-nar-bundles/nifi-ldap-iaa-providers-bundle/nifi-ldap-iaa-providers/src/main/java/org/apache/nifi/ldap/LdapProvider.java
 ---
@@ -38,11 +38,10 @@
 import 
org.springframework.ldap.core.support.SimpleDirContextAuthenticationStrategy;
 import org.springframework.security.authentication.BadCredentialsException;
 import 
org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
+import 
org.springframework.security.authentication.encoding.LdapShaPasswordEncoder;
 import org.springframework.security.core.Authentication;
 import 
org.springframework.security.core.userdetails.UsernameNotFoundException;
-import 
org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider;
-import org.springframework.security.ldap.authentication.BindAuthenticator;
-import 
org.springframework.security.ldap.authentication.LdapAuthenticationProvider;
+import org.springframework.security.ldap.authentication.*;
--- End diff --

I imagine this was your IDE collapsing these imports, but our [coding style 
guidelines](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeStyle)
 discourage the use of wildcard imports. 


---

[GitHub] nifi pull request #2089: Nifi-ldap-iaa support for PasswordComparisonAuthent...

[felixalbani]

GitHub user felixalbani opened a pull request:

https://github.com/apache/nifi/pull/2089

Nifi-ldap-iaa support for PasswordComparisonAuthenticator

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felixalbani/nifi-1 NIFI-4293

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2089


commit 3c8749d5d72d742f65c1890f6f60cd6f58dbe906
Author: Felix Albani 
Date:   2017-08-15T18:47:23Z

Nifi-ldap-iaa support for PasswordComparisonAuthenticator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---