[jira] [Commented] (JDO-764) Allow JDO annotations to be used in meta-annotations
[
https://issues.apache.org/jira/browse/JDO-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031986#comment-16031986
]
Michael Bouschen commented on JDO-764:
--
+1
> Allow JDO annotations to be used in meta-annotations
>
>
> Key: JDO-764
> URL: https://issues.apache.org/jira/browse/JDO-764
> Project: JDO
> Issue Type: Improvement
> Components: api, specification
>Affects Versions: JDO 3.1
>Reporter: Andy Jefferson
> Fix For: JDO 3.2
>
> Attachments: JDO-764.patch
>
>
> By default annotations are used directly in a persistable class. Java
> additionally allows annotations to be formed of other annotations. This is
> particularly useful where a user has a particular combination of annotations
> to set on a class/field/method and wants to simply annotate with an
> abbreviated form. For example, specifying attributes of an annotation
> @PersistenceCapable(detachable="true", identityType="datastore",
> embeddedOnly="true")
> or formed of multiple annotations
> @PersistenceCapable(detachable="true")
> @Extension(vendorName="datanucleus", key="multitenancy-column-name",
> value="TENANT")
> These can be represented as meta-annotations like this
> @Target(TYPE)
> @Retention(RUNTIME)
> @PersistenceCapable(detachable="true", identityType="datastore",
> embeddedOnly="true")
> @interface @DatastoreIdPersistable
> {
> }
> @Target(TYPE)
> @Retention(RUNTIME)
> @PersistenceCapable(detachable="true")
> @Extension(vendorName="datanucleus", key="multitenancy-column-name",
> value="TENANT")
> @interface @MultitenantPersistable
> {
> }
> and the user can subsequently just annotate their persistable class as
> @DatastoreIdPersistable
> public class MyClass1 {...}
> @MultitenantPersistable
> public class MyClass2 {...}
> The work required to support this in the JDO spec is simply to update the
> following annotations to add @Target({ElementType.ANNOTATION_TYPE})
> The annotations requiring this are
> @Element, @EmbeddedId, @Key, @NotPersistent, @Order, @Persistent,
> @Serialized, @Transactional, and @Value (all other annotations already have
> @Target({ElementType.TYPE}) which already permits their usage in
> meta-annotations.
> The same is proposed for JPA 2.2, see
> https://github.com/javaee/jpa-spec/issues/43
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (JDO-761) Add TCK test running sample queries from the spec
[ https://issues.apache.org/jira/browse/JDO-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031983#comment-16031983 ] Michael Bouschen commented on JDO-761: -- Checked in the patch (see revision 1797113). All test pass using DN version 5.1.0-m3-SNAPSHOT. > Add TCK test running sample queries from the spec > - > > Key: JDO-761 > URL: https://issues.apache.org/jira/browse/JDO-761 > Project: JDO > Issue Type: Task > Components: tck >Affects Versions: JDO 3.1 >Reporter: Michael Bouschen >Assignee: Michael Bouschen >Priority: Critical > Fix For: JDO 3.2 > > Attachments: JDO-761-patch.txt > > > Chapter "14.10 Examples" of the JDO specification includes 20 sample > queries. There should be a TCK test class running these queries to make sure > the queries are correct. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (JDO-764) Allow JDO annotations to be used in meta-annotations
[
https://issues.apache.org/jira/browse/JDO-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031822#comment-16031822
]
Craig L Russell commented on JDO-764:
-
+1
This is a really excellent idea.
Get one more vote and check it in!
> Allow JDO annotations to be used in meta-annotations
>
>
> Key: JDO-764
> URL: https://issues.apache.org/jira/browse/JDO-764
> Project: JDO
> Issue Type: Improvement
> Components: api, specification
>Affects Versions: JDO 3.1
>Reporter: Andy Jefferson
> Fix For: JDO 3.2
>
> Attachments: JDO-764.patch
>
>
> By default annotations are used directly in a persistable class. Java
> additionally allows annotations to be formed of other annotations. This is
> particularly useful where a user has a particular combination of annotations
> to set on a class/field/method and wants to simply annotate with an
> abbreviated form. For example, specifying attributes of an annotation
> @PersistenceCapable(detachable="true", identityType="datastore",
> embeddedOnly="true")
> or formed of multiple annotations
> @PersistenceCapable(detachable="true")
> @Extension(vendorName="datanucleus", key="multitenancy-column-name",
> value="TENANT")
> These can be represented as meta-annotations like this
> @Target(TYPE)
> @Retention(RUNTIME)
> @PersistenceCapable(detachable="true", identityType="datastore",
> embeddedOnly="true")
> @interface @DatastoreIdPersistable
> {
> }
> @Target(TYPE)
> @Retention(RUNTIME)
> @PersistenceCapable(detachable="true")
> @Extension(vendorName="datanucleus", key="multitenancy-column-name",
> value="TENANT")
> @interface @MultitenantPersistable
> {
> }
> and the user can subsequently just annotate their persistable class as
> @DatastoreIdPersistable
> public class MyClass1 {...}
> @MultitenantPersistable
> public class MyClass2 {...}
> The work required to support this in the JDO spec is simply to update the
> following annotations to add @Target({ElementType.ANNOTATION_TYPE})
> The annotations requiring this are
> @Element, @EmbeddedId, @Key, @NotPersistent, @Order, @Persistent,
> @Serialized, @Transactional, and @Value (all other annotations already have
> @Target({ElementType.TYPE}) which already permits their usage in
> meta-annotations.
> The same is proposed for JPA 2.2, see
> https://github.com/javaee/jpa-spec/issues/43
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (JDO-764) Allow JDO annotations to be used in meta-annotations
[
https://issues.apache.org/jira/browse/JDO-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Jefferson updated JDO-764:
---
Attachment: JDO-764.patch
Patch providing the extra annotation config to allow use as meta-annotations
> Allow JDO annotations to be used in meta-annotations
>
>
> Key: JDO-764
> URL: https://issues.apache.org/jira/browse/JDO-764
> Project: JDO
> Issue Type: Improvement
> Components: api, specification
>Affects Versions: JDO 3.1
>Reporter: Andy Jefferson
> Fix For: JDO 3.2
>
> Attachments: JDO-764.patch
>
>
> By default annotations are used directly in a persistable class. Java
> additionally allows annotations to be formed of other annotations. This is
> particularly useful where a user has a particular combination of annotations
> to set on a class/field/method and wants to simply annotate with an
> abbreviated form. For example, specifying attributes of an annotation
> @PersistenceCapable(detachable="true", identityType="datastore",
> embeddedOnly="true")
> or formed of multiple annotations
> @PersistenceCapable(detachable="true")
> @Extension(vendorName="datanucleus", key="multitenancy-column-name",
> value="TENANT")
> These can be represented as meta-annotations like this
> @Target(TYPE)
> @Retention(RUNTIME)
> @PersistenceCapable(detachable="true", identityType="datastore",
> embeddedOnly="true")
> @interface @DatastoreIdPersistable
> {
> }
> @Target(TYPE)
> @Retention(RUNTIME)
> @PersistenceCapable(detachable="true")
> @Extension(vendorName="datanucleus", key="multitenancy-column-name",
> value="TENANT")
> @interface @MultitenantPersistable
> {
> }
> and the user can subsequently just annotate their persistable class as
> @DatastoreIdPersistable
> public class MyClass1 {...}
> @MultitenantPersistable
> public class MyClass2 {...}
> The work required to support this in the JDO spec is simply to update the
> following annotations to add @Target({ElementType.ANNOTATION_TYPE})
> The annotations requiring this are
> @Element, @EmbeddedId, @Key, @NotPersistent, @Order, @Persistent,
> @Serialized, @Transactional, and @Value (all other annotations already have
> @Target({ElementType.TYPE}) which already permits their usage in
> meta-annotations.
> The same is proposed for JPA 2.2, see
> https://github.com/javaee/jpa-spec/issues/43
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
