Minutes: JDO TCK Conference Call Wednesday November 22, 9:30 AM Pacific Time (PST)

2017-11-22 Thread Craig Russell
Attendees: Michael Bouschen, Tilmann Zäschke, Craig Russell

Next meeting will be Wednesday December 13 at 9:30 Pacific.

Agenda:

1. JDO-766 "Support more JDBC-aware databases in JDO TCK" 
https://issues.apache.org/jira/browse/JDO-766
2. JDO-765 "TCK should fail if tests fail" 
https://issues.apache.org/jira/browse/JDO-765

Patch was checked in. JIRA resolved. Fixed in: 3.2. Component: TCK.

3. JDO-767 "JDO TCK lifecycle tests fail" 
https://issues.apache.org/jira/browse/JDO-767

Craig, Michael, and Tilmann all see the same five errors in the lifecycle test. 
AI Michael check out a fresh workspace and see what the results are.

4. Failure in api test case testGetPMFNullResource(javax.jdo.JDOHelperTest) 

PMFMapMapTest sets the context class loader to refer to specific directories. 
But at the end of the test, the context class loader is not reset. This causes 
a subsequent test to fail.

Also, the test cases inside the test class have dependencies on other test 
cases. This is a separate issue. It looks like the tests do not test what they 
intended to test.

AI Michael file two JIRAs. 

5. Need to resolve specification lead issue now that Craig is no longer working 
for Oracle.
6. JDO 3.1: Need to go through change lists in JIRA for 3.1 RC1 and 3.1 to 
prepare JCP Change Log
7. Other issues

Action Items from weeks past:

[Oct 30 2015] AI Craig: File a maintenance review with JCP
[Apr 17 2015] AI Craig: Oracle spec page on JDO need to be updated once the JCP 
Maintenance Release for JDO 3.1 is published
[Oct 17 2014] AI Matthew any updates for "Modify specification to address NoSQL 
datastores": https://issues.apache.org/jira/browse/JDO-651?
[Feb 28 2014] AI Everyone: take a look at 
https://issues.apache.org/jira/browse/JDO-712
[Feb 28 2014] AI Everyone: take a look at 
https://issues.apache.org/jira/browse/JDO-625
[Dec 13 2013] AI Craig file a JIRA for java.sql.Blob and java.sql.Clob as 
persistent field types
[Aug 24 2012] AI Craig update the JIRAs JDO-689 JDO-690 and JDO-692 about 
JDOHelper methods. In process.

Craig L Russell
Secretary, Apache Software Foundation
c...@apache.org http://db.apache.org/jdo



[jira] [Updated] (JDO-765) TCK should fail if tests fail

2017-11-22 Thread Michael Bouschen (JIRA)

 [ 
https://issues.apache.org/jira/browse/JDO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bouschen updated JDO-765:
-
Component/s: tck

> TCK should fail if tests fail
> -
>
> Key: JDO-765
> URL: https://issues.apache.org/jira/browse/JDO-765
> Project: JDO
>  Issue Type: Bug
>  Components: tck
>Affects Versions: JDO 3.1
>Reporter: Tilmann Zäschke
>Priority: Trivial
> Fix For: JDO 3.2
>
> Attachments: JDO-765-patch-v4.txt
>
>
> Currently, TCK test failures are reported to the console and in the logs, but 
> the Maven build still succeeds.
> The proposal is to make the behavior configurable, the default being that the 
> Maven build fails if any TCK tests fail.
> The new configuration option would be called "-Djdo.tck.onFailure" and have 
> the following options:
>  * "failFast" will immediately abort the test run. 
>  * "failEventually" (default) will execute the whole TCK before failing. 
>  * "logOnly" will report failures to console and logs only but return 
> 'SUCCESS' to the Maven execution environment.
> Attached is a patch with an implementation of the proposed changes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (JDO-765) TCK should fail if tests fail

2017-11-22 Thread Michael Bouschen (JIRA)

 [ 
https://issues.apache.org/jira/browse/JDO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bouschen reassigned JDO-765:


Assignee: Tilmann Zäschke

> TCK should fail if tests fail
> -
>
> Key: JDO-765
> URL: https://issues.apache.org/jira/browse/JDO-765
> Project: JDO
>  Issue Type: Bug
>  Components: tck
>Affects Versions: JDO 3.1
>Reporter: Tilmann Zäschke
>Assignee: Tilmann Zäschke
>Priority: Trivial
> Fix For: JDO 3.2
>
> Attachments: JDO-765-patch-v4.txt
>
>
> Currently, TCK test failures are reported to the console and in the logs, but 
> the Maven build still succeeds.
> The proposal is to make the behavior configurable, the default being that the 
> Maven build fails if any TCK tests fail.
> The new configuration option would be called "-Djdo.tck.onFailure" and have 
> the following options:
>  * "failFast" will immediately abort the test run. 
>  * "failEventually" (default) will execute the whole TCK before failing. 
>  * "logOnly" will report failures to console and logs only but return 
> 'SUCCESS' to the Maven execution environment.
> Attached is a patch with an implementation of the proposed changes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (JDO-765) TCK should fail if tests fail

2017-11-22 Thread Michael Bouschen (JIRA)

 [ 
https://issues.apache.org/jira/browse/JDO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bouschen updated JDO-765:
-
Affects Version/s: JDO 3.1

> TCK should fail if tests fail
> -
>
> Key: JDO-765
> URL: https://issues.apache.org/jira/browse/JDO-765
> Project: JDO
>  Issue Type: Bug
>Affects Versions: JDO 3.1
>Reporter: Tilmann Zäschke
>Priority: Trivial
> Fix For: JDO 3.2
>
> Attachments: JDO-765-patch-v4.txt
>
>
> Currently, TCK test failures are reported to the console and in the logs, but 
> the Maven build still succeeds.
> The proposal is to make the behavior configurable, the default being that the 
> Maven build fails if any TCK tests fail.
> The new configuration option would be called "-Djdo.tck.onFailure" and have 
> the following options:
>  * "failFast" will immediately abort the test run. 
>  * "failEventually" (default) will execute the whole TCK before failing. 
>  * "logOnly" will report failures to console and logs only but return 
> 'SUCCESS' to the Maven execution environment.
> Attached is a patch with an implementation of the proposed changes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (JDO-765) TCK should fail if tests fail

2017-11-22 Thread Michael Bouschen (JIRA)

 [ 
https://issues.apache.org/jira/browse/JDO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bouschen updated JDO-765:
-
Fix Version/s: JDO 3.2

> TCK should fail if tests fail
> -
>
> Key: JDO-765
> URL: https://issues.apache.org/jira/browse/JDO-765
> Project: JDO
>  Issue Type: Bug
>Affects Versions: JDO 3.1
>Reporter: Tilmann Zäschke
>Priority: Trivial
> Fix For: JDO 3.2
>
> Attachments: JDO-765-patch-v4.txt
>
>
> Currently, TCK test failures are reported to the console and in the logs, but 
> the Maven build still succeeds.
> The proposal is to make the behavior configurable, the default being that the 
> Maven build fails if any TCK tests fail.
> The new configuration option would be called "-Djdo.tck.onFailure" and have 
> the following options:
>  * "failFast" will immediately abort the test run. 
>  * "failEventually" (default) will execute the whole TCK before failing. 
>  * "logOnly" will report failures to console and logs only but return 
> 'SUCCESS' to the Maven execution environment.
> Attached is a patch with an implementation of the proposed changes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (JDO-767) JDO TCK lifecycle tests fail

2017-11-22 Thread Andy Jefferson (JIRA)

[ 
https://issues.apache.org/jira/browse/JDO-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262323#comment-16262323
 ] 

Andy Jefferson commented on JDO-767:


JDO TCK (SVN trunk) passes for me, and always has from the point where DN 
passed it for the first time; I don't release code that breaks tests (ever). If 
someone gets some failure then they see something I don't see, so they need to 
investigate it.

PS DN "lifecycle state transition" code has not changed in years either.

> JDO TCK lifecycle tests fail
> 
>
> Key: JDO-767
> URL: https://issues.apache.org/jira/browse/JDO-767
> Project: JDO
>  Issue Type: Bug
>  Components: tck
>Affects Versions: JDO 3.1
>Reporter: Craig L Russell
>Assignee: Tilmann Zäschke
> Fix For: JDO 3.2
>
>
> cat dsid-lifecycle-tck.txt 
> 10:14:11,507 (main) INFO  [org.apache.jdo.tck] - Exception during setUp or 
> runtest: 
> junit.framework.AssertionFailedError: 
> Assertion A5.6.2-6 (NontransactionalWriteDatastoreRollback) failed: after 
> datastore rollback
> expected: 100
>   actual: 999
>   at junit.framework.Assert.fail(Assert.java:47)
>   at org.apache.jdo.tck.JDO_Test.failOnError(JDO_Test.java:1245)
>   at 
> org.apache.jdo.tck.lifecycle.NontransactionalWriteDatastoreRollback.testDatastoreRollback(NontransactionalWriteDatastoreRollback.java:87)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:154)
>   at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:284)
>   at junit.framework.TestResult$1.protect(TestResult.java:106)
>   at junit.framework.TestResult.runProtected(TestResult.java:124)
>   at junit.framework.TestResult.run(TestResult.java:109)
>   at junit.framework.TestCase.run(TestCase.java:118)
>   at junit.framework.TestSuite.runTest(TestSuite.java:208)
>   at junit.framework.TestSuite.run(TestSuite.java:203)
>   at junit.framework.TestSuite.runTest(TestSuite.java:208)
>   at junit.framework.TestSuite.run(TestSuite.java:203)
>   at junit.textui.TestRunner.doRun(TestRunner.java:116)
>   at 
> org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:108)
>   at 
> org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:148)
>   at 
> org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:123)
> 10:14:11,527 (main) INFO  [org.apache.jdo.tck] - Exception during setUp or 
> runtest: 
> junit.framework.AssertionFailedError: 
> Assertion A5.6.2-4 (NontransactionalWriteDatastoreCommitConflict) failed: 
> after datastore commit with conflict
> expected: 999
>   actual: 555
>   at junit.framework.Assert.fail(Assert.java:47)
>   at org.apache.jdo.tck.JDO_Test.failOnError(JDO_Test.java:1245)
>   at 
> org.apache.jdo.tck.lifecycle.NontransactionalWriteDatastoreCommitConflict.testDatastoreCommitConflict(NontransactionalWriteDatastoreCommitConflict.java:90)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:154)
>   at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:284)
>   at junit.framework.TestResult$1.protect(TestResult.java:106)
>   at junit.framework.TestResult.runProtected(TestResult.java:124)
>   at junit.framework.TestResult.run(TestResult.java:109)
>   at junit.framework.TestCase.run(TestCase.java:118)
>   at junit.framework.TestSuite.runTest(TestSuite.java:208)
>   at junit.framework.TestSuite.run(TestSuite.java:203)
>   at junit.framework.TestSuite.runTest(TestSuite.java:208)
>   at junit.framework.TestSuite.run(TestSuite.java:203)
>   at junit.textui.TestRunner.doRun(TestRunner.java:116)
>   at 
> org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:108)
>   at 
> org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:148)
>   at 
> org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:123)
> 10:14:11,532 (main) INFO  [org.apache.jdo.tck] - Exception during setUp or 
> runtest: 
> junit.framework.AssertionFailedError: 
> Assertion A5.6.2-10 (NontransactionalWriteOptimisticRollback) failed: after 
> optimistic rollback
> expected: 100
>   actual: 999
>   at junit.framework.Assert.fail(Assert.java:47)
>   at