[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172342#comment-16172342 ] Michael Bouschen commented on JDO-749: -- Checked in the patch (see revision 1808943). > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson >Assignee: Michael Bouschen > Fix For: JDO 3.2 > > Attachments: JDO-749-patch.txt > > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108420#comment-15108420 ] Andy Jefferson commented on JDO-749: Java8 Expressions now added to jdo-api > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Fix For: JDO 3.2 > > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005255#comment-15005255 ] Andy Jefferson commented on JDO-749: Actually, after doing a few tests with Java7 and Java8, we cannot simply add Java8 related classes to jdo-api compile to 1.8 and run with 1.7, since some operations have a check on major.minor version and it finds the jdo-api with major.minor as 52.0. Ways around this are 1. Have 2 jdo-api jars. One for java7 and one for java8 (with the java.time support), and the user pulls in the one they require. 2. Just move to java8 minimum > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Fix For: JDO 3.2 > > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902597#comment-14902597 ] Tilmann Zäschke commented on JDO-749: - Thanks for the clarification on 1.7/1.8. I'll move the discussion about the query API to https://issues.apache.org/jira/browse/JDO-652, I think this might be a more appropriate place. > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902427#comment-14902427 ] Tilmann Zäschke commented on JDO-749: - I fully support moving to Java 1.8. But I'm not sure that it is possible to release source/target JRE 1.7 code using an 1.8 JDK. At least I used to have problem releasing 1.6 using a 1.7 JDK, and it didn't even contain 1.7 specific code. Could you clarify how/that 1.8 code can be back-compiled to 1.7? And something taht is a bit off-topic: If we really move to a 1.8 API, maybe it would make sense to rediscuss the new query API. Would it make sense to design it in a way that it is compatible with the Java 8 streams and possibly lambdas? > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902332#comment-14902332 ] Andy Jefferson commented on JDO-749: So the real question is, is everyone ok with updating the (minimum) JDK that Apache JDO needs to be developed with to 1.8? (after all 1.7 is past EOL). With that we can add support for JDK 1.8 types in the API (for JDO 3.2), add tests for them in the TCK, whilst still releasing jars that have 1.7 1.7 > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902561#comment-14902561 ] Andy Jefferson commented on JDO-749: I can add Java 8 classes to a project with those maven compile directives, and have JAVA_HOME set to JDK 1.8 (so using a JDK 1.8 compiler), and do a mvn clean install, and it compiles/installs. At runtime if running with JRE 1.8 and I make use of a LocalXXX class it works fine, and if I'm at runtime with JRE 1.7 then I won't have any LocalXXX class in my persistence capable classes so no problem there either. Since there are no explicit references to the JDK 1.8 classes in any class that a JRE 1.7 user will be instantiating then there is no problem at runtime when using JRE 1.7 (i.e this is a *specific case* of using JDK 1.8 classes without referring to them in non JRE 1.8 code). Admittedly some IDE's have issues with such a setup and the better solution is to go to JRE 1.8 for all; question of timing. And about yet another 'redesign' of the query API, we have waited nearly 3 years for this one from the provision of the DN TypesafeQuery API with little input from others. Bear in mind that I wouldn't be contributing much time, so if you want it then you need to provide time/ideas/implementations/tests. > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875871#comment-14875871 ] Craig L Russell commented on JDO-749: - Is it possible to require this support only when the runtime is java 8? I like the functionality but have no interest in back-porting the new classes to java 7, which JDO still supports. > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-749) Support for java.time types, and querying using associated methods
[ https://issues.apache.org/jira/browse/JDO-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875955#comment-14875955 ] Andy Jefferson commented on JDO-749: The XXXExpression classes could be included in the JDO API, but with the proviso that the JDO API would need to be built using JDK 1.8 (though runnable for JRE 1.7+). > Support for java.time types, and querying using associated methods > -- > > Key: JDO-749 > URL: https://issues.apache.org/jira/browse/JDO-749 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > > Refer to an associated issue for JPA for what support should look like > https://java.net/jira/browse/JPA_SPEC-63 > The methods that should be supported in queries would initially be > LocalDateTime : getDayOfMonth, getMonth, getYear, getHour, getMinute, > getSecond > LocalTime : getHour, getMinute, getSecond > LocalDate : getDayOfMonth, getMonth, getYear > These would need to be part of JDOQL string-based, as well as the > JDOQLTypedQuery (hence have equivalent Expression classes). > Note that all of these are already implemented in DataNucleus, and there are > JDOQLTypedQuery expression classes available. > Timing of this simply depends on the JRE that the next release of JDO is > targetted at, since this needs Java 8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
