Re: Behavior of Enable/Disable

2010-02-23 Thread Patrick Radtke
On Mon, Feb 22, 2010 at 2:18 PM, sebb seb...@gmail.com wrote:
 On 22/02/2010, Patrick Radtke prad...@nulli.com wrote:
 Hi All,

  We found that the current behavior of enable/disable to not be what we
  desire when using the tool.
  The current behavior is to just enable/disable the selected component,
  while in our use we found we always wanted to enable/disable the
  current component and all sub components.

 Not sure I follow why there is a problem.

 If you disable a Controller, then it does not run, and neither do any
 of its sub-components.

 If you disable a Sampler, then any subcomponents such as Listeners and
 Assertions won't run.

 So I don't follow how the proposed changes will help.

D'oh, I guess I should have tried that!
We had just assumed you had to to disable everything underneath as well.

-Patrick

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



Behavior of Enable/Disable

2010-02-22 Thread Patrick Radtke
Hi All,

We found that the current behavior of enable/disable to not be what we
desire when using the tool.
The current behavior is to just enable/disable the selected component,
while in our use we found we always wanted to enable/disable the
current component and all sub components.

We would like to contribute this patch back.
I can thing of the following ways to integrate this back in:
1. Replace the current behavior with the new behavior.
2. Add  two more menu items 'Enable Subtree'/'Disable Subtree' to the
component's contextual menu.
3. Create two sub menus called 'Enable' and 'Disable' and within each
of those have a menu item for the current behavior and the new
behavior.

Anyone have any thoughts of which of the 3 is best? Doing #2 or #3
would require localizing the new menu item text into other languages.

-Patrick

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



Re: Behavior of Enable/Disable

2010-02-22 Thread sebb
On 22/02/2010, Patrick Radtke prad...@nulli.com wrote:
 Hi All,

  We found that the current behavior of enable/disable to not be what we
  desire when using the tool.
  The current behavior is to just enable/disable the selected component,
  while in our use we found we always wanted to enable/disable the
  current component and all sub components.

Not sure I follow why there is a problem.

If you disable a Controller, then it does not run, and neither do any
of its sub-components.

If you disable a Sampler, then any subcomponents such as Listeners and
Assertions won't run.

So I don't follow how the proposed changes will help.

  We would like to contribute this patch back.
  I can thing of the following ways to integrate this back in:
  1. Replace the current behavior with the new behavior.
  2. Add  two more menu items 'Enable Subtree'/'Disable Subtree' to the
  component's contextual menu.
  3. Create two sub menus called 'Enable' and 'Disable' and within each
  of those have a menu item for the current behavior and the new
  behavior.

  Anyone have any thoughts of which of the 3 is best? Doing #2 or #3
  would require localizing the new menu item text into other languages.

  -Patrick

  -
  To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
  For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org