Re: [kaffe] picky patch
Hi Rob, hi Tim --- gonzo [EMAIL PROTECTED] wrote: Hi all. in code-analyze.[ch], the methods are currently entitles verifyMethod, verifyBasicBlock, tidyVerifyMethod, etc., and these are called from intrp/machine.c, jit/machine.c, and jit3/machine.c to perform code analysis before compilation (from intrp i think they are actually expected to verify the soundness of the bytecode, which will be totally unecessary once a full link-time verifier is added). the methods that are called for actual link-time verification are verify2 and verify3 in verify.c. to avoid confusing the compiler, in my working copy of kaffe i've renamed the methods in code-analyze.[ch] analyzeMethod, analyzeBasicBlock, etc., and every time i upgrade to a newer version of CVS i have to patch the names. Sounds o.k. to me to rename the methods if they don't perform verification at all. But before I check it in, I'd like to see class-analyze.[ch] from JanosVM merged into the kaffe CVS tree. There are two main diffs: CIF_* stuff, which is used in jit3 and powerpc jit and memory management changes, i.e. moving from KMALLOC to gc_malloc. Tim, should I merge it in as it is, and pull the jit3 changes in as well, plus the powerpc jitter, or leave the memory management stuff out, etc.? cheers, dalibor topic __ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com ___ kaffe mailing list [EMAIL PROTECTED] http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
Re: [kaffe] picky patch
Hi Rob, hi Tim hi, Sounds o.k. to me to rename the methods if they don't perform verification at all. ditto But before I check it in, I'd like to see class-analyze.[ch] from JanosVM merged into the kaffe CVS tree. There are two main diffs: CIF_* stuff, This change is a bit sketchy, i wouldn't add it yet. which is used in jit3 and powerpc jit and memory management changes, i.e. moving from KMALLOC to gc_malloc. Tim, should I merge it in as it is, and pull the jit3 changes in as well, plus the powerpc jitter, or leave the memory management stuff out, etc.? Maybe, maybe not. The next release will have a bunch of changes related to this, so you might want to wait a bit before making a decision on which bits to merge in. cheers, dalibor topic tim ___ kaffe mailing list [EMAIL PROTECTED] http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
Re: [kaffe] picky patch
Hi Dalibor and Tim, to avoid confusing the compiler, in my working copy of kaffe i've renamed the methods in code-analyze.[ch] analyzeMethod, analyzeBasicBlock, etc., and every time i upgrade to a newer version of CVS i have to patch the names. Sounds o.k. to me to rename the methods if they don't perform verification at all. But before I check it in, I'd like to see class-analyze.[ch] from JanosVM merged into the kaffe CVS tree. at the moment code-analyze.c does actually perform enough verification to ensure the consistency of the bytecode. things like making sure the max size of the operand stack and locals are never violated, and it also appears to do basic type checking (ie - making sure you don't use iload_0 when local 0 is holding a reference). it doesn't do type checking and lots of other stuff a verifier has to take care of, though (if it did, i wouldn't have written my own ;) ). once the actual verifier is done, i'm going to take a closer look at code-analyze's functions to see what can be stripped out if the bytecode is known to be verfied. that is, it would be nice if i could leave those files with just the code that's necessary to prepare codeInfo structions for jit compilation. cheers, ~rob ___ kaffe mailing list [EMAIL PROTECTED] http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
