[frameworks-kio] [Bug 346403] kdialog freezes when startDir in --getopenfilename contains a lot of files

2016-10-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=346403

--- Comment #9 from David Faure  ---
Thanks for the backtraces. They don't necessarily indicate "hanging in
libharfbuzz".
More likely, KFilePreviewGenerator::Private::dispatchIconUpdateQueue() is
triggering dataChanged for one item at a time, just like in the bug I fixed.

This confirms my suspicion that it's related to previews. I don't mean the side
panel, I mean the icons themselves turning into a preview of the file (e.g. for
images, you see the image in small instead of the generic "this is an image"
icon). To confirm this, you can try again without previews enabled (although
the actual action of disabling previews will be slow until you get my bugfix --
better do that in a small folder before going back to the big folder).

The way to find out if it's hanging in harfbuzz is simple: once you're in gdb,
do
break KDirModel::itemChanged
cont
and you should see that it does continue, and it will hit itemChanged again,
and again (once per file).
This goes back to the event loop between files though, i.e. it's supposed to be
happening "in the background" while you can still use the dialog. That's
definitely what I see here.

In /usr/bin the issue is: most files don't have an extension, so mimetype
determination has to happen (by reading the contents of the file), and this too
happens delayed (in the background), from the same KFilePreviewGenerator class
(yes, it does more than the name indicate, it does mimetype determination and
previews). So it's likely the same issue, just triggered slightly differently.
I expect it to make the app more busy in fact, given that previews are
generated by a separate process (kioslave) so in theory the app (kdialog here)
should be waiting for the preview to come in (just a little bit).

Anyhow, I'm a bit puzzled because when previews are generated, then yes it's
expected that the view will re-layout one item at a time. It's what happens
here, it's what happens for you... but somehow the user visible behaviour seems
different? Or my machine is too powerful for me to find it slow

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 346403] kdialog freezes when startDir in --getopenfilename contains a lot of files

2016-10-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=346403

--- Comment #8 from David Faure  ---
Git commit 09cd8420e6c901a482c346fdaf4bc1cc38587646 by David Faure.
Committed on 13/10/2016 at 16:52.
Pushed by dfaure into branch 'master'.

Major performance improvement when turning previews off in the file dialog.

Added a method for this KDirModel so it can emit dataChanged only once
(or once per dir in a tree) rather than for every item.
REVIEW: 129159

M  +0-10   src/filewidgets/kdiroperator.cpp
M  +1-24   src/filewidgets/kfilepreviewgenerator.cpp
M  +27   -1src/widgets/kdirmodel.cpp
M  +7-0src/widgets/kdirmodel.h

http://commits.kde.org/kio/09cd8420e6c901a482c346fdaf4bc1cc38587646

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 346403] kdialog freezes when startDir in --getopenfilename contains a lot of files

2016-10-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=346403

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org,
   ||kdelibs-b...@kde.org
Product|kfile   |frameworks-kio
   Assignee|br...@frogmouth.net |fa...@kde.org
  Component|general |general

--- Comment #3 from David Faure  ---
The right product is kio, reassigning.

I can reproduce major slowness when clicking on the button to turn previews off
in the file dialog, and I have just fixed that. However I don't see the
slowness otherwise. Is this with previews on or off ? What type of files, in
terms of extension and content ?

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 368999] Folders ending with a space in their name are not retrieved from Folder View

2016-09-27 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368999

--- Comment #2 from David Faure  ---
Bug in QUrl, actually.

qDebug() << "in:" << urlArg;
QUrl url = QUrl::fromUserInput(urlArg, QDir::currentPath());
qDebug() << "out:" << url;

in: "/home/dfaure/bugs/trailing space "
out: QUrl("file:///home/dfaure/bugs/trailing space")

I'll keep digging and I'll fix it in Qt.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdesrc-build] [Bug 368070] kdesrc-build-setup is still about Qt 4

2016-09-06 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368070

--- Comment #2 from David Faure  ---
FindQt4.cmake was using qmake.

Qt5 installs cmake config files, which cmake picks up using CMAKE_PREFIX_PATH
unless it's in a standard location. qmake is not involved at all (except in the
bit of code in ECM that uses qmake -query to find out where the qt plugins are
installed, but that's very minor). I'm 100% sure that CMAKE_PREFIX_PATH should
be set.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 367998] quick-search field does not receive some keys

2016-09-03 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367998

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #1 from David Faure  ---
Do you mean that typing "cvs" always loses focus while typing it, or only when
doing this shortly after switching to another folder ?

The bug I know about (and fixed in https://phabricator.kde.org/D2642, pending
review; feel free to test this patch) happens when typing into a quick-search
filter (any one of the two) just after switching folders, because the
messagelist steals focus at the end of the folder loading (when enabling one of
the options like "select the last message" or "select the first unread email").

Is this what you mean, or something else?

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdesrc-build] [Bug 368070] New: kdesrc-build-setup is still about Qt 4

2016-08-31 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368070

Bug ID: 368070
   Summary: kdesrc-build-setup is still about Qt 4
   Product: kdesrc-build
   Version: Git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: setup wizard
  Assignee: mp...@kde.org
  Reporter: fa...@kde.org

I see  "~/qt4" and "branch 4.8" in kdesrc-build-setup (and the qt 4 git repo),
it looks like it should be updated.

I was looking at this when trying to help a new kdesrc-build user on IRC, and
it made me wonder about something else: when people install qt in a custom dir
like ~/qt5, I think they need to pass -DCMAKE_PREFIX_PATH=$HOME/qt5 to cmake so
that qt5 is picked up, right? That's something kdesrc-build could do
automatically based on the value of "qtdir" ...

Reproducible: Always

-- 
You are receiving this mail because:
You are watching all bug changes.


[dolphin] [Bug 366795] "Paste one file"/Ctrl-V disabled when copying a local file to an smb share

2016-08-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366795

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #6 from David Faure  ---
Ah, I think this happens when the slave doesn't emit a UDSItem for "." in its
directory listing.
This leads to a null root item, which leads (now) to the action being disabled.

I would say that's a bug in the slave, it's supposed to emit a UDSItem for ".".

-- 
You are receiving this mail because:
You are watching all bug changes.


[www.kde.org] [Bug 366750] Frameworks 5.25.0 is displayed as 5.25.0.0 -> link not found

2016-08-16 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366750

--- Comment #2 from David Faure  ---
Git commit a4ef90d64f065f439a20e7d04f900d1422e96bee by David Faure.
Committed on 16/08/2016 at 18:12.
Pushed by dfaure into branch 'frameworks/5.0'.

Fix wrong additional .0 in new automation for index.php

Thanks to cfeck and lueck for noticing and fixing for 5.25!

M  +1-1create_sources_inc

http://commits.kde.org/sysadmin/release-tools/a4ef90d64f065f439a20e7d04f900d1422e96bee

-- 
You are receiving this mail because:
You are watching all bug changes.


[kate] [Bug 354613] "/XXX is a file, but a folder was expected." (for FTP)

2016-08-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354613

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #1 from David Faure  ---
I think commit 18e62e7 in plasma-integration fixed this.
Does it still happen with plasma >= 5.6.1 ?

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 75324] Integrate KIO Slaves into file system using FUSE gateway

2016-08-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=75324

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
   Assignee|fa...@kde.org   |vla...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 75324] Integrate KIO Slaves into file system using FUSE gateway

2016-08-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=75324

--- Comment #27 from David Faure  ---
"Not all platforms support FUSE" is only the argument why we don't use FUSE
_instead_ of our current solution in KIO (like gnome does AFAIK). But I would
say this isn't what is being discussed here, which is rather about an
*additional* KIO-over-FUSE feature.

The reason I don't like it is GUI apps being blocked (for a VERY long time)
when pulling the plug (i.e. losing connection to the server, for whichever
reason).

But if you like it, despite that risk, you can
1) resurrect https://techbase.kde.org/Projects/KioFuse
2) use sshfs

I would reassign the bug report to kiofuse if it actually had a bugzilla
product/component.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 359581] wrong file permissions (umask 000) when using right click -> create new file

2016-08-06 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359581

David Faure  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kio/ |http://commits.kde.org/kio/
   |dc8588efe72a5ca7670d0371537 |b61fcd1878d4df39f57b3e94788
   |d99a0d4c690f5   |5e63cba670843
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #9 from David Faure  ---
Git commit b61fcd1878d4df39f57b3e947885e63cba670843 by David Faure.
Committed on 06/08/2016 at 21:31.
Pushed by dfaure into branch 'master'.

Fix KIO::put("file:///path") to respect the umask.

(Bug introduced when porting kio_file to QFile, in KF 5.0)

This fixes permissions on files created with "Create New...".
FIXED-IN: 5.25

M  +23   -1autotests/knewfilemenutest.cpp
M  +5-9src/ioslaves/file/file.cpp

http://commits.kde.org/kio/b61fcd1878d4df39f57b3e947885e63cba670843

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdelibs] [Bug 297020] Annoying but harmless warning message on startup of every KUniqueApplication: QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbeha

2016-08-05 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=297020

David Faure  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #44 from David Faure  ---
This has been fixed by deprecating KUniqueApplication in KF 5.0 and porting the
apps to KDBusService instead.

-- 
You are receiving this mail because:
You are watching all bug changes.


[keditbookmarks] [Bug 258505] Tried to drag the links into a folder [qDeleteAll<QList<TreeItem*> >, ~TreeItem, TreeItem::deleteChildren, KBookmarkModel::removeBookmark]

2016-08-05 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=258505

David Faure  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kde-
   ||baseapps/e1dfe34c61ea4eae30
   ||b3392c953a99ed948bbc55

--- Comment #33 from David Faure  ---
Git commit e1dfe34c61ea4eae30b3392c953a99ed948bbc55 by David Faure.
Committed on 05/08/2016 at 20:59.
Pushed by dfaure into branch 'master'.

keditbookmarks: fix two bugs due to delayed-init in treeitem.

This led to asserts and/or crashes during drag-n-drop or sorting.

With thanks to Nick Leverton for the reproducible testcase (turned into
a unittest).

M  +8-2keditbookmarks/kbookmarkmodel/commands.cpp
M  +8-1keditbookmarks/kbookmarkmodel/model.cpp
M  +48   -0keditbookmarks/kbookmarkmodel/tests/kbookmarkmodeltest.cpp
A  +414  -0keditbookmarks/kbookmarkmodel/tests/kde-bug-258505-bookmarks.xml
M  +8-0keditbookmarks/kbookmarkmodel/treeitem.cpp

http://commits.kde.org/kde-baseapps/e1dfe34c61ea4eae30b3392c953a99ed948bbc55

-- 
You are receiving this mail because:
You are watching all bug changes.


[keditbookmarks] [Bug 258505] Tried to drag the links into a folder [qDeleteAll<QList<TreeItem*> >, ~TreeItem, TreeItem::deleteChildren, KBookmarkModel::removeBookmark]

2016-08-05 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=258505

David Faure  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #32 from David Faure  ---
Nice testcase, I made it into a unittest and I found the two bugs (the null
pointer in comments 19 & 20, and the crash in deleteChildren). First one fixed,
second fix coming up.

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 157272] disable system notification for all applications should be possible (as in kde 3.5.x) (disable sounds for all apps)

2016-08-02 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=157272

--- Comment #30 from David Faure  ---
I couldn't go to Plasma 5.7 due to the KF-5.24 requirement, so this will be in
Plasma 5.8 (October)

https://community.kde.org/Schedules/Plasma_5

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 358116] messageviewer leaks temporary files with mail parts in it

2016-08-01 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358116

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||fa...@kde.org

--- Comment #8 from David Faure  ---
This was fixed (for the case of cleanly quitting kmail) in c803a7a (v16.07.80).
Please test.

We can't do much in case of crashes -- except fixing those crashes in the first
place, of course :-)

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #9 from David Faure  ---
Fixed by
http://commits.kde.org/kcalcore/3023b48e9782ae047c3f9edf122e1cd4958f5e82

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

--- Comment #8 from David Faure  ---
Found a Qt bug report about this, reopened it with more details,
https://bugreports.qt.io/browse/QTBUG-51758.

Meanwhile it's quite pointless to do all this for an empty container, I'll add
an if() in kcalcore, good for performance, not just as a workaround.

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

--- Comment #7 from David Faure  ---
I have reduced the issue to this testcase, which crashes indeed.

QVector vec;
vec.erase(std::remove(vec.begin(), vec.end(), 42), vec.end());
vec.reserve(0);

-- 
You are receiving this mail because:
You are watching all bug changes.


[kcalcore] [Bug 362724] enable calendar

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362724

David Faure  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED
 CC||fa...@kde.org

--- Comment #3 from David Faure  ---


*** This bug has been marked as a duplicate of bug 355736 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 CC||m...@xanum.uam.mx

--- Comment #6 from David Faure  ---
*** Bug 362724 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korgac] [Bug 358152] korganizer reminder tool crashes at akonadi/kontact start

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358152

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #2 from David Faure  ---


*** This bug has been marked as a duplicate of bug 355736 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korgac] [Bug 362012] akonadi crashes whenever I try to start it from the command line

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362012

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from David Faure  ---


*** This bug has been marked as a duplicate of bug 355736 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 362183] crash while adding new event

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362183

David Faure  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||fa...@kde.org

--- Comment #1 from David Faure  ---


*** This bug has been marked as a duplicate of bug 355736 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 CC||christiande...@web.de

--- Comment #3 from David Faure  ---
*** Bug 358152 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 CC||amos.elb...@gmail.com

--- Comment #4 from David Faure  ---
*** Bug 362012 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|korganizer-de...@kde.org|fa...@kde.org
 CC||korganizer-de...@kde.org
 Ever confirmed|0   |1

--- Comment #2 from David Faure  ---
Also happens when disabling/re-enabling some calendars, same backtrace.

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 CC||kol...@aon.at

--- Comment #5 from David Faure  ---
*** Bug 362183 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 355736] korganizer crashes in QVector<QSharedPointer >::reserve(int)

2016-07-25 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355736

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
Summary|korganizer crashes when |korganizer crashes in
   |'akonadictl restart' is run |QVector::reserve(int)

-- 
You are receiving this mail because:
You are watching all bug changes.


[dolphin] [Bug 359581] wrong file permissions (umask 000) when using right click -> create new file

2016-07-24 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359581

David Faure  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kio/
   ||dc8588efe72a5ca7670d0371537
   ||d99a0d4c690f5
   Version Fixed In||5.25
 Resolution|DUPLICATE   |FIXED

--- Comment #6 from David Faure  ---
Git commit dc8588efe72a5ca7670d0371537d99a0d4c690f5 by David Faure.
Committed on 24/07/2016 at 09:41.
Pushed by dfaure into branch 'master'.

KNewFileMenu: fix copying template file from embedded resource

Fix from Wolfgang Bauer, unittest from me.
FIXED-IN: 5.25
REVIEW: 128510

M  +12   -2autotests/knewfilemenutest.cpp
M  +3-1src/filewidgets/knewfilemenu.cpp

http://commits.kde.org/kio/dc8588efe72a5ca7670d0371537d99a0d4c690f5

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdesrc-build] [Bug 365813] options doesn't work for module-sets

2016-07-24 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365813

David Faure  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #2 from David Faure  ---
Thanks for the patch, much appreciated, I needed this to be able to work on
kdepim ;)
Tested to work, please push the change.

"could end up meaning two separate things" is already a problem, I think, when
having a module and a module-set with the same name. For instance,
kf5-extragear-build-include says

module-set kmymoney
repository kde-projects
use-modules kdiagram alkimia kmymoney
end module-set

What happens when doing "kdesrc-build kmymoney" is that it builds the
module-set, which also means one can't *just* rebuild the module alone. And,
with this patch, "options kmymoney" would always apply to the whole module-set
rather than just one module. It seems to me that module-set-options wouldn't be
ideal because it would fix the 2nd issue while "kdesrc-build kmymoney" would
still be ambiguous.

The obvious best solution to that problem is to not use module names for
module-sets, since this makes us lose flexibility. Therefore I would rename
these badly named module sets ("akonadi" could very well be "kde-pim-akonadi",
in fact that module set name is useless, maybe "module" would have been enough?
(I forgot it that would use branch-group settings...)).

And then if we make sure that we don't have conflicts anymore (=> your
suggestion of a warning sounds good), we can keep using "options" for both (so
this patch is fine).

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 349789] Local Folders Disappear when Last Search Deleted

2016-07-22 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349789

David Faure  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kite
   ||mmodels/e2a688651cc5fb3cca6
   ||82c4153866609713e76a9
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.25
 Resolution|--- |FIXED

--- Comment #4 from David Faure  ---
Git commit e2a688651cc5fb3cca682c4153866609713e76a9 by David Faure.
Committed on 22/07/2016 at 22:09.
Pushed by dfaure into branch 'master'.

KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out
rowsRemoved signal

If the row being removed from the source model isn't shown by KRFPM,
it's correct that we don't need to emit any signals, however we still
need to tell our base class QSFPM so that it updates the mappings
of the visible siblings below that removed row.

Testcase: deleting the Last Search folder in kmail
(full integration test for this testcase will be added to mailcommon).

REVIEW: 128428
FIXED-IN: 5.25

M  +3-1autotests/krecursivefilterproxymodeltest.cpp
M  +0-20   src/krecursivefilterproxymodel.cpp

http://commits.kde.org/kitemmodels/e2a688651cc5fb3cca682c4153866609713e76a9

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 363673] Popup menu - Create New - Link to Application does nothing useful

2016-07-22 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363673

David Faure  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kio/
   ||525232d30ee682de4778667c824
   ||4778b50620e67
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.25
 Resolution|--- |FIXED

--- Comment #4 from David Faure  ---
Git commit 525232d30ee682de4778667c8244778b50620e67 by David Faure, on behalf
of Chinmoy Ranjan Pradhan.
Committed on 22/07/2016 at 22:01.
Pushed by dfaure into branch 'master'.

KNewFileMenu: Fix creating link to application

This was broken since the switch to resource files as input files.
KPropertiesDialog does not support that, so a temp file has to be created first
(and deleted when the properties dialog is closed)
FIXED-IN: 5.25
REVIEW: 128501

M  +33   -4src/filewidgets/knewfilemenu.cpp
M  +1-0src/filewidgets/knewfilemenu.h

http://commits.kde.org/kio/525232d30ee682de4778667c8244778b50620e67

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 343673] KDEInit could not launch

2016-07-21 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=343673

David Faure  changed:

   What|Removed |Added

 CC||hrvoje.sen...@gmail.com

--- Comment #27 from David Faure  ---
*** Bug 337889 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 337889] Klauncher blocks upon starting DBusMulti applications

2016-07-21 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337889

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from David Faure  ---


*** This bug has been marked as a duplicate of bug 343673 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdesrc-build] [Bug 365813] New: options doesn't work for module-sets

2016-07-18 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365813

Bug ID: 365813
   Summary: options doesn't work for module-sets
   Product: kdesrc-build
   Version: Git
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: mp...@kde.org
  Reporter: fa...@kde.org

I would like to keep using branch-group kf5-qt5 (for KF5 itself, for the
workspace, for most apps, etc.) but I would like to switch to
Applications/16.08 for the kde pim stack.


Reproducible: Always

Steps to Reproduce:
The modules that make up "kde pim" are a very large number (hmm what's the
proper English sentence for this?).

They are defined in 3 module-sets in kf5-kdepim-build-include:
 akonadi kde-pimlibs kde-pim
Therefore my attempt, to avoid forking kf5-kdepim-build-include, was to write,
in my kdesrc-buildrc:

include extragear/utils/kdesrc-build/kf5-qt5-build-include

options akonadi
branch Applications/16.08
end options
options kde-pimlibs
branch Applications/16.08
end options
options kde-pim
branch Applications/16.08
end options


Actual Results:  
This works well for akonadi, because that's the module name, but not for the
others, e.g. kdesrc-build kde-pimlibs shows

Building kcontacts from kde-pimlibs (1/43)
Updating kcontacts (to branch master)


Expected Results:  
Could "options" for a module-set be applied to all the modules of the
module-set ?

Alternatively you might prefer a more explicit module-set-options, don't know
what fits best with kdesrc-build's overall design for modules and module-sets.

-- 
You are receiving this mail because:
You are watching all bug changes.


[digikam] [Bug 365375] Open with... ignores parameters of Exec line in Desktop Entry

2016-07-16 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365375

--- Comment #7 from David Faure  ---
You could at least use KIO::DesktopExecParser which does the parsing and
escaping correctly (unlike this QRegExp, when given a complex sh Exec line),
and fully supports the desktop entry spec (you added %d, but not %k...).

 KIO::DesktopExecParser parser(service, QList () <<
QUrl::fromLocalFile(dest));
 process.setArguments(parser.resultingArguments());

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-frameworkintegration] [Bug 344469] Icon themes from inside Qt5 application resources are ignored

2016-07-15 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=344469

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM
 CC||fa...@kde.org

--- Comment #14 from David Faure  ---
So this is fixed in Qt, right ?
 (-> closing, please reopen if I misunderstood)

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 157272] disable system notification for all applications should be possible (as in kde 3.5.x) (disable sounds for all apps)

2016-07-15 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=157272

--- Comment #28 from David Faure  ---
I don't disagree. It would be an additional fix at another layer, which some
people suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kde] [Bug 232246] Autostart ignores symbolic links

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=232246

David Faure  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED
  Latest Commit||http://commits.kde.org/libk
   ||sieve/ee4afdd78597cb9379a39
   ||951b9eca94a8e927f98

--- Comment #2 from David Faure  ---
Git commit ee4afdd78597cb9379a39951b9eca94a8e927f98 by David Faure.
Committed on 14/07/2016 at 14:51.
Pushed by dfaure into branch 'master'.

KSieve Session: fix race while handling SSL errors.

Summary:
No need to post a request to the thread for handling an ignored ssl error,
which the thread will simply handle by emitting the sslDone signal,
which goes back to the main thread. By doing that we were making it possible
for the thread to emit other things meanwhile - like the received data from the
server,
out of sequence (the main thread can only handle it after receiving sslDone)

This fixes the never-ending spinning in "Manage Sieve Scripts" in kmail
for me (which happened about 20% of the time).

Test Plan: Manage Sieve Scripts in kmail, > 5 times.

Reviewers: dvratil, mlaurent

Reviewed By: mlaurent

Subscribers: kde-pim, #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D2167

M  +5-1src/kmanagesieve/session.cpp
M  +0-21   src/kmanagesieve/sessionthread.cpp
M  +0-2src/kmanagesieve/sessionthread_p.h

http://commits.kde.org/libksieve/ee4afdd78597cb9379a39951b9eca94a8e927f98

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 352927] Copying symbolic links with Dolphin adds absolute path to link

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=352927

--- Comment #7 from David Faure  ---
varlesh: please open new bug reports for unrelated problems. This bug report
was about *copying* symlinks, your report is about *creating* symlinks. I can
confirm the bug and I'm looking into it, but please don't hijack existing bug
reports for new issues. Can you open a new bug report?

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 365356] KIO supports WebDAV, but doesn't accept the dav:// URL scheme (Nautilus syntax)

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365356

--- Comment #2 from David Faure  ---
Did you also report a Nautilus bug saying that they should handle webdav://,
KIO syntax? :-)

In any case Elvis is right, if we are to support dav:/ then it's not just
dolphin that should support it, e.g. kioclient should support it too, this has
to happen one layer below, in kio. Not sure how though.

1) Supporting dav and webdav equally (without redirect) is feasible, but with
some mess in kio_http's code
 (e.g. there are quite some if (m_protocol == "webdav" || m_protocol ==
"webdavs") around, although this could certainly be factorized)

2) The problem is we don't really have the concept of "aliases" for protocols,
apart from the KProtocolManager::slaveProtocol mechanism, not sure it still
works (FTP handled by HTTP proxies is a rather old concept afaik, so this has
probably been untested for a while).

3) One could write a kio_dav ioslave that redirects stat(), listDir(), get()
and put() to webdav (there's probably more?).
Ah, either with actual redirection, or using ForwardingSlaveBase (i.e. internal
delegation).

In any case I don't have enough motivation (nor even a webdav account) to do
this myself, but I'll be happy to review a patch;-)

-- 
You are receiving this mail because:
You are watching all bug changes.


[digikam] [Bug 365375] Open with... ignores parameters of Exec line in Desktop Entry

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365375

--- Comment #5 from David Faure  ---
The (admitted quite new) KRun::runApplication does exactly what you want : it
computes the process arguments and then passes them to QProcess. No runtime
dependency on anything else. It should work just fine on Windows.

I'm surprised that running desktop files with %f/%u/etc. in them is a required
feature on Windows though ?

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 157272] disable system notification for all applications should be possible (as in kde 3.5.x) (disable sounds for all apps)

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=157272

David Faure  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/plas
   ||ma-desktop/49eec39d11e7f689
   ||a763e837bc82869bb08db4df
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #26 from David Faure  ---
Git commit 49eec39d11e7f689a763e837bc82869bb08db4df by David Faure.
Committed on 14/07/2016 at 13:54.
Pushed by dfaure into branch 'master'.

Add button "Disable sounds for all of these events".

Requires KF 5.24 for knotifyconfig commit 9d5440c.

M  +17   -3kcms/knotify/knotify.cpp
M  +1-0kcms/knotify/knotify.h

http://commits.kde.org/plasma-desktop/49eec39d11e7f689a763e837bc82869bb08db4df

-- 
You are receiving this mail because:
You are watching all bug changes.


[digikam] [Bug 365375] Open with... ignores parameters of Exec line in Desktop Entry

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365375

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #3 from David Faure  ---
This patch looks awful to me ;)
  (it duplicates what KRun does much better, it breaks on files with a
double-quote in the name, and for non-local files, it breaks on any other
special command from the desktop entry spec like %d since it will keep it
instead of providing its value, etc.)

Why not just use KRun::runService() or (since KF 5.24) KRun::runApplication() ?

For the other overload (without a kservice), there's KRun::run().

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 365641] kio has a runtime dependency on kinit (circular dependency)

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365641

--- Comment #1 from David Faure  ---
Since it's a *runtime* dependency and not a compile time dependency, it's not a
problem.

It's typical of any runtime dependency, we had that with kde-runtime for all of
the KDE4 time frame, for instance. kde-runtime had a compile-time dependency on
kdelibs4, and kdelibs4 had a runtime dependency on kde-runtime (which provided
a number of executables used by kdelibs4).

So you need kio to compile kinit, and then you install both, and then it all
works.

I'm not sure what this means in terms of packaging though. Installing either
one should install the other as well. I suppose one could say we should merge
them then, but having them separated makes it possible to *one day* remove some
dependencies.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 328246] Manage Sieve scripts feature broken

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=328246

--- Comment #16 from David Faure  ---
I can't possibly know that :)

If you see "KTcpSocket::showSslErrors" in the *kmail* debug output, then it's
likely that this patch fixes it.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 328246] Manage Sieve scripts feature broken

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=328246

--- Comment #14 from David Faure  ---
Fix available at https://phabricator.kde.org/D2167

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 328246] Manage Sieve scripts feature broken

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=328246

--- Comment #13 from David Faure  ---
OK the actual issue is elsewhere. Things are happening out of order, sometimes
(race condition).

KManageSieve::SessionThread::doStartSsl: 0x3aa7f00 SessionThread::doStartSsl()
KManageSieve::SessionThread::doSendData: 0x3aa7f00 C:  "LISTSCRIPTS"
[]
KManageSieve::SessionThread::doSendData: 0x3aa7f00 C:  "AUTHENTICATE \"PLAIN\"
[...]\""
KManageSieve::SessionThread::slotDataReceived: 0x3aa7f00 S:  "NO \"Authenticate
first\""

This LISTSCRIPTS should only happen after authenticate, not before.
I sometimes see a race condition the other way around, m_state in Session is
not yet PostTls so all responses are unhandled, and only then sslDone() is
called.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 328246] Manage Sieve scripts feature broken

2016-07-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=328246

David Faure  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 CC||fa...@kde.org
 Status|RESOLVED|REOPENED

--- Comment #12 from David Faure  ---
This patch was reverted, it broke other servers, reopening.

Looking at this code, I found another issue though, maybe it fixes this?
https://phabricator.kde.org/D2163

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 349789] Local Folders Disappear when Last Search Deleted

2016-07-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349789

David Faure  changed:

   What|Removed |Added

 CC||r...@w3.org

--- Comment #2 from David Faure  ---
*** Bug 341746 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 341746] Deleting a search folder puts kontact/kmail2 in dire state and finally crashes the Application

2016-07-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341746

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from David Faure  ---
Turned out to be a KRecursiveFilterProxyModel bug, actually.
Fix coming up.

*** This bug has been marked as a duplicate of bug 349789 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 349789] Local Folders Disappear when Last Search Deleted

2016-07-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349789

David Faure  changed:

   What|Removed |Added

 CC||thiago.bauermann@kolabnow.c
   ||om

--- Comment #3 from David Faure  ---
*** Bug 346280 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 346280] Kontact crash when deleting search folder

2016-07-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=346280

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from David Faure  ---
Confirmed. Most recent behaviour was what the screenshot at bug 349789 shows,
so merging with that one.
Fix coming up.

*** This bug has been marked as a duplicate of bug 349789 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 313083] Deleting 'last search' folder destroys the messages listed from the system

2016-07-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=313083

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #1 from David Faure  ---
Hello.

Were they really deleted, or was it rather that folders disappeared from the
folder tree, but after restarting kmail everything was back? That would be bug
349789, which I just fixed. Please advise so we know what to do with this
report.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmail2] [Bug 349789] Local Folders Disappear when Last Search Deleted

2016-07-12 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349789

David Faure  changed:

   What|Removed |Added

   Assignee|kdepim-b...@kde.org |fa...@kde.org
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.


[Akonadi] [Bug 355229] akonadiconsole browser does not show any resource entries

2016-07-05 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355229

David Faure  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/akon
   ||adi/381acbc294dcecb0d4beb63
   ||721080d231e4bca38
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from David Faure  ---
Git commit 381acbc294dcecb0d4beb63721080d231e4bca38 by David Faure.
Committed on 05/07/2016 at 07:02.
Pushed by dfaure into branch 'master'.

Port StatisticsProxyModel to KExtraColumnsProxyModel.

* this fixes sibling() - the unittest confirmed Dan's assessment that
sibling() got broken for StatisticsProxyModel with Qt5.

* this reduces the number of dataChanged signals emitted by the proxy:
instead of dataChanged((row,0) (row,0)) + dataChanged((row,1) (row,3))
the proxy now emits dataChanged((row,0) (row,3)) directly

* I also removed the code emitting dataChanged for parent indexes,
the reasoning was "so that cumulative totals can be updated", but there
are no cumulative totals anywhere in this proxy (other than the tooltip).

* the awful model-index-struct-casting hack is no longer necessary,
the code is much simpler, there are now unittests (both here and for
the base class KExtraColumnsProxyModel in kitemmodels)...

M  +1-0autotests/libs/CMakeLists.txt
A  +241  -0autotests/libs/statisticsproxymodeltest.cpp [License: LGPL
(v2+)]
A  +79   -0autotests/libs/test_model_helpers.h [License: LGPL (v2+)]
M  +72   -279  src/core/models/statisticsproxymodel.cpp
M  +9-18   src/core/models/statisticsproxymodel.h

http://commits.kde.org/akonadi/381acbc294dcecb0d4beb63721080d231e4bca38

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 157272] disable system notification for all applications should be possible (as in kde 3.5.x) (disable sounds for all apps)

2016-06-28 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=157272

--- Comment #24 from David Faure  ---
Git commit 9d5440c14cf9e8107f2cb270ad69cec98ab9303c by David Faure.
Committed on 28/06/2016 at 07:56.
Pushed by dfaure into branch 'master'.

KNotifyConfigWidget: add disableAllSounds() method

This saves a lot of clicking compared to selecting each event
in the list and unchecking the "Play sound" checkbox, something
I have to do any time I set up a new computer (for me or around the office).
REVIEW: 127926

M  +11   -0src/knotifyconfigwidget.cpp
M  +6-0src/knotifyconfigwidget.h
M  +20   -0src/knotifyeventlist.cpp
M  +2-0src/knotifyeventlist.h

http://commits.kde.org/knotifyconfig/9d5440c14cf9e8107f2cb270ad69cec98ab9303c

-- 
You are receiving this mail because:
You are watching all bug changes.


[extra-cmake-modules] [Bug 364820] No Link to libstdc++ on MSYS on Windows (And Linking Issues)

2016-06-28 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364820

David Faure  changed:

   What|Removed |Added

  Component|general |general
Version|unspecified |5.23.0
   Assignee|fa...@kde.org   |alex.me...@kde.org
 CC||ecm-bugs-n...@kde.org
Product|frameworks-karchive |extra-cmake-modules

-- 
You are receiving this mail because:
You are watching all bug changes.


[KScreen] [Bug 364657] kscreen segfault in Generator::biggestOutput (qt4/kdelibs4)

2016-06-26 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364657

David Faure  changed:

   What|Removed |Added

Summary|Application: KDE Daemon |kscreen segfault in
   |(kded4), signal:|Generator::biggestOutput
   |Segmentation fault  |(qt4/kdelibs4)
Product|frameworks-kcrash   |KScreen
   Assignee|fa...@kde.org   |se...@kde.org
  Component|general |kded

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 364397] soundcloud.desktop is a HTML file

2016-06-17 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364397

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1
   Assignee|fa...@kde.org   |k...@pusling.com

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

2016-06-17 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=64754

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.24
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/kxml
   ||gui/cfb9d1923b1376153760519
   ||edf4760248176c7c8

--- Comment #49 from David Faure  ---
Git commit cfb9d1923b1376153760519edf4760248176c7c8 by David Faure.
Committed on 17/06/2016 at 08:49.
Pushed by dfaure into branch 'master'.

KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

Summary:
The code was assuming that all actions from the client being removed
were together in one merge point, but the group feature (added slightly later)
changed that. Indices therefore have to be adjusted after each action removal.

While extending the unittest to check this for dynamic actionlists, I found
another bug in the updating of merging indices: when a client inserts an
actionlist element (or possibly a group element for child-child-clients)
and then N more actions, the actionlist would go down N times. Fixed by
comparing clientNames, i.e. only merge points from other clients should
go down while inserting actions, nor our own [except in plugActionList].
FIXED-IN: 5.24

Test Plan:
Editing toolbars in kate to add actions (without group) to
the katepart toolbar, would lead to incoherent moving of toolbar buttons
at every document switch. This commit fixes that.

Reviewers: svuorela, dhaumann

Reviewed By: dhaumann

Subscribers: kde-frameworks-devel

Differential Revision: https://phabricator.kde.org/D1924

M  +73   -45   autotests/kxmlgui_unittest.cpp
M  +3-1src/kxmlguibuilder.h
M  +2-12   src/kxmlguifactory.cpp
M  +46   -69   src/kxmlguifactory_p.cpp
M  +3-3src/kxmlguifactory_p.h

http://commits.kde.org/kxmlgui/cfb9d1923b1376153760519edf4760248176c7c8

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

2016-06-16 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=64754

David Faure  changed:

   What|Removed |Added

   Assignee|co...@kde.org   |fa...@kde.org
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 363991] Drag and drop does not work in folder view

2016-06-16 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363991

--- Comment #6 from David Faure  ---
Git commit f2772c4fe63944f71f797c0d34d2cdb37897a535 by David Faure.
Committed on 16/06/2016 at 13:34.
Pushed by dfaure into branch 'master'.

Fix DnD onto desktop:/ app desktop file.

We need to resolve from desktop:/ to file:/ so that DropJob
can handle application .desktop files.

M  +1-1src/panels/folders/folderspanel.cpp
M  +1-1src/views/dolphinview.cpp

http://commits.kde.org/dolphin/f2772c4fe63944f71f797c0d34d2cdb37897a535

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 357556] During import of vCard: Message box with either-or-question provides Yes/No buttons

2016-06-15 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357556

David Faure  changed:

   What|Removed |Added

   Version Fixed In||Applications/16.04
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/even
   ||tviews/376da8f1c6d537f387d9
   ||05ab4466ec6d7a6c8df6
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from David Faure  ---
Git commit 376da8f1c6d537f387d905ab4466ec6d7a6c8df6 by David Faure.
Committed on 15/06/2016 at 10:13.
Pushed by dfaure into branch 'Applications/16.04'.

Port away from KLocale (which was used for use12Clock()).

Amazingly, this fixes a bug with a messagebox showing "Yes/No" instead
of "Merge/Add" when launching korganizer with a .ics file as argument.

Here's why:
KLocale::global() creates a QTranslator instance, which sends a LanguageChange
event. QDialogButtonBox (already shown at that point) reacts by retranslating
the buttons, ignoring the custom text we set on the buttons. That's a Qt bug,
I'll look into fixing that as well.
FIXED-IN: Applications/16.04

M  +13   -6src/agenda/timelabels.cpp

http://commits.kde.org/eventviews/376da8f1c6d537f387d905ab4466ec6d7a6c8df6

-- 
You are receiving this mail because:
You are watching all bug changes.


[korganizer] [Bug 357556] During import of vCard: Message box with either-or-question provides Yes/No buttons

2016-06-15 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357556

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
   Assignee|korganizer-de...@kde.org|fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 352644] FTP shares exported by eShare app on Android are inaccessible from Dolphin with "Could not enter folder ." error message

2016-06-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=352644

--- Comment #6 from David Faure  ---
Oh, you're now using KF5, I didn't notice that the "Using KDE Development
Platform 4.14.9" version info was from September 2015 :-)

kio_ftp had debug output disabled in KF5, I only re-enabled it today (due to
this report) so it'll be in KF 5.24 -- another month before we can get more
debug output, unless you feel like compiling KIO from git.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 352644] FTP shares exported by eShare app on Android are inaccessible from Dolphin with "Could not enter folder ." error message

2016-06-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=352644

--- Comment #4 from David Faure  ---
Next step is to get debug output from kio_ftp. Can you follow the instructions
at
https://techbase.kde.org/Development/Tutorials/Debugging/Debugging_IOSlaves#GUI_.28Qt4.2Fkdelibs4_instructions.29
to get that output?

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 363634] KF5 fails to load Windows executables located in the application bin directory

2016-06-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363634

David Faure  changed:

   What|Removed |Added

   Assignee|fa...@kde.org   |vonr...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-karchive] [Bug 364071] assert when reading an unusual but valid Zip file (entry named "/" and bad modes)

2016-06-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364071

--- Comment #1 from David Faure  ---
Yes it would be very useful to have a small zip file showing the issue, both
for debugging and for the unittest.

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 356237] Unable to change icon associated with mimetype if ~/.local/share/mime/packages does not already exist.

2016-06-03 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356237

--- Comment #3 from David Faure  ---
Well, the source files for update-mime-database are those under the "packages"
subdir. It generates everything else from that. So if there's no packages
subdir, u-m-d has nothing to do, no bug there.

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 357896] Plasmashell and kwin scrambled with qt 5.6 beta when QT_AUTO_SCREEN_SCALE_FACTOR=1

2016-06-03 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357896

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #6 from David Faure  ---
Why does plasmashell set Qt::AA_DisableHighDpiScaling? This gives it tiny fonts
for me (high dpi screen, QT_SCALE_FACTOR=2)

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 363337] Recent docs/history shortcuts in kicker/kickoff fail when clicked with "Could not find any application or handler..." error

2016-05-24 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363337

--- Comment #10 from David Faure  ---
Git commit 9c1c48161416a2dd70fdb1dfeb92ed0b7dde75d9 by David Faure.
Committed on 24/05/2016 at 19:48.
Pushed by dfaure into branch 'master'.

Give clearer error message when KRun(URL) is given a URL without scheme.

M  +4-3src/widgets/krun.cpp

http://commits.kde.org/kio/9c1c48161416a2dd70fdb1dfeb92ed0b7dde75d9

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 363337] Recent docs/history shortcuts in kicker/kickoff fail when clicked with "Could not find any application or handler..." error

2016-05-23 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363337

--- Comment #7 from David Faure  ---
Found it. The URL being given to KRun is wrong, it has no scheme at all. The
error message would show file:/// in front if it did. This is a QString->QUrl
conversion issue.

With no scheme, KRun can't check that the protocol supports reading, that's why
the error message is new, but the bug is in whichever code is assembling this
URL.
I'll add asserts to catch this earlier in the future ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 363337] Recent docs/history shortcuts in kicker/kickoff fail when clicked with "Could not find any application or handler..." error

2016-05-21 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363337

--- Comment #4 from David Faure  ---
Try porting to KProtocolInfo::isKnownProtocol, which will return true for
mailto as soon as one mail client is installed.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 358813] kdeinit5 crash after logout

2016-05-21 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358813

--- Comment #10 from David Faure  ---
Can you confirm my hypothesis by doing echo $DISPLAY in an xterm?

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 358813] kdeinit5 crash after logout

2016-05-21 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358813

--- Comment #8 from David Faure  ---
:#3  QMessageLogger::fatal (this=this@entry=0x7ffe86010420,
msg=msg@entry=0x7f24a7f28b78 "QXcbConnection: Could not connect to display %s")
at global/qlogging.cpp:784
:#4  0x7f24a7e94c40 in QXcbConnection::QXcbConnection (this=0x5573eb5194a0,
nativeInterface=0x5573eb50fc90, canGrabServer=,
defaultVisualId=4294967295, displayName=0x0) 

This says that you don't have the variable $DISPLAY set.
Just to be sure -- is this on X11? You have X running, right?
I have no idea why your setup doesn't set $DISPLAY, but that's definitely a
setup bug.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kconfig] [Bug 340691] system-wide kdeglobals "overwrite" local ones

2016-05-18 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=340691

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #10 from David Faure  ---
commit 27ebf75bd4 should fix this for good, thanks Hrvoje

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-ki18n] [Bug 363111] ki18n 5.22.0 compile fails with 'translation_found' was not declared in this scope

2016-05-16 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363111

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #3 from David Faure  ---
sources/ki18n-5.22.1.tar.xz uploaded for packagers.

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 157272] disable system notification for all applications should be possible (as in kde 3.5.x) (disable sounds for all apps)

2016-05-15 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=157272

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #22 from David Faure  ---
I'm much annoyed by the amount of clicks it takes to disable all sounds, too,
so I finally implemented a button for disabling all sounds for the current app,
at least.
https://git.reviewboard.kde.org/r/127926/

Yes the KDE3 solution was more flexible, but also much harder to
understand/use. I'd like to cover the main use case, disabling all sounds. If
someone wants to disable all kopete messages, that's still N clicks (N = number
of events). But at least now disabling all sounds for all apps (a common use
case) is M clicks (M = number of apps), as opposed to N*M before this fix ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 344741] Dolphin freezes while displayed files' content are modified

2016-05-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=344741

--- Comment #10 from David Faure  ---
That isn't the same bug then. The backtraces above were about testparm taking a
long time, not 0,02s...
Do you still get a backtrace in QProcess::waitForFinished called by
KSambaSharePrivate::runProcess?

I don't use ArchLinux.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdesrc-build] [Bug 363059] New: qmake should be run with the -r option

2016-05-14 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363059

Bug ID: 363059
   Summary: qmake should be run with the -r option
   Product: kdesrc-build
   Version: Git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: mp...@kde.org
  Reporter: fa...@kde.org

$ kdesrc-build -v --reconfigure libaccounts-qt   

Building libaccounts-qt (build system qmake) (1/1)
Updating libaccounts-qt (to branch master)
Updating libaccounts-qt using existing branch master
This module will not be built. Nothing updated.
No changes to libaccounts-qt source, proceeding to build.
Unable to install libaccounts-qt!



Reproducible: Always

Steps to Reproduce:
module libaccounts-qt
  repository https://gitlab.com/accounts-sso/libaccounts-qt.git
  qmake-options PREFIX=/tmp
end module

1. Comment out the qmake-options line
2. kdesrc-build libaccounts-qt
This will fail to install into /usr, as expected
3. Enable the qmake-options line again
4. kdesrc-build --reconfigure libaccounts-qt

Actual Results:  
Same error. And yet qmake was run again, I see in the logs.
The verbose output above is quite unclear about that BTW.
1) "This module will not be built" ... why? seems wrong.
2) If I use reconfigure on a cmake module I see "Running cmake...", so surely
there should be a similar line with "Running qmake..." for qmake modules.

Expected Results:  
If qmake was run with -r, then the change would actually take effect.
This is a qmake issue, where it only regenerates the toplevel Makefile, but not
Makefiles in subdirs, unless -r is passed.

The patch below fixes the main issue, but I'm still filing this for posterity,
for feedback, and because the output could be improved too.

diff --git a/modules/ksb/BuildSystem/QMake.pm
b/modules/ksb/BuildSystem/QMake.pm
index 2f7924b..aa91a74 100644   
--- a/modules/ksb/BuildSystem/QMake.pm
+++ b/modules/ksb/BuildSystem/QMake.pm
@@ -45,6 +45,7 @@ sub configureInternal
 my $builddir = $module->fullpath('build');
 my $sourcedir = $module->fullpath('source');
 my @qmakeOpts = split(' ', $module->getOption('qmake-options'));
+push @qmakeOpts, '-r';
 my @projectFiles = glob("$sourcedir/*.pro");

 if (!@projectFiles || !$projectFiles[0]) {

-- 
You are receiving this mail because:
You are watching all bug changes.


[kscreenlocker] [Bug 353440] Can't unlock session - password is always wrong

2016-05-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353440

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #3 from David Faure  ---
For the record, on OpenSuSE, making kcheckpass suid root is not enough, one
should also make sure to compile kscreenlocker and plasma-workspace with the
cmake options
-DKDE4_COMMON_PAM_SERVICE=xdm -DKDE4_KCHECKPASS_PAM_SERVICE=xdm
(yes, "KDE4", even in the KF5 version)

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kconfig] [Bug 340691] system-wide kdeglobals "overwrite" local ones

2016-05-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=340691

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #9 from David Faure  ---
I can't select another webbrowser than firefox on OpenSuSE because
/etc/xdg/kdeglobals says BrowserApplication=firefox. The use of SimpleConfig
when saving means that writeEntry() with an empty QString does nothing, because
KConfig doesn't see that there is a more-global value to override explicitly.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kio] [Bug 75324] Integrate KIO Slaves into file system using FUSE gateway

2016-05-13 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=75324

--- Comment #20 from David Faure  ---
"It's so productive to be able to mount ftp, sftp, smb, and others, and access
them reliably from one app to another..." 
Even when you then close down the laptop and go home, and upon reopening the
laptop, any operation on all of these mount points hangs (blockingly!) for 5
minutes because you lost the connection to the server? In my experience when
this happens the application is completely blocked, not even repainting or
anything, which is extremely annoying and counter-productive, isn't it?

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 358813] kdeinit5 crash after logout

2016-05-11 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358813

David Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from David Faure  ---
Seems fixed then, please reopen if it happens again.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 362542] Powerdevil should inhibit suspend when a file transfer is in progress

2016-05-02 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362542

--- Comment #2 from David Faure  ---
But how? KIO can't depend on powerdevil (which is in workspace).

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 358813] kdeinit5 crash after logout

2016-05-01 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358813

--- Comment #2 from David Faure  ---
:#3  QMessageLogger::fatal (this=this@entry=0x3f285166ca0,
msg=msg@entry=0x3ed3e43c818 "QXcbConnection: Could not connect to display %s")
at global/qlogging.cpp:781
:#4  0x03ed3e3ad860 in QXcbConnection::QXcbConnection (this=0x10e2afea90,
nativeInterface=0x10e2af51a0, canGrabServer=,
defaultVisualId=4294967295, displayName=0x0) at qxcbconnection.cpp:511
:#5  0x03ed3e3b1ffa in QXcbIntegration::QXcbIntegration (this=,
:#6  0x03ed4f6293de in QXcbIntegrationPlugin::create (this=,
system=..., parameters=..., argc=@0x3f28516715c: 2, argv=0x10e2ae2e20) at
qxcbmain.cpp:50
:#7  0x03ed4e641365 in loadIntegration (argv=0x10e2ae2e20,
argc=@0x3f28516715c: 2, 
:#9  0x03ed4e6507c5 in init_platform (argv=0x10e2ae2e20,
argc=@0x3f28516715c: 2, 
:#10 QGuiApplicationPrivate::createPlatformIntegration (this=0x10e2af4bc0) at
:#11 0x03ed4e6517f5 in QGuiApplicationPrivate::createEventDispatcher
(this=) at kernel/qguiapplication.cpp:1193
:#12 0x03ed4e317f64 in QCoreApplication::init
(this=this@entry=0x3f285167190) at 
:#13 0x03ed4e3180a9 in QCoreApplication::QCoreApplication
(this=0x3f285167190, p=...) at kernel/qcoreapplication.cpp:689
:#14 0x03ed4e653a24 in QGuiApplication::QGuiApplication
(this=0x3f285167190, 
:#15 0x03ed3e4cedfd in kdemain (argc=2, argv=0x10e2ae2e20) at
/usr/src/debug/kde-frameworks/kinit-5.18.0/kinit-5.18.0/src/klauncher/klauncher_main.cpp:162
:#16 0x0010e07caa5f in launch (argc=2, _name=0x10e07cd97c "klauncher",
args=
:#17 0x0010e07cba88 in start_klauncher () at
/usr/src/debug/kde-frameworks/kinit-5.18.0/kinit-5.18.0/src/kdeinit/kinit.cpp:1035
:#18 0x0010e07c78c0 in main (argc=1, argv=) at
/usr/src/debug/kde-frameworks/kinit-5.18.0/kinit-5.18.0/src/kdeinit/kinit.cpp:1794

That is extremely peculiar... why is klauncher still only starting, at the time
of logout or maybe this crash dialog was open the whole time?

Does this still happen?

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 355390] Localized Dolphin crashes when I try to create new folder

2016-05-01 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355390

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.22
  Latest Commit||http://commits.kde.org/kio/
   ||487c83920761ac76451d9bbb33e
   ||e39990395c40f
 Status|CONFIRMED   |RESOLVED

--- Comment #30 from David Faure  ---
Git commit 487c83920761ac76451d9bbb33ee39990395c40f by David Faure.
Committed on 01/05/2016 at 08:56.
Pushed by dfaure into branch 'master'.

New file menu: filter out duplicates (e.g. between .qrc and system files)
FIXED-IN: 5.22

M  +17   -1src/filewidgets/knewfilemenu.cpp

http://commits.kde.org/kio/487c83920761ac76451d9bbb33ee39990395c40f

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 340332] can't launch synaptic from KDE5 launcher

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=340332

David Faure  changed:

   What|Removed |Added

 CC||g396654...@gmail.com

--- Comment #2 from David Faure  ---
*** Bug 340304 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 340304] Kdeinit5 can't launch

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=340304

David Faure  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from David Faure  ---


*** This bug has been marked as a duplicate of bug 340332 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kcrash] [Bug 336833] [Valgrind] "Invalid read of size 4" in KCrash::setCrashHandler(void (*)(int)) (qstring.h:89)

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=336833

--- Comment #2 from David Faure  ---
Ah, what is (was) the contents of your $DISPLAY environment variable?

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kcrash] [Bug 336833] [Valgrind] "Invalid read of size 4" in KCrash::setCrashHandler(void (*)(int)) (qstring.h:89)

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=336833

--- Comment #1 from David Faure  ---
Does this still happen? When I valgrind the test program from kcrash (which
also ends up in kcrashInitialize()), valgrind doesn't complain.

64 bit system, not 32 bits, right?

-- 
You are receiving this mail because:
You are watching all bug changes.


[systemsettings] [Bug 359850] Dolphin as default File Manager not possible

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359850

David Faure  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|ASSIGNED|RESOLVED

--- Comment #26 from David Faure  ---
Amazing. So this really did look like a bad patch by the OpenSUSE packagers

Closing the bug, since you guys can't reproduce the bug anymore.
Feel free to reopen it if it in fact still happens.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 355115] Copying/Moving files in split view intermittantly results in an error

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355115

David Faure  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from David Faure  ---


*** This bug has been marked as a duplicate of bug 353195 ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kio] [Bug 353195] Copy error for folders with mixed files & folders in Split View

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353195

David Faure  changed:

   What|Removed |Added

 CC||patrickrif...@yandex.com

--- Comment #27 from David Faure  ---
*** Bug 355115 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-kinit] [Bug 340304] Kdeinit5 can't launch

2016-04-30 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=340304

--- Comment #1 from David Faure  ---
Does this still happen?

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdelibs] [Bug 361956] KSaveFile breaks hard links

2016-04-22 Thread David Faure via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361956

--- Comment #2 from David Faure  ---
KSaveFile no longer exists in KF5.

Is this about Qt4/kdelibs4, or about Qt5's QSaveFile?

-- 
You are receiving this mail because:
You are watching all bug changes.


  1   2   3   >