[k3b] [Bug 367639] k3b fails to continue multisession (blue ray)
https://bugs.kde.org/show_bug.cgi?id=367639 --- Comment #60 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Thomas, Thanks a lot for your Multi-Session help :) @sebastian Please test as Thomas suggested, the simulator is not able to reproduce Multi-Session environment. Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 386401] "Continue Multisession Project" don't work
https://bugs.kde.org/show_bug.cgi?id=386401 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 386401] "Continue Multisession Project" don't work
https://bugs.kde.org/show_bug.cgi?id=386401 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |DUPLICATE CC||lesliez...@llvm.org.cn Status|UNCONFIRMED |RESOLVED --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** This bug has been marked as a duplicate of bug 367639 *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 367639] k3b fails to continue multisession (blue ray)
https://bugs.kde.org/show_bug.cgi?id=367639 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||rikudou__sen...@outlook.com --- Comment #57 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** Bug 386401 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 386309] Crash when vcd rip is started
https://bugs.kde.org/show_bug.cgi?id=386309 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- What about under X11? https://github.com/KDE/kwidgetsaddons/blob/master/src/kmessagebox.cpp#L396 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 386105] K3b FFmpeg decode plugin seems to be broken, produces noise
https://bugs.kde.org/show_bug.cgi?id=386105 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi blaze, Thanks for your report! > Also ffmpeg plugin currently uses deprecated API I migrated libAV before https://github.com/isoft-linux/libKeyFrame/blob/master/libKeyFrame.c#L295 and welcome the patch about migration :) > https://i.imgur.com/l9wpxYG.png That is very good DIFF! it is clear that K3B ffmpeg plugin bring in the noise. but it is not easy to use FFT and Band-pass filter to filter it ... > What this code actually does? It looks the most suspicious. And what "if > needed" does mean? I have no idea why need to SWAP, perhaps it is better to ask the original author :) https://github.com/KDE/k3b/commit/97f72a28ef87ef62f89967e237f441e03d3b5b3b#diff-edc47aa8fac740c80253cd4bec4ba15dR207 You can test to comment the SWAP code, then rebuild K3B to verify whether or not produce the noise. Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 386220] Freezes
https://bugs.kde.org/show_bug.cgi?id=386220 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- And 2.0.3 was not be maintained, please try 17.08 https://github.com/KDE/k3b -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385549] The information on the recorded size does not appear to match
https://bugs.kde.org/show_bug.cgi?id=385549 --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Cristian, I found some DIFF: Size 23,3 GB 23.851,0 GB 23852 MB Could you use: du -lh under your MP3 and JPEG directories, then provide the total SIZE, thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385677] src/projects/k3bdataurladdingdialog.cpp:469: possible missing break ?
https://bugs.kde.org/show_bug.cgi?id=385677 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/k3b ||/4e73356c23c6246b4907b0bece ||59777a4a92ce6f --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 4e73356c23c6246b4907b0bece59777a4a92ce6f by Leslie Zhai. Committed on 13/10/2017 at 03:20. Pushed by lesliezhai into branch 'master'. Fix switch stmt missing break issue. A patch by dcb...@hotmail.com! Maybe clang analyzer's false negative? CCMAIL: artem.dergac...@gmail.com M +1-0src/projects/k3bdataurladdingdialog.cpp https://commits.kde.org/k3b/4e73356c23c6246b4907b0bece59777a4a92ce6f -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385094] "copy medium" icon is missing on Gnome
https://bugs.kde.org/show_bug.cgi?id=385094 --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Dr. Chapatin That's a pity, but KDE default icon theme (breeze) has one: tools-media-optical-copy (/usr/share/icons/breeze/actions/24/tools-media-optical-copy.svg) to express "Copy Medium". Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385676] k3b-master/src/projects/k3bvcdburndialog.cpp:62: lots of missing breaks ?
https://bugs.kde.org/show_bug.cgi?id=385676 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/k3b ||/d6686bb0ce07601f2f980cdf00 ||1c472ea37e027e Resolution|--- |FIXED --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit d6686bb0ce07601f2f980cdf001c472ea37e027e by Leslie Zhai. Committed on 13/10/2017 at 03:13. Pushed by lesliezhai into branch 'master'. Fix switch stmt missing break issue. A patch by dcb...@hotmail.com! M +10 -6src/projects/k3bvcdburndialog.cpp https://commits.kde.org/k3b/d6686bb0ce07601f2f980cdf001c472ea37e027e -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385674] libk3b/projects/datacd/k3bdatadoc.cpp:484: duplicate if condition ?
https://bugs.kde.org/show_bug.cgi?id=385674 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/k3b ||/d9c451f91bef3bc1c00a780814 ||24f1be2c2ae65f --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit d9c451f91bef3bc1c00a78081424f1be2c2ae65f by Leslie Zhai. Committed on 13/10/2017 at 03:04. Pushed by lesliezhai into branch 'master'. [libk3b] Fix potential copy-paste issue. A patch by dcb...@hotmail.com! M +1-1libk3b/projects/datacd/k3bdatadoc.cpp https://commits.kde.org/k3b/d9c451f91bef3bc1c00a78081424f1be2c2ae65f -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385667] K3B doesn't close Blu-ray discs correctly
https://bugs.kde.org/show_bug.cgi?id=385667 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Lloyd, v2.10.0 was not be maintained any more, please use K3b v17.08 https://github.com/KDE/k3b Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385635] verification appears to be via checksum comparison rather than actual data comparison
https://bugs.kde.org/show_bug.cgi?id=385635 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi zcw913, v2.0.2 was not be maintained any more, please use K3b v17.08 https://github.com/KDE/k3b Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385305] System Configuration Problem
https://bugs.kde.org/show_bug.cgi?id=385305 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** This bug has been marked as a duplicate of bug 382754 *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382754] K3b complains about missing cdrskin at start up
https://bugs.kde.org/show_bug.cgi?id=382754 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||rich.addis...@gmail.com --- Comment #24 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** Bug 385305 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385367] K3b uses "/tmp" as default path to save VCD rips
https://bugs.kde.org/show_bug.cgi?id=385367 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Nate, Thanks for your patch! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 377385] Some icons are missing on Gnome
https://bugs.kde.org/show_bug.cgi?id=377385 --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** Bug 385094 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385094] "copy medium" icon is missing on Gnome
https://bugs.kde.org/show_bug.cgi?id=385094 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||lesliez...@llvm.org.cn --- Comment #3 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** This bug has been marked as a duplicate of bug 377385 *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 385549] The information on the recorded size does not appear to match
https://bugs.kde.org/show_bug.cgi?id=385549 --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Cristian, Thanks for your report! 23852 * 0.62 = 14788.24 correct? then I will check it out. Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384750] Progress bars don't work when I save a project to an ISO file
https://bugs.kde.org/show_bug.cgi?id=384750 --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- but it updates the percentage for me: K3b::IsoImager --- mkisofs print size result: 194070 (397455360 bytes) System --- K3b Version: 17.11.70 KDE Version: 5.36.0 Qt Version: 5.7.1 Kernel: 4.12.11-200.fc25.x86_64 Used versions --- mkisofs: 1.1.11 mkisofs --- 194070 I: -input-charset not specified, using utf-8 (detected in locale settings) Using CMAKEDETERMINECOMPILERAB000.BIN;1 for AMDAPPSDK-3.0/samples/opencl/cl/1.x/HelloWorld/build/CMakeFiles/3.9.0/CMakeDetermineCompilerABI_CXX.bin (CMakeDetermineCompilerABI_C.bin) 0.52% done, estimate finish Mon Sep 25 11:04:34 2017 0.77% done, estimate finish Mon Sep 25 11:04:34 2017 1.04% done, estimate finish Mon Sep 25 11:04:34 2017 1.29% done, estimate finish Mon Sep 25 11:04:34 2017 1.55% done, estimate finish Mon Sep 25 11:04:34 2017 1.81% done, estimate finish Mon Sep 25 11:04:34 2017 2.07% done, estimate finish Mon Sep 25 11:04:34 2017 2.32% done, estimate finish Mon Sep 25 11:04:34 2017 2.58% done, estimate finish Mon Sep 25 11:04:34 2017 2.83% done, estimate finish Mon Sep 25 11:04:34 2017 3.10% done, estimate finish Mon Sep 25 11:04:34 2017 3.35% done, estimate finish Mon Sep 25 11:04:34 2017 3.61% done, estimate finish Mon Sep 25 11:04:34 2017 3.87% done, estimate finish Mon Sep 25 11:04:34 2017 4.13% done, estimate finish Mon Sep 25 11:04:34 2017 4.38% done, estimate finish Mon Sep 25 11:04:34 2017 4.64% done, estimate finish Mon Sep 25 11:04:34 2017 4.90% done, estimate finish Mon Sep 25 11:04:34 2017 5.16% done, estimate finish Mon Sep 25 11:04:34 2017 5.42% done, estimate finish Mon Sep 25 11:04:34 2017 5.67% done, estimate finish Mon Sep 25 11:04:34 2017 5.93% done, estimate finish Mon Sep 25 11:04:34 2017 6.19% done, estimate finish Mon Sep 25 11:04:34 2017 6.45% done, estimate finish Mon Sep 25 11:04:34 2017 6.70% done, estimate finish Mon Sep 25 11:04:34 2017 6.96% done, estimate finish Mon Sep 25 11:04:34 2017 7.22% done, estimate finish Mon Sep 25 11:04:34 2017 7.48% done, estimate finish Mon Sep 25 11:04:34 2017 7.73% done, estimate finish Mon Sep 25 11:04:34 2017 7.99% done, estimate finish Mon Sep 25 11:04:34 2017 8.25% done, estimate finish Mon Sep 25 11:04:34 2017 8.51% done, estimate finish Mon Sep 25 11:04:34 2017 8.76% done, estimate finish Mon Sep 25 11:04:34 2017 9.02% done, estimate finish Mon Sep 25 11:04:34 2017 9.28% done, estimate finish Mon Sep 25 11:04:34 2017 9.54% done, estimate finish Mon Sep 25 11:04:34 2017 9.79% done, estimate finish Mon Sep 25 11:04:34 2017 10.05% done, estimate finish Mon Sep 25 11:04:34 2017 10.31% done, estimate finish Mon Sep 25 11:04:34 2017 10.57% done, estimate finish Mon Sep 25 11:04:34 2017 10.82% done, estimate finish Mon Sep 25 11:04:34 2017 11.08% done, estimate finish Mon Sep 25 11:04:34 2017 11.34% done, estimate finish Mon Sep 25 11:04:34 2017 11.60% done, estimate finish Mon Sep 25 11:04:34 2017 11.86% done, estimate finish Mon Sep 25 11:04:34 2017 12.11% done, estimate finish Mon Sep 25 11:04:34 2017 12.37% done, estimate finish Mon Sep 25 11:04:34 2017 12.63% done, estimate finish Mon Sep 25 11:04:34 2017 12.89% done, estimate finish Mon Sep 25 11:04:34 2017 13.14% done, estimate finish Mon Sep 25 11:04:34 2017 13.40% done, estimate finish Mon Sep 25 11:04:34 2017 13.66% done, estimate finish Mon Sep 25 11:04:34 2017 13.92% done, estimate finish Mon Sep 25 11:04:34 2017 14.17% done, estimate finish Mon Sep 25 11:04:34 2017 14.44% done, estimate finish Mon Sep 25 11:04:34 2017 14.69% done, estimate finish Mon Sep 25 11:04:34 2017 14.95% done, estimate finish Mon Sep 25 11:04:34 2017 15.20% done, estimate finish Mon Sep 25 11:04:34 2017 15.47% done, estimate finish Mon Sep 25 11:04:34 2017 15.72% done, estimate finish Mon Sep 25 11:04:34 2017 15.98% done, estimate finish Mon Sep 25 11:04:34 2017 16.23% done, estimate finish Mon Sep 25 11:04:34 2017 16.50% done, estimate finish Mon Sep 25 11:04:34 2017 16.75% done, estimate finish Mon Sep 25 11:04:34 2017 17.01% done, estimate finish Mon Sep 25 11:04:34 2017 17.26% done, estimate finish Mon Sep 25 11:04:34 2017 17.53% done, estimate finish Mon Sep 25 11:04:34 2017 17.78% done, estimate finish Mon Sep 25 11:04:34 2017 18.04% done, estimate finish Mon Sep 25 11:04:34 2017 18.29% done, estimate finish Mon Sep 25 11:04:34 2017 18.56% done, estimate finish Mon Sep 25 11:04:34 2017 18.81% done, estimate finish Mon Sep 25 11:04:34 2017 19.07% done, estimate finish Mon Sep 25 11:04:34 2017 19.32% done, estimate finish Mon Sep 25 11:04:34 2017 19.59% done, estimate finish Mon Sep 25 11:04:34 2017 19.84% done, estimate finish Mon Sep 25 11:04:34 2017 20.10% done, estimate finish Mon Sep 25 11:04:34 2017 20.36% done, estimate finish Mon Sep
[k3b] [Bug 384678] K3b fails reading cue files with title larger than 80 bytes
https://bugs.kde.org/show_bug.cgi?id=384678 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Latest Commit||https://commits.kde.org/k3b ||/faaa4299083f23a39352602c4e ||69053845ce81c2 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit faaa4299083f23a39352602c4e69053845ce81c2 by Leslie Zhai. Committed on 25/09/2017 at 03:02. Pushed by lesliezhai into branch 'master'. Revert parseLine for CueFileParser owing to no responese for the testplan. M +1-2libk3b/projects/k3bcuefileparser.cpp https://commits.kde.org/k3b/faaa4299083f23a39352602c4e69053845ce81c2 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384750] Progress bars don't work when I save a project to an ISO file
https://bugs.kde.org/show_bug.cgi?id=384750 --- Comment #3 from Leslie Zhai <lesliez...@llvm.org.cn> --- then how to reproduce the issue? mkisofs --- /usr/bin/genisoimage: No such file or directory. Failed to open VIDEO_TS.IFO /usr/bin/genisoimage: Can't open VMG info for '/tmp/k3bVideoDvd20vsLE/'. /usr/bin/genisoimage: Unable to parse DVD-Video structures. /usr/bin/genisoimage: Could not find correct 'VIDEO_TS' directory. Possible reasons: - VIDEO_TS subdirectory was not found on specified location - VIDEO_TS has invalid contents mkisofs calculate size command: --- /usr/bin/genisoimage -gui -graft-points -print-size -quiet -volid untitled -volset -appid K3B THE CD KREATOR (C) 1998-2017 SEBASTIAN TRUEG, MICHAL MALEK AND LESLIE ZHAI -publisher -preparer -sysid LINUX -volset-size 1 -volset-seqno 1 -sort /tmp/k3b.h10397 -no-cache-inodes -udf -iso-level 1 -path-list /tmp/k3b.X10397 -dvd-video -f /tmp/k3bVideoDvd20vsLE I have no idea how to create COPYRIGHT *legal* DVD image... -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384743] Remove "Do not show again" from "Help" menu>"System check"
https://bugs.kde.org/show_bug.cgi?id=384743 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|REOPENED|RESOLVED Latest Commit||https://commits.kde.org/k3b ||/e5174fc9661a8e60623d650f49 ||34d8265d442bc6 Resolution|--- |FIXED --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit e5174fc9661a8e60623d650f4934d8265d442bc6 by Leslie Zhai. Committed on 25/09/2017 at 02:27. Pushed by lesliezhai into branch 'master'. Hide Do not show again CheckBox for forceCheck. M +3-1src/k3bsystemproblemdialog.cpp M +1-0src/k3bsystemproblemdialog.h https://commits.kde.org/k3b/e5174fc9661a8e60623d650f4934d8265d442bc6 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381368] "do not show again" from system configuration problems dialog is not remembered
https://bugs.kde.org/show_bug.cgi?id=381368 --- Comment #16 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** Bug 384743 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384743] Remove "Do not show again" from "Help" menu>"System check"
https://bugs.kde.org/show_bug.cgi?id=384743 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||lesliez...@llvm.org.cn --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** This bug has been marked as a duplicate of bug 381368 *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384750] Progress bars don't work when I save a project to an ISO file
https://bugs.kde.org/show_bug.cgi?id=384750 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- My question is: failed to save a project to an ISO file? if not failed I need to check DataJob. -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 377105] Disc space/time bar is broken
https://bugs.kde.org/show_bug.cgi?id=377105 --- Comment #19 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Dr. Chapatin, Sorry for my late response! perhaps you need to confirm that: > maybe remove all the text above the QProgressBar and show the same info on > mouseover (tooltip) the disc space/time bar? but not waiting for VGA or other developers, thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384678] K3b fails reading cue files with title larger than 80 bytes
https://bugs.kde.org/show_bug.cgi?id=384678 --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit c84ad1e966697622b8e96557fbe6061fd5a7 by Leslie Zhai. Committed on 14/09/2017 at 02:25. Pushed by lesliezhai into branch 'master'. Hi Mayeul, Please test it for me what will happen if cue title is larger than 80 bytes, thanks! M +2-1libk3b/projects/k3bcuefileparser.cpp https://commits.kde.org/k3b/c84ad1e966697622b8e96557fbe6061fd5a7 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong
https://bugs.kde.org/show_bug.cgi?id=384471 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||lesliez...@llvm.org.cn Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384566] K3b does not correctly determine the write speed of Blu-ray Discs
https://bugs.kde.org/show_bug.cgi?id=384566 --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Cristian, Could you help haman to build K3B git to test? thanks a lot! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384566] K3b does not correctly determine the write speed of Blu-ray Discs
https://bugs.kde.org/show_bug.cgi?id=384566 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||carav...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384566] K3b does not correctly determine the write speed of Blu-ray Discs
https://bugs.kde.org/show_bug.cgi?id=384566 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi haman, Please try https://download.kde.org/stable/applications/17.08.1/src/k3b-17.08.1.tar.xz v2.0.x was not be maintained any more. Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 5051e3b80f66d4dc1308a8bbef54b845b8c54559 by Leslie Zhai. Committed on 11/09/2017 at 02:26. Pushed by lesliezhai into branch 'master'. Update comment. M +3-1libk3b/jobs/k3biso9660imagewritingjob.cpp https://commits.kde.org/k3b/5051e3b80f66d4dc1308a8bbef54b845b8c54559 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit e2a5e4d95c228cda313ad6dadffb23648c05081a by Leslie Zhai. Committed on 08/09/2017 at 03:05. Pushed by lesliezhai into branch 'master'. Thomas please review it. M +18 -21 libk3b/jobs/k3biso9660imagewritingjob.cpp https://commits.kde.org/k3b/e2a5e4d95c228cda313ad6dadffb23648c05081a -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384443] [MATSHITA BD-MLT UJ240AS] It does not record its maximum speed
https://bugs.kde.org/show_bug.cgi?id=384443 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|UNCONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 280134] k3b should prevent from going into suspend/hibernate by system.
https://bugs.kde.org/show_bug.cgi?id=280134 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/k3b ||/39051155b116c317608181e78b ||843373615054ef --- Comment #7 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 39051155b116c317608181e78b843373615054ef by Leslie Zhai. Committed on 07/09/2017 at 03:43. Pushed by lesliezhai into branch 'master'. Implement preventing from going into suspend/hibernate by system. but waiting for KF5::Solid WITH_NEW_SOLID_JOB WIP: Base class for Solid Asynchronous apis https://cgit.kde.org/solid.git/tree/CMakeLists.txt#n79 M +6-0CMakeLists.txt M +32 -10 libk3b/core/k3bcore.cpp https://commits.kde.org/k3b/39051155b116c317608181e78b843373615054ef -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384443] [MATSHITA BD-MLT UJ240AS] It does not record its maximum speed
https://bugs.kde.org/show_bug.cgi?id=384443 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |DUPLICATE CC||lesliez...@llvm.org.cn Status|UNCONFIRMED |RESOLVED --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** This bug has been marked as a duplicate of bug 380067 *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 380067] [MATSHITA BD-MLT UJ240AS] :-( unable to WRITE@LBA=6d9a00h: Input/output error
https://bugs.kde.org/show_bug.cgi?id=380067 --- Comment #50 from Leslie Zhai <lesliez...@llvm.org.cn> --- *** Bug 384443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/k3b ||/a359173975e574c4cae62214f7 ||de28648d14167c Resolution|--- |FIXED --- Comment #73 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit a359173975e574c4cae62214f7de28648d14167c by Leslie Zhai. Committed on 07/09/2017 at 01:56. Pushed by lesliezhai into branch 'master'. Teach K3B learned to handle BD. A patch by Thomas Schmitt! Tested by Cristian Aravena Romero! also took CT consultation for my brain, but the result is not too bad :) M +0-2libk3b/jobs/k3biso9660imagewritingjob.cpp M +0-6libk3b/projects/datacd/k3bdatajob.cpp M +1-1libk3b/projects/videodvd/k3bvideodvddoc.cpp M +0-9src/k3bemptydiscwaiter.cpp https://commits.kde.org/k3b/a359173975e574c4cae62214f7de28648d14167c -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #67 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 329c969be1dbc3455d65925bcad32f4df3a5b428 by Leslie Zhai. Committed on 06/09/2017 at 01:54. Pushed by lesliezhai into branch 'master'. Add BD-RE MediaType as Thomas's idea. M +4-2libk3b/jobs/k3biso9660imagewritingjob.cpp M +6-0libk3b/projects/datacd/k3bdatajob.cpp https://commits.kde.org/k3b/329c969be1dbc3455d65925bcad32f4df3a5b428 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #58 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 4cc3da32a6dac6405a67f7791f49ef38149dadd6 by Leslie Zhai. Committed on 05/09/2017 at 02:28. Pushed by lesliezhai into branch 'master'. also print the properties which sees as present. removed K3B_DEBUG macro, this macro will be enabled only with -DK3B_DEBUG=ON cmake build option. When is it morning where Leslie lives? I'm overdue for bed too :) M +8-4src/k3bemptydiscwaiter.cpp https://commits.kde.org/k3b/4cc3da32a6dac6405a67f7791f49ef38149dadd6 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #41 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 837eeb482a13af6a27616a4412f5cd8d92b7feaf by Leslie Zhai. Committed on 04/09/2017 at 02:11. Pushed by lesliezhai into branch 'master'. Prints the desired info in a user-visible way. Test plan: Cristian Aravena Romero run k3b in his enviorment to reproduce the issue, then print the MediaType, MediaState and MinMediaSize. M +4-0src/k3bemptydiscwaiter.cpp https://commits.kde.org/k3b/837eeb482a13af6a27616a4412f5cd8d92b7feaf -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #40 from Leslie Zhai <lesliez...@llvm.org.cn> --- I will add qDebug to print them next Monday, I am using my phone to reply :) -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #35 from Leslie Zhai <lesliez...@llvm.org.cn> --- Please use GDB to set breakpoint and print -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #32 from Leslie Zhai <lesliez...@llvm.org.cn> --- Yes! > Hello Leslie Zhai, > > git clone git://anongit.kde.org/k3b (?) > > Regards, > -- > Cristian -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 384117] K3b uses "/tmp" as default path to save dvd rips
https://bugs.kde.org/show_bug.cgi?id=384117 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/k3b ||/3125c7cda1e54c1c425189a443 ||03dc360038d777 --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 3125c7cda1e54c1c425189a44303dc360038d777 by Leslie Zhai. Committed on 29/08/2017 at 01:46. Pushed by lesliezhai into branch 'master'. Use vartmp instead of tmp. A patch by Fedora engineer! M +1-1src/projects/kostore/KoZipStore.cpp M +1-1src/rip/k3bvideocdrippingoptions.h https://commits.kde.org/k3b/3125c7cda1e54c1c425189a44303dc360038d777 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #26 from Leslie Zhai <lesliez...@llvm.org.cn> --- (In reply to Cristian Aravena Romero from comment #25) > (In reply to Thomas Schmitt from comment #24) > > Hello, > > > > i am out of ideas, except that Leslie prepares a test version of K3B > > by which Cristian can build and test. > > I look forward to compiling the trial version and testing it. Just let me > know the commit to download ... http://www.leetcode.cn/2016/08/k3b.html#depend please follow the Dependence and Build. > > Regards, > -- > Cristian -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383835] Crash after closing audio project
https://bugs.kde.org/show_bug.cgi?id=383835 --- Comment #13 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 3cbe1f53c5e79864d4594879402297db902da703 by Leslie Zhai. Committed on 25/08/2017 at 03:31. Pushed by lesliezhai into branch 'master'. Remove dead assignment private variable. M +1-2src/projects/k3bprojectplugindialog.cpp M +0-1src/projects/k3bprojectplugindialog.h https://commits.kde.org/k3b/3cbe1f53c5e79864d4594879402297db902da703 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383835] Crash after closing audio project
https://bugs.kde.org/show_bug.cgi?id=383835
--- Comment #12 from Leslie Zhai <lesliez...@llvm.org.cn> ---
> //m_plugin(plugin)
yes, ProjectPlugin* m_plugin is Dead assignment
http://www.leetcode.cn/2016/11/analyzing-code-for-kde-qt-open-source-components.html#k3b
it never be used after assginment during constructor.
diff --git a/src/projects/k3bprojectplugindialog.cpp
b/src/projects/k3bprojectplugindialog.cpp
index 994424f..84841f6 100644
--- a/src/projects/k3bprojectplugindialog.cpp
+++ b/src/projects/k3bprojectplugindialog.cpp
@@ -25,8 +25,7 @@ K3b::ProjectPluginDialog::ProjectPluginDialog(
K3b::ProjectPlugin* plugin, K3b::
QString(),
START_BUTTON|CANCEL_BUTTON,
START_BUTTON,
-plugin->metaObject()->className() ),
- m_plugin(plugin)
+plugin->metaObject()->className() )
{
m_pluginGui = plugin->createGUI( doc, this );
Q_ASSERT( m_pluginGui );
diff --git a/src/projects/k3bprojectplugindialog.h
b/src/projects/k3bprojectplugindialog.h
index 8a085c5..a799703 100644
--- a/src/projects/k3bprojectplugindialog.h
+++ b/src/projects/k3bprojectplugindialog.h
@@ -36,7 +36,6 @@ namespace K3b {
void loadSettings( const KConfigGroup& config );
private:
-ProjectPlugin* m_plugin;
ProjectPluginGUIBase* m_pluginGui;
};
}
but I argue that it might not the root cause...
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 383931] DVD extraction fails
https://bugs.kde.org/show_bug.cgi?id=383931 --- Comment #10 from Leslie Zhai <lesliez...@llvm.org.cn> --- > Does Leslie Zhai's recommendation of using kdenlive instead work at all? yes, kdenlive is better choice than transcode, kdenlive use up-to-date libAV, but transcode use very old library, and my wife prefer to use kdenlive :) -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383835] Crash after closing audio project
https://bugs.kde.org/show_bug.cgi?id=383835
--- Comment #10 from Leslie Zhai <lesliez...@llvm.org.cn> ---
> This edit makes a workaround:
> Extractor::~Extractor()
> {
> //delete d->m_plugin;
Memory leak...
> d->m_plugin = NULL;
> delete d;
> }
>
> I only use k3b to burn audio so is it possible to make depending on
> kfilemetadata optional? I presume taglib would be enough.
Welcome patch!
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 383835] Crash after closing audio project
https://bugs.kde.org/show_bug.cgi?id=383835
--- Comment #8 from Leslie Zhai <lesliez...@llvm.org.cn> ---
Hi Mark,
Thanks for your investigation. please try this patch for kfilemetadata:
diff --git a/src/extractor.cpp b/src/extractor.cpp
index 7becc41..e863f02 100644
--- a/src/extractor.cpp
+++ b/src/extractor.cpp
@@ -31,7 +31,10 @@ Extractor::Extractor()
Extractor::~Extractor()
{
-delete d->m_plugin;
+if (d->m_plugin) {
+delete d->m_plugin;
+d->m_plugin = NULL;
+}
delete d;
}
then try again to set breakpoint.
Regards,
Leslie Zhai
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 383931] DVD extraction fails
https://bugs.kde.org/show_bug.cgi?id=383931 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||wba...@tmo.at --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Jim, > https://bugs.kde.org/show_bug.cgi?id=381131#c7 Please help ArchLinux users, thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383931] DVD extraction fails
https://bugs.kde.org/show_bug.cgi?id=383931 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||jspe...@jimsara.org, ||lesliez...@llvm.org.cn -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383819] Text ilegible in darker themes/colour scheme
https://bugs.kde.org/show_bug.cgi?id=383819 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/k3b ||/fe3d5c28930560a8913a4ff447 ||f520ad22feff13 --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit fe3d5c28930560a8913a4ff447f520ad22feff13 by Leslie Zhai. Committed on 23/08/2017 at 03:13. Pushed by lesliezhai into branch 'master'. Fix text ilegible in darker themes/colour scheme issue. M +24 -18 src/k3bdiskinfoview.cpp M +1-1src/pics/RobsTheme/k3b.theme https://commits.kde.org/k3b/fe3d5c28930560a8913a4ff447f520ad22feff13 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383835] Crash after closing audio project
https://bugs.kde.org/show_bug.cgi?id=383835 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Mark, > I'm using latest GIT. Crash is not fixed. Let's find out the root cause! please enable -g: $ mkdir build $ cd build $ cmake .. -DCMAKE_INSTALL_PREFIX=/usr \ -DCMAKE_BUILD_TYPE=Debug \ -DKDE_INSTALL_LIBDIR=lib \ -DKDE_INSTALL_LIBEXECDIR=lib \ -DBUILD_TESTING=ON \ -DK3B_ENABLE_PERMISSION_HELPER=ON $ make -j4 gdb ./build/src/k3b then set breakpoint b libk3b/plugin/k3baudiodecoder.cpp:549 r Creating an audio project, adding tracks, then closing it, goto breakpoint, then p d->metaDataCollection and backtrace show there might be issue during the destructor of KFileMetaData::Extractor, so please download kfilemetadata-5.36.0's tarball https://download.kde.org/stable/frameworks/5.36/kfilemetadata-5.36.0.tar.xz $ tar xvf kfilemetadata-5.36.0.tar.xz $ cd kfilemetadata-5.36.0 add -g for CMakesList.txt: diff --git a/CMakeLists.txt b/CMakeLists.txt index acedc03..4db0051 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -88,6 +88,7 @@ endif() # TYPE OPTIONAL PURPOSE "Support for mobi metadata") add_definitions(-DTRANSLATION_DOMAIN=\"kfilemetadata5\") +add_definitions(-g) add_subdirectory(src) if (BUILD_TESTING) $ mkdir build $ cd build $ cmake .. -DCMAKE_INSTALL_PREFIX=/usr \ -DKDE_INSTALL_LIBDIR=lib $ make -j4 # make install then it is able to set breakpoint for the destructor of KFileMetaData::Extractor b /yourpath/kfilemetadata/src/extractor.cpp:32 p d->m_plugin Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383819] Text ilegible in darker themes/colour scheme
https://bugs.kde.org/show_bug.cgi?id=383819 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Gustavo, Could you switch to quant theme, then attach the screenshot for me? thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #17 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Cristian, > Try by creating a data file of 21.5 GiB size Then how to reproduce the issue? https://pbs.twimg.com/media/DHzWyToVYAAwEse.png Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #16 from Leslie Zhai <lesliez...@llvm.org.cn> --- > One can see how the criteria are set up in waitForDisc(): > Currently i fail to see the spot where this is called. So it would be > interesting to see by what values the loop gets programmed. call waitForDisc https://github.com/KDE/k3b/blob/master/src/k3bemptydiscwaiter.cpp#L747 ^ | | call K3b::EmptyDiscWaiter::wait https://github.com/KDE/k3b/blob/master/src/k3bjobprogressdialog.cpp#L625 ^ | | override Device::MediaType waitForMedium https://github.com/KDE/k3b/blob/master/src/k3bjobprogressdialog.h#L65 ^ | | virtual Device::MediaType waitForMedium https://github.com/KDE/k3b/blob/master/libk3b/core/k3bjob.h#L154 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #13 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Thomas, Thanks for your kind suggestion! > but currently i do not understand how this loop works and were the state is > changed. QEventLoop http://doc.qt.io/qt-5/qeventloop.html it will emit leaveModality signal when finishWaiting https://cgit.kde.org/k3b.git/tree/src/k3bemptydiscwaiter.cpp#n706 then quit the QEventLoop https://cgit.kde.org/k3b.git/tree/src/k3bemptydiscwaiter.cpp#n199 Hi Cristian, > dvd+rw-mediainfo /dev/sr0 2>&1 | tee -i >/tmp/bd_mediainfo.txt Please try and attach the bd_mediainfo.txt, thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382506] Impossible to save an ISO file to an empty folder on Gnome
https://bugs.kde.org/show_bug.cgi?id=382506 --- Comment #21 from Leslie Zhai <lesliez...@llvm.org.cn> --- Dear Albert, > Why does 17.08 release not include this fix? Perhaps I missed some important Release Notification email? https://mail.kde.org/pipermail/release-team/2017-August/thread.html Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382506] Impossible to save an ISO file to an empty folder on Gnome
https://bugs.kde.org/show_bug.cgi?id=382506 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||aa...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382506] Impossible to save an ISO file to an empty folder on Gnome
https://bugs.kde.org/show_bug.cgi?id=382506 --- Comment #19 from Leslie Zhai <lesliez...@llvm.org.cn> --- Dear Felix, > it's outdated... > Last Updated: 2017-04-20 19:15 Please help Dr. Chapatin to test k3b-git for ArchLinux, thanks a lot :) Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382506] Impossible to save an ISO file to an empty folder on Gnome
https://bugs.kde.org/show_bug.cgi?id=382506 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||felixonm...@archlinux.org -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382506] Impossible to save an ISO file to an empty folder on Gnome
https://bugs.kde.org/show_bug.cgi?id=382506 --- Comment #17 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Dr. Chapatin, Please try k3b-git https://aur.archlinux.org/packages/k3b-git Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 --- Comment #9 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Cristian, Sorry for my late response! > See this report: > https://bugs.launchpad.net/cdemu/+bug/1697987 Yes, I do not have BD medium for testing, and the simulator is not able to reproduce the issue by providing the same environment, please Thomas give me some suggestion, thanks a lot! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"
https://bugs.kde.org/show_bug.cgi?id=381074 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||scdbac...@gmx.net -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382776] Enable "apply" button only when some setting is changed
https://bugs.kde.org/show_bug.cgi?id=382776 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn --- Comment #3 from Leslie Zhai <lesliez...@llvm.org.cn> --- (In reply to Dr. Chapatin from comment #2) > What is the status of this bug? much lower priority than BUG 382941 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941 --- Comment #21 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 8cf67cf6ec6312fb82cdca729fc03e2acea22989 by Leslie Zhai. Committed on 15/08/2017 at 01:41. Pushed by lesliezhai into branch 'master'. [libk3bdevice] Update comment for modeSense M +8-5libk3bdevice/k3bdevice.cpp M +25 -25 libk3bdevice/k3bdevice_mmc.cpp https://commits.kde.org/k3b/8cf67cf6ec6312fb82cdca729fc03e2acea22989 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941 --- Comment #18 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit d50a0c30b582aa2fc5cfccea4b87a70adc2d5d81 by Leslie Zhai. Committed on 14/08/2017 at 08:21. Pushed by lesliezhai into branch 'master'. Fix wrong comparison if there are no descriptors. A patch by Thomas Schmitt! Testplan by Mark: cdrskin -V dev=/dev/sr0 2>&1 >/tmp/cdrskin_scsi_log M +2-6libk3bdevice/k3bdevice.cpp https://commits.kde.org/k3b/d50a0c30b582aa2fc5cfccea4b87a70adc2d5d81 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941 --- Comment #15 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 96540735dbcc3189812e6d46cf7d147f006e5654 by Leslie Zhai. Committed on 14/08/2017 at 07:06. Pushed by lesliezhai into branch 'master'. [tests] Remove some testcase might lead UB issue. Testcase by Matthias Schwarzott! M +14 -18 tests/k3bdeviceglobalstest.cpp https://commits.kde.org/k3b/96540735dbcc3189812e6d46cf7d147f006e5654 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941
--- Comment #13 from Leslie Zhai <lesliez...@llvm.org.cn> ---
> Firstly, k3bdeviceglobals.cpp line 215- can revert to:
>
> quint16 K3b::Device::from2Byte(const unsigned char* d)
> {
> if (d == NULL) {
> qWarning() << "Invalid Byte!";
https://github.com/KDE/k3b/commit/4c8e704345a75076ef639dd748483512a7c4d52d
>
> Now, the actual fix. data.size() returns (for me) 34 so (34 - 32 - 8)
> becomes negative which is then assigned to an unsigned int.
what 32 stands for? and why minus 8? where the *magic number* comes from?
>
> Here's my workaround:
> k3bdevice.cpp 3241
>
> // Ensure number of descriptors claimed actually fits in the data
> // returned by the mode sense command.
> if ((data.size() - 32 - 8) > 0) {
> if( static_cast( numDesc ) > ((data.size() - 32 - 8) / 4) )
> numDesc = (data.size() - 32 - 8) / 4;
> }
>
> cd_wr_speed_performance* wr = (cd_wr_speed_performance*)mm->wr_speed_des;
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||scdbac...@gmx.net -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941
--- Comment #12 from Leslie Zhai <lesliez...@llvm.org.cn> ---
Git commit 16576d6fd33fd4fd81f66904d29a4478a91a561f by Leslie Zhai.
Committed on 14/08/2017 at 03:35.
Pushed by lesliezhai into branch 'master'.
Revert from{2,4}Byte.
Hi Thomas:
Please help me! I have no idea why num_wr_speed_des (numDesc) might
be wrong? and how to make it correct if bigger than (32 - 8) / 4,
and where the *magic numbers* about 32 and 8 come from.
Testcase by Matthias Schwarzott!
CCMAIL: scdbac...@gmx.net
M +11 -8libk3bdevice/k3bdevice.cpp
M +2-2libk3bdevice/k3bdeviceglobals.cpp
M +19 -5tests/k3bdeviceglobalstest.cpp
https://commits.kde.org/k3b/16576d6fd33fd4fd81f66904d29a4478a91a561f
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 383011] k3b cannot create DVD video image
https://bugs.kde.org/show_bug.cgi?id=383011 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/k3b ||/d2679715487c2254ed5a55b20a ||a21ea0b36421f0 Resolution|--- |FIXED --- Comment #11 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit d2679715487c2254ed5a55b20aa21ea0b36421f0 by Leslie Zhai. Committed on 11/08/2017 at 01:17. Pushed by lesliezhai into branch 'master'. Fix cannot create DVD video image issue. Reviewers: aacid, anthonyfieroni, sitter Reviewed By: sitter Subscribers: KDE Applications Differential Revision: https://phabricator.kde.org/D7063 M +21 -14 libk3b/projects/videodvd/k3bvideodvdimager.cpp https://commits.kde.org/k3b/d2679715487c2254ed5a55b20aa21ea0b36421f0 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383236] "X" button from burning progress window does not work
https://bugs.kde.org/show_bug.cgi?id=383236 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/k3b ||/47d665f10651c60869c73a33c5 ||ce3ca3f917d247 --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 47d665f10651c60869c73a33c5ce3ca3f917d247 by Leslie Zhai. Committed on 08/08/2017 at 03:01. Pushed by lesliezhai into branch 'master'. Fix "X" button from burning progress window does not work issue. M +7-6src/k3bjobprogressdialog.cpp https://commits.kde.org/k3b/47d665f10651c60869c73a33c5ce3ca3f917d247 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Latest Commit||https://commits.kde.org/k3b ||/d70ef9a8c89e954a223f25e25b ||d5c2202aefaa2e Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit d70ef9a8c89e954a223f25e25bd5c2202aefaa2e by Leslie Zhai. Committed on 08/08/2017 at 02:15. Pushed by lesliezhai into branch 'master'. Fix Blu-ray media sizes in fill widget are incorrect issue. A patch by Henryk Hecht! Thank you! I am better now :) I will fix my Cerebral vasospasm issue, and take ultrasonography consultation this afternoon. Reviewed By: Thomas Schmitt M +2-3libk3b/core/k3bglobals.h https://commits.kde.org/k3b/d70ef9a8c89e954a223f25e25bd5c2202aefaa2e -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 --- Comment #7 from Leslie Zhai <lesliez...@llvm.org.cn> --- Dear Thomas, > Go see a doctor. A good one, who does what is needed, not just what he can. Thank you! I will see a doctor tomorrow to take ultrasonography consultation. my eyes were congested this morning, and right now not congested any more, I took photo via webcam to check my status, but only headache... not feel good, maybe some part effect my reading and writing functions, a lot of typo... thanks for web browser's spell check. > The type of "d" is somewhere in the C++ spaghetti definitions. D-pointer https://bugs.kde.org/show_bug.cgi?id=344392#c28 the good news is my brain's memory function is OK :) > So: The patch proposal looks good to me. Then could I apply Henryk Hecht's patch? sorry for my reading function... Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- Dear Albert, I need your help if I pass away, please find another maintainers for K3B if the repository keep quiet more than one year, it means I pass away... I experienced Brain spasm twice last weekend when I was bathing, I feel really difficult to read and write English... I seriously hurt my head several times ago, sorry fellows. Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||aa...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 --- Comment #4 from Leslie Zhai <lesliez...@llvm.org.cn> --- (In reply to Thomas Schmitt from comment #2) > Hi, > > > ask Thomas for help :) > > Shouldn't that have been "asking Thomas for help" ? > Your statement sounds like you urge Henryk to ask me. But you Cc'ed > me to this bug. So i under stand that you ask me. yes, I need your help :) > > (I guess a native speaker of english ROFLs all the day when seeing > us foreigners stumbling through the language.) Sorry for my poor English :( and I experienced Brain spasm last weekend when I was bathing, I feel really difficult to read and write English... perhaps I need some medicine to relieve my brain high pressure... > > > > This change is an improvement over the wrong values which are > hardcoded currently. > > The real size given the fact that growisofs always formats BD-R and that > all burn programs have to format BD-RE, a hardcoded size seems wrong > on the first hand. The BD payload size varies with formatting. > One can ask the drive when a still formattable medium is inserted. > > Here with a blank single layer BD-R: > [code] > $ dvd+rw-mediainfo /dev/sr4 > ... > READ FORMAT CAPACITIES: > unformatted: 12219392*2048=25025314816 > 00h(3000): 11826176*2048=24220008448 > 32h(0):11826176*2048=24220008448 > 32h(0):5796864*2048=11871977472 > 32h(0):12088320*2048=24756879360 > ... > [/code] > or > [code] > $ cdrskin dev=/dev/sr4 --list_formats -toc > ... > Format status: unformatted, up to 23866.0 MiB > Format idx 0 : 00h , 11826176s , 23098.0 MiB > Format idx 1 : 32h , 11826176s , 23098.0 MiB > Format idx 2 : 32h , 5796864s , 11322.0 MiB > Format idx 3 : 32h , 12088320s , 23610.0 MiB > ... > Media blocks : 0 readable , 12219392 writable , 12219392 overall > ... > [/code] > These sizes from 11 GB to 25 GB are only a rough overview what is > possible. One may format to about any payload size. > > So one should examine where the values MediaSizeBluRay25Gb and > MediaSizeBluRay50Gb are used, whether the medium is present and > already formatted, and to which size it will be possibly formatted > during the burn run. Sorry for my illness, please give me some hint about how to get the correct MediaSizeBluRay25Gb/MediaSizeBluRay50Gb value before the buring job. > > As said, growisofs formats all BD by default. One can force it > to use maximum media payload size by option > [code] > -use-the-force-luke=spare=none > [/code] > dvd+rw-format has option "-ssa" which besides the documented "none", > "default", and "max", also takes "min" or a number with suffixes > "G", "M", "K" which it obviously treats as merchants GB, MB, KB with > a block size of 2000 rather than 2048. An adventurous computation > which is wrong at least with MB and GB. (KB depends on what Andy > Polyakov intended "K" to be exactly: 1000 or 1024.) > See: > > https://sources.debian.net/src/dvd%2Brw-tools/7.1-11.1/dvd%2Brw-format.cpp/ > #L273 > > cdrskin does not format BD-R by default. One would have to use an option > from the following list > [code] > format_defectmgt_max > format_defectmgt_min > blank=format_defectmgt_none > format_by_index_ > blank=format_defectmgt_payload_ > [/code] > where "<number"> picks a size from the --list_formats output and "" > is the decimal number of desired payload blocks. > BD-RE must get formatted. If no blank=format_.., is given, then the > default size as of format "00h" is used. Normally: 23098 MiB. > > > Henyk Hecht wrote: > > I think this bug is at least a couple of years old; I am surprised that > > it is still around, and that no one has reported it. > > Both, unpatched and patched numbers, are not overly significant. > Decisive is the payload size when burning begins. > growisofs is not very good in this: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699186 > > So on unformatted BD media K3B should decide which size it wants, > enforce that size, and use it for its own calculations. > On already formatted BD-R, it must use the currently formatted size. > > Already formatted BD-RE could be re-formatted to a different size. > But that's unusual. (Dunno whether it does harm if done too often.) > > > Have a nice day :) > > Thomas -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 --- Comment #1 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Henryk, Thanks for your patch! but I am not familiar with it, so I can't review it, ask Thomas for help :) Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383211] Blu-ray media sizes in fill widget are incorrect
https://bugs.kde.org/show_bug.cgi?id=383211 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||lesliez...@llvm.org.cn, ||scdbac...@gmx.net -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383000] K3B crashes from time to tiem
https://bugs.kde.org/show_bug.cgi?id=383000 --- Comment #10 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Michael, Thanks for your report! please try my patch https://commits.kde.org/k3b/9a289750eec11de8acfb9bf5aea12dcab09ba005 Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383000] K3B crashes from time to tiem
https://bugs.kde.org/show_bug.cgi?id=383000 --- Comment #9 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 9a289750eec11de8acfb9bf5aea12dcab09ba005 by Leslie Zhai. Committed on 07/08/2017 at 01:58. Pushed by lesliezhai into branch 'master'. Fix SRC_STATE use-after-free issue. M +4-2libk3b/plugin/k3baudiodecoder.cpp https://commits.kde.org/k3b/9a289750eec11de8acfb9bf5aea12dcab09ba005 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383011] k3b cannot create DVD video image
https://bugs.kde.org/show_bug.cgi?id=383011 --- Comment #9 from Leslie Zhai <lesliez...@llvm.org.cn> --- (In reply to Don Campbell from comment #8) > (In reply to Leslie Zhai from comment #5) > > Hi Don, > > > > Could you test the patch https://phabricator.kde.org/D7063 thanks! > > > > Regards, > > Leslie Zhai > > Hi Leslie, > > I am not a Linux developer. Your link doesn't give me enough to go on to > create a patched version of k3b for me to test under Fedora 26. I would be > glad to test a patched version if someone wants to provide it. > > Don the patch https://phabricator.kde.org/file/data/k542q6wih4c2z6q7oejy/PHID-FILE-qmrjkwrvzj424jz2gwrn/D7063.diff is for k3b git master. -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382754] K3b complains about missing cdrskin at start up
https://bugs.kde.org/show_bug.cgi?id=382754 --- Comment #23 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit a3b8df01582085729d36f4a068e8f592179f95db by Leslie Zhai. Committed on 04/08/2017 at 01:18. Pushed by lesliezhai into branch 'master'. Fix complains about missing cdrskin at start up before big structural change. M +3-2src/k3bsystemproblemdialog.cpp https://commits.kde.org/k3b/a3b8df01582085729d36f4a068e8f592179f95db -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383000] K3B crashes from time to tiem
https://bugs.kde.org/show_bug.cgi?id=383000 --- Comment #6 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Erwin, Could you do me a favor to reproduce the issue by gdb, and provide the backtrance information please? thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383000] K3B crashes from time to tiem
https://bugs.kde.org/show_bug.cgi?id=383000 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||erw...@dds.nl -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383011] k3b cannot create DVD video image
https://bugs.kde.org/show_bug.cgi?id=383011 --- Comment #7 from Leslie Zhai <lesliez...@llvm.org.cn> --- (In reply to Erwin Lam from comment #6) > Hello Leslie, > > Wolfgang Bauer was so kind to create a new k3b package for openSUSE leap > 42.3 with your patch applied. k3b works fine again with your patch. my sincere thanks goes to Wolfgang, and also thanks for your test, just waiting for the reviewer https://phabricator.kde.org/D7063 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383011] k3b cannot create DVD video image
https://bugs.kde.org/show_bug.cgi?id=383011 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added CC||wba...@tmo.at -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383000] K3B crashes from time to tiem
https://bugs.kde.org/show_bug.cgi?id=383000 --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Mark, Thanks for your help! and please do me a favor to use gdb debug k3b and paste the bt information, thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A
https://bugs.kde.org/show_bug.cgi?id=382941
--- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> ---
(In reply to Mark from comment #4)
> Unfortunately the fix causes a new problem. All is fine until opening the
> burn dialog which then says "Please insert an empty disc..." Medium Info
> shows no supported writing speeds.
>
> Reverting k3bdeviceglobals.cpp 217 to:
> if (d==NULL) {
>
> plus my original hack has it working again.
only check whether or not `d` is NULL pointer is not enough! there is
out-of-bounds hidden danger when strlen(d) is 1, then d[1] will out-of-bounds.
>
> I can spend some time this weekend looking at it in more detail so any clues
> you could give me as to what to look for would help.
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 382754] K3b complains about missing cdrskin at start up
https://bugs.kde.org/show_bug.cgi?id=382754 --- Comment #21 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 4a6aa76ea4d80dfdf530921d54060fac3647c9ac by Leslie Zhai. Committed on 03/08/2017 at 08:38. Pushed by lesliezhai into branch 'master'. Prepare for big structural change. M +2-2src/k3bsystemproblemdialog.cpp https://commits.kde.org/k3b/4a6aa76ea4d80dfdf530921d54060fac3647c9ac -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382754] K3b complains about missing cdrskin at start up
https://bugs.kde.org/show_bug.cgi?id=382754 Leslie Zhai <lesliez...@llvm.org.cn> changed: What|Removed |Added Ever confirmed|0 |1 Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382754] K3b complains about missing cdrskin at start up
https://bugs.kde.org/show_bug.cgi?id=382754
--- Comment #19 from Leslie Zhai <lesliez...@llvm.org.cn> ---
(In reply to Thomas Schmitt from comment #18)
> Hi,
>
> In
> https://github.com/KDE/k3b/blob/master/src/k3bsystemproblemdialog.cpp
> it should not be recorded as CRITICAL if only one of cdrecord or cdrskin
> is not usable.
>
> A quick solution would be to report the messages preliminarily as
> NON_CRITICAL and to check at the end of the burn program tests whether
> both are missing.
> If so, one would issue a CRITICAL message saying that no CD burn program
> for cdrecord compatible options was found.
>
> -
>
> In general the relation of the burn programs is wrongly represented in
> this piece of code.
>
> The programs overlap with their capabilites. If you just want to burn
> a DVD-R with write type DAO, then growisofs, cdrecord, and cdrskin are
> all three valid candidates for that.
> If you want to burn CD XA or fast BD-RE multi-session, then two of
> the three are not suitable.
>
> So the severity evaluation should be delayed until it is clear how many of
> the burn programs are available, and which tasks they can cover.
>
> Consider something like this (properly adapted to K3B idiom, of course):
>
> struct burn_candidate {
> char *name;
> char *path;
> char *purpose;
> char *remarks[8];
>
> /* Problems, restrictions, or reasons for being unusable */
> int permission_problem;
> int does_not_exist;
> int is_outdated;
> int too_much_root;
> int not_enough_root;
> int would_need_atapi;
> ... maybe more ...
>
> /* Program capabilities */
> int does_cd_data;
> int does_cd_audio;
> int does_cd_other;
> int does_cd_multi_session;
> int does_cd_by_options;
> int does_cd_by_cue;
> int does_dvd;
> int does_dvd_multi_session;
> int does_bd;
> int does_bd_multi_session;
> int does_overwritable_multi_session;
> int does_fast_bdre;
> ... maybe more ...
> };
very good suggestion!
k3b use too simple `QStringList`
https://github.com/KDE/k3b/blob/master/libk3b/core/k3bexternalbinmanager.cpp#L64
1. addFeature, for example:
https://github.com/KDE/k3b/blob/master/libk3b/core/k3bdefaultexternalprograms.cpp#L551
2. hasFeature, for example:
https://github.com/KDE/k3b/blob/master/libk3b/projects/k3bcdrskinwriter.cpp#L216
it needs more detailed feature checker for cdrecord, growisofs, cdrdao and
other K3bConcreteWriter.
>
> There would be an array of them with an element for each program that
> may be used.
> The tests would assess the problems and capabilities but not yet call
> problems.append().
> They would rather record the parameters needed for the messages.
>
> When all assessment is done, one would next look which programs are
> actually usable and which capabilities are covered by them.
>
> If an important capapability is not covered by a usable program,
> then this is should be reported as CRITICAL.
> Further one could at this point choose the default programs for the
> various tasks which demand the covered capabilities.
>
> (Another burn backend K3B could encounter is "xorrecord", which is the
> cdrecord options emulation of xorriso. CD, DVD, BD. Data only. No audio.
> Based on libburn like cdrskin.)
>
> -
>
> Before declaring a capability to be covered, the programmer will have
> to verify that K3B can actually use that program for that task.
> I.e. is K3B prepared to produce the necessary options ?
> Can the program really do what the options demand ?
>
> So, this proposal would cause substantial work and review of the
> existing K3B code that controls the backend runs.
yes, k3b will emit infoMessage about MessageError when be lack of some feature
during the prepareProcess before the actual burning job, for example:
https://github.com/KDE/k3b/blob/master/libk3b/projects/k3bcdrskinwriter.cpp#L245
and it is better to provide detailed checkSystem at startup, so users might
install missing packages if desire some features, thoughts?
>
>
> Have a nice day :)
>
> Thomas
--
You are receiving this mail because:
You are watching all bug changes.
[k3b] [Bug 383011] k3b cannot create DVD video image
https://bugs.kde.org/show_bug.cgi?id=383011 --- Comment #5 from Leslie Zhai <lesliez...@llvm.org.cn> --- Hi Don, Could you test the patch https://phabricator.kde.org/D7063 thanks! Regards, Leslie Zhai -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 383011] k3b cannot create DVD video image
https://bugs.kde.org/show_bug.cgi?id=383011 --- Comment #2 from Leslie Zhai <lesliez...@llvm.org.cn> --- (In reply to Leslie Zhai from comment #1) > Hi Erwin, > > Please review my patch https://git.reviewboard.kde.org/r/130212/ > > Regards, > Leslie Zhai - a LLVM developer https://reviews.llvm.org/p/xiangzhai/ please review https://phabricator.kde.org/D7063 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 381368] "do not show again" from system configuration problems dialog is not remembered
https://bugs.kde.org/show_bug.cgi?id=381368 --- Comment #14 from Leslie Zhai <lesliez...@llvm.org.cn> --- Git commit 762fc98addfc5a83e80aa1c7d83384a512c48f33 by Leslie Zhai. Committed on 02/08/2017 at 06:44. Pushed by lesliezhai into branch 'master'. Add forceCheck for ManualCheckSystem. M +1-1src/k3b.cpp M +2-2src/k3bsystemproblemdialog.cpp M +1-1src/k3bsystemproblemdialog.h https://commits.kde.org/k3b/762fc98addfc5a83e80aa1c7d83384a512c48f33 -- You are receiving this mail because: You are watching all bug changes.
