[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #50 from Omar Amin  ---
Sure.
I'll max tomorrow send you a list of screenshots with the colors for feedback,
I've found a side effect from my patch and i'm working on it and will get back
to you soon.

Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

Omar Amin  changed:

   What|Removed |Added

  Attachment #98977|0   |1
is obsolete||

--- Comment #47 from Omar Amin  ---
Created attachment 99002
  --> https://bugs.kde.org/attachment.cgi?id=99002=edit
group border fitting, different background colors for grouped images.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #42 from Omar Amin  ---
Created attachment 98977
  --> https://bugs.kde.org/attachment.cgi?id=98977=edit
Not final patch, just a trial for feedback

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #39 from Omar Amin  ---
Dear Mr Gilles,

I've attached three images for the three problems i'm currently addressing:
1- Group border was transparent so when the theme is changed to black
background, the border is visible, but i think it can be better, please let me
know your opinion.

2- The Image to be totally included inside the thumbnail, i'm still solving
this, what i'm trying to do is to limit the image thumbnail size (the space in
which the image and its border to be drawn within) to make sure that the image
and its border doesn't go outside the thumbnail also, they doesn't overlay the
group indicator

3- the grouped images background color while expanded as requested by Mr Jens.

What i'm trying to do:
1- to add to each theme two more appropriate colors one for the grouped images
background color while expanded, the other to choose the border color depending
on the theme, the current setting is suitable when the background is white, but
it doesn't look good when using any other background color.

2- resize the image thumbnail to fit within a max width and max height that are
a function of the slider value in the buttom right so as to the grouped border
fit within the image thumbnail as requested, but i didn't manage to do it yet.


If there're other requests please let me know what are they, and i'll finish
within the next couple of days.

I'm expecting to finish these suggestions max by tomorrow(Friday) or by
Saturday.

I'm sorry for the long delay, it won't happen again

Thank you,
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #38 from Omar Amin  ---
Created attachment 98939
  --> https://bugs.kde.org/attachment.cgi?id=98939=edit
Group images highlighted when group is expanded

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #37 from Omar Amin  ---
Created attachment 98938
  --> https://bugs.kde.org/attachment.cgi?id=98938=edit
progress in ensure the image border doesn't go outside the thumbnail border,
temp solution

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #36 from Omar Amin  ---
Created attachment 98937
  --> https://bugs.kde.org/attachment.cgi?id=98937=edit
Black background theme, group bordered is filled

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #32 from Omar Amin  ---
if we need to use the rotated borders, we can adjust the border for each image
at different thumbnail sizes differently that will make us able to fit the
rotated borders at different thumbnail sizes entirely inside the image
rectangle, the only withdraw for this approach would be it'll show less number
of images per row in the album grid.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #31 from Omar Amin  ---
Dear Mr Gilles and Mr Jens,

I made this simple stack just for confirming if that's what we need or not?, i
made it on a separate project to make the compilation quicker, that's why not
all digKam image info is shown nor the borders, it's just for confirming the
view and if that's what's required or not.

I'll still make the turned corner, or did i misunderstood the requirements?

I didn't fully understand what you mean by:

- "I think that we must to render a smallest thumb with a largest border in
case of grouped items"
do you mean that the border will be of different size for different images?
and
"Just try to make the grouped border frame better, to render it inside the
thumbnails, not outside"
how can the rotated frames fit inside the thumbnail?

if you can clarify more that would be perfect.

sorry for inconvenience.

Regards,
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #30 from Omar Amin  ---
Created attachment 98715
  --> https://bugs.kde.org/attachment.cgi?id=98715=edit
stack proposal

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #26 from Omar Amin  ---
(In reply to caulier.gilles from comment #25)
> Note : LightRoom groupped items is called "Image Stacked". It's explained
> here :
> 
> http://valeriegoettsch.com/lightroom-grid-view-icons/
> 
> Excepted the icon+number of items in the stack, no specify frames is draw.
> 
> Gilles

Thanks for the feedback.

to start working i just want to make sure that i understood what's required.

In the following image
http://valeriegoettsch.com/wp-content/uploads/badges-diagram.jpg

I'll imitate the following features:
- Stack (stating 1 of 2 -- where 2 is the group images count)
- the virtual copy (do i need to draw the turned corner to indicate visually
that this is a group ?)

in the following image 
https://bugs.kde.org/attachment.cgi?id=98577=edit
What about the icon in the bottom right on which the number of grouped images
is written ?
should it be removed?

Thank you,
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #22 from Omar Amin  ---
Dear Mr Gilles,

I'm sorry for being late, attached the new patch containing the modifications
needed for centring the thumbnail inside the group borders, If we have time I
can work on the other needed modifications (grouped images different background
colour and the darker group border) and get back to you as soon as I finish
them.

Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

Omar Amin  changed:

   What|Removed |Added

  Attachment #98455|0   |1
is obsolete||

--- Comment #21 from Omar Amin  ---
Created attachment 98630
  --> https://bugs.kde.org/attachment.cgi?id=98630=edit
Group border modification patch v2

Contains code for centring thumbnail inside new group borders

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #17 from Omar Amin  ---
Hello,

I've fixed the centring issue for the thumbnail and have attached a sample for
3 different groups, please let me know if you think they're still not
symmetrical.

Regarding the large thumbnail support, I've tried to reproduce this issue on my
PC but couldn't

I tried the following
>From Settings->Configure-digiKam --> Album View :
I checked the option --> use large thumbnail size for high screen resolution
and restart digiKam for this option to take effect, but nothing happened

Also from Tools-> Maintenance :
I checked the rebuild thumbnails  and restarted digiKam but nothing happened.

Do I need to have an HD screen for this option to take effect?

I'll still search for the code responsible for handling this issue and get back
to you with the patch once i finish it.

Thank you :)
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

Omar Amin  changed:

   What|Removed |Added

  Attachment #98456|0   |1
is obsolete||

--- Comment #16 from Omar Amin  ---
Created attachment 98577
  --> https://bugs.kde.org/attachment.cgi?id=98577=edit
Thumbnail centred

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #15 from Omar Amin  ---
Dear Mr Gilles,

I'm sorry for being late, I'll start today on it, and also tomorrow will be
working on it the whole day, and will send a patch tomorrow max.

Mr Jens, yes for sure i can, I'll also try to do the grouped background color
and get back to you :)

Regards,
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #10 from Omar Amin  ---
Created attachment 98456
  --> https://bugs.kde.org/attachment.cgi?id=98456=edit
Screenshot of the new grouped images border

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #9 from Omar Amin  ---
Created attachment 98455
  --> https://bugs.kde.org/attachment.cgi?id=98455=edit
Group border modification patch

This patch is for grouped images border new background

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #7 from Omar Amin  ---
Hi Mr Gilles,


I'll look into it during this week, and will finish it by next Friday, Please
let me know if you need it finished earlier.

Regards,
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.