[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=486037

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||6.0.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-08 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=486037

Harald Sitter  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/discover/-/commit/5246ef |ma/discover/-/commit/c531b7
   |454c5be0b16e3df7e232e4d3b39 |eb8c38ae3761256e0a4f4e16091
   |84435d0 |3984cbc

--- Comment #9 from Harald Sitter  ---
Git commit c531b7eb8c38ae3761256e0a4f4e160913984cbc by Harald Sitter.
Committed on 08/05/2024 at 14:41.
Pushed by sitter into branch 'Plasma/6.0'.

packagekit: return empty license array when unknown

this was previously made non-empty so it looks like a valid license set.
since then we've grown the ability to actually show unknown licenses as
unknown in the UI, but that requires the license array to actually be
empty. so, make it empty again (:


(cherry picked from commit 5246ef454c5be0b16e3df7e232e4d3b3984435d0)

M  +1-1libdiscover/backends/PackageKitBackend/PackageKitResource.cpp

https://invent.kde.org/plasma/discover/-/commit/c531b7eb8c38ae3761256e0a4f4e160913984cbc

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-08 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=486037

Harald Sitter  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/discover/-/commit/5246ef
   ||454c5be0b16e3df7e232e4d3b39
   ||84435d0

--- Comment #8 from Harald Sitter  ---
Git commit 5246ef454c5be0b16e3df7e232e4d3b3984435d0 by Harald Sitter.
Committed on 08/05/2024 at 09:06.
Pushed by sitter into branch 'master'.

packagekit: return empty license array when unknown

this was previously made non-empty so it looks like a valid license set.
since then we've grown the ability to actually show unknown licenses as
unknown in the UI, but that requires the license array to actually be
empty. so, make it empty again (:

M  +1-1libdiscover/backends/PackageKitBackend/PackageKitResource.cpp

https://invent.kde.org/plasma/discover/-/commit/5246ef454c5be0b16e3df7e232e4d3b3984435d0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=486037

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |major
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=486037

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #7 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/discover/-/merge_requests/831

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-07 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=486037

Harald Sitter  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #6 from Harald Sitter  ---
Thanks.

The problem appears to be that the package fails to resolve and consequently
has an empty (I think) license which then triggers a UI bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-06 Thread Eamonn Rea
https://bugs.kde.org/show_bug.cgi?id=486037

--- Comment #5 from Eamonn Rea  ---
The output is quite long, so I'll put a couple of notes I wanted to make here,
before the output:
1. Although there are a couple of results, the Geany I am referring to is the
IDE
2. The output of `pkcon get-details geany` occurs for every system package I
try to view on Discover that is not already installed (since Discover isn't
meant to be used to install Arch packages afaik) -- However, *not* all system
packages are missing a license. In other words, even though this message will
always appear, even packages that display correctly in Discover will also show
this, both from the UI and that command.
3. This affects more than just Geany, other examples of packages with missing
licenses are OpenTTD, 0 A.D., and Snes9x.
4. Packages missing a license are usually also missing screenshots. Distro
packages that do have license information will usually also display
screenshots.

**

$ appstreamcli search geany
Identifier: io.sourceforge.chart_geany.chart-geany [desktop-application]
Name: Chart Geany
Summary: 
  Chart Geany is a free cross platform software solution for market technical
analysis, charting
  and a portfolio manager
Bundle: flatpak:app/io.sourceforge.chart_geany.chart-geany/x86_64/stable
Homepage: https://chart-geany.sourceforge.io/
Icon: io.sourceforge.chart_geany.chart-geany.png
---
Identifier: org.gnome.Devhelp.desktop [desktop-application]
Name: Devhelp
Summary: A developer tool for browsing and searching API documentation
Bundle: flatpak:app/org.gnome.Devhelp/x86_64/stable
Homepage: https://wiki.gnome.org/Apps/Devhelp/
Icon: org.gnome.Devhelp.png
---
Identifier: org.gnome.Devhelp.desktop [desktop-application]
Name: Devhelp
Summary: A developer tool for browsing and searching API documentation
Package: devhelp
Homepage: https://wiki.gnome.org/Apps/Devhelp/
Icon: devhelp_org.gnome.Devhelp.png
---
Identifier: org.geany.Geany [desktop-application]
Name: Geany
Summary: A fast and lightweight IDE
Bundle: flatpak:app/org.geany.Geany/x86_64/stable
Homepage: https://geany.org/
Icon: org.geany.Geany.png
---
Identifier: geany.desktop [desktop-application]
Name: Geany
Summary: A fast and lightweight IDE using GTK+
Package: geany
Icon: geany_geany.png

**

$ appstreamcli dump geany.desktop


  geany.desktop
  Geany
  A fast and lightweight IDE using GTK+
  
Fast and lightweight IDE
  
  geany
  geany.desktop
  geany_geany.png
  geany_geany.png
  geany_geany.png
  geany
  
Development
IDE
TextEditor
  
  
text/plain
text/x-chdr
text/x-csrc
text/x-c++hdr
text/x-c++src
text/x-java
text/x-dsrc
text/x-pascal
text/x-perl
text/x-python
application/x-php
application/x-httpd-php3
application/x-httpd-php4
application/x-httpd-php5
application/xml
text/html
text/css
text/x-sql
text/x-diff
  
  
Text
Editor
  


**

$ pkcon get-details geany
Resolving   [=] 
Getting details [=] 
Finished[=] 
Fatal error: geany;2.0-1;x86_64;extra: could not find or read package

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-06 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=486037

--- Comment #4 from Harald Sitter  ---
Very strange.

Please post the output of 

appstreamcli search geany
appstreamcli dump geany.desktop
pkcon get-details geany

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-04 Thread Eamonn Rea
https://bugs.kde.org/show_bug.cgi?id=486037

--- Comment #3 from Eamonn Rea  ---
Created attachment 169201
  --> https://bugs.kde.org/attachment.cgi?id=169201=edit
Geany does not display a license, and viewing information shows a Proprietary
Software warning

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-04 Thread Eamonn Rea
https://bugs.kde.org/show_bug.cgi?id=486037

--- Comment #2 from Eamonn Rea  ---
It happens with Geany when listing the package manager release. I'll add an
attachment.

I believe there are other examples I found at the time of reporting, but I can
only recall Geany, and I have confirmed the issue still exists with Geany. The
screenshot I will attach following this comment was taken today.

The Arch Linux packages page does correctly list Geany as having a license:
https://archlinux.org/packages/extra/x86_64/geany/

But in the case where Discover cannot pull it, I think it would be good to have
some sort of case to handle as fallback.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 486037] Application without metadata defaults to license information as proprietary

2024-05-03 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=486037

Harald Sitter  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||sit...@kde.org

--- Comment #1 from Harald Sitter  ---
Which application does this happen with for example?

-- 
You are receiving this mail because:
You are watching all bug changes.