[clazy] [Bug 403394] Warn about missed override of helper functions for QException descendants

2019-02-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=403394

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

--- Comment #3 from Sergio Martins  ---
ok, makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 403394] Warn about missed override of helper functions for QException descendants

2019-02-15 Thread Roman
https://bugs.kde.org/show_bug.cgi?id=403394

--- Comment #2 from Roman  ---
(In reply to Sergio Martins from comment #1)
> Should they be pure virtual to begin with ?

If you mean in QException class, i believe no, because QConcurrent need to
throw something, but your code can just not expect QException, but something
more specific.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 403394] Warn about missed override of helper functions for QException descendants

2019-02-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=403394

--- Comment #1 from Sergio Martins  ---
Should they be pure virtual to begin with ?

-- 
You are receiving this mail because:
You are watching all bug changes.