[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

swatilodh...@gmail.com changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/digi
   ||kam/868520574949d0f0febdc44
   ||44875809360ad5626
 Resolution|--- |FIXED
   Version Fixed In||5.1.0
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #22 from swatilodh...@gmail.com ---
Thanks a lot Maik for testing. I'll apply the patch and close this entry.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #21 from Maik Qualmann  ---
Yes, the patch works. With this patch, an image is again visible in the album
when the image information is missing. After rereading metadata from the image
are the image information also available again. I have so far found no negative
side effects. We have before release from DigiKam-5.1.0 time to test. Swati,
apply the patch.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #20 from Maik Qualmann  ---
Swati, I look to this problem and the patch tomorrow.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #19 from caulier.gil...@gmail.com ---
I cannot test for the moment as i'm not at home. Ask to Maik if he can test.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #18 from swatilodh...@gmail.com ---
(In reply to caulier.gilles from comment #17)
> In your new patch xml file is untouched, only cpp files. It's wanted ?

Yes, 'cause that cpp file decides the images to be displayed in the UI. So,
JOIN must be changed here. 
Does it works well for you too?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #17 from caulier.gil...@gmail.com ---
In your new patch xml file is untouched, only cpp files. It's wanted ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #16 from caulier.gil...@gmail.com ---
In your new patch xml file is untouched. It's the w

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #15 from swatilodh...@gmail.com ---
Created attachment 100335
  --> https://bugs.kde.org/attachment.cgi?id=100335=edit
Updated patch

Okay, I did realize after some testing that I made some unwanted changes in the
XML schema file which weren't required.
Please take a look at the updated patch, and let me know if it's good enough!

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

swatilodh...@gmail.com changed:

   What|Removed |Added

 Attachment #100320|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #14 from caulier.gil...@gmail.com ---
Well, if the schema of tables are untouched no, and it sound the case. Only the
way to handle data from table with SQL action are touched.

But the revision of XML file need to be increased of course.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #13 from swatilodh...@gmail.com ---
(In reply to caulier.gilles from comment #12)
> By intrusive, i want mean it touch code in different place.
> 
> As sqlite code in XML file is touched, the sqlite schema ID need to be
> updated ? No schema updater need to be written ?

Do you think it should be updated? Since it is only a fix for a issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #12 from caulier.gil...@gmail.com ---
By intrusive, i want mean it touch code in different place.

As sqlite code in XML file is touched, the sqlite schema ID need to be updated
? No schema updater need to be written ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #11 from swatilodh...@gmail.com ---
(In reply to caulier.gilles from comment #9)
> Swati, 
> 
> In your patch, did you touch the sqlite schema or only mysql one ?

I've changed the queries for both MySQL and SQLite in XML schema file, and of
course the common queries for both in source code.

> The patch is a little bit intrusive.

Could you please tell me which part?

 Do you test this patch to see if side
> effects are introduced in general digiKam use cases ?

As far as I did, it worked fine for me!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

--- Comment #10 from caulier.gil...@gmail.com ---
Richard,

This patch from Swati sound acceptable for you ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339607

caulier.gil...@gmail.com changed:

   What|Removed |Added

Summary|MYSQL : Images not show if  |MYSQL : Images not show if
   |corresponding   |corresponding
   |ImageInformation entry does |ImageInformation entry does
   |not exist in database   |not exist in database
   ||[patch]

--- Comment #9 from caulier.gil...@gmail.com ---
Swati, 

In your patch, did you touch the sqlite schema or only mysql one ?

The patch is a little bit intrusive. Do you test this patch to see if side
effects are introduced in general digiKam use cases ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.