[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=357577

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|ProgressManager |ProgressManager-Splashscree
   ||n

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=357577

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Database-Scan   |ProgressManager

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=357577

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|general |Database-Scan

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #22 from caulier.gil...@gmail.com ---
To Thomas, from comment #19 :

>BTW: Additionally face detection seems to have problems with special 
>characters (unicode) in file >names, it shows "file system" errors or file 
>"format not recognized" error for these files, maybe >something with file name 
>encoding or conversion QFile-name <-> QUrl goes wrong (I also had >these 
>things in Kwave).

Can you open a new file in bugzilla about this problem with :

1/ The file name pattern to use to reproduce the problem
2/ The console backtrace while the problem appears.

Note : KUrl to QUrl port was been a big mess and need huge regression tests.
Typically, in the future, we will take a care to use less KDE API when Qt API
do the job as well. It's typically a waste of time to port back from KDE to Qt
and can introduce undesired dysfunctions in code. Porting KUrl to QUrl take me
more than one month for only digiKam core , which is unacceptable for a project
as digiKam...

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

Maik Qualmann  changed:

   What|Removed |Added

Summary|crashes after splash screen |crashes after splash screen
   |with ASSERT failure in  |with ASSERT failure in
   |QVector |QVector [patch]

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

Maik Qualmann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.0.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/digi
   ||kam/e10a52aefc55d6e47e73691
   ||0353a53546fd21fde

--- Comment #21 from Maik Qualmann  ---
Git commit e10a52aefc55d6e47e736910353a53546fd21fde by Maik Qualmann.
Committed on 11/01/2016 at 19:29.
Pushed by mqualmann into branch 'master'.

insert trash album after root album, otherwise not exist the parent album
FIXED-IN: 5.0.0

M  +2-1NEWS
M  +9-4libs/album/albummanager.cpp

http://commits.kde.org/digikam/e10a52aefc55d6e47e736910353a53546fd21fde

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

Maik Qualmann  changed:

   What|Removed |Added

  Attachment #96548|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #18 from Maik Qualmann  ---
Created attachment 96562
  --> https://bugs.kde.org/attachment.cgi?id=96562=edit
albummanager2.patch

A trash for each root album working again.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #20 from Thomas Eschenbacher  ---
short update: now, after waiting for a very very long time, it shows Albums and
Images again! It seems that it had to do it's job about face recognition in
background, without any visible hint for the user what is going on. It was just
luck that I recognized this, because I started it from the console, normally I
would have given up already, called the "useless" and killed it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #19 from Thomas Eschenbacher  ---
Thanks for the patch! 

It does not show any of my albums and I cannot see any picture anywhere,  so
the application is pretty useless at the moment, but at least it starts and no
longer crashes! :-)

The "Album" tree view (or whatever that widget on the left side is), is nearly
empty, it contains only the string "Albums" with something that looks like a
generic "image" icon at the left. Nothing else, nothing to expand or
collapse...

Another odd thing: it seems that the settings have not been properly migrated,
the strings to my albums were URL encoded or so, the edit fields showed strings
like "%2Fhome%2Fuser%2FPictures". After I added my local collection manually
again, I can see in the console debug output that it iterates over my complete
collection and tries to do some face detection. But still nothing in the Albums
list.

BTW: Additionally face detection seems to have problems with special characters
(unicode) in file names, it shows "file system" errors or file "format not
recognized" error for these files, maybe something with file name encoding or
conversion QFile-name <-> QUrl goes wrong (I also had these things in Kwave).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #16 from caulier.gil...@gmail.com ---
Qt said that QVector are used out on index. This is an internal use, not from
digiKam.

The Digikam::AbstractAlbumModel::slotAlbumAboutToBeAdded is called with these
arguments (this=0x1390690, album=0x21f7de0, parent=0x21f6410, prev=0x0)

prev = 0 wnat mean that a parent album must be registered in model. Code
relevant from digiKam is here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/models/abstractalbummodel.cpp#L422

This call Qt like this QAbstractItemModel::beginInsertRows (this=0x1390690,
parent=..., first=0, last=0)

...and it crash. Note that first and last are null, which is fine with Qt API :

http://doc.qt.io/qt-5/qabstractitemmodel.html#beginInsertRows

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #17 from Maik Qualmann  ---
Created attachment 96548
  --> https://bugs.kde.org/attachment.cgi?id=96548=edit
albummanager.patch

Can you try this patch in the "core" subdirectory?

patch -p0 < albummanager.patch

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #13 from Thomas Eschenbacher  ---
sorry, that is not possible. Valgrind is broken and unusable too, crashes quite
early due to this bug:
https://bugs.kde.org/show_bug.cgi?id=323431

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #14 from caulier.gil...@gmail.com ---
Did you use AMD based CPU on your computer ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #11 from Thomas Eschenbacher  ---
No, debug symbols (as you get per -g in the CFLAGS) are necessary for a usable
backtrace but not sufficient.

You need to get theQt5  libs compiled "QT_DEBUG" defined and "QT_NO_DEBUG"
_not_ defined, the same way you do when you want a KDE application to evaluate
Q_ASSERT checks. See /usr/include/qt5/QtCore/qglobal.h  ~line 665, where
Q_ASSERT is handled.

Normally Qt packages from distributions are compiled without QT_DEBUG and thus
silently ignore such kinds of error situations. 

Maybe you have more luck by using a "developer build" of Qt and force digikam
to use it by setting LD_LIBRARY_PATH into it. (see
http://doc.qt.io/qt-5/configure-options.html and use the option
"-developer-build" as suggested)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #12 from Maik Qualmann  ---
I have the code of AbstractAlbumModel::slotAlbumAboutToBeAdded(...) debugged
and found nothing.

Can you digiKam with valgrind testing and post the output?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #2 from caulier.gil...@gmail.com ---
It sound like a Qt5 bug. 

#13 0x0037b2808c61 in QAbstractItemModel::beginInsertRows (this=0x13c1c40,
parent=..., first=0, last=0)
at itemmodels/qabstractitemmodel.cpp:2602
#14 0x7795dc64 in Digikam::AbstractAlbumModel::slotAlbumAboutToBeAdded
(this=0x13c1c40, album=0x22514a0, 
parent=0x32a94c0, prev=0x0) at
/usr/src/packages/multimedia/digikam/core/libs/models/abstractalbummodel.cpp:438

When a parent album need to be inserted in the model (prev = 0),
QAbstractItemModel::beginInsertRows() i scalled with 2 arguments to 0.

I tried to reproduce the problem here, and it's not reproducible (Qt 5.5.1)

Which Qt version did you use ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #1 from Thomas Eschenbacher  ---
Created attachment 96473
  --> https://bugs.kde.org/attachment.cgi?id=96473=edit
console output up to the crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #5 from Maik Qualmann  ---
Please try again with latest git commit. The crash is not to reproduce here.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

Thomas Eschenbacher  changed:

   What|Removed |Added

 CC||thomas.eschenbac...@gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #3 from Thomas Eschenbacher  ---
as I wrote above: Qt-5.5.1
It is 100% reproducible here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 357577] crashes after splash screen with ASSERT failure in QVector

[Thomas Eschenbacher via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357577

--- Comment #6 from Thomas Eschenbacher  ---
how can I get this source version you are talking about?

I followed the instructions on the project homepage, which lead me to this
repo:
> git remote -v
origin  git://anongit.kde.org/digikam-software-compilation (fetch)
origin  git://anongit.kde.org/digikam-software-compilation (push)

but your change is not visible there.
I tried to "git remote set-url origin git://anongit.kde.org/digikam.git" but
that has lead to a big mess, had to restore the local repo from backup.

What should I do now?

-- 
You are receiving this mail because:
You are watching all bug changes.