[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #21 from swatilodh...@gmail.com ---
Patch works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

Maik Qualmann  changed:

   What|Removed |Added

   Version Fixed In||5.0.0
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/digi
   ||kam/d18903fa644affd5f2b3c27
   ||5b2544a54a9d64782

--- Comment #20 from Maik Qualmann  ---
Git commit d18903fa644affd5f2b3c275b2544a54a9d64782 by Maik Qualmann.
Committed on 02/07/2016 at 17:30.
Pushed by mqualmann into branch 'master'.

make MySQL text fields case-sensitive
FIXED-IN: 5.0.0

M  +1-2NEWS
M  +81   -37   data/database/dbconfig.xml.cmake.in
M  +4-1libs/database/coredb/coredbschemaupdater.cpp

http://commits.kde.org/digikam/d18903fa644affd5f2b3c275b2544a54a9d64782

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #19 from Maik Qualmann  ---
Created attachment 99808
  --> https://bugs.kde.org/attachment.cgi?id=99808=edit
schemaupdater6.patch

Ok, this patch works for a new MySQL DB and for an update of the DB. Swati,
please test the patch. I will this patch now commit to git/master and close
this bug.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

Maik Qualmann  changed:

   What|Removed |Added

  Attachment #99791|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #18 from Maik Qualmann  ---
I think the text fields from AlbumRoots need it too:
(line 934)
label LONGTEXT,
identifier LONGTEXT,
specificPath LONGTEXT,

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #17 from swatilodh...@gmail.com ---
Created attachment 99791
  --> https://bugs.kde.org/attachment.cgi?id=99791=edit
Final patch

Please test this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

swatilodh...@gmail.com changed:

   What|Removed |Added

  Attachment #99735|0   |1
is obsolete||
  Attachment #99735|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #16 from swatilodh...@gmail.com ---
(In reply to Maik Qualmann from comment #15)
> Swati,
> I think we need case-sensitivity in almost all text fields. I have tested it
> once for Albums.relativePath. It does the problem here on, if the path is
> different only in case-sensitivity. Is there a global statement for the DB?

I think in mysql-global.conf file, you could change
"collation_server=utf8_general_ci" to "collation-server=utf8_bin"

Or in etc/mysql/my.cnf file, under [mysqld]  section, you need to change the
collation, since MySQL is case insensitive by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[Maik Qualmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #15 from Maik Qualmann  ---
Swati,
I think we need case-sensitivity in almost all text fields. I have tested it
once for Albums.relativePath. It does the problem here on, if the path is
different only in case-sensitivity. Is there a global statement for the DB?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[Richard Mortimer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #14 from Richard Mortimer  ---
Changing the collation is the correct thing to do.

Regarding the patch the schema update is required but the v7 to v8 patch needs
to perform an "alter table" command. The update has to assume that the v7
schema is intact and any changes are as specified.

That said before 5.0 is released we need to update the MySQL v7 schema. Whilst
MySQL has never been a stable/supported database the existing 4.x series uses a
base v7 and the existing new database v7 schema has the changes for referential
integrity included. IMHO the v7 to v8 updater should convert the 4.x schema to
the latest schema. Anyone who has been using the 5.x beta series will be able
to "fixup" their schema with a simple version update command. I will dig out my
notes and generate update commands to include in Swati's patch so that the
schema update gets done in a single commit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||richm+...@oldelvet.org.uk

--- Comment #13 from caulier.gil...@gmail.com ---
Richard, 

I would to have your viewpoint about Swati patch to fix this issue, especially
the schema updater part to fix table properties.

Thanks in advance

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Attachment #99691|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Attachment #99700|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #12 from swatilodh...@gmail.com ---
Created attachment 99735
  --> https://bugs.kde.org/attachment.cgi?id=99735=edit
Updated patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

swatilodh...@gmail.com changed:

   What|Removed |Added

 CC||li...@daniel-bauer.com

--- Comment #11 from swatilodh...@gmail.com ---
*** Bug 268204 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #10 from swatilodh...@gmail.com ---
Two functions are basically added to update the version in schemaupdater file
1) copyV4toV5()
2) updateV7toV8()

And a dbaction "UpdateSchemaFromV7ToV8" in XML schema file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

--- Comment #9 from caulier.gil...@gmail.com ---
Swaty,

The 2nd patch sound changes a lots of code. Why ? Can you details the patch ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 364131] SCAN : same picture with different file extensions : database scan only finds one variant of the file [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364131

caulier.gil...@gmail.com changed:

   What|Removed |Added

Summary|SCAN : same picture with|SCAN : same picture with
   |different file extensions : |different file extensions :
   |database scan only finds|database scan only finds
   |one variant of the file.|one variant of the file
   ||[patch]

-- 
You are receiving this mail because:
You are watching all bug changes.