[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Tarball |Tarball-Compilation

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Documentation   |Bundle-Tarball

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

   Assignee|txe...@gmail.com|digikam-de...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

Version|5.0.0   |5.1.0

--- Comment #21 from caulier.gil...@gmail.com ---
[gilles@localhost release]$ git log -u -1
32655482fb47e46a3521ec3a8b523a217529441f
commit 32655482fb47e46a3521ec3a8b523a217529441f
Author: Gilles Caulier 
Date:   Wed Aug 10 10:34:18 2016 +0200

when CMakeLists.txt file is created for showfoto documentation i18n build,
do not overwrite digikam doc rules, just append new showfoto rules
BUGS: 365135
FIXED-IN: 5.2.0

diff --git a/project/release/fetch_l10n_doc.rb
b/project/release/fetch_l10n_doc.rb
index 743b3f0..3ed8eac 100755
--- a/project/release/fetch_l10n_doc.rb
+++ b/project/release/fetch_l10n_doc.rb
@@ -168,8 +168,8 @@ i18nlangs.each_line do |lang|
 end

 if (complete == true)
-makefile = File.open( "CMakeLists.txt", File::RDWR)
-makefile << "KDOCTOOLS_CREATE_HANDBOOK( showfoto/index.docbook
INSTALL_DESTINATION ${HTML_INSTALL_DIR}/#{lang}/ SUBDIR digikam )"
+makefile = File.open( "CMakeLists.txt", "a")
+makefile << "\nKDOCTOOLS_CREATE_HANDBOOK(
showfoto/index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/#{lang}/ SUBDIR
digikam )"
 makefile.close()
 end

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Steven Robbins via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #20 from Steven Robbins  ---
Looking for the patch to cherry-pick.  The link given doesn't lead anywhere. 
How can I find the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
  Latest Commit|http://commits.kde.org/scra |http://commits.kde.org/scra
   |tch/mwiesweg/digikam-sc/583 |tch/mwiesweg/digikam-sc/326
   |562a182662fb91d3a52e5aec79f |55482fb47e46a3521ec3a8b523a
   |ce90f9249d  |217529441f
   Version Fixed In|5.1.0   |5.2.0
 Resolution|--- |FIXED

--- Comment #19 from caulier.gil...@gmail.com ---
Git commit 32655482fb47e46a3521ec3a8b523a217529441f by Gilles Caulier.
Committed on 10/08/2016 at 08:34.
Pushed by cgilles into branch 'master'.

when CMakeLists.txt file is created for showfoto documentation i18n build, do
not overwrite digikam doc rules, just append new showfoto rules
FIXED-IN: 5.2.0

M  +2-2project/release/fetch_l10n_doc.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/32655482fb47e46a3521ec3a8b523a217529441f

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

Rex Dieter  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #18 from Rex Dieter  ---
digikam-5.1.0 tarball appears to have gotten this wrong still, but in a
different way than before.  Now the layout is correct, but CMakeLists.txt is
incorrect, for example,

digikam-5.1.0/doc-translated/digikam/it/CMakeLists.txt contains:
KDOCTOOLS_CREATE_HANDBOOK( showfoto/index.docbook INSTALL_DESTINATION
${HTML_INSTALL_DIR}/it/ SUBDIR digikam )

Only the showfoto handbook is installed, and is installed to the wrong place.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit|http://commits.kde.org/scra |http://commits.kde.org/scra
   |tch/mwiesweg/digikam-sc/26d |tch/mwiesweg/digikam-sc/583
   |56cc7a165e7efce6d22278fbda7 |562a182662fb91d3a52e5aec79f
   |a959b4ede3  |ce90f9249d

--- Comment #17 from caulier.gil...@gmail.com ---
Git commit 583562a182662fb91d3a52e5aec79fce90f9249d by Gilles Caulier.
Committed on 10/07/2016 at 14:48.
Pushed by cgilles into branch 'master'.

fix doc i18n extract to respect right dir tree to compile

M  +5-5bootstrap.linux
M  +40   -57   project/release/fetch_l10n_doc.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/583562a182662fb91d3a52e5aec79fce90f9249d

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #16 from caulier.gil...@gmail.com ---
Done :

[gilles@localhost 5.x]$ ./bootstrap.linux
Qt5 Install Path : /usr/lib64/qt5
KF5 Install Path : /usr
digiKam Install Path : /usr
--
--
-- Starting CMake configuration for: digikam-software-collection
-- Could NOT find Ruby (missing:  RUBY_INCLUDE_DIR RUBY_LIBRARY
RUBY_CONFIG_INCLUDE_DIR) (found version "2.2.0")
-- Extract documentation translation files from KDE repositories. Please wait,
it can take a while...
-- NOTE: (u) want mean uncomplete translations files, which will be removed
from compilation.
digikam: af(u) ar(u) az(u) be(u) bg(u) bn(u) br(u) bs(u) ca(u) cs(u) csb(u)
cy(u) da(u) de(u) el(u) en_GB(u) eo(u) es(u) et(u) eu(u) fa(u) fi(u) fo(u)
fr(u) fy(u) ga(u) gl(u) ha(u) he(u) hi(u) hr(u) hsb(u) hu(u) id(u) is(u) it
ja(u) ka(u) kk(u) km(u) ko(u) ku(u) lb(u) lo(u) lt(u) lv(u) mi(u) mk(u) mn(u)
ms(u) mt(u) nb(u) nds(u) ne(u) nl nn(u) nso(u) oc(u) pa(u) pl(u) pt pt_BR ro(u)
ru(u) rw(u) se(u) sk(u) sl(u) sq(u) sr(u) sr@Latn(u) ss(u) sv ta(u) te(u) tg(u)
th(u) tr(u) tt(u) uk uz(u) uz@cyrillic(u) ven(u) vi(u) wa(u) xh(u) zh_CN(u)
zh_HK(u) zh_TW(u) zu(u) 
showfoto: it nl pt pt_BR sv uk 
kipi-plugins: af(u) ar(u) az(u) be(u) bg(u) bn(u) br(u) bs(u) ca(u) cs(u)
csb(u) cy(u) da(u) de(u) el(u) en_GB(u) eo(u) es(u) et(u) eu(u) fa(u) fi(u)
fo(u) fr(u) fy(u) ga(u) gl(u) ha(u) he(u) hi(u) hr(u) hsb(u) hu(u) id(u) is(u)
it(u) ja(u) ka(u) kk(u) km(u) ko(u) ku(u) lb(u) lo(u) lt(u) lv(u) mi(u) mk(u)
mn(u) ms(u) mt(u) nb(u) nds(u) ne(u) nl(u) nn(u) nso(u) oc(u) pa(u) pl(u) pt(u)
pt_BR(u) ro(u) ru(u) rw(u) se(u) sk(u) sl(u) sq(u) sr(u) sr@Latn(u) ss(u) sv(u)
ta(u) te(u) tg(u) th(u) tr(u) tt(u) uk(u) uz(u) uz@cyrillic(u) ven(u) vi(u)
wa(u) xh(u) zh_CN(u) zh_HK(u) zh_TW(u) zu(u) 
-- Documentation translation files extraction done.
--
--
-- Compilation configuration for: digikam-software-collection
-- digiKam core will be compiled.. NO
-- Kipiplugins will be compiled... NO
-- Local shared libkipi will be compiled.. NO
-- Local shared libksane will be compiled. NO
-- Local shared libmediawiki will be compiled. NO
-- Local shared libkvkontakte will be compiled NO
-- Extract application translations files. NO
-- Extract documentation translations files... YES
-- Translations will be compiled.. NO
-- Handbooks will be compiled. YES
-- Tests code will be compiled YES
-- Found KF5: success (found version "5.23.0") found components:  DocTools 
-- Found KF5: success (found suitable version "5.23.0", minimum required is
"5.1.0") found components:  DocTools 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/gilles/Devel/5.x/build
Now run make in /home/gilles/Devel/5.x/build.

[gilles@localhost 5.x]$ 
[gilles@localhost doc]$ make 
Scanning dependencies of target doc-digikam-digikam-index-cache-bz2
[ 33%] Generating index.cache.bz2
[ 33%] Built target doc-digikam-digikam-index-cache-bz2
Scanning dependencies of target doc-digikam-showfoto-index-cache-bz2
[ 66%] Generating index.cache.bz2
[ 66%] Built target doc-digikam-showfoto-index-cache-bz2
Scanning dependencies of target doc-kipi-plugins-index-cache-bz2
[100%] Generating index.cache.bz2
[100%] Built target doc-kipi-plugins-index-cache-bz2

[gilles@localhost doc]$ 
[gilles@localhost doc-translated]$ make
Scanning dependencies of target
doc-translated-digikam-it-showfoto-index-cache-bz2
[ 16%] Generating showfoto/index.cache.bz2
[ 16%] Built target doc-translated-digikam-it-showfoto-index-cache-bz2
Scanning dependencies of target
doc-translated-digikam-nl-showfoto-index-cache-bz2
[ 33%] Generating showfoto/index.cache.bz2
[ 33%] Built target doc-translated-digikam-nl-showfoto-index-cache-bz2
Scanning dependencies of target
doc-translated-digikam-pt-showfoto-index-cache-bz2
[ 50%] Generating showfoto/index.cache.bz2
[ 50%] Built target doc-translated-digikam-pt-showfoto-index-cache-bz2
Scanning dependencies of target
doc-translated-digikam-pt-BR-showfoto-index-cache-bz2
[ 66%] Generating showfoto/index.cache.bz2
I/O warning : failed to load external entity
"/usr/share/kf5/kdoctools/customization/xsl/pt-BR.xml"
No "pt_br" localization of "footer-doc-comment" exists; using "en".
No "pt_br" localization of "footer-doc-feedback" exists; using "en".
No "pt_br" localization of "footer-doc-teamname" exists; using "en".
No "pt_br" localization of "footer-doc-comment" exists; using "en".
No "pt_br" localization of "footer-doc-feedback" exists; using "en".
No "pt_br" localization of "footer-doc-teamname" exists; using "en".
No "pt_br" localization of "footer-doc-comment" exists; using "en".
No "pt_br" localization of "footer-doc-feedback" exists; using "en".
No "pt_br" 

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #15 from caulier.gil...@gmail.com ---
You has right, dir tree in doc-translated is not good.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #14 from Rex Dieter  ---
It's just that currently showfoto translations include references to
../digikam/ like:
warning: failed to load external entity "../digikam/file-formats.docbook"
so either the folder layout has to match that expectation (like the english
docs do in the tarball), or some other better fix needs to happen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #13 from caulier.gil...@gmail.com ---
You want mean that directories tree hierarchy in doc translated is wrong. It's
generated by a ruby script at release time. I take a look

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #12 from Rex Dieter  ---
OK, silly me, comment #5 nailed it, the folder layout is wrong.  tarball
includes:
doc-translated/digikam/digikam/
doc-translated/digikam/showfoto/

and the cmake/buildsystem expects:
doc-translated/digikam//digikam/
doc-translated/digikam/showfoto/

So just a matter of changing layout to match this expectation in the next
release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #11 from caulier.gil...@gmail.com ---
With my previous commit, if doc sub dir is not present and if
DIGIKAMSC_COMPILE_DOC=ON, cmake report :

"At least, one documentation directory is missing. Compilation of documentation
is disabled..."

And doc is not compiled as expected...

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #9 from Rex Dieter  ---
ok, I think I found the cause, this only happens if you build out of src tree,
since showfoto tries to do:
warning: failed to load external entity "../digikam/file-formats.docbook"

which fails to exist in the out-of-src tree doc build dir.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #10 from caulier.gil...@gmail.com ---
Note : Forget the docbook compilation. It's broken in translations. We tried to
package it, but it cannot be compiled. Problem is located in translations. The
English reference handbook compile fine else.

This is why we have dropped handbook from the tarball.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #8 from Rex Dieter  ---
It's not 100% clear to me where/how entity 'doc-file-formats' is supposed to be
set

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #7 from Rex Dieter  ---
Even with this commit (against digikam-5.0.0 tarball sources), I'm still seeing
failures,

All of similar form:

cd
/var/tmp/kdecache-rdieter1/BUILDROOT/digikam-5.0.0/doc-translated/digikam/showfoto/it
&& /usr/bin/meinproc5 --check --cache
/var/tmp/kdecache-rdieter1/BUILDROOT/digikam-5.0.0/x86_64-redhat-linux-gnu/doc-translated/digikam/showfoto/it//index.cache.bz2
index.docbook
warning: failed to load external entity "../digikam/file-formats.docbook"
index.docbook:221: parser error : Failure to process entity doc-file-formats
 
  ^
index.docbook:221: parser error : Entity 'doc-file-formats' not defined
 
  ^
Error: `xmllint --noout` outputted text
doc-translated/digikam/showfoto/it/CMakeFiles/doc-translated-digikam-showfoto-it-index-cache-bz2.dir/build.make:64:
recipe for target 'doc-translated/digikam/showfoto/it/index.cache.bz2' failed
make[2]: *** [doc-translated/digikam/showfoto/it/index.cache.bz2] Error 1

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

Rex Dieter  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/scra
   ||tch/mwiesweg/digikam-sc/26d
   ||56cc7a165e7efce6d22278fbda7
   ||a959b4ede3
 Resolution|--- |FIXED
   Version Fixed In||5.1.0

--- Comment #6 from caulier.gil...@gmail.com ---
Git commit 26d56cc7a165e7efce6d22278fbda7a959b4ede3 by Gilles Caulier.
Committed on 10/07/2016 at 12:44.
Pushed by cgilles into branch 'master'.

check if documentation directories are prsent before to try to compile doc plus
translations
FIXED-IN: 5.1.0

M  +5-3CMakeLists.txt

http://commits.kde.org/scratch/mwiesweg/digikam-sc/26d56cc7a165e7efce6d22278fbda7a959b4ede3

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||k...@nicolaslecureuil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Burkhard Lueck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

Burkhard Lueck  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||lu...@hube-lueck.de

--- Comment #5 from Burkhard Lueck  ---
ca builds fine in kde svn.

2 obvious reasons for this error:

1) language ca 
docs/extragear-graphics/digikam/* missing in tarball

2) all languages
   folder layout in svn 
  [lang]/digikam/*
/showfoto/*
  folder layout in tarball
  digikam/[lang]/*
  showfoto/[lang]/*

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|showfoto|Documentation

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Steven Robbins via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

--- Comment #4 from Steven Robbins  ---
Yes, that is correct.  The error happens for all languages in the showfoto
docs.  Digikam docs build OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 365135] Digikam 5 fails to build with DIGIKAMSC_COMPILE_DOC=on

[Steven Robbins via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365135

Steven Robbins  changed:

   What|Removed |Added

Version|unspecified |5.0.0
Product|i18n|digikam
  Component|ca  |showfoto

-- 
You are receiving this mail because:
You are watching all bug changes.