[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=381028

Elvis Angelaccio  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/fil |https://cgit.kde.org/fileli
   |elight/4f8d281aad8e8390fb8e |ght.git/commit/?id=c353bb21
   |6044da6a8bb0abb0195c|f2b5d56692ddafb673a66a5f49b
   ||b272c

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=381028

Elvis Angelaccio  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/fil
   ||elight/4f8d281aad8e8390fb8e
   ||6044da6a8bb0abb0195c
 CC||elvis.angelac...@kde.org
   Version Fixed In||17.12.3

--- Comment #6 from Elvis Angelaccio  ---
Should be fixed by
https://commits.kde.org/filelight/4f8d281aad8e8390fb8e6044da6a8bb0abb0195c

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=381028

--- Comment #5 from Harald Sitter  ---
Seems to me that this commit is in master as well? Plus the commit is about the
exclusion list (i.e. the blacklist of paths not to search), so I'd assume the
bug at hand is simply a different incarnation of fileight's terribly
inconsistent trailing slash handling.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=381028

Christoph Feck  changed:

   What|Removed |Added

 CC||sit...@kde.org

--- Comment #4 from Christoph Feck  ---
The current stable branch includes
https://cgit.kde.org/filelight.git/commit/src?h=Applications/17.04=b06ec65e0c79d8eea8e44d4367364fd572c3dd19
which might have fixed the issue, but the commits in master might miss that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381028

as...@openmailbox.org changed:

   What|Removed |Added

 CC||as...@openmailbox.org

--- Comment #3 from as...@openmailbox.org ---
Created attachment 106142
  --> https://bugs.kde.org/attachment.cgi?id=106142=edit
Patch which adds the separator

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381028

--- Comment #2 from as...@openmailbox.org ---
I just build the current master from source
f83358667ac611f8c8a2cd41097442dce1d5c711
And still able to produce the bug.

I don't see any related commit which could have fixed it nether.

I believe it's due to
https://cgit.kde.org/filelight.git/tree/src/localLister.cpp?id=f83358667ac611f8c8a2cd41097442dce1d5c711#n215

Where `cwd->append(folder, new_dirname);` should instead be
`cwd->append(folder,  new_dirname + '/');` like the line below.

Changing it as such fixed the bug for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 381028] Missing path separator when backing up from scanned directory

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=381028

Burkhard Lueck  changed:

   What|Removed |Added

 CC||lu...@hube-lueck.de

--- Comment #1 from Burkhard Lueck  ---
Ubuntu 16.10
$ filelight --version
filelight 1.21

filelight master build from sources
KDE Frameworks 5.35.0
Qt 5.7.0 (built against 5.7.0)

I can not reproduce this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.