[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash when any trashinfo files have relative paths
https://bugs.kde.org/show_bug.cgi?id=486697 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Summary|kioworker crashes on|kioworker crashes on |opening Dolphin or moving |opening Dolphin or moving |items to Trash |items to Trash when any ||trashinfo files have ||relative paths Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #13 from Nate Graham --- Hmm, you would think so, but after reading over the XDG trash spec again(https://specifications.freedesktop.org/trash-spec/trashspec-latest.html): I ran across the following: > The key “Path” contains the original location of the file/directory, as > either an absolute > pathname (starting with the slash character “/”) or a relative pathname > (starting with > any other character). A relative pathname is to be from the directory in > which the > trash directory resides (for example, from $XDG_DATA_HOME for the “home > trash” directory); > it MUST not include a “..” directory, and for files not “under” that > directory, absolute > pathnames must be used. The system SHOULD support absolute pathnames only in > the “home > trash” directory, not in the directories under $topdir. So relative pathnames are supported by the spec. Maybe the assert in our code is wrong, or maybe something changed in the universe surrounding it to make it start producing invalid results. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697
--- Comment #12 from main.zone4...@fastmail.com ---
I found the cause of the crash after bisecting the .local/share/Trash
directory.
The root cause of the problem are the files in the ./Trash/info directory.
There are many files like this:
```
[Trash Info]
Path=Anki2/addons21/291119185
DeletionDate=2024-04-26T00:50:13
```
The Path property is not an absolute path, hence "info.origPath[0] ==
QLatin1Char('/')" failed.
I'm pretty sure these files were deleted from within Anki (Flatpak).
I wonder if Anki used the wrong API?
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 --- Comment #11 from main.zone4...@fastmail.com --- Crash completely resolved after manually deleting everything in the .local/share/Trash folder. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 --- Comment #10 from main.zone4...@fastmail.com --- Hi Nate, I’ve also checked the files in .local/share/Trash/info, here’s a few examples: │ File: Screenshot_20240418_233817.png.trashinfo 1 │ [Trash Info] 2 │ Path=/home/xxx/Downloads/Screenshot_20240418_233817.p │ ng 3 │ DeletionDate=2024-05-06T17:29:56 ───┬─── │ File: Taylor.trashinfo ───┼─── 1 │ [Trash Info] 2 │ Path=/home/xxx/Desktop/Taylor 3 │ DeletionDate=2024-05-07T15:52:03 I don’t see any property called “origPath”. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 --- Comment #9 from main.zone4...@fastmail.com --- │ File: .config/ktrashrc 1 │ [/home/xxx/.local/share/Trash] 2 │ Days=7 3 │ LimitReachedAction=0 4 │ Percent=2 5 │ UseSizeLimit=true 6 │ UseTimeLimit=true │ File: .config/trashrc 1 │ [NetworkShares] 2 │ NextID=4 3 │ smb://192.168.1.72/books:/home/xxx/books=1 4 │ smb://192.168.1.72/downloads:/home/xxx/server_downloads=0 5 │ smb://192.168.1.72/media:/home/xxx/media=3 6 │ smb://192.168.1.72/media:/home/xxx/server=2 7 │ 8 │ [Status] 9 │ Empty=false -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 Nate Graham changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #8 from Nate Graham --- Can you please paste the output of running `cat ~/.config/*trashrc` in a terminal window? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 --- Comment #7 from Nate Graham --- And it's an assert and you hit it because Neon builds with asserts on for user builds. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 Nate Graham changed: What|Removed |Added Severity|major |crash -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697
--- Comment #6 from Nate Graham ---
#15 0x76e592cc2ac2 in qt_assert (assertion=assertion@entry=0x76e58e4a64d0
"info.origPath[0] == QLatin1Char('/')", file=file@entry=0x76e58e4a6478
"./src/kioworkers/trash/trashimpl.cpp", line=line@entry=782) at
./src/corelib/global/qassert.cpp:68
Perhaps "info.origPath" is empty, such that there is no character at index 0.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697
Nate Graham changed:
What|Removed |Added
Resolution|BACKTRACE |---
Status|NEEDSINFO |REPORTED
--- Comment #5 from Nate Graham ---
Thanks, that's helpful.
#0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=130728306881152)
at ./nptl/pthread_kill.c:44
#1 __pthread_kill_internal (signo=6, threadid=130728306881152) at
./nptl/pthread_kill.c:78
#2 __GI___pthread_kill (threadid=130728306881152, signo=signo@entry=6) at
./nptl/pthread_kill.c:89
#3 0x76e592442476 in __GI_raise (sig=6) at ../sysdeps/posix/raise.c:26
#4 0x76e592deb48e in KCrash::defaultCrashHandler (sig=6) at
./src/kcrash.cpp:593
#5
#6 __pthread_kill_implementation (no_tid=0, signo=6, threadid=130728306881152)
at ./nptl/pthread_kill.c:44
#7 __pthread_kill_internal (signo=6, threadid=130728306881152) at
./nptl/pthread_kill.c:78
#8 __GI___pthread_kill (threadid=130728306881152, signo=signo@entry=6) at
./nptl/pthread_kill.c:89
#9 0x76e592442476 in __GI_raise (sig=sig@entry=6) at
../sysdeps/posix/raise.c:26
#10 0x76e5924287f3 in __GI_abort () at ./stdlib/abort.c:79
#11 0x76e592cfdb6e in qAbort () at ./src/corelib/global/qglobal.cpp:161
#12 0x76e592cf820a in qt_message_fatal (message=..., context=...)
at ./src/corelib/global/qlogging.cpp:2025
#13 qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef
__va_list_tag __va_list_tag *) (msgType=msgType@entry=QtFatalMsg, context=...,
msg=, ap=ap@entry=0x7fff8bcf3e40) at
./src/corelib/global/qlogging.cpp:374
#14 0x76e592cfe511 in QMessageLogger::fatal (this=,
msg=) at ./src/corelib/global/qlogging.cpp:889
#15 0x76e592cc2ac2 in qt_assert (assertion=assertion@entry=0x76e58e4a64d0
"info.origPath[0] == QLatin1Char('/')", file=file@entry=0x76e58e4a6478
"./src/kioworkers/trash/trashimpl.cpp", line=line@entry=782) at
./src/corelib/global/qassert.cpp:68
#16 0x76e58e48eb13 in TrashImpl::readInfoFile (trashId=0, info=...,
infoPath=..., this=0x7fff8bcf47c0) at ./src/kioworkers/trash/trashimpl.cpp:782
#17 TrashImpl::infoForFile (this=0x7fff8bcf47c0, trashId=0, fileId=...,
info=...) at ./src/kioworkers/trash/trashimpl.cpp:735
#18 0x76e58e4932f8 in TrashImpl::list (this=0x7fff8bcf47c0) at
./src/kioworkers/trash/trashimpl.cpp:715
#19 0x76e58e494ee6 in TrashProtocol::listRoot (this=0x7fff8bcf47a0) at
./src/kioworkers/trash/kio_trash.cpp:506
#20 TrashProtocol::listDir (this=0x7fff8bcf47a0, url=...) at
./src/kioworkers/trash/kio_trash.cpp:403
#21 0x76e592e96748 in KIO::WorkerSlaveBaseBridge::listDir
(this=0x620fcde81050, url=...) at ./src/core/workerbase_p.h:121
#22 0x76e592e93616 in KIO::SlaveBase::dispatch (this=0x620fcde81050,
command=71, data=...) at ./src/core/slavebase.cpp:1229
#23 0x76e592f4666a in KIO::SlaveBase::dispatchLoop() [clone .constprop.0]
(this=) at ./src/core/slavebase.cpp:350
#24 0x76e592e90b3d in KIO::WorkerBase::dispatchLoop
(this=this@entry=0x7fff8bcf47b0) at ./src/core/workerbase.cpp:27
#25 0x76e58e492ae9 in kdemain (argc=, argc@entry=4,
argv=) at ./src/kioworkers/trash/kio_trash.cpp:48
#26 0x620fcc5be5a0 in main (argc=5, argv=0x7fff8bcf4b38) at
/usr/include/x86_64-linux-gnu/qt6/QtCore/qvarlengtharray.h:84
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 --- Comment #4 from main.zone4...@fastmail.com --- Created attachment 169288 --> https://bugs.kde.org/attachment.cgi?id=169288=edit kio coredump -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 486697] kioworker crashes on opening Dolphin or moving items to Trash
https://bugs.kde.org/show_bug.cgi?id=486697 Nate Graham changed: What|Removed |Added Status|REPORTED|NEEDSINFO Version|unspecified |6.1.0 Resolution|--- |BACKTRACE CC||kdelibs-b...@kde.org, ||n...@kde.org Product|kde |frameworks-kio Component|general |Trash Assignee|unassigned-b...@kde.org |kio-bugs-n...@kde.org --- Comment #3 from Nate Graham --- You're right, it does look trash-related. Unfortunately I can't reproduce the crash myself on current git master, and the backtrace is incomplete and missing debug symbols for the following lines that we need to figure out exactly what's going wrong: #13 0x772d9d0f9b13 in ?? () from /usr/lib/x86_64-linux-gnu/qt6/plugins/kf6/kio/kio_trash.so #14 0x772d9d0fe2f8 in ?? () from /usr/lib/x86_64-linux-gnu/qt6/plugins/kf6/kio/kio_trash.so #15 0x772d9d0ffee6 in ?? () from /usr/lib/x86_64-linux-gnu/qt6/plugins/kf6/kio/kio_trash.so #16 0x772da1b02748 in ?? () from /lib/x86_64-linux-gnu/libKF6KIOCore.so.6 #17 0x772da1aff616 in ?? () from /lib/x86_64-linux-gnu/libKF6KIOCore.so.6 #18 0x772da1bb266a in ?? () from /lib/x86_64-linux-gnu/libKF6KIOCore.so.6 #19 0x772d9d0fdae9 in kdemain () from /usr/lib/x86_64-linux-gnu/qt6/plugins/kf6/kio/kio_trash.so #20 0x5d048b9b15a0 in ?? () Could you please install debug symbols for KIO and attach a new symbolicated backtrace generated by using `coredumpctl gdb` in a terminal window? See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_using_coredumpctl for details about how to do this. Thanks again! -- You are receiving this mail because: You are watching all bug changes.
