[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=355493

Valeriy Malov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/gwe
   ||nview/b55420b2ac3dc72ebffdb
   ||89dbb9e662d64950ecd

--- Comment #6 from Valeriy Malov  ---
Git commit b55420b2ac3dc72ebffdb89dbb9e662d64950ecd by Valeriy Malov.
Committed on 09/11/2017 at 14:52.
Pushed by valeriymalov into branch 'master'.

Try to keep ContextManager in sync with viewed files in MainWindow

Summary:
ContextManager now is responsible for switching to the directory
containing requested URL and selecting it. However, if it is not
possible, URL is still kept (in case of remote URLs), while selection is
cleared (to avoid dragging in local files)

MainWindow now relies on ContextManager's selection and/or
selectedFileItemList instead of ThumbnailView selection. If selection &
currentUrl are empty, refuse to open View tab, otherwise display
selected items.

This should prevent (reduce?) the amount of mismatches between which
files user sees, and which files are being operated upon
(e.g. by FileOpsContextManagerItem)
Related: bug 275807, bug 326190, bug 306835

Test Plan:
Tried playing around to make sure it doesn't break any old behaviour
Tried deleting all image files while in View mode, to make sure we back out
when we run out of images
Tried opening an http url and check that operations apply to it unless we
select something in browse tab
And then remote image should be unloaded from the View tab since our actions
will now affect user-selected items

Tests pass but they don't seem to cover this?

Reviewers: #kde_applications, gateau, rkflx

Reviewed By: gateau, rkflx

Subscribers: ngraham, rkflx, gateau

Differential Revision: https://phabricator.kde.org/D8196

M  +1-11   app/fileopscontextmanageritem.cpp
M  +27   -70   app/mainwindow.cpp
M  +25   -2lib/contextmanager.cpp
M  +1-0lib/contextmanager.h

https://commits.kde.org/gwenview/b55420b2ac3dc72ebffdb89dbb9e662d64950ecd

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=355493

--- Comment #5 from Nate Graham  ---
Please feel free to post a patch for review at https://phabricator.kde.org/.
Even if it's imperfect, you may get some good ideas and suggestions for
improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=355493

Valeriy Malov  changed:

   What|Removed |Added

 CC||jazzv...@gmail.com

--- Comment #4 from Valeriy Malov  ---
This could be probably fixed by resetting the mViewMainPage and switching back
to "Browse" tab when Gwenview tries to open an invalid selection

However, Gwenview also opens remote files, and does that in a manner that
interferes with normal operation, so resetting the view breaks it

Here's a couple of interesting exercises:

First
- Open thumbnail view, select some folder or file
- Open remote file (e.g. via http)
- Tap "Delete"
- Selected files or folders are now gone

Second
- Open a local file via thumbnail view
- Open remote URL
- Click on the "Browse" button on the toolbar
- Click on the local file you had opened before
- You still have the remote image opened in the View tab

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=355493

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=355493

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #3 from Nate Graham  ---
Wow, this is really bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=355493

Nate Graham  changed:

   What|Removed |Added

 CC||efelthau...@gmail.com

--- Comment #2 from Nate Graham  ---
*** Bug 363849 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355493

xunilh...@8chan.co changed:

   What|Removed |Added

 CC||xunilh...@8chan.co

--- Comment #1 from xunilh...@8chan.co ---
I can confirm this bug, also please see:
https://bugs.kde.org/show_bug.cgi?id=363849

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 355493] Gwenview Caused Severe Data Loss When Performing Delete File Operation

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355493

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

-- 
You are receiving this mail because:
You are watching all bug changes.