[gwenview] [Bug 359736] Crash when reloading SVG image

[Peter Mühlenpfordt]

https://bugs.kde.org/show_bug.cgi?id=359736

Peter Mühlenpfordt  changed:

   What|Removed |Added

   Version Fixed In||18.04.1
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/gwe
   ||nview/f11f5a43b4a65a1a9f289
   ||3dc577b94b7af94a37b

--- Comment #9 from Peter Mühlenpfordt  ---
Git commit f11f5a43b4a65a1a9f2893dc577b94b7af94a37b by Peter Mühlenpfordt.
Committed on 15/04/2018 at 07:50.
Pushed by muhlenpfordt into branch 'Applications/18.04'.

Fix reloading of SVG images

Summary:
If an SVG image is reloaded ({key F5} or {nav File > Reload}) the
`QSvgRenderer` is not updated after loading and Gwenview crashes
when trying to zoom. If the SVG file is changed outside Gwenview
while it is viewed and then reloaded it's not updated.
This is caused by a missing connection to the `loaded()` signal
and calling `SvgImageView::finishLoadFromDocument()` to setup the
new renderer.
FIXED-IN: 18.04.1

Test Plan:
1. Open SVG image in View Mode
2. Press {key F5} to reload
3. Zoom by mouse scroll or moving the slider
4. Gwenview should not crash

1. Open SVG image in View Mode
2. Overwrite viewed file with another SVG outside Gwenview
3. Press {key F5} to reload
4. New image should display

Reviewers: #gwenview, rkflx

Reviewed By: #gwenview, rkflx

Subscribers: rkflx, huoni

Differential Revision: https://phabricator.kde.org/D12187

M  +6-4lib/documentview/svgviewadapter.cpp

https://commits.kde.org/gwenview/f11f5a43b4a65a1a9f2893dc577b94b7af94a37b

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Huon]

https://bugs.kde.org/show_bug.cgi?id=359736

Huon  changed:

   What|Removed |Added

 CC||h...@plonq.org

--- Comment #8 from Huon  ---
This crash doesn't happen as soon as you reload an SVG, it only crashes if you
try to change the zoom afterwards. For example if you hit F5 then navigate to
Browse view, there is no crash. But hit F5 then click the zoom slider - crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Anton Yablokov]

https://bugs.kde.org/show_bug.cgi?id=359736

Anton Yablokov  changed:

   What|Removed |Added

 CC||stsav...@mail.ru

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Anton Yablokov]

https://bugs.kde.org/show_bug.cgi?id=359736

--- Comment #7 from Anton Yablokov  ---
Created attachment 106148
  --> https://bugs.kde.org/attachment.cgi?id=106148=edit
New crash information added by DrKonqi

gwenview (4.14.0 pre) on KDE Platform 4.14.2 using Qt 4.8.6

- What I was doing when the application crashed:

I changed an opened SVG file externally and then hit Reload in the menu.

-- Backtrace (Reduced):
#6  QSvgTinyDocument::draw (this=0x21, p=p@entry=0x7ffeb5c217b0, bounds=...) at
qsvgtinydocument.cpp:232
#7  0x7f0f3ec87c75 in QSvgRenderer::render (this=,
painter=painter@entry=0x7ffeb5c217b0, bounds=...) at qsvgrenderer.cpp:414
#8  0x7f0f3ec8925e in QGraphicsSvgItem::paint (this=0xfb60d0,
painter=0x7ffeb5c217b0, option=0x1087d68, widget=) at
qgraphicssvgitem.cpp:254
#9  0x7f0f4222d882 in _q_paintItem (item=item@entry=0xfb60e0,
painter=painter@entry=0x7ffeb5c217b0, option=option@entry=0x1087d68,
widget=widget@entry=0x1087410, useWindowOpacity=,
painterStateProtection=painterStateProtection@entry=true) at
graphicsview/qgraphicsscene.cpp:4305
#10 0x7f0f42241c89 in QGraphicsScenePrivate::drawItemHelper
(this=0x1087b40, item=, painter=0x7ffeb5c217b0,
option=0x1087d68, widget=0x1087410, painterStateProtection=) at
graphicsview/qgraphicsscene.cpp:4567

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Martin Walch]

https://bugs.kde.org/show_bug.cgi?id=359736

Martin Walch  changed:

   What|Removed |Added

 CC||walch.mar...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=359736

Christoph Feck  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
Version|unspecified |16.12.0

--- Comment #4 from Christoph Feck  ---
Reproducible also with Qt 5.7.1.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=359736

Christoph Feck  changed:

   What|Removed |Added

 CC||kheyfbo...@gmail.com

--- Comment #6 from Christoph Feck  ---
*** Bug 330198 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=359736

Christoph Feck  changed:

   What|Removed |Added

 CC||lukas.ka...@centrum.cz

--- Comment #5 from Christoph Feck  ---
*** Bug 345272 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Lukasz]

https://bugs.kde.org/show_bug.cgi?id=359736

--- Comment #3 from Lukasz  ---
Created attachment 103173
  --> https://bugs.kde.org/attachment.cgi?id=103173=edit
Sample file that crashes gwenview

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[Lukasz]

https://bugs.kde.org/show_bug.cgi?id=359736

Lukasz  changed:

   What|Removed |Added

 CC||dolo...@outlook.com

--- Comment #2 from Lukasz  ---
Application: Gwenview (gwenview), signal: Segmentation fault
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7fe02c2da8c0 (LWP 9509))]

Thread 7 (Thread 0x7fe001c87700 (LWP 9516)):
#0  0x7fe020c1010f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fe00764645b in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#2  0x7fe0076462b7 in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#3  0x7fe020c0a454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fe026c2c7df in clone () from /usr/lib/libc.so.6

Thread 6 (Thread 0x7fe002488700 (LWP 9515)):
#0  0x7fe020c1010f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fe00764645b in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#2  0x7fe0076462b7 in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#3  0x7fe020c0a454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fe026c2c7df in clone () from /usr/lib/libc.so.6

Thread 5 (Thread 0x7fe002c89700 (LWP 9514)):
#0  0x7fe020c1010f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fe00764645b in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#2  0x7fe0076462b7 in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#3  0x7fe020c0a454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fe026c2c7df in clone () from /usr/lib/libc.so.6

Thread 4 (Thread 0x7fe00348a700 (LWP 9513)):
#0  0x7fe020c1010f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fe00764645b in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#2  0x7fe0076462b7 in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#3  0x7fe020c0a454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fe026c2c7df in clone () from /usr/lib/libc.so.6

Thread 3 (Thread 0x7fe003e90700 (LWP 9512)):
#0  0x7fe020c1010f in pthread_cond_wait@@GLIBC_2.3.2 () from
/usr/lib/libpthread.so.0
#1  0x7fe00764645b in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#2  0x7fe0076462b7 in ?? () from /usr/lib/xorg/modules/dri/radeonsi_dri.so
#3  0x7fe020c0a454 in start_thread () from /usr/lib/libpthread.so.0
#4  0x7fe026c2c7df in clone () from /usr/lib/libc.so.6

Thread 2 (Thread 0x7fe00ec3e700 (LWP 9511)):
#0  0x7fe026c2348d in poll () from /usr/lib/libc.so.6
#1  0x7fe01f5bc786 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7fe01f5bc89c in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#3  0x7fe0275462db in QEventDispatcherGlib::processEvents
(this=0x7fe0080008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x7fe0274efd3a in QEventLoop::exec (this=this@entry=0x7fe00ec3dcd0,
flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5  0x7fe027312063 in QThread::exec (this=this@entry=0x7fe026b42d20
<(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>) at
thread/qthread.cpp:507
#6  0x7fe0268cede5 in QDBusConnectionManager::run (this=0x7fe026b42d20
<(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>) at
qdbusconnection.cpp:178
#7  0x7fe027316cf8 in QThreadPrivate::start (arg=0x7fe026b42d20 <(anonymous
namespace)::Q_QGS__q_manager::innerFunction()::holder>) at
thread/qthread_unix.cpp:368
#8  0x7fe020c0a454 in start_thread () from /usr/lib/libpthread.so.0
#9  0x7fe026c2c7df in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7fe02c2da8c0 (LWP 9509)):
[KCrash Handler]
#6  0x7fe0249d0bf7 in QSvgTinyDocument::draw(QPainter*, QRectF const&) ()
from /usr/lib/libQt5Svg.so.5
#7  0x7fe0249d33de in QGraphicsSvgItem::paint(QPainter*,
QStyleOptionGraphicsItem const*, QWidget*) () from /usr/lib/libQt5Svg.so.5
#8  0x7fe028edeff2 in _q_paintItem (item=item@entry=0x2807640,
painter=painter@entry=0x7ffc3904e3a0, option=option@entry=0x26953b8,
widget=widget@entry=0x270ec20, useWindowOpacity=,
painterStateProtection=painterStateProtection@entry=true) at
graphicsview/qgraphicsscene.cpp:4280
#9  0x7fe028eef214 in QGraphicsScenePrivate::drawItemHelper
(this=this@entry=0x26951a0, item=item@entry=0x2807640,
painter=painter@entry=0x7ffc3904e3a0, option=option@entry=0x26953b8,
widget=widget@entry=0x270ec20, painterStateProtection=) at
graphicsview/qgraphicsscene.cpp:4542
#10 0x7fe028ef10f4 in QGraphicsScenePrivate::draw
(this=this@entry=0x26951a0, item=item@entry=0x2807640,
painter=painter@entry=0x7ffc3904e3a0, viewTransform=,
transformPtr=transformPtr@entry=0x29e67f0, exposedRegion=,
widget=, opacity=opacity@entry=1, effectTransform=, wasDirtyParentSceneTransform=, drawItem=)
at 

[gwenview] [Bug 359736] Crash when reloading SVG image

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359736

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=330198

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[sedrubal via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359736

--- Comment #1 from sedrubal  ---
Created attachment 97930
  --> https://bugs.kde.org/attachment.cgi?id=97930=edit
New crash information added by DrKonqi

gwenview (4.14.0 pre) on KDE Platform 4.14.17 using Qt 4.8.7

- What I was doing when the application crashed:

I changed the displayed svg and moved my cursor over gwenview.

-- Backtrace (Reduced):
#6  0x7f577ee77267 in QSvgTinyDocument::draw(QPainter*, QRectF const&) ()
at /lib64/libQtSvg.so.4
#7  0x7f577ee7a03e in QGraphicsSvgItem::paint(QPainter*,
QStyleOptionGraphicsItem const*, QWidget*) () at /lib64/libQtSvg.so.4
#10 0x7f577f8c38a6 in QGraphicsScenePrivate::drawItemHelper(QGraphicsItem*,
QPainter*, QStyleOptionGraphicsItem const*, QWidget*, bool) () at
/lib64/libQtGui.so.4
#11 0x7f577f8c459c in QGraphicsScenePrivate::draw(QGraphicsItem*,
QPainter*, QTransform const*, QTransform const*, QRegion*, QWidget*, double,
QTransform const*, bool, bool) () at /lib64/libQtGui.so.4
#12 0x7f577f8c5121 in
QGraphicsScenePrivate::drawSubtreeRecursive(QGraphicsItem*, QPainter*,
QTransform const*, QRegion*, QWidget*, double, QTransform const*) () at
/lib64/libQtGui.so.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 359736] Crash when reloading SVG image

[sedrubal via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359736

sedrubal  changed:

   What|Removed |Added

 CC||sebastian.end...@online.de

-- 
You are receiving this mail because:
You are watching all bug changes.