[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=382391

Christoph Feck  changed:

   What|Removed |Added

  Latest Commit||https://commist.kde.org/kca
   ||lc/ad3596fdab39bac758dbc5bc
   ||07bb985db3054896
   Version Fixed In||19.04.0
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Christoph Feck  ---
Fixed with https://phabricator.kde.org/D10555

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[Julian Schraner]

https://bugs.kde.org/show_bug.cgi?id=382391

Julian Schraner  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
 CC||m...@xyquadrat.ch

--- Comment #6 from Julian Schraner  ---
I've seen that the revision has been stale for a while, @martonmiklos: feel
free to ping Christoph again now that you have fixed the inline issues :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[martonmiklos]

https://bugs.kde.org/show_bug.cgi?id=382391

--- Comment #5 from martonmiklos  ---
The attached patch only works for locale which decimal separator is , and the
thousand separator is neither . or , (most commonly space). With this locale it
will interpret the . as a decimal point too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[Evan Teran]

https://bugs.kde.org/show_bug.cgi?id=382391

--- Comment #4 from Evan Teran  ---
It has been a while since I was terribly active with kcalc. Fortunately,
Christopher has been awesome about handling the occasiobal issue that crops
up (thanks!).

I've always had mixed feeling about how to handle the separator issue. How
shall we parse 1,234?

1234?

Or

1 + (234/1000)

You solution seems mostly reasonable, but we should be careful about the
corner cases if any come up.

Thanks for looking into this issue!

On Thu, Feb 15, 2018, 3:19 PM martonmiklos  wrote:

> https://bugs.kde.org/show_bug.cgi?id=382391
>
> --- Comment #3 from martonmiklos  ---
> Thanks Cristoph for the hint, I have created the D10555 phabricator issue.
> I have no idea who should I add as reviewer. Evan Teran no longer seems to
> be
> active here and I have not been able to find him in the reviewer list.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[martonmiklos]

https://bugs.kde.org/show_bug.cgi?id=382391

--- Comment #3 from martonmiklos  ---
Thanks Cristoph for the hint, I have created the D10555 phabricator issue. 
I have no idea who should I add as reviewer. Evan Teran no longer seems to be
active here and I have not been able to find him in the reviewer list.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=382391

--- Comment #2 from Christoph Feck  ---
Marton, the idea for the patch is good, but we shouldn't hardcode 'Nbsp' as the
only allowed group separator. I suggest to just check that it is neither '.'
nor ','. Would you like to upload an updated patch to
https://phabricator.kde.org/differential/diff/create/ so that we can review it?

Julien, this ticket is for the Paste action, and not related to Numpad input.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[Julien F]

https://bugs.kde.org/show_bug.cgi?id=382391

Julien F  changed:

   What|Removed |Added

 CC||k...@danslecosmos.org

--- Comment #1 from Julien F  ---
In the French locale, the expected behaviour is the same as the proposed patch.
I think most users there are expecting the key "." on the numpad to be
interpreted as ",". The current behaviour is very frustrating.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 382391] Accept both decimal separators (comma and dot) from clipboard with locales where it is straightforward

[martonmiklos]

https://bugs.kde.org/show_bug.cgi?id=382391

martonmiklos  changed:

   What|Removed |Added

Summary|Apply both decimal  |Accept both decimal
   |separators (comma and dot)  |separators (comma and dot)
   |with locales where it is|from clipboard with locales
   |straightforward |where it is straightforward

-- 
You are receiving this mail because:
You are watching all bug changes.