[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0 (due to "remove null pointer checks for 'this' optimization") [KDevelop::AbstractType::indexed]

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

 CC||sylko.olzsc...@gmail.com

--- Comment #29 from Kevin Funk  ---
*** Bug 365752 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0 (due to "remove null pointer checks for 'this' optimization") [KDevelop::AbstractType::indexed]

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

 CC||sla...@lach.art.pl

--- Comment #28 from Kevin Funk  ---
*** Bug 364819 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0 (due to "remove null pointer checks for 'this' optimization") [KDevelop::AbstractType::indexed]

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

 CC||robert.styles.forsyth@gmail
   ||.com

--- Comment #27 from Kevin Funk  ---
*** Bug 364697 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0 (due to "remove null pointer checks for 'this' optimization") [KDevelop::AbstractType::indexed]

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

Summary|KDevelop crashes during |KDevelop crashes during
   |parsing a project when it   |parsing a project when it
   |is compiled with GCC 6.0|is compiled with GCC 6.0
   ||(due to "remove null
   ||pointer checks for 'this'
   ||optimization")
   ||[KDevelop::AbstractType::in
   ||dexed]

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #25 from Kevin Funk  ---
Did you also try kdev-php & kdev-python?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #24 from Kevin Funk  ---
@Jan: Can you confirm all issues have been resolved? Does KDevelop work for
you?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

 CC||br...@ioda-net.ch

--- Comment #23 from Kevin Funk  ---
*** Bug 366433 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

robert.be...@gmail.com changed:

   What|Removed |Added

 CC||robert.be...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #22 from robert.be...@gmail.com ---
Created attachment 99737
  --> https://bugs.kde.org/attachment.cgi?id=99737=edit
New crash information added by DrKonqi

kdevelop (4.7.3) on KDE Platform 4.14.21 using Qt 4.8.7

KDevelop crashes every time I open it.

-- Backtrace (Reduced):
#6  0x7fae0bd5246c in KDevelop::AbstractType::indexed() const () at
/usr/lib64/libkdevplatformlanguage.so.8
#7  0x7fad52ff0dec in Cpp::ExpressionParser::evaluateType(AST*,
ParseSession*, KDevelop::TopDUContext const*) () at
/usr/lib64/libkdev4cppduchain.so
#8  0x7fad52fb4531 in
TypeBuilder::visitSimpleTypeSpecifier(SimpleTypeSpecifierAST*) () at
/usr/lib64/libkdev4cppduchain.so
#9  0x7fad52cbf236 in DefaultVisitor::visitTypedef(TypedefAST*) () at
/usr/lib64/libkdev4cppparser.so
#10 0x7fad52f80c42 in ContextBuilder::visitTypedef(TypedefAST*) () at
/usr/lib64/libkdev4cppduchain.so

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

dontar...@yahoo.com changed:

   What|Removed |Added

 CC||dontar...@yahoo.com

--- Comment #21 from dontar...@yahoo.com ---
*** Bug 364750 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #20 from Kevin Funk  ---
Nowhere, because it isn't released (yet?).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[fantaz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

fantaz  changed:

   What|Removed |Added

 CC||ski...@riteh.hr

--- Comment #19 from fantaz  ---
Please, 
Where on earth can one install/download version 4.7.4? Don't see it on
http://download.kde.org/stable/kdevelop/, nor it is in opensuse's tumbleweed
repo...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

 CC||aschm...@graphtek.com

--- Comment #18 from Kevin Funk  ---
*** Bug 364028 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Simon Andric via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In|4.7 |4.7.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In||4.7

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Kevin Funk  ---
All issues in kdevplatform/kdevelop resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #13 from Kevin Funk  ---
Git commit ca8d751a20b5d1e7b028af39e78547fc0e9d696b by Kevin Funk.
Committed on 21/03/2016 at 23:39.
Pushed by kfunk into branch '4.7'.

Fix places with undefined behavior

New API: IndexedType::IndexedType(const AbstractType::Ptr& type)

Places where we may call AbstractPtr::indexed with this being a nullptr.

Similar patches probably need to be applied to other language plugins

CCMAIL: kdevelop-de...@kde.org

M  +3-1languages/cpp/cppduchain/cppducontext.h
M  +3-3languages/cpp/cppduchain/declarationbuilder.cpp
M  +1-1languages/cpp/cppduchain/expressionparser.cpp
M  +2-2languages/cpp/cppduchain/name_visitor.cpp
M  +2-2languages/cpp/cppduchain/templatedeclaration.cpp
M  +3-3languages/cpp/cppduchain/typeconversion.cpp
M  +2-2languages/cpp/cppduchain/typeutils.cpp

http://commits.kde.org/kdevelop/ca8d751a20b5d1e7b028af39e78547fc0e9d696b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #12 from Kevin Funk  ---
Git commit 5ea89d672f288fc1233af86548f11388e6076e3d by Kevin Funk.
Committed on 21/03/2016 at 23:37.
Pushed by kfunk into branch '1.7'.

Fix places with undefined behavior

New API: IndexedType::IndexedType(const AbstractType::Ptr& type)

Places where we may call AbstractPtr::indexed with this being a nullptr.

M  +1-1language/duchain/instantiationinformation.cpp
M  +1-1language/duchain/repositories/typerepository.cpp
M  +1-1language/duchain/repositories/typerepository.h
M  +1-1language/duchain/types/abstracttype.cpp
M  +2-2language/duchain/types/arraytype.cpp
M  +2-2language/duchain/types/containertypes.cpp
M  +2-2language/duchain/types/containertypes.h
M  +5-5language/duchain/types/functiontype.cpp
M  +7-0language/duchain/types/indexedtype.cpp
M  +1-3language/duchain/types/indexedtype.h
M  +2-2language/duchain/types/pointertype.cpp
M  +2-2language/duchain/types/referencetype.cpp
M  +2-2language/duchain/types/typealiastype.cpp

http://commits.kde.org/kdevplatform/5ea89d672f288fc1233af86548f11388e6076e3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Jonathan Wakely via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #11 from Jonathan Wakely  ---
(In reply to Kevin Funk from comment #9)
> Alright. I need to test this properly. Uses of AbstractType::indexed seem
> like a can of worms, most of the callers don't check AbstractType*.

Could it be solved with the NullObject pattern? i.e. make abstractType() always
return a valid non-null pointer, returning a pointer to some global,
empty/default/dumb object instead of null. That would mean that
m_baseType->abstractType()->indexed() never dereferences null, and you don't
need to fix every caller.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Jonathan Wakely via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Jonathan Wakely  changed:

   What|Removed |Added

 CC||zi...@kayari.org

--- Comment #10 from Jonathan Wakely  ---
You don't need GCC 6, you should be able to find the null dereferences using
ubsan in GCC 5, and maybe 4.9 too.

But building GCC 6 isn't a big deal. https://gcc.gnu.org/wiki/InstallingGCC

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

   Keywords||junior-jobs
   Target Milestone|--- |5.0.0
   Severity|grave   |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Jan Grulich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #8 from Jan Grulich  ---
Created attachment 98004
  --> https://bugs.kde.org/attachment.cgi?id=98004=edit
KDevelop 5 crash backtrace (#2)

Now I can open a project, but once I move the mouse cursor to some text to
visualize the help, it crashes again. Backtrace attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #7 from Kevin Funk  ---
Git commit 935756dbab00479954d905d8ea4b29e3bd2e5647 by Kevin Funk.
Committed on 21/03/2016 at 10:36.
Pushed by kfunk into branch '1.7'.

Fix -fdelete-null-pointer-checks issues

Backtrace (reduced):
10 0x7fc2221b9e9c in KDevelop::AbstractType::indexed() const
(this=0x0) at
/home/jgrulich/development/projects/kdevplatform/language/duchain/types/abstracttype.cpp:99
11 0x7fc22212f4a6 in
KDevelop::Declaration::setAbstractType(KDevelop::TypePtr)
(this=0x7fc1b40a42a0, type=...) at
/home/jgrulich/development/projects/kdevplatform/language/duchain/declaration.cpp:269
12 0x7fc1f1eb988e in (anonymous
namespace)::Visitor::setDeclType<(CXCursorKind)10>(KDevelop::Declaration*,
KDevelop::AbstractType*) (decl=, type=,
this=) at
/home/jgrulich/development/projects/kdevelop/languages/clang/duchain/builder.cpp:786

M  +1-1language/duchain/declaration.cpp

http://commits.kde.org/kdevplatform/935756dbab00479954d905d8ea4b29e3bd2e5647

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Jan Grulich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #6 from Jan Grulich  ---
Created attachment 98003
  --> https://bugs.kde.org/attachment.cgi?id=98003=edit
KDevelop 5 crash backtrace

The fix above helped to KDevelop 4.7 (at least I managed to open a project
successfully) , but KDevelop 5.0 still crashes. See the attached backtrace.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Jan Grulich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Jan Grulich  changed:

   What|Removed |Added

 CC||jgrul...@redhat.com

--- Comment #2 from Jan Grulich  ---
Created attachment 97959
  --> https://bugs.kde.org/attachment.cgi?id=97959=edit
backtrace

I didn't see any compilation error, it compiles just fine, it crashes later
once I try to open any project. 

Attaching backtrace of the crash with KDevelop 4.7.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

Kevin Funk  changed:

   What|Removed |Added

   Keywords||release_blocker
   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #1 from Kevin Funk  ---
Where are the problems? Do you get compile errors with GCC6 without additional
compiler flags? If yes, please post them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #4 from Kevin Funk  ---
Git commit 513519edb3fa25d39370cee71b4813741994dd20 by Kevin Funk.
Committed on 18/03/2016 at 16:41.
Pushed by kfunk into branch '1.7'.

Fix -fdelete-null-pointer-checks issues

Prepare for upcoming GCC6, which sets this by default

M  +2-3language/duchain/topducontext.cpp

http://commits.kde.org/kdevplatform/513519edb3fa25d39370cee71b4813741994dd20

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Jan Grulich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #3 from Jan Grulich  ---
Created attachment 97960
  --> https://bugs.kde.org/attachment.cgi?id=97960=edit
KDevelop build log

Also attaching build log in hope that may help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 360707] KDevelop crashes during parsing a project when it is compiled with GCC 6.0

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360707

--- Comment #5 from Kevin Funk  ---
Sorry, I don't have GCC6 around + I am reluctant to install it (breaks my Clang
setup here, don't ask).

Please check if this solves the crash for you. I'm not sure the compiler
warnings in KTextEditor (-Waddress) are problematic. Didn't check.

-- 
You are receiving this mail because:
You are watching all bug changes.