[kdevplatform] [Bug 361961] Appearance of differ dialog is not suitable for source code

2016-04-29 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361961

Kevin Funk  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Kevin Funk  ---
Alright, I just noticed we already have a hard dependency on libkomparediff2
(when compiling the patchreview plugin). So we already require it to be there.

Marking this one as invalid then.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdevplatform] [Bug 361961] Appearance of differ dialog is not suitable for source code

2016-04-29 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361961

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #4 from Aleix Pol  ---
I think we should just assume that libkcomparediff is there and drop such
dialog altogether.

It's not something we're maintaining appropriately anyway, since most of us
never see it.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdevplatform] [Bug 361961] Appearance of differ dialog is not suitable for source code

2016-04-29 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361961

Kevin Funk  changed:

   What|Removed |Added

   Priority|NOR |LO

--- Comment #3 from Kevin Funk  ---
Thanks for the confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdevplatform] [Bug 361961] Appearance of differ dialog is not suitable for source code

2016-04-28 Thread Alexander Potashev via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361961

--- Comment #2 from Alexander Potashev  ---
Oops... On the machine where I noticed the poorly formatted diff I had to
disable "patchreview" because I was too lazy to install libkcomparediff2[kf5].

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdevplatform] [Bug 361961] Appearance of differ dialog is not suitable for source code

2016-04-21 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361961

Kevin Funk  changed:

   What|Removed |Added

  Component|git |vcs
 CC||aleix...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.


[kdevplatform] [Bug 361961] Appearance of differ dialog is not suitable for source code

2016-04-21 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361961

Kevin Funk  changed:

   What|Removed |Added

   Keywords||junior-jobs
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Kevin Funk  ---
Confirmed. The patch review plugin usually takes care of displaying the diff
inside the KDevelop main window though.

Can you make sure it is loaded?

At any rate: We need to fix the workflow where it is missing, so keeping this
one open.

-- 
You are receiving this mail because:
You are watching all bug changes.