[kmail2] [Bug 366981] Mailto URL does not allows a body with line breaks

[Bernhard Scheirle via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366981

--- Comment #5 from Bernhard Scheirle  ---
Thanks Montel.

But the `if (!body.isEmpty()) { [...] }` does now nothing: body comes from
values and gets inserted into values (with the same key).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 366981] Mailto URL does not allows a body with line breaks

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366981

Laurent Montel  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/mess
   ||agelib/c5cd3c5129a1b8a33da8
   ||94eaadb79b461e45c3cc
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.3.1

--- Comment #4 from Laurent Montel  ---
Git commit c5cd3c5129a1b8a33da894eaadb79b461e45c3cc by Montel Laurent.
Committed on 21/08/2016 at 07:20.
Pushed by mlaurent into branch 'Applications/16.08'.

Fix Bug 366981 - Mailto URL does not allows a body with line breaks

FIXED-IN: 5.3.1

M  +11   -0messagecore/autotests/stringutiltest.cpp
M  +1-0messagecore/autotests/stringutiltest.h
M  +1-3messagecore/src/utils/stringutil.cpp

http://commits.kde.org/messagelib/c5cd3c5129a1b8a33da894eaadb79b461e45c3cc

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 366981] Mailto URL does not allows a body with line breaks

[Bernhard Scheirle via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366981

Bernhard Scheirle  changed:

   What|Removed |Added

 CC||bernhard+...@scheirle.de

--- Comment #3 from Bernhard Scheirle  ---
I'm also affected by this bug.

I think I found the cause for this, and if so it should be easy to fix.

KMail uses MessageCore::StringUtil::parseMailtoUrl[1] to parse url query
parameters.
In parseMailtoUrl it uses QUrlQuery::queryItems() to get the list of
parameters.
By default queryItems does not decode all "%" elements.[2]

So using QUrlQuery::queryItems(QUrl::FullyDecoded) instead should fix this.

I think the explicit "%0A" to "\n" transformation in Lines 197-202 would than
be obsolete as well. [1]
Especially since mailto urls must have "%0D%0A" and not "%0A" line breaks.  [3]

[1] Line 185:
https://quickgit.kde.org/?p=messagelib.git=blob=41d01b75b9058281ac9f5bdd4e4abea0c34b309a=0c5e64ed193141edd63de7eb01a10e6d353e1856=messagecore%2Fsrc%2Futils%2Fstringutil.cpp
[2] http://doc.qt.io/qt-5/qurl.html#ComponentFormattingOption-enum
[3] RFC2368 Section 5: http://www.ietf.org/rfc/rfc2368.txt

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 366981] Mailto URL does not allows a body with line breaks

[Nicolás Alvarez via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366981

Nicolás Alvarez  changed:

   What|Removed |Added

   Assignee|n...@kde.org|kdepim-b...@kde.org
 CC||nicolas.alva...@gmail.com
  Component|Spam|general
Version|unspecified |5.1.3
  Group|sysadmin|
Product|Spam|kmail2

--- Comment #2 from Nicolás Alvarez  ---
My apologies, I accidentally selected this bug while deleting a lot of spam.
Restoring data...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 366981] Mailto URL does not allows a body with line breaks

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366981

--- Comment #1 from priv...@bernhard-lindner.de ---
An different users reported that the command line works with KMail 4.14.2.

-- 
You are receiving this mail because:
You are watching all bug changes.