[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit|https://commits.kde.org/kwi |https://commits.kde.org/kwi
   |n/a5735e19b99d21d843252dcb1 |n/eec6afe6f5fef80f519c7afb3
   |2a147d122760371 |3e4fd568d74aab0

--- Comment #8 from Martin Gräßlin  ---
Git commit eec6afe6f5fef80f519c7afb33e4fd568d74aab0 by Martin Gräßlin.
Committed on 22/04/2017 at 06:17.
Pushed by graesslin into branch 'master'.

Don't map screenedge approach window if edge is only used for touch

Summary:
Another regression from enabling touch support on X11.
The approach window for pointer input gets unmapped as soon as the mouse
enters the window. This ensures that mouse motion events are not stolen
from other applications. But with the touch events we did not even react
on the enter event if it's not activated for pointer. The result was an
area around the screenedge being blocked for pointer input.

This change only creates and maps the approach window if the edge is
activated for pointer input.

Test Plan:
Activated edges through pointer and touch, reconfigured and tested
motion events

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D5528

M  +15   -1plugins/platforms/x11/standalone/edge.cpp

https://commits.kde.org/kwin/eec6afe6f5fef80f519c7afb33e4fd568d74aab0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

--- Comment #7 from Martin Gräßlin  ---
Next try: https://phabricator.kde.org/D5528

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #6 from Martin Gräßlin  ---
nope, it's not yet sufficient. The screenedges still block events.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/a5735e19b99d21d843252dcb1
   ||2a147d122760371
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Martin Gräßlin  ---
Git commit a5735e19b99d21d843252dcb12a147d122760371 by Martin Gräßlin.
Committed on 20/04/2017 at 15:03.
Pushed by graesslin into branch 'master'.

[platforms/x11] Do not grab touch events

Summary:
Grabbing the touch events seems to cause issues. It seems to also grab
pointer events from touchpad and breaks touch input on other events.

Also testing shows that we don't need it and get touch ownership events
for our screenedge windows reported.

Test Plan: Triggered touch screen edge, normal system usage on X11

Reviewers: #plasma, #kwin

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D5520

M  +0-18   plugins/platforms/x11/standalone/xinputintegration.cpp

https://commits.kde.org/kwin/a5735e19b99d21d843252dcb12a147d122760371

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Thomas Lübking]

https://bugs.kde.org/show_bug.cgi?id=378951

Thomas Lübking  changed:

   What|Removed |Added

 CC||thomas.luebk...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Thomas Lübking]

https://bugs.kde.org/show_bug.cgi?id=378951

--- Comment #4 from Thomas Lübking  ---
This sounds as if the touch device (driver) fakes a pointer and this fails when
the touch device is passively grabbed?

xinput
lspci
lsusb

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D5520

--- Comment #3 from Martin Gräßlin  ---
Possible fix at https://phabricator.kde.org/D5520

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

  Component|input   |platform-x11-standalone

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Koller]

https://bugs.kde.org/show_bug.cgi?id=378951

--- Comment #2 from Martin Koller  ---
The rpm says:
Version : 5.9.90git~20170417T040509~4a5734c

HTH

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||Wayland-, X11+

--- Comment #1 from Martin Gräßlin  ---
As there is no 5.9.90 yet I need to know which exact git hash was used for the
package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 378951] regression: can no longer use touchscreen with kwin_x11

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378951

Martin Gräßlin  changed:

   What|Removed |Added

  Component|core|input
Version|5.9.4   |git master

-- 
You are receiving this mail because:
You are watching all bug changes.