[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #8 from Albert Astals Cid --- There is a bit of a regression there, make sure you click on the top list of the dialog that shows up asking for which certificate to use and it should work. We have fixed that for next release. Please confirm this works for you. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888
Simon changed:
What|Removed |Added
CC||simon.praetorius@tu-dresden
||.de
Status|RESOLVED|REOPENED
Resolution|FIXED |---
--- Comment #7 from Simon ---
The situation in 24.02.2 seems to be worse, i.e. one cannot sign a document
anymore. The password dialog pops up but now an empty string is not allowed
anymore and one has no way of signing the document ("cancel"/close the dialog
will cancel the signing process). This is tested with the attached document and
also other documents with a signature field.
--
You are receiving this mail because:
You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Nate Graham changed: What|Removed |Added Version Fixed In||24.02.2 CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Albert Astals Cid changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/okular/-/commit/ea243a |hics/okular/-/commit/013976 |2a03f9249c3fc36bdbcdb71d987 |69c997a612c69dc528a9229 |de064ce |070450a --- Comment #6 from Albert Astals Cid --- Git commit 01397669c997a612c69dc528a9229070450a by Albert Astals Cid, on behalf of Nicolas Fella. Committed on 03/04/2024 at 15:59. Pushed by aacid into branch 'release/24.02'. Fix DocumentHasPassword check A document can be encrypted without requiring a password to open/sign it. Currently we assume we need a password to sign it for such documents, but that's not correct. Instead of checking whether the document is encrypted remember whether we needed a password for opening. (cherry picked from commit ea243a2a03f9249c3fc36bdbcdb71d987de064ce) M +2-1generators/poppler/generator_pdf.cpp M +2-0generators/poppler/generator_pdf.h https://invent.kde.org/graphics/okular/-/commit/01397669c997a612c69dc528a9229070450a -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Nicolas Fella changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/okular/-/commit/ea243a ||2a03f9249c3fc36bdbcdb71d987 ||de064ce Resolution|--- |FIXED --- Comment #5 from Nicolas Fella --- Git commit ea243a2a03f9249c3fc36bdbcdb71d987de064ce by Nicolas Fella, on behalf of Nicolas Fella. Committed on 02/04/2024 at 11:04. Pushed by aacid into branch 'master'. Fix DocumentHasPassword check A document can be encrypted without requiring a password to open/sign it. Currently we assume we need a password to sign it for such documents, but that's not correct. Instead of checking whether the document is encrypted remember whether we needed a password for opening. M +2-1generators/poppler/generator_pdf.cpp M +2-0generators/poppler/generator_pdf.h https://invent.kde.org/graphics/okular/-/commit/ea243a2a03f9249c3fc36bdbcdb71d987de064ce -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/961 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #3 from Albert Astals Cid --- (In reply to Nicolas Fella from comment #2) > The prompt comes from > https://invent.kde.org/graphics/okular/-/blob/master/part/signaturepartutils. > cpp#L409 > > DocumentHasPassword comes from > https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/ > generator_pdf.cpp#L1593 > > The assumption seems to be that if the document is encrypted we need the > password to *read* it, but that's not the case here Yeah, DocumentHasPassword implementation needs to be changed to something like "did call to init had a non empty password variable" -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Nicolas Fella changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de --- Comment #2 from Nicolas Fella --- The prompt comes from https://invent.kde.org/graphics/okular/-/blob/master/part/signaturepartutils.cpp#L409 DocumentHasPassword comes from https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/generator_pdf.cpp#L1593 The assumption seems to be that if the document is encrypted we need the password to *read* it, but that's not the case here -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification
https://bugs.kde.org/show_bug.cgi?id=474888 --- Comment #1 from Oliver Sander --- Created attachment 161879 --> https://bugs.kde.org/attachment.cgi?id=161879=edit Acrobat security settings -- You are receiving this mail because: You are watching all bug changes.
