[plasmashell] [Bug 358556] floating point for QT_DEVICE_PIXEL_RATIO

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358556

--- Comment #5 from David Edmundson  ---
FYI, on 5.6 now this will work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358556] floating point for QT_DEVICE_PIXEL_RATIO

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358556

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #1 from David Edmundson  ---
Only integers work for that variable. which is why we only set them to
integers.
You can try and argue the case with Qt, but a lot of drawing code does go weird
with non integer stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358556] floating point for QT_DEVICE_PIXEL_RATIO

[Alin M Elena via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358556

Alin M Elena  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|UPSTREAM|---

--- Comment #2 from Alin M Elena  ---
I have no idea what artefacts do you see... 
I used 1.5 on my computer with no issues. 
the same on my phone I used qt5 with non integer pixel ratios without issues.

anyhow changing the start script to allow non-integers does not change with
anything the behaviour right now. The users who want to be "safe" can still use
integers... the rest can use non-integers. 

Alin

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358556] floating point for QT_DEVICE_PIXEL_RATIO

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358556

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #3 from David Edmundson  ---
I don't see any artefacts because as I said, it doesn't work with non integers

>From Qt5.5
qxcbscreen.cpp:static bool dpr_scaling_enabled =
(qgetenv("QT_DEVICE_PIXEL_RATIO").toInt() > 1


Your phone is maybe wayland?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358556] floating point for QT_DEVICE_PIXEL_RATIO

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358556

--- Comment #4 from David Edmundson  ---
Did some research, QT_SCALE_FACTOR (the Qt 5.6 one which is renamed) is float
based. 

I'll make sure to keep that when I do the port.

-- 
You are receiving this mail because:
You are watching all bug changes.