[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #37 from Eike Hein  ---
It was committed after 5.12.3 fwiw (yesterday).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=361097

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||n...@kde.org
 Resolution|--- |FIXED

--- Comment #36 from Nate Graham  ---
Works fine for me too in Plasma 5.12.3 and git master. Either the patch was
committed, or the issue was resolved in another capacity. Painlessroaster,
please re-open the bug if you can reproduce this in Plasma 5.12.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=361097

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #35 from Alexander Mentyu  ---
renaming long file names on desktop: ok
multiline edit box: ok
click on the end of file name: ok


Distribution: KDE neon Developer Edition - Unstable Branches
Plasma: 5.11.90
Frameworks: 5.42.0
Qt: 5.9.3
Kernel 4.10.0-42-generic


Netrunner Rolling
Plasma: 5.11.4
Apps: 17.08.3
Frameworks: 5.40.0
Qt: 5.9.3
Kernel: 4.14.3-1-MANJARO

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Mario Tosques via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

Mario Tosques  changed:

   What|Removed |Added

 CC||mario.tosq...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

stefanpro...@kolabnow.com changed:

   What|Removed |Added

 CC||stefanpro...@kolabnow.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #34 from painless roaster  ---
Eike Hein:

You can review last version of patch? Now it might already be complete. I hope.
:-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99230|0   |1
is obsolete||

--- Comment #33 from painless roaster  ---
Created attachment 99379
  --> https://bugs.kde.org/attachment.cgi?id=99379=edit
FolderView rename patch - version 8

fix popup mode (position and size)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #32 from painless roaster  ---
Thank you for review. Manual handling with ScrollBarAlwaysOn/Off is solution
for add width if need vertical scroller. It provides persistent text wrapping.

Please try the new version of patch.
I removed redundant code, magic constants and hack.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99214|0   |1
is obsolete||

--- Comment #31 from painless roaster  ---
Created attachment 99230
  --> https://bugs.kde.org/attachment.cgi?id=99230=edit
FolderView rename patch - version 7

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Anthony via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

Anthony  changed:

   What|Removed |Added

 CC||bvb...@abv.bg

--- Comment #30 from Anthony  ---
Patch looks good, but when you write qml keep in your mind it is different from
C++. You can make
visible: targetItem != null
setted targetItem to null will set automatically visible to false :) So it's
not needed to initialize properties to -1, just add exactly what you want like
a logic and it will work
property int maxHeight: theme.mSize(theme.defaultFont).height *
(plasmoid.configuration.textLines + 1)
Do not set width and hieght to 60 and do not get difference between
Qt.ScrollBarAlwaysOn - Qt.ScrollBarAlwaysOff, this is make it by Qt. So patch
can be twice a small and more compact. You can add to review here ->
https://git.reviewboard.kde.org/r/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #29 from painless roaster  ---
I do not like a few months broken operating system. :-)
Please know of ways to identify width scroller in textarea?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #28 from Eike Hein  ---
There still seem to be some magic numbers like the two 60s, and I don't like
the hacky approach to getting the scrollbar width ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #27 from painless roaster  ---
Hi, magic numbers are now removed. Now is exactly the same editing position and
the position of the label.
It is now acceptable?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99100|0   |1
is obsolete||

--- Comment #26 from painless roaster  ---
Created attachment 99214
  --> https://bugs.kde.org/attachment.cgi?id=99214=edit
FolderView rename patch - version 6

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #25 from Eike Hein  ---
Sorry, I haven't had time to deal with it yet due to being very busy with
rewriting the Task Manager. I know the patch in its currenty form will be
unacceptable because it contains magic values, which isn't ok - it will likely
break with different themes or system settings. Hard-coding pixel measurements
in that fashion is not OK code. But I want to tell you how to fix it and for
that I need to find some time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #24 from painless roaster  ---
Hi. Any news about this ticket? I created a video with current and patched
state. Current state is horrible.

Tip for quick apply patch:
# cd /usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui
# patch < FolderView_05.patch
# killall plasmashell; plasmashell &

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #23 from painless roaster  ---
Created attachment 99204
  --> https://bugs.kde.org/attachment.cgi?id=99204=edit
desktop record - patched state - after patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #22 from painless roaster  ---
Created attachment 99203
  --> https://bugs.kde.org/attachment.cgi?id=99203=edit
desktop record - current state - before patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99096|0   |1
is obsolete||

--- Comment #20 from painless roaster  ---
Created attachment 99099
  --> https://bugs.kde.org/attachment.cgi?id=99099=edit
FolderView rename patch - version 5

optimize use of numerical contants

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99099|0   |1
is obsolete||

--- Comment #21 from painless roaster  ---
Created attachment 99100
  --> https://bugs.kde.org/attachment.cgi?id=99100=edit
FolderView rename patch - version 5

fix header of patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #19 from painless roaster  ---
Oxygen OK, Fusion OK.
Font size 8 - 12 OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #18 from Eike Hein  ---
What for themes other than Breeze? And for other font sizes?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #17 from painless roaster  ---
Now patch contain comment of numerical constants. If you known variables or
constants for these dimensions, please replace it.
I tested these values for all sizes of icons in breeze theme. Editing looks
very good for short and long multilines filenames.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99094|0   |1
is obsolete||

--- Comment #16 from painless roaster  ---
Created attachment 99096
  --> https://bugs.kde.org/attachment.cgi?id=99096=edit
FolderView rename patch - version 5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #15 from Eike Hein  ---
Just taking a quick look at it: I see hard-coded numbers like 12 and 28, which
is probably wrong (do they work with different font sizes and themes?). If
they're right they need code comments explaining why.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #14 from Eike Hein  ---
Thanks, I'll probably review it after the weekend unless I can get around to it
later/tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #13 from painless roaster  ---
My FolderView patch is finally completed.
Please review it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #12 from painless roaster  ---
Last patch fixes issue:
 - open file (or folder) if click in textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99066|0   |1
is obsolete||

--- Comment #11 from painless roaster  ---
Created attachment 99094
  --> https://bugs.kde.org/attachment.cgi?id=99094=edit
Attachments FolderView rename patch - version 5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #10 from painless roaster  ---
next verion of patch resolve issues:
 - padding size in textarea
 - dynamic add width if need vertical scroller
 - set size and position by label

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99045|0   |1
is obsolete||

--- Comment #9 from painless roaster  ---
Created attachment 99066
  --> https://bugs.kde.org/attachment.cgi?id=99066=edit
FolderView rename patch - version 4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

  Attachment #99021|0   |1
is obsolete||
  Attachment #99044|0   |1
is obsolete||

--- Comment #8 from painless roaster  ---
Created attachment 99045
  --> https://bugs.kde.org/attachment.cgi?id=99045=edit
FolderView rename patch - version 3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #7 from painless roaster  ---
Try next patch in attachment, please.
This patch resolve issues:
 - dynamic resize of height (only if need add height)
 - initial size

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #6 from painless roaster  ---
Created attachment 99044
  --> https://bugs.kde.org/attachment.cgi?id=99044=edit
FolderView rename patch - version 2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #5 from Eike Hein  ---
Promising patch, but there's a few things I don't like about it:
- With short filenames that fit the icon delegate without eliding, the filename
often ends up being wrapped in the field anyway, because it's too small and
then the scrollbar eats space
- The document margins in TextArea seem to be different, causing the text to
move down and to the right a bit when going from the label to edit mode

Would be cool if you could iterate on it a bit more and resubmit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #4 from painless roaster  ---
Try patch in attachment, please. I use TextArea instead of TextField.
This patch resolve issues:
 - multiline edit (rename) long filename
 - correct size of edit box
 - escape from edit box if pressed Esc

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #3 from painless roaster  ---
Created attachment 99021
  --> https://bugs.kde.org/attachment.cgi?id=99021=edit
FolderView rename patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

Eike Hein  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
   Severity|major   |normal

--- Comment #2 from Eike Hein  ---
Please leave managing bug metadata to those who make use of that metadata. We
understand the bug is important to you (this is true of basically everyone who
reports a bug).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

painless roaster  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[painless roaster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

--- Comment #1 from painless roaster  ---
File operations in the operating system are very important. Please leave a high
priority for this bug.
Give the task to novice user to rename file with long filename. He immediately
says 'linux does not work'.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361097] impossible rename file with long filename in desktop (with folder view)

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361097

David Edmundson  changed:

   What|Removed |Added

   Severity|grave   |normal
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.