[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379635

Christoph Feck  changed:

   What|Removed |Added

 CC||aspotas...@gmail.com

--- Comment #52 from Christoph Feck  ---
*** Bug 426741 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/329db2a68c6e7
   ||0722bce7058af8b5ec31238b07b
   Version Fixed In||5.20

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #51 from Andrius Štikonas  ---
(In reply to Patrick Silva from comment #49)
> Context menu of window decoration is still affected after this workaround.

I can reproduce that but not reliably (happens maybe 50% of time if I
right-click on window decoration and then right click on desktop).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #50 from David Edmundson  ---
>Are there any other apps that we ship that are affected by that Qt bug?

Not many, it requires both QtQuick with QWidget context menus.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #49 from Patrick Silva  ---
Context menu of window decoration is still affected after this workaround.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #48 from Andrius Štikonas  ---
(In reply to David Edmundson from comment #47)
> >If from a user perspective the problem is effectively fixed now, should this 
> >bug report be closed?
> 
> If a bug exists and a user doesn't see it.. sounds like the start of a
> philosophical question.
> 

If I understand correctly, this was a workaround in plasmashell. Are there any
other apps that we ship that are affected by that Qt bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-05 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=379635

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #47 from David Edmundson  ---
>If from a user perspective the problem is effectively fixed now, should this 
>bug report be closed?

If a bug exists and a user doesn't see it.. sounds like the start of a
philosophical question.

In general /a/ report needs to stay open so we can eventually do things
properly. In this case we do have the upstream report. I think that will
suffice.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #46 from Nate Graham  ---
If from a user perspective the problem is effectively fixed now, should this
bug report be closed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-02 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #45 from Vlad Zahorodnii  ---
Git commit 329db2a68c6e70722bce7058af8b5ec31238b07b by Vlad Zahorodnii.
Committed on 02/10/2020 at 16:44.
Pushed by vladz into branch 'Plasma/5.20'.

[Shell Corona] Work around popup dismissal bug on Wayland

A popup needs to grab the keyboard and the pointer in order to dismiss
itself when another window is clicked. It works perfectly on X11.

On Wayland though, the compositor is responsible for dismissing popups
if some surface of another application has been clicked. Note that I
said "of another application." If user clicks some surface of the same
application, the compositor won't dismiss the popup.

If the application uses only QtWidgets, then the popup will be closed
as expected in both cases. But if the application uses both Qt Quick and
Qt Widgets, e.g. plasmashell, then the popup won't be dismissed if a
QQuickItem has been clicked.

It is a Qt bug, but for the time being, this change introduces an event
filter that monitors Qt::MouseButtonPress events and when needed closes
the active popup widget. This is a workaround.


(cherry picked from commit 6689abaffb076515085f2912028a1e3e3deaf36f)

M  +95   -0shell/shellcorona.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/329db2a68c6e70722bce7058af8b5ec31238b07b

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-10-02 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #44 from Vlad Zahorodnii  ---
Git commit 6689abaffb076515085f2912028a1e3e3deaf36f by Vlad Zahorodnii.
Committed on 02/10/2020 at 16:42.
Pushed by vladz into branch 'master'.

[Shell Corona] Work around popup dismissal bug on Wayland

A popup needs to grab the keyboard and the pointer in order to dismiss
itself when another window is clicked. It works perfectly on X11.

On Wayland though, the compositor is responsible for dismissing popups
if some surface of another application has been clicked. Note that I
said "of another application." If user clicks some surface of the same
application, the compositor won't dismiss the popup.

If the application uses only QtWidgets, then the popup will be closed
as expected in both cases. But if the application uses both Qt Quick and
Qt Widgets, e.g. plasmashell, then the popup won't be dismissed if a
QQuickItem has been clicked.

It is a Qt bug, but for the time being, this change introduces an event
filter that monitors Qt::MouseButtonPress events and when needed closes
the active popup widget. This is a workaround.

M  +95   -0shell/shellcorona.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/6689abaffb076515085f2912028a1e3e3deaf36f

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-09-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #43 from Nate Graham  ---
Is this purely a Qt issue that we need to wait for a fix for, or is there
anything we can do on the Plasma or KWin side?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-09-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #42 from Nate Graham  ---
*** Bug 426991 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-09-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI

--- Comment #41 from Nate Graham  ---
Tons and tons of dupes, and this becomes more obvious as Wayland gains users
due to its improved stability these days. Raising priority.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-09-27 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

Patrick Silva  changed:

   What|Removed |Added

 CC||anditosan1...@gmail.com

--- Comment #40 from Patrick Silva  ---
*** Bug 426993 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-09-17 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

Patrick Silva  changed:

   What|Removed |Added

 CC||brunoguedes.n...@gmail.com

--- Comment #39 from Patrick Silva  ---
*** Bug 426654 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-06-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

Nate Graham  changed:

   What|Removed |Added

 CC||plasma-b...@kde.org
  Component|generic-wayland |general
   Assignee|plasma-b...@kde.org |k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-06-15 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

Patrick Silva  changed:

   What|Removed |Added

 CC||claudius.ell...@live.de

--- Comment #38 from Patrick Silva  ---
*** Bug 422966 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-05-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #37 from Nate Graham  ---
Thanks for adding a reference to that Qt bug, Vlad. Is this purely an upstream
issue, or something we can work around on the KDE side?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-05-04 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #36 from Andrius Štikonas  ---
(In reply to tromzy from comment #35)
> I've recently noticed that the bug only occurs if the desktop is in
> "Desktop" mode (i.e. no icons on the desktop), it does not happen if the
> desktop is in "Folder view" mode (with icons on the desktop).

The bug is also visible on other Plasma surfaces (e.g. taskbar), I don't think
this would be affected by the desktop mode. In any case, Vlad has a reproducer
app that he attached to Qt bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-05-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #35 from tro...@free.fr ---
I've recently noticed that the bug only occurs if the desktop is in "Desktop"
mode (i.e. no icons on the desktop), it does not happen if the desktop is in
"Folder view" mode (with icons on the desktop).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-05-04 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=379635

Vlad Zahorodnii  changed:

   What|Removed |Added

URL||https://bugreports.qt.io/br
   ||owse/QTBUG-83972

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-03-03 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

Patrick Silva  changed:

   What|Removed |Added

 CC||dracaphal...@gmail.com

--- Comment #34 from Patrick Silva  ---
*** Bug 418415 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

Nate Graham  changed:

   What|Removed |Added

 CC||a...@heyquark.com

--- Comment #33 from Nate Graham  ---
*** Bug 417082 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #32 from Nate Graham  ---
*** Bug 383904 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-01-19 Thread kmi
https://bugs.kde.org/show_bug.cgi?id=379635

kmi  changed:

   What|Removed |Added

 CC||kamika...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2020-01-18 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #31 from Patrick Silva  ---
Context menu of window decoration is also affected.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2019-11-01 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

Patrick Silva  changed:

   What|Removed |Added

   Keywords||wayland

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2019-09-07 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

Patrick Silva  changed:

   What|Removed |Added

 CC||todaywe@nuke.africa

--- Comment #30 from Patrick Silva  ---
*** Bug 411683 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2019-05-16 Thread mthw0
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #29 from mthw0  ---
This bug does persist, but only with folders, not widgets (at least not with
analog clock)

Operating System: Arch Linux 
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0 beta3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2019-05-16 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #28 from Patrick Silva  ---
This bug persists with plasma 5.16 beta.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0 beta3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2019-01-17 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #27 from Patrick Silva  ---
bug persists in plasma 5.15 beta :(

Operating System: Arch Linux 
KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54.0
Qt Version: 5.12.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-10-13 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #26 from Dr. Chapatin  ---
Bug persists.

Operating System: Arch Linux 
KDE Plasma Version: 5.14.0
Qt Version: 5.11.2
KDE Frameworks Version: 5.50.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-28 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

Dr. Chapatin  changed:

   What|Removed |Added

 CC||luizl...@gmail.com

--- Comment #25 from Dr. Chapatin  ---
*** Bug 377123 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #24 from Andrius Štikonas  ---

(In reply to Andrius Štikonas from comment #22)
> (In reply to Vlad Zagorodniy from comment #21)
> > (In reply to Andrius Štikonas from comment #20)
> > > To make it slightly less, darn, this patch seems to break some minor 
> > > things
> > > too (sometimes popup doesn't open when it should), it wasn't perfect 
> > > anyway.
> > 
> > When exactly?
> 
> 1) Right click on the desktop.
> 2) Press Ctrl+F2 (to switch to another Virtual desktop)
> 3) Right click on Plasma panel, popup doesn't open

Opened another bug for this issue https://bugs.kde.org/show_bug.cgi?id=398628.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #23 from Andrius Štikonas  ---
(In reply to Andrius Štikonas from comment #22)
> (In reply to Vlad Zagorodniy from comment #21)
> > (In reply to Andrius Štikonas from comment #20)
> > > To make it slightly less, darn, this patch seems to break some minor 
> > > things
> > > too (sometimes popup doesn't open when it should), it wasn't perfect 
> > > anyway.
> > 
> > When exactly?
> 
> 1) Right click on the desktop.
> 2) Press Ctrl+F2 (to switch to another Virtual desktop)
> 3) Right click on Plasma panel, popup doesn't open

Ok, I partially take it back. It's not a regression of the patch. It seems to
be  another issue which is present even without your patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #22 from Andrius Štikonas  ---
(In reply to Vlad Zagorodniy from comment #21)
> (In reply to Andrius Štikonas from comment #20)
> > To make it slightly less, darn, this patch seems to break some minor things
> > too (sometimes popup doesn't open when it should), it wasn't perfect anyway.
> 
> When exactly?

1) Right click on the desktop.
2) Press Ctrl+F2 (to switch to another Virtual desktop)
3) Right click on Plasma panel, popup doesn't open

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #21 from Vlad Zagorodniy  ---
(In reply to Andrius Štikonas from comment #20)
> To make it slightly less, darn, this patch seems to break some minor things
> too (sometimes popup doesn't open when it should), it wasn't perfect anyway.

When exactly?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #20 from Andrius Štikonas  ---
(In reply to Nate Graham from comment #19)
> Darn.

To make it slightly less, darn, this patch seems to break some minor things too
(sometimes popup doesn't open when it should), it wasn't perfect anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #19 from Nate Graham  ---
Darn.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #18 from Vlad Zagorodniy  ---
(In reply to Nate Graham from comment #17)
> Awesome, wanna submit that patch for review?

See Roman's comment https://phabricator.kde.org/D15480#325325

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #17 from Nate Graham  ---
Awesome, wanna submit that patch for review?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #16 from Andrius Štikonas  ---
Well, even with full patch, popups don't work as well as on X11.

I sometimes still can open both popup at window titlebar and taskbar
simultaneously.

Also if I open popup on chromium  (via XWayland) titlebar and then right click
on the webpage, I can see both kwin popup menu and chromium popup menu
simultaneously.

Nevertheless, it feels better than without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #15 from Andrius Štikonas  ---
(In reply to Andrius Štikonas from comment #14)
> Not sure if I understood correctly what is the patch from bug #398566 (as it
> has no context lines at all) but the patch that I tried improves situation
> but doesn't completely resolve it.
> 
> diff --git a/popup_input_filter.cpp b/popup_input_filter.cpp
> index fc74540ed..c9e93c559 100644
> --- a/popup_input_filter.cpp
> +++ b/popup_input_filter.cpp
> @@ -65,13 +65,9 @@ bool PopupInputFilter::pointerEvent(QMouseEvent *event,
> quint32 nativeButton)
>  // filter out this press
>  return true;
>  }
> -if (pointerFocus && pointerFocus->isDecorated()) {
> -// test whether it is on the decoration
> -const QRect clientRect = QRect(pointerFocus->clientPos(),
> pointerFocus->clientSize()).translated(pointerFocus->pos());
> -if (!clientRect.contains(event->globalPos())) {
> -cancelPopups();
> -return true;
> -}
> +if (!m_popupClients.contains(pointerFocus)) {
> +cancelPopups();
> +return true;
>  }
>  }
>  return false;

Sorry, I just noticed the lines are specified there. I'll try that patch again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #14 from Andrius Štikonas  ---
Not sure if I understood correctly what is the patch from bug #398566 (as it
has no context lines at all) but the patch that I tried improves situation but
doesn't completely resolve it.

diff --git a/popup_input_filter.cpp b/popup_input_filter.cpp
index fc74540ed..c9e93c559 100644
--- a/popup_input_filter.cpp
+++ b/popup_input_filter.cpp
@@ -65,13 +65,9 @@ bool PopupInputFilter::pointerEvent(QMouseEvent *event,
quint32 nativeButton)
 // filter out this press
 return true;
 }
-if (pointerFocus && pointerFocus->isDecorated()) {
-// test whether it is on the decoration
-const QRect clientRect = QRect(pointerFocus->clientPos(),
pointerFocus->clientSize()).translated(pointerFocus->pos());
-if (!clientRect.contains(event->globalPos())) {
-cancelPopups();
-return true;
-}
+if (!m_popupClients.contains(pointerFocus)) {
+cancelPopups();
+return true;
 }
 }
 return false;

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-09-13 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

Dr. Chapatin  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #13 from Dr. Chapatin  ---
*** Bug 398566 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-08-27 Thread mthw0
https://bugs.kde.org/show_bug.cgi?id=379635

mthw0  changed:

   What|Removed |Added

 CC||jari...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-07-12 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=379635

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #12 from Michael D  ---
Same as Chapatin. If I click the desktop or switch virtual desktops, the menu
remains. If I click an application, it disappears. I'm on Manjaro testing with
Plasma 5.13.2 and Qt 5.11.1.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-06-10 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=379635

hiwatari.se...@gmail.com changed:

   What|Removed |Added

 CC||hiwatari.se...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-05-21 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #11 from Dr. Chapatin  ---
qt 5.11 rc2 on Arch Linux, qt 5.10 on neon dev unstable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-05-21 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=379635

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #10 from David Edmundson  ---
what Qt version?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-05-19 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #9 from Dr. Chapatin  ---
Bug persists in plasma 5.13 beta.
Context menu of icons in desktop
remains open if I click on desktop background or press ESC.
The same happens with the context menu of any element in plasma panel (icon in
system tray, task manager entry, pinned app icon, widget).
If I click on some window instead on desktop background, the conext menu is
closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2018-02-07 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #8 from Dr. Chapatin  ---
plasma 5.12 stable has the same bug on Arch Linux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-12-02 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

Dr. Chapatin  changed:

   What|Removed |Added

 CC||pavbara...@gmail.com

--- Comment #7 from Dr. Chapatin  ---
*** Bug 387526 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-10-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #6 from Nate Graham  ---
*** Bug 386298 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-10-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=379635

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-10-16 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=379635

David Edmundson  changed:

   What|Removed |Added

 CC||verme...@gmail.com

--- Comment #5 from David Edmundson  ---
*** Bug 385784 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-08-23 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=379635

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-08-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379635

--- Comment #4 from Christoph Feck  ---
*** Bug 383487 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-08-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379635

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=383904

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-08-18 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

Andrius Štikonas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-08-17 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=379635

David Edmundson  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #3 from David Edmundson  ---
*** Bug 383485 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-08-02 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379635

Christoph Feck  changed:

   What|Removed |Added

 CC||a.markiew...@live.com

--- Comment #2 from Christoph Feck  ---
*** Bug 382765 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-06-13 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=379635

Dr. Chapatin  changed:

   What|Removed |Added

 CC||yy...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-06-13 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=379635

Andrius Štikonas  changed:

   What|Removed |Added

 CC||andr...@stikonas.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-06-12 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379635

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||tro...@free.fr

--- Comment #1 from Elvis Angelaccio  ---
*** Bug 381125 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-06-09 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379635

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379635] popmenu at desktop doesn't disappear when lost focus.

2017-05-26 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379635

Christoph Feck  changed:

   What|Removed |Added

  Component|Desktop Containment |generic-wayland
   Assignee|se...@kde.org   |plasma-b...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.