[plasmashell] [Bug 380495] Freezes during login process

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=380495

David Edmundson  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/5bc35571901c0
   ||29fade2ccbcdef191cb3ce01150
 Resolution|--- |FIXED

--- Comment #12 from David Edmundson  ---
Git commit 5bc35571901c029fade2ccbcdef191cb3ce01150 by David Edmundson.
Committed on 19/06/2019 at 08:49.
Pushed by davidedmundson into branch 'master'.

Simplify KSplash

Summary:
Forking and printing a PID gains nothing.

The new startplasma script tracks the process used to start ksplash
itself.

Test Plan:
Logged in, saw a splash
Ran the test from systemsettings, saw a splash

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21890

M  +0-30   ksplash/ksplashqml/main.cpp

https://commits.kde.org/plasma-workspace/5bc35571901c029fade2ccbcdef191cb3ce01150

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=380495

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[George R. Goffe]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #11 from George R. Goffe  ---
This problem still seems to exist. Is anyone working this bug?

George...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[George R. Goffe]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #10 from George R. Goffe  ---
Dave,

Unsupported? Are you kidding me? I've been using KDE for over 10 years and have
not had this problem.

I have in fact tried SDDM and still have the problem.

George...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[YOSHINO Yoshihito]

https://bugs.kde.org/show_bug.cgi?id=380495

YOSHINO Yoshihito  changed:

   What|Removed |Added

 Resolution|NOT A BUG   |---
 Status|RESOLVED|REPORTED

--- Comment #9 from YOSHINO Yoshihito  ---
Hello,

I am the original reporter of this bug. This bug is still applicable to recent
ksplashqml. Debian-based systems bundle the attached patch and work fine.
I would really appreciate it if the patch would be included upstream.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=380495

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED

--- Comment #8 from David Edmundson  ---
>from my .xinitrc file.


Not using a Display Manager is unsupported. 90% of the time it is a user setup
issue, and this is not a support forum.

Please use SDDM and reopen if you still have an issue. If that works, use "env"
to compare what's different.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[George R. Goffe]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #7 from George R. Goffe  ---
I forgot to indicate "my" level of ksplashqml... so here it is: 

plasma-workspace-5.15.3-1.fc31.x86_64

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[George R. Goffe]

https://bugs.kde.org/show_bug.cgi?id=380495

George R. Goffe  changed:

   What|Removed |Added

 CC||grgo...@yahoo.com

--- Comment #6 from George R. Goffe  ---
Created attachment 118832
  --> https://bugs.kde.org/attachment.cgi?id=118832=edit
gzip'd file containing the execution of startkde from my .xinitrc file.

Hi,

I think I have this same problem with a Fedora Core 31 (rawhide) system. The
system is freshly installed and has several rounds of "normal" package
upgrades.

I have my run level set to 3, a text mode login. After login I issue a startx
command which uses my .xinitrc config file which contains " /usr/bin/bash -xv
/usr/bin/startkde". Startkde just never ends. I have included output of this
.xinitrc script.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380495

pos...@posteo.eu changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[YOSHINO Yoshihito]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #5 from YOSHINO Yoshihito  ---
(In reply to David Edmundson from comment #4)
> ‎[01:15] ‎<‎yyoshino_‎>‎ d_ed: actually I do not figure out the problem on
> wayland in pre-5.3.90 - On my machine startplasmacompositor seems to work
> well both with or without this patch
> 
> 
> I'm a bit lost. Do we think this patch needed or not?

Yes, the patch is needed. Sorry I have mistyped, to clarify: On my X
environment - startkde works well when the patch is applied. On my wayland
envionment - startplasmacompositor works even without the patch due to another
reason, but is not that good - not fully working. Because uim (an input method
system I'm using) is currently broken on wayland, its daemon process crashes on
startup and ksplash does not hang but the input method does not function.

On my wayland environment I could not reproduce the original (pre-5.3.95)
problem on wayland the commit
https://cgit.kde.org/plasma-workspace.git/commit/?id=56d2c15b9acb9c4b57398b281685807c3191f622
has tried to fix.

> There is another (possibly simpler?) way to solve this. We could background
> immediately and then replace all the kill $ksplash_pid with kquitapp5 and
> the DBus name.

I would use the dbus quit interface, while I don't know at first glance why it
does not work on my machine, with a following error:
> Error: org.freedesktop.DBus.Error.UnknownObject
> No such object path '/MainApplication'

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=380495

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #4 from David Edmundson  ---
‎[01:15] ‎<‎yyoshino_‎>‎ d_ed: actually I do not figure out the problem on
wayland in pre-5.3.90 - On my machine startplasmacompositor seems to work well
both with or without this patch


I'm a bit lost. Do we think this patch needed or not?

---

There is another (possibly simpler?) way to solve this. We could background
immediately and then replace all the kill $ksplash_pid with kquitapp5 and the
DBus name.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #3 from yy.y.ja...@gmail.com ---
Here is some additional info for more clarity:

Actually the attached patch just changes ksplashqml to simulate pre-5.3.90
behavior, where it does not emit log anywhere (because it had closed all the
file descriptors). The only difference is that SplashApp's file descriptors 0,
1 and 2 are open during its initialization phase.

The ksplashqml's caller is /usr/bin/startkde (symlinked by
/usr/bin/x-session-manager in a fresh Debian KDE desktop installation), at line
187:
> ksplash_pid=`ksplashqml "${ksplashrc_ksplash_theme}" --pid`
The caller hangs at this point. As in the previous comment it is reading file
descriptor 3, which is apparently the stdout of the ksplashqml process, and is
waiting forever, which means the pipe is not closed and is empty. The pipe's
file descriptor (writer side) is shared through fork. A small main.c and small
caller script attached are a minimal example of the situation.
The caller expects that ksplashqml with "--pid" option emit the pid string of
its forked process and immediately exit. In reality the ksplashqml process
emits the string, but its forked process also holds the pipe and does not
close. Thus it hangs. The forked process must not write anything to the pipe,
otherwise the caller reads it after the (expected) pid string. So in order to
only fix the problem closing (replacing) stdout should suffice.

ksplashqml splash app is a qt5 QGuiApplication, which by default loads
QPlatformInputContext (input method) plugins. This is why ksplashqml launches
an input method system.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #2 from yy.y.ja...@gmail.com ---
Created attachment 106035
  --> https://bugs.kde.org/attachment.cgi?id=106035=edit
an example launcher script for the app to illustrate the hang situation

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380495

--- Comment #1 from yy.y.ja...@gmail.com ---
Created attachment 106034
  --> https://bugs.kde.org/attachment.cgi?id=106034=edit
an example app to illustrate the hang situation

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380495

yy.y.ja...@gmail.com changed:

   What|Removed |Added

 CC||yy.y.ja...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 380495] Freezes during login process

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380495

d...@debian.org changed:

   What|Removed |Added

 CC||d...@debian.org

-- 
You are receiving this mail because:
You are watching all bug changes.