[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #18 from Akseli Lahtinen --- Git commit 3a5e4f5d5eeb39c96cb55aecc0894ef86b7c497d by Akseli Lahtinen. Committed on 15/05/2024 at 10:08. Pushed by akselmo into branch 'Plasma/6.0'. systemmonitor: create configEngine for config items Requires: https://invent.kde.org/plasma/libksysguard/-/merge_requests/346 This now creates a configEngine per systemmonitor, which fixes a bug where Plasma systemmonitor applets configuration windows would use Plasma colors. M +3-2applets/systemmonitor/systemmonitor/systemmonitor.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/3a5e4f5d5eeb39c96cb55aecc0894ef86b7c497d -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #17 from Akseli Lahtinen --- Git commit f7d874e83d22ea65b70d4467ee610c9f2f8af860 by Akseli Lahtinen. Committed on 15/05/2024 at 09:43. Pushed by akselmo into branch 'Plasma/6.0'. FaceLoader: use qmlEngine for configEngine Requires: https://invent.kde.org/plasma/libksysguard/-/merge_requests/346 Add `qmlEngine(this)` to the sensorfacecontroller configEngine parameter. We can use same engine here since SystemMonitor is not using Plasma coloring. (cherry picked from commit 8154f79bd54777a85c18c067d56155f341dce994) 1417b681 FaceLoader: use qmlEngine for configEngine M +1-1src/page/FaceLoader.cpp https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/f7d874e83d22ea65b70d4467ee610c9f2f8af860 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #15 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4323 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #16 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/290 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #14 from Akseli Lahtinen --- Git commit 52f6668fd1be2fc5d6b69a665d999841c0bc7436 by Akseli Lahtinen. Committed on 15/05/2024 at 09:36. Pushed by akselmo into branch 'master'. systemmonitor: create configEngine for config items Requires: https://invent.kde.org/plasma/libksysguard/-/merge_requests/346 This now creates a configEngine per systemmonitor, which fixes a bug where Plasma systemmonitor applets configuration windows would use Plasma colors. M +3-2applets/systemmonitor/systemmonitor/systemmonitor.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/52f6668fd1be2fc5d6b69a665d999841c0bc7436 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #13 from Akseli Lahtinen --- Git commit 8154f79bd54777a85c18c067d56155f341dce994 by Akseli Lahtinen. Committed on 15/05/2024 at 09:26. Pushed by akselmo into branch 'master'. FaceLoader: use qmlEngine for configEngine Requires: https://invent.kde.org/plasma/libksysguard/-/merge_requests/346 Add `qmlEngine(this)` to the sensorfacecontroller configEngine parameter. We can use same engine here since SystemMonitor is not using Plasma coloring. M +1-1src/page/FaceLoader.cpp https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/8154f79bd54777a85c18c067d56155f341dce994 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #12 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/289 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #11 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4320 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/libksysguard/-/commit/3f |ma/libksysguard/-/commit/f5 |fd61ba57ef690a78eccded05508 |b14b496597a68c2ebd67940f3c3 |3d6aa4ead44 |936a60b4a28 --- Comment #10 from Nate Graham --- Git commit f5b14b496597a68c2ebd67940f3c3936a60b4a28 by Nate Graham, on behalf of Akseli Lahtinen. Committed on 08/05/2024 at 19:47. Pushed by ngraham into branch 'Plasma/6.0'. SensorFaceController: use a separate QQmlEngine in createConfigUi Config UI was using same engine as the applet, so it would inherit the colors wrongly from the Plasma Theme instead of the standard color scheme. This caused issues in mixed light/dark global themes. Fix it by creating a new engine just for the config windows. FIXED-IN: 6.0.5 (cherry picked from commit 3ffd61ba57ef690a78eccded055083d6aa4ead44) 754f64a8 SensorFaceController: createConfigUi creates its own QQmlEngine 50262dad Rename to configEngine 168aca46 Add original engine as parent for the configEngine M +4-2faces/SensorFaceController.cpp https://invent.kde.org/plasma/libksysguard/-/commit/f5b14b496597a68c2ebd67940f3c3936a60b4a28 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 Nate Graham changed: What|Removed |Added Version Fixed In||6.0.5 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/libksysguard/-/commit/3f ||fd61ba57ef690a78eccded05508 ||3d6aa4ead44 --- Comment #9 from Nate Graham --- Git commit 3ffd61ba57ef690a78eccded055083d6aa4ead44 by Nate Graham, on behalf of Akseli Lahtinen. Committed on 08/05/2024 at 19:46. Pushed by ngraham into branch 'master'. SensorFaceController: use a separate QQmlEngine in createConfigUi Config UI was using same engine as the applet, so it would inherit the colors wrongly from the Plasma Theme instead of the standard color scheme. This caused issues in mixed light/dark global themes. Fix it by creating a new engine just for the config windows. FIXED-IN: 6.0.5 M +4-2faces/SensorFaceController.cpp https://invent.kde.org/plasma/libksysguard/-/commit/3ffd61ba57ef690a78eccded055083d6aa4ead44 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/344 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #7 from S. Christian Collins --- Created attachment 168619 --> https://bugs.kde.org/attachment.cgi?id=168619=edit new look of the bug (sensors details) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 --- Comment #6 from S. Christian Collins --- Created attachment 168618 --> https://bugs.kde.org/attachment.cgi?id=168618=edit new look of the bug (pie chart details) With the upgrade to Plasma 6.0.4 and Frameworks 6.1.0, this bug has changed its colors, literally. Previously, the text color for certain widgets was being pulled from the dark plasma theme, conflicting with the light application theme making the white text impossible to read against the white background (when using Twilight). Now, the widget background is also being pulled from the plasma theme, leading to cases of hard to read black text on a dark background and white check marks instead of black. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 Paolo Zamponi changed: What|Removed |Added CC||feu...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483689] Invisible text in some widget settings with mixed light/dark theme e.g. Breeze Twilight
https://bugs.kde.org/show_bug.cgi?id=483689 Nate Graham changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |CONFIRMED Summary|invisible text in widget|Invisible text in some |settings|widget settings with mixed ||light/dark theme e.g. ||Breeze Twilight Ever confirmed|0 |1 --- Comment #5 from Nate Graham --- Yeah, looks like it. Can reproduce that now. -- You are receiving this mail because: You are watching all bug changes.
