[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

Stephane MANKOWSKI  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/skro
   ||oge/a55de18a80f02c163185097
   ||5ca7da758dccb7dc3
 Status|ASSIGNED|RESOLVED

--- Comment #13 from Stephane MANKOWSKI  ---
Git commit a55de18a80f02c1631850975ca7da758dccb7dc3 by Stephane Mankowski.
Committed on 22/08/2016 at 18:40.
Pushed by smankowski into branch 'master'.
Skrooge perpetually asks me to save updated tab state
Corrected by a previous commit

M  +1-0CHANGELOG

http://commits.kde.org/skrooge/a55de18a80f02c1631850975ca7da758dccb7dc3

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #12 from Stephane MANKOWSKI  ---
Hi,

For your information, another user has the same kind of issue.
I am analyzing with him because hes is french (like me) and on ubuntu (I am on
kubuntu):
https://forum.ubuntu-fr.org/viewtopic.php?pid=21569431#p21569431

But, I am still not able to reproduce this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #11 from dberg...@gmail.com ---
(In reply to Stephane MANKOWSKI from comment #9)
> Could you confirm that you have the following lines in your skroogerc file?
> [Notification Messages]
> updateBookmarkOnClose=false
> updateContextOnClose=false
I don't have these lines in my skroogerc file, but I do have these:
[Main Panel]
update_modified_bookmarks=2
update_modified_contexts=2

Even after checking the boxes in the confirmation panel for the Dashboard
bookmark and the other Page states, those lines you mentioned don't show up.

I tried adding them manually to the bottom of my skroogerc file and after
opening the application, they moved up to a different spot in the file, but
they had no effect on the behavior of the popups. Checking the boxes doesn't
change the behavior either. It works during one session, but then after
reopening the application, the popups come back.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #10 from Stephane MANKOWSKI  ---
Could you also check the box in confirmation panel to avoid to be asked again
and again?

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #9 from Stephane MANKOWSKI  ---
(In reply to dberg918 from comment #8)
> Interesting. Can you confirm that all pages are showing a modified state
> even after just opening the file? 
I confirm.
> That shouldn't happen, should it?
> 
> I have attached a video showing the results of the command you mentioned, as
> well as the popups. You can also see that each tab has the "save" icon on
> it, even after it has just been opened.
The behavior of the video is not normal.
I don't understand why you have this.

Could you confirm that you have the following lines in your skroogerc file?
[Notification Messages]
updateBookmarkOnClose=false
updateContextOnClose=false

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #8 from dberg...@gmail.com ---
Interesting. Can you confirm that all pages are showing a modified state even
after just opening the file? That shouldn't happen, should it?

I have attached a video showing the results of the command you mentioned, as
well as the popups. You can also see that each tab has the "save" icon on it,
even after it has just been opened.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #7 from dberg...@gmail.com ---
Created attachment 100323
  --> https://bugs.kde.org/attachment.cgi?id=100323=edit
Proof video

Video showing the bug in action

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #6 from Stephane MANKOWSKI  ---
Hi,

I am not able to reproduce the issue with your file.
In settings, options are well on "Never", so there is no panel asking to save
the state.

Could you launch the following command and confirm that you have only one file
found?
find ~/ -name skroogerc

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #5 from dberg...@gmail.com ---
(In reply to Stephane MANKOWSKI from comment #4)
> I asked you to remove the other skroogerc file not this one.
> In fact, for compatibility reason, the old skroogerc file (for KDE4) is
> copied in ~/.config/skroogerc (KF5).
> So, if you still have the old version, when skrooge is started, the old
> version overwrite the new one.
> 
> So, please, remove the other skroogerc file as explained in my previous post.
Ah, my apologies. Yes, I used to have the .kde4/../skroogerc file, but I
deleted that folder after I had migrated away from KDE4 apps.
>
> No, these options are exactly done to do what you want.
> But, if another skroogerc file exists, the this file will overwrite the
> official one and these options will come back to the previous value.
Oh, okay. This must be an issue with my SKG file then. I've been using this
particular file since before the transition to KF5/Qt5, so it has seen a lot of
changes!

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #4 from Stephane MANKOWSKI  ---
(In reply to dberg918 from comment #3)
> Thanks for your reply.
> 
> Actually, I have tried removing ~/.config/skroogerc a number of times in the
> past. It works the first time I open Skrooge after removal--the popup
> windows go away--but once it writes a new config file and I close the
> application and reopen it, the problem comes back.
I asked you to remove the other skroogerc file not this one.
In fact, for compatibility reason, the old skroogerc file (for KDE4) is copied
in ~/.config/skroogerc (KF5).
So, if you still have the old version, when skrooge is started, the old version
overwrite the new one.

So, please, remove the other skroogerc file as explained in my previous post.
> 
> There are a few options about saving page states in Skrooge's settings, but
> they don't seem to work. One is "Update modified pages on close" and the
> other is "Update modified bookmarks on close." I have both set to "Never." I
> don't think those are related to my issue though, because those options
> sound like they affect behavior when closing the whole application, not just
> a page or a bookmark within the application itself.
No, these options are exactly done to do what you want.
But, if another skroogerc file exists, the this file will overwrite the
official one and these options will come back to the previous value.
> 
> What I find strange is that I haven't even changed the state of any of these
> pages, but Skrooge thinks they've changed and asks me to save the "modified"
> state. Based on my observation, it seems that page states are actually saved
> into the SKG file and not the skroogerc file, which leads me to believe
> there's something wrong with my SKG file. I have attached an anonymized
> version with which you may be able to reproduce the issue.
OK, I will check with your file this evening.
> 
> This is occurring on a newly compiled 2.4.0 package in Fedora 24. On Arch
> Linux, which I have installed on another computer, I don't get the popups,
> but I can see that Skrooge thinks the page states are all modified on
> startup.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #3 from dberg...@gmail.com ---
Thanks for your reply.

Actually, I have tried removing ~/.config/skroogerc a number of times in the
past. It works the first time I open Skrooge after removal--the popup windows
go away--but once it writes a new config file and I close the application and
reopen it, the problem comes back.

There are a few options about saving page states in Skrooge's settings, but
they don't seem to work. One is "Update modified pages on close" and the other
is "Update modified bookmarks on close." I have both set to "Never." I don't
think those are related to my issue though, because those options sound like
they affect behavior when closing the whole application, not just a page or a
bookmark within the application itself.

What I find strange is that I haven't even changed the state of any of these
pages, but Skrooge thinks they've changed and asks me to save the "modified"
state. Based on my observation, it seems that page states are actually saved
into the SKG file and not the skroogerc file, which leads me to believe there's
something wrong with my SKG file. I have attached an anonymized version with
which you may be able to reproduce the issue.

This is occurring on a newly compiled 2.4.0 package in Fedora 24. On Arch
Linux, which I have installed on another computer, I don't get the popups, but
I can see that Skrooge thinks the page states are all modified on startup.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #2 from dberg...@gmail.com ---
Created attachment 100305
  --> https://bugs.kde.org/attachment.cgi?id=100305=edit
Anonymized test file

Anonymized SKG file that may have broken page states saved in it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

--- Comment #1 from Stephane MANKOWSKI  ---
Hi,

Could you launch this from a command line?
find ~/ -name skroogerc

You should find only one file in .config.
If you have an other one, remove it.

Tell me if this works well after that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[skrooge] [Bug 366025] Skrooge perpetually asks me to save updated tab state

[Stephane MANKOWSKI via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366025

Stephane MANKOWSKI  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|guillaume.deb...@gmail.com  |steph...@mankowski.fr
 Status|UNCONFIRMED |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.